We needed to set a grit define to build the blink_resources target
properly. We were doing this via a global define that affected all
targets, but now we're doing this with a local define instead.
R=rtoy@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1338193003
Cr-Original-Commit-Position: refs/heads/master@{#348812}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4be705ba5d1d13fbb1c5d2f4f578273f13ed632c
Now that we have minigbm in third_party we can set ozone_platform_gbm=1 by default.
BUG=530712
TEST=tryjobs for linux_chromium_chromeos_ozone_rel_ng,
cast_shell_linux
Review URL: https://codereview.chromium.org/1336023002
Cr-Original-Commit-Position: refs/heads/master@{#348802}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 88e504e383e7641e139bc836b33ded00a0d46668
This factors the irt_* toolchain definitions using a template to reduce
copied boilerplate. It also switches the ARM build to use arm-nacl-clang
rather than arm-nacl-gcc, which matches what the GYP build does now. Many
of the compilation flags are still not at all right, but this is enough
for the build of the IRT to complete successfully.
BUG=531702
R=dpranke@chromium.org
Review URL: https://codereview.chromium.org/1341143002
Cr-Original-Commit-Position: refs/heads/master@{#348781}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 916aafa6563eb600b60a683d52d0c121f2eaee92
This library is used by Chrome on Chrome OS to allocate accelerated
graphics buffers. The version avaiable on Ubuntu is too old, and as a
result we can't run unit tests for the gbm platform code on developer
workstations or on the waterfall.
This adds the library to third_party and fixes up the build files to use
either the OS copy (for Chrome OS release builds) or gardened copy (for
testing on the waterfall) depending on the value of "use_system_minigbm".
BUG=530712
TEST=
GYP_DEFINES="use_ozone=1 chromeos=1 ozone_platform_gbm=1 use_system_minigbm=0" gclient runhooks
ninja -C out/Release ozone_unittests
./out/Release/ozone_unittests
gn gen out_gn_ozone --args='target_os="chromeos" use_ozone=true ozone_platform_gbm=true use_system_minigbm=false'
ninja -C out_gn_ozone ozone_unittests
./out_gn_ozone/Release/ozone_unittests
Review URL: https://codereview.chromium.org/1341473003
Cr-Original-Commit-Position: refs/heads/master@{#348758}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c231bffd37754a1ab09fbbb4a1260438be638df4
Previously //build/config/sanitizer:deps unconditionally depended on
//third_party/instrumented_libraries:deps. This dependency is only necessary
//when compiling with a sanitizer, and in standalone other projects like nacl,
//instrumented_libraries doesn't exist.
This patch makes all contents of sanitizer:deps conditional on using a
sanitizer, which matches what the documentation explicitly says.
BUG=
Review URL: https://codereview.chromium.org/1341043005
Cr-Original-Commit-Position: refs/heads/master@{#348719}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: bc6f9a5b1858c70d852029f77020cabd3db879f6
An "adb install" always terminates the app, so when skipping the step,
we should terminate the app to have consistent behaviour.
BUG=
Review URL: https://codereview.chromium.org/1334303003
Cr-Original-Commit-Position: refs/heads/master@{#348712}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a87495be3a6a5be1ac0d1175898efa54689a99ff
This also moves the config out of the template. Otherwise this will generate an
error if there is more than one MIDL target in the same directory.
Use forward_variables_from in the MIDL template.
TBR=dpranke@chromium.org
Review URL: https://codereview.chromium.org/1335283002
Cr-Original-Commit-Position: refs/heads/master@{#348664}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7c0c67ed3859656cb869fb517527938f70ed0cc6
Uses forward_variables_from for the gcc_toolchain and nacl_toolchain templates
when applicable.
Add the ability to clear the sanitizer flags and use this for nacl.
Review URL: https://codereview.chromium.org/1338803004
Cr-Original-Commit-Position: refs/heads/master@{#348522}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f5d97233985fac498ada3def2c2b3f4e8bbaafd9
Motivated by Install() getting a new permissions attribute without
InstallSplitApk() being updated (http://crrev.com/de468d72d9e)
There is also a sematic change:
- When a previous install is present and reinstall=False, we used to
check if the install on-device was identical and no-op in this case.
Now, we do an uninstall + install regardless of whether the on-device
version is identical. This new behaviour is more correct since it
guarantees that no stale data will be present when reinstall=False.
BUG=
Review URL: https://codereview.chromium.org/1337073002
Cr-Original-Commit-Position: refs/heads/master@{#348419}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 307cf30fea5e791de2ebac395b1d9a154afc637b
//build/config/compiler/BUILD.gn has the following lines which make the declarations in the toolchains superfluous:
# Pass the same C/C++ flags to the objective C/C++ compiler.
cflags_objc += cflags_c
cflags_objcc += cflags_cc
R=brettw@chromium.org
BUG=none
Review URL: https://codereview.chromium.org/1335503006
Cr-Original-Commit-Position: refs/heads/master@{#348197}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: bd1aafe5d735405a27266a38a0af38be2d17d0bd
Also doing a fork() changes thread id (syscall gettid), which breaks the
assumptions in cygprofile.cc, disabled a fork in library_prefetcher.
Verified: with these changes the instrumented build is able to display the
contents of 'https://google.com'. It does not finish loading though, which is
probably due to some other timeouts.
BUG=503613
Review URL: https://codereview.chromium.org/1325053009
Cr-Original-Commit-Position: refs/heads/master@{#347918}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e3a753f17bac62738b0dbf0b36510f767b081e4b
Reason for revert:
Caused check_licenses to fail:
https://build.chromium.org/p/chromium/builders/Linux/builds/66701
Original issue's description:
> Fix typo in install-sysroot.py
>
> install-sysroot.py was intended to default to installing
> the sysroot ia32, but within this script 'i386' is used to
> refer to this architecture.
>
> This most likely went unnoticed since the ia32 builder
> either use branding=Official, or explicitly set
> use_sysroot=1, or have a complete set of packages for
> cross building on the host system.
>
> BUG=504446
>
> Committed: https://crrev.com/1d62049b4c176fbd43bed90fc9a76273b11ad406
> Cr-Commit-Position: refs/heads/master@{#347821}
TBR=dpranke@chromium.org,sbc@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=504446
Review URL: https://codereview.chromium.org/1315773003
Cr-Original-Commit-Position: refs/heads/master@{#347839}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3b27a2de111759359162bcad49753e17ee1cf002
install-sysroot.py was intended to default to installing
the sysroot ia32, but within this script 'i386' is used to
refer to this architecture.
This most likely went unnoticed since the ia32 builder
either use branding=Official, or explicitly set
use_sysroot=1, or have a complete set of packages for
cross building on the host system.
BUG=504446
Review URL: https://codereview.chromium.org/1317973005
Cr-Original-Commit-Position: refs/heads/master@{#347821}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1d62049b4c176fbd43bed90fc9a76273b11ad406
Currently, it will double report test failures, and
will improperly report crashes without a long message.
BUG=512305
Review URL: https://codereview.chromium.org/1311783005
Cr-Original-Commit-Position: refs/heads/master@{#347785}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2347b0e01194f15e2c4fecaaea4b2e84a0ba058a
The default depot_tools pylintrc disables some checks that we can
reasonably enable in build/android/. This CL does so.
BUG=
Review URL: https://codereview.chromium.org/1315743004
Cr-Original-Commit-Position: refs/heads/master@{#347720}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 58b4d3677418a2360c23e118199f5cf8992d4178
If use_concatenated_impulse_responses is set (in config.gni), then
grit needs to have it defined as well. This is needed to reference
the appropriate response files for the HRTF panner in WebAudio.
BUG=528424
TEST=webaudio panner tests pass
Review URL: https://codereview.chromium.org/1311013010
Cr-Original-Commit-Position: refs/heads/master@{#347534}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4c50633b258d948b7d28f4bb7af3a787ac8b7079
libevdev-cros is not needed for the host tooling, and is not availale for
the host in a chroot chromeos building environment.
BUG=527996
Review URL: https://codereview.chromium.org/1322343002
Cr-Original-Commit-Position: refs/heads/master@{#347531}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 97739b5fcf32a746c38d8142bff56d0072953dbf
newt
dpranke
spang
mlliu
mcgrathr
joelo
sergeyu
brettw
jbudorick
agrieve
stip
yfriedman
thakis
pcc
rnephew
andybons
pasko
akuegel
chrishtr
sbc
megjablon
andrewhayden
rtoy
petermayo
nparker