Reason for reland:
- content_browsertests and component_browsertests updated to
clear the correct private data directory between test runs.
Uses delete_device_stale=True when pushing. This will prevent tests
mistakenly passing when they depend on stale data files from a previous test.
TBR=jbudorick@chromium.org,thakis@chromium.org,mef@chromium.org,torne@chromium.org
BUG=607169,617213,616155
Review-Url: https://codereview.chromium.org/2043803003
Cr-Original-Commit-Position: refs/heads/master@{#398601}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d4d66d4d0353020ddf9f1423d08cf39ed911c329
Reduce the number of tasks using the copy_bundle_data and compile_xcassets
tools as they can cause lots of I/O contention when invoking ninja with a
large number of parallel jobs (e.g. when using distributed build like goma).
Use the same depth as the link_pool (but in a separate pool).
BUG=612786
Review-Url: https://codereview.chromium.org/2018553003
Cr-Original-Commit-Position: refs/heads/master@{#398585}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a78c5b20b9d0d8cb6e883e3efb83dafbc7849655
The HandleVerifier prevent you from using any ScopedHandle during a module initialization (i.e. if a DLL use one in DllMain this will call back into its host executable that hasn't been initialized yet and things will derail). In this CL I'm adding a build flag to make it possible to use it in a single module mode..
Committed: https://crrev.com/a89708a5c1bfe778ed1615f0bc92f0e9ae2e2192
Cr-Commit-Position: refs/heads/master@{#398361}
BUG=618205
Review-Url: https://codereview.chromium.org/1977833003
Cr-Original-Commit-Position: refs/heads/master@{#398575}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 82ef0204161f34381ab832a576c4789e1063e0ee
Reason for revert:
ScopedHandleTest.* tests fail to die on try bots.
BUG=618205
Original issue's description:
> Add a buildflag to use the handle verifier in a per module mode.
>
> The HandleVerifier prevent you from using any ScopedHandle during a module initialization (i.e. if a DLL use one in DllMain this will call back into its host executable that hasn't been initialized yet and things will derail). In this CL I'm adding a build flag to make it possible to use it in a single module mode..
>
> Committed: https://crrev.com/a89708a5c1bfe778ed1615f0bc92f0e9ae2e2192
> Cr-Commit-Position: refs/heads/master@{#398361}
TBR=wfh@chromium.org,chrisha@chromium.org,thakis@chromium.org,sebmarchand@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2047013003
Cr-Original-Commit-Position: refs/heads/master@{#398496}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 71f86049e34c437a0a7498b231bb19353486f81f
"android_tool_prefix" within the toolchain definitions was always being
keyed off of target_cpu rather than the toolchain cpu.
BUG=616819
Review-Url: https://codereview.chromium.org/2036263002
Cr-Original-Commit-Position: refs/heads/master@{#398463}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d13c10da70c170ddbdb044ef752f98a870915eee
The HandleVerifier prevent you from using any ScopedHandle during a module initialization (i.e. if a DLL use one in DllMain this will call back into its host executable that hasn't been initialized yet and things will derail). In this CL I'm adding a build flag to make it possible to use it in a single module mode..
Review-Url: https://codereview.chromium.org/1977833003
Cr-Original-Commit-Position: refs/heads/master@{#398361}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a89708a5c1bfe778ed1615f0bc92f0e9ae2e2192
The 'bin' part should be lowercase. This matters on case-sensitive
filesystems, such as those commonly used on Linux.
BUG=495204
Review-Url: https://codereview.chromium.org/2046633005
Cr-Original-Commit-Position: refs/heads/master@{#398340}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7a5ad5a66ab0283e2c8093b2e3f04ad1a22e337e
Chrome on iOS uses different format by default for the "CFBundleVersion"
and "CFBundleShortVersionString" Info.plist values.
Change _AddVersionKeys function to take as parameter a dictionary from
Info.plist keys to version format using @MAJOR@, @MINOR@, @BUILD@ and
@PATCH@ patterns to represent the different component of the version,
and pass a different dictionary depending on the platform.
Refactor how the version is extracted using the build/util/version.py
script (it was invoked twice, but the second invocation can be removed
as the output needs to be post-processed).
BUG=502295,616750
Review-Url: https://codereview.chromium.org/2044893002
Cr-Original-Commit-Position: refs/heads/master@{#398323}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8001eee13920c32ca685f6700bbe2db77eed8046
Without this explicit flag, the base-dir ends up as //chromium/src
within a webrtc checkout rather than //.
BUG=webrtc:5956
Review-Url: https://codereview.chromium.org/2046523003
Cr-Original-Commit-Position: refs/heads/master@{#398298}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9cdbc547091fcb196cc49720811af83510670e8f
There were a couple of build file issues that broke the ASAN Debug
bot and the MSAN bots on the lkgr waterfall. This CL fixes those issues,
and also flips the MSAN bots back to GYP since the main MSAN bots
are still kinda broken and it's easier to keep them all consistent.
TBR=mbarbella@chromium.org
BUG=605732
Review-Url: https://codereview.chromium.org/2048513002
Cr-Original-Commit-Position: refs/heads/master@{#398215}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7319eac326e6a9474a572cebd0c6fff9a5035ad0
The Mac and iOS GN bots don't currently limit the number of concurrent
links. The official continuous win bots aren't on MB because they can't
limit the number of concurrent links through MB.
This CL adds a 'concurrent_links' arg to GN, which calls the
get_concurrent_links script to get the appropriate default value
(making this consistent across platforms), and also adds a hack
to MB to translate a gyp_link_concurrent "GYP_DEFINE" to the
GYP_LINK_CONCURRENCY env var.
The CL also adds a test for this MB hack and the similar, already existing
LLVM_FORCE_HEAD_REVISION hack.
R=scottmg@chromium.org, brettw@chromium.org
BUG=602480, 611491, 616390
Review-Url: https://codereview.chromium.org/2031233002
Cr-Original-Commit-Position: refs/heads/master@{#398200}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ec079268641d3d284884a5acf55d75af6065f549
Reason for revert:
Breaking quota-related tests in content_browsertests
https://crbug.com/617213
Original issue's description:
> Reland of Move side-loaded test data /sdcard -> /sdcard/chromium_tests_root
>
> Reason for reland:
> Updated webview tests that broke (WebViewLayoutTest.java)
>
> And use delete_device_stale=True when pushing. This will prevent tests
> mistakenly passing when they depend on stale data files from a previous test.
>
> TBR=jbudorick@chromium.org,thakis@chromium.org,mef@chromium.org
> BUG=607169
>
> Committed: https://crrev.com/2524a0db714a44fbce723e00f6ed914e6d143cb6
> Cr-Commit-Position: refs/heads/master@{#396479}
TBR=jbudorick@chromium.org,thakis@chromium.org,mef@chromium.org,torne@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=607169,617213,616155
Review-Url: https://codereview.chromium.org/2044523003
Cr-Original-Commit-Position: refs/heads/master@{#398137}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 55ff9438e11da5a78a6ba5d100cebfcfdbc07deb
Reason for revert:
The Clang warning was removed again in r271761.
Original issue's description:
> Suppress -Wnonportable-include-path on clang tot bots
>
> BUG=617318
> R=hans@chromium.org
>
> Committed: 2bc751024eTBR=thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=617318
Review-Url: https://codereview.chromium.org/2043813002
Cr-Original-Commit-Position: refs/heads/master@{#398065}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2b359d2e5b4f7639055c9c6ff3ed39a03a2a3a0b
Chromoting no longer relies on the sas.dll so we can clean up some of the
build files and remove these variables.
BUG=
Review-Url: https://codereview.chromium.org/2030423002
Cr-Original-Commit-Position: refs/heads/master@{#398057}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: de1387d31ef6fffe415c947ce3af245882f71fcf
This creates a new script called the linker driver, which runs all three
steps of linking: the image link, debug info link, and stripping. In GYP,
the last two steps were handled as postbuilds, but GN lacks those. Instead,
the linker driver performs all three operations in one build step.
BUG=330301,431177
R=mark@chromium.org,dpranke@chromium.org
Review-Url: https://codereview.chromium.org/1999513002
Cr-Original-Commit-Position: refs/heads/master@{#397880}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b89811bd0b77ae38f45359c6d78a5e06b997e499
In order to allow Chrome on iOS to use build/mac/tweak_info_plist.py,
add options required to control the format of the generated plist file
(--format), the product reported to breakpad (--platform) and a way to
override some portion of the version string (--version-overrides).
This is required to allow Chrome on iOS to migrate from it old fork of
tweak_info_plist shell script and to incorporate tweak_info_plist.py
in the GN build.
BUG=502295
Review-Url: https://codereview.chromium.org/2037043002
Cr-Original-Commit-Position: refs/heads/master@{#397745}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 77bf6652e84cfb17925382598e9e50873065b3c2
Chrome on iOS needs to use tweak_info_plist, so port support
for info_plist_target from mac_info_plist to ios_info_plist.
BUG=617134
Review-Url: https://codereview.chromium.org/2033403003
Cr-Original-Commit-Position: refs/heads/master@{#397727}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e0ab61670fb9d7826de41e313004a0e4d0379da6
Thus, add USE_EXTERNAL_POPUP_MENU flag so that Blimp Engine can follow the same code path of the external Android popup menus before it reaches WebContentsView.
BUG=598764
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/1992393002
Cr-Original-Commit-Position: refs/heads/master@{#397575}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c643d33cf668665bac4562e69a72f9ef29b5bbed
This allows to sanitize null pointer accesses and
could increase readability of the messages from UBSan Vptr bot
(once enabled there).
BUG=616268,616870
Review-Url: https://codereview.chromium.org/2028383006
Cr-Original-Commit-Position: refs/heads/master@{#397538}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2ec1834c98f0fd1caf86983f31d0d1a122e0ad1e
If DEPOT_TOOLS_WIN_TOOLCHAIN=0 and vcvarsall.bat has not been run then
WINDOWSSDKDIR will probably not be set and copying cdb\cdb.exe will fail
when copy_cdb_to_output.py tries to read WINDOWSSDKDIR from environ.
This change handles that case by using the default SDK location.
BUG=616146
Review-Url: https://codereview.chromium.org/2030723002
Cr-Original-Commit-Position: refs/heads/master@{#397483}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 250abd283b7db0274df689e6b0dad571fd180a4f
Implement the assets catalog compilation without using mac_tool.py
from tools/gyp in order to make //build independent from the rest
of Chromium checkout.
BUG=616813
Review-Url: https://codereview.chromium.org/2023223002
Cr-Original-Commit-Position: refs/heads/master@{#397469}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 17dd77eb2af78643ffeb32bbb2ee48c2d22106e7
Robolectric uses javac annotation processors when building. This
means it will need to pass some "-processor RobolectricProcessor" to
javac as well as some "-Akey=value" args
Additionally, since this processor is run by javac, Robolectric can't
be compiled using the interface.jars. This is why I am adding an
enable_interface_jars_javac option for GN.
Finally, Robolectric uses the Java services functionality. I will
need to add some configs to the META-INF/services/ dir in the
Robolectric jars for this to work correctly. This is the purpose
of the --provider-configurations option I am adding.
BUG=
Review-Url: https://codereview.chromium.org/2014983003
Cr-Original-Commit-Position: refs/heads/master@{#397262}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 14569c856b4cd3a362f89a3b913f744b9a210732
Start using bundled gold as default linker for Linux MIPS,
since gold in current bundled binutils (2.26) supports mips32.
BUG=none
TEST=Build Chromium for Linux MIPS
Review-Url: https://codereview.chromium.org/2027173002
Cr-Original-Commit-Position: refs/heads/master@{#397246}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 867134974146cb103320e398e7544b717bbbc0fe
thakis
bpastene
milko.leporis
agrieve
sdefresne
sebmarchand
glider
battre
haibinlu
hans
dpranke
rnephew
jbudorick
joedow
rsesek
Gordana.Cmiljanovic
jochen
krasin
brucedawson
hzl
mikecase
watk