Reason for revert:
Attempting to fix cronet build issues.
Original issue's description:
> Revert of Remove android_support_annotations target. (patchset #2 id:20001 of https://codereview.chromium.org/2137433002/ )
>
> Reason for revert:
> Broke the tree
>
> Original issue's description:
> > Remove android_support_annotations target.
> >
> > android-support-annotations.jar and android-support-v13.jar both define android.support.annotations. Since we use both, this can produce errors building when we try to use android.support.annotations in a new target (eg com.android.dex.DexException: Multiple dex files define Landroid/support/annotation/AnimRes).
> >
> > android-support-annotations.jar contains a subset of android-support-v13.jar, so I am removing it and updating all dependencies to point to the latter.
> >
> > BUG=623012
> >
> > Committed: https://crrev.com/dd8383aa3af51d5c067e445c1390dc9eadc6a220
> > Cr-Commit-Position: refs/heads/master@{#404371}
>
> TBR=jochen@chromium.org,bauerb@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=623012
>
> Committed: https://crrev.com/2ccd50c3c7f17e770e511096af7d62e36f13135e
> Cr-Commit-Position: refs/heads/master@{#404390}
TBR=jochen@chromium.org,bauerb@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=623012
Review-Url: https://codereview.chromium.org/2140543002
Cr-Original-Commit-Position: refs/heads/master@{#404656}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3196a901443858f34e9c765f32a83eed978a9393
All .strings files that need to be in binary1 format are now
converted by using the "bundle_data_strings" template so the
conversion can be remove from "copy_bundle_data" tool.
BUG=625578
Review-Url: https://codereview.chromium.org/2130813002
Cr-Original-Commit-Position: refs/heads/master@{#404621}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f52c49dc18851aaf7ca4f3a78b5312350193f5ba
Reason for revert:
It's breaking the Gyp Official build and I can't fix this right now.
BUG=626828
Original issue's description:
> Move the Syzygy scripts out of //chrome/
>
> Also move the syzygy_optimize and syzygy_asan GN templates to //build/win/syzygy so they can be reused in //content (without adding a dependency with //chrome).
>
> BUG=619086
>
> Committed: https://crrev.com/71a43cab53042f33d77fe8eebe8c2463a92f9758
> Cr-Commit-Position: refs/heads/master@{#404503}
TBR=chrisha@chromium.org,dpranke@chromium.org,gab@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=619086
Review-Url: https://codereview.chromium.org/2129333002
Cr-Original-Commit-Position: refs/heads/master@{#404530}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6318d34b911380a6ebb3f1c8787024ba3e3400eb
Currently, the test runner only takes action on SIGTERM on test execution
threads and only stops at the end of a test shard. In some cases, this isn't
fast enough. This CL makes the main thread drop test execution.
This CL also tweaks the handling of test results to better handle UNKNOWNs.
BUG=
Review-Url: https://codereview.chromium.org/2134523002
Cr-Original-Commit-Position: refs/heads/master@{#404507}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6c04fde85a18fc3bc8498f9735b984beaf8209c7
Also move the syzygy_optimize and syzygy_asan GN templates to //build/win/syzygy so they can be reused in //content (without adding a dependency with //chrome).
BUG=619086
Review-Url: https://codereview.chromium.org/2126673002
Cr-Original-Commit-Position: refs/heads/master@{#404503}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 71a43cab53042f33d77fe8eebe8c2463a92f9758
All suites now use isolate files that are either generated from gn
data / data_deps or checked in to chromium.
BUG=
Review-Url: https://codereview.chromium.org/2131083003
Cr-Original-Commit-Position: refs/heads/master@{#404488}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e17088df1d6f3cab29c0c817d7f71def8a84841e
We used to not pass /GS since clang-cl used to not implement buffer security
checks and would warn about this flag being ignored. Now clang-cl implements
some form of buffer security checking and no longer warns on /GS, so that's
no longer necessary. This reverts the gyp bits of
https://codereview.chromium.org/1828543003/
/GS is also on by default, and as of https://codereview.chromium.org/1957523005
it's no longer explicitly passed in gn builds -- so no .gn files need to be
changed.
Since /GS is on by default, this CL doesn't change behavior.
BUG=598767
Review-Url: https://codereview.chromium.org/2129213002
Cr-Original-Commit-Position: refs/heads/master@{#404413}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: cc683aecb8e88d03139477b8eba81aeb1e3c2e9c
Reason for revert:
Broke the tree
Original issue's description:
> Remove android_support_annotations target.
>
> android-support-annotations.jar and android-support-v13.jar both define android.support.annotations. Since we use both, this can produce errors building when we try to use android.support.annotations in a new target (eg com.android.dex.DexException: Multiple dex files define Landroid/support/annotation/AnimRes).
>
> android-support-annotations.jar contains a subset of android-support-v13.jar, so I am removing it and updating all dependencies to point to the latter.
>
> BUG=623012
>
> Committed: https://crrev.com/dd8383aa3af51d5c067e445c1390dc9eadc6a220
> Cr-Commit-Position: refs/heads/master@{#404371}
TBR=jochen@chromium.org,bauerb@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=623012
Review-Url: https://codereview.chromium.org/2132033002
Cr-Original-Commit-Position: refs/heads/master@{#404390}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2ccd50c3c7f17e770e511096af7d62e36f13135e
android-support-annotations.jar and android-support-v13.jar both define android.support.annotations. Since we use both, this can produce errors building when we try to use android.support.annotations in a new target (eg com.android.dex.DexException: Multiple dex files define Landroid/support/annotation/AnimRes).
android-support-annotations.jar contains a subset of android-support-v13.jar, so I am removing it and updating all dependencies to point to the latter.
BUG=623012
Review-Url: https://codereview.chromium.org/2137433002
Cr-Original-Commit-Position: refs/heads/master@{#404371}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: dd8383aa3af51d5c067e445c1390dc9eadc6a220
This change modifies install-sysroot.py to add support for
installing ARM64 sysroot. Also update the jessie arm64 package list.
BUG=613452
Review-Url: https://codereview.chromium.org/2078293002
Cr-Original-Commit-Position: refs/heads/master@{#404323}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ad891a49ee7aeff1a42559c0a059cb51f053e1fb
Add a template "bundle_data_strings" to convert a .strings file to
binary1 property list format and declare it in a bundle_data target
(similar to "bundle_data_xib" template).
This is added in preparation of removing the automatic conversion
of .strings file to binary1 format by the "copy_bundle_data" tool
in build/toolchain/mac/BUILD.gn. There are no client upstream yet.
BUG=625578
Review-Url: https://codereview.chromium.org/2130743002
Cr-Original-Commit-Position: refs/heads/master@{#404142}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 02416e8ab9a11f44eba47d269cd0aa5fb843895b
udev support in Linux is used to get plug & play notification when an USB device
is plugged in. This is something that is unlikely to be used in Blimp Engine. So
disabling the code from Blimp Engine build.
BUG=625277
Review-Url: https://codereview.chromium.org/2112383003
Cr-Original-Commit-Position: refs/heads/master@{#403983}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a2c19e55cf5e0e87f2b99232182c1be0a94be9f1
Until now the protobuf generator targets in the build files
did hard-code the unconditional generation of C++ and python
stubs. There are two new upcoming use cases, that are,
bit.ly/TracingV2 (see BUG) and gRPC, where we need to generate
C++ stubs using a custom protoc plugin.
This CL introduces the plumbing necessary to the GYP/GN
build files to be able to pass an arbitrary plugin to
the protoc invocation. See crrev.com/2083373002 as an example of
how this will be used in upcoming CLs.
BUG=622680
Review-Url: https://codereview.chromium.org/2082693002
Cr-Original-Commit-Position: refs/heads/master@{#403981}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b241e6e5fa05e90eaa4199d4bc497869e3cf08e1
The limitation that static libraries can't be used in various targets on Mac has been lifted. Now components can unconditionally be static libraries on non-component builds.
BUG=618797
Review-Url: https://codereview.chromium.org/2111683002
Cr-Original-Commit-Position: refs/heads/master@{#403974}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b8adea3236abf4f866ea1265e279d5520b8a9fd0
Android templates have never been tested in non-default toolchains, and
should never be necessary since java is not toolchain-dependent.
BUG=none
Review-Url: https://codereview.chromium.org/2121833002
Cr-Original-Commit-Position: refs/heads/master@{#403963}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 09d787e26cac78497700f700c31361099bf9071a
Reason for revert:
Breaks ninja noticing when .java files change.
Original issue's description:
> Make Android .build_configs aware of prebuilts and java sources
>
> This information will be necessary for generating gradle projects for
> Android Studio.
>
> BUG=620034
>
> Committed: https://crrev.com/2bb3a690dc221b8a5dac4c4d99055e69ffe712b8
> Cr-Commit-Position: refs/heads/master@{#403822}
TBR=wnwen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=620034
Review-Url: https://codereview.chromium.org/2126003002
Cr-Original-Commit-Position: refs/heads/master@{#403939}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 333d257e513ae47c7f4d09895079a6dc6822ec62
Directories within srcjars are supposed to reflect java package names.
The extra path component was making Android Studio unhappy.
BUG=620034
Review-Url: https://codereview.chromium.org/2123003002
Cr-Original-Commit-Position: refs/heads/master@{#403897}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a6e90c933afa77aae92cab39edc89db34cd7455e
This will make them available on builder/tester configurations (they are
within gen/ at the moment). It will also make their location more
obvious for archiving / de-obfuscating purposes.
BUG=none
Review-Url: https://codereview.chromium.org/2117153002
Cr-Original-Commit-Position: refs/heads/master@{#403705}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 19b7958ad4e0214898e8033c1ee908364ab20fb7
When building Chrome on iOS there are 60000+ copy_bundle_data steps,
so using a python script is slow. Instead re-implement the logic in
pure shell and using hard-links when possible.
Improve the build time of a clobber build by 4.6x (measured on a
Mac Pro using goma with a reduction from 32m24.498s to 7m1.310s
according to "time").
Commands used to time the build:
$ gn clean out/gn-Debug-iphoneos
$ time ninja -j 1000 -C out/gn-Debug-iphoneos All_iOS
BUG=621030
Review-Url: https://codereview.chromium.org/2106353004
Cr-Original-Commit-Position: refs/heads/master@{#403696}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d5e358f61f3d6257062cdc6a6ec6a76104273ca7
The existing assumption in the code (that the existense of package name
within android_resource() rules determines whether they should be
linted) turned out to be false.
The new logic does not look at package names, but instead collects all
reference resources, and then excludes any of them that were already
linted by another android_library().
BUG=621774
Review-Url: https://codereview.chromium.org/2113943002
Cr-Original-Commit-Position: refs/heads/master@{#403687}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a12be529fb88039cc3090a83c4fbaaf04e13b144
Investigation of why official chrome_elf.dll builds were 86,016 bytes
larger on gn than gyp showed that encryption functions such as
aesni_cbc_encrypt were being pulled in. Deleting the implementations
of these functions from the .asm file caused no errors which proved that
the functions weren't being referenced, they just weren't being
discarded. Changing the yasm_assemble template to use static_library
fixed that and made the file sizes identical.
Comparison of the dia2dump -p output after that change showed there were
still two extra symbols in the gn builds:
class breakpad::CrashKeysWin * breakpad::CrashKeysWin::keeper_
__aullrem(__aullrem)
keeper_ is a global variable - those are harder to discard, even with
/Gw - but making its source file part of a static_library fixed it.
link /verbose showed that __aullrem is pulled in by an object file that
is then discarded but I decided that following that trail wasn't worth
it. The file sizes are identical and dumpbin /headers shows that the
.text sections virtual size is just 96 bytes larger in the gn case.
Additional changes of source set to static_library may address the
remaining diffs, but they are not large enough to matter.
TL;DR The linker tries to discard unreferenced symbols but it is not
perfect at doing it, even with /Gw and /Gy. Assembly functions may be
difficult also. Use source_set with care.
BUG=624274
Review-Url: https://codereview.chromium.org/2114783002
Cr-Original-Commit-Position: refs/heads/master@{#403480}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0ab90cb1edf8f08f1fa5d2551aa21cac225163cf
Removes extra v8 snapshot and natives validation on Windows. All platforms
have the same validation henceforth.
BUG=501799
Review-Url: https://codereview.chromium.org/2103903002
Cr-Original-Commit-Position: refs/heads/master@{#403430}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 10b5a96b363a6ff23176d27a2e7fb1bba300f089
jbudorick
apatole
sebmarchand
peconn
sdefresne
smaier
marshall
thakis
bpastene
michaelbai
davidben
skobes
tzik
agrieve
Paweł Hajdan, Jr
antz
sriramsr
kraynov
brettw
benwells
pcc
mikecase
brucedawson
oth