Several test fixes are included to support this change.
Note: This CL only provides a GYP implementation (no GN). This is not a
regression from the previous state.
BUG=510211
Review URL: https://codereview.chromium.org/1282603005
Cr-Original-Commit-Position: refs/heads/master@{#344128}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 62ca3f0326203cca221bba6f0ee038ff292ecc66
Added fractional line coverage to line by line coverage information so that the fractional line coverage will be available in generated JSON files.
Changed logging level of skipped files.
BUG=
Review URL: https://codereview.chromium.org/1284083004
Cr-Original-Commit-Position: refs/heads/master@{#343944}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 39bc8c2a5c6a7b9b4f97d2b29359e151b9ccf402
Currently, it throws an exception to know it cannot do hardware level disable, this
changes it to use profile discovery to decide how to disable charging.
BUG=520958
Review URL: https://codereview.chromium.org/1293143002
Cr-Original-Commit-Position: refs/heads/master@{#343929}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c0202d6ab7d128fe54e6fea8ab654918e5e2f3f2
When EMMA files are missing (i.e. the emma_filter didn't cover the java
source file that was changed) the script should still run properly.
Handled missing EMMA files by skipping them and only running coverage
stats on source files that have corresponding EMMA files.
Also updated tests.
BUG=
Review URL: https://codereview.chromium.org/1299693003
Cr-Original-Commit-Position: refs/heads/master@{#343917}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7d5973f6998a87987c474585fe1ac3179a39480b
It is contained in the SDK manager package google_play_services
version 26. Running hooks/gyp/gn will check the local version
and prompt to run the update if it is needed.
BUG=491280,477059
Review URL: https://codereview.chromium.org/1292753002
Cr-Original-Commit-Position: refs/heads/master@{#343862}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0c50961006cd76b2a20f445a6f296535664e777d
The shared library flags currently being passed should only be passed in
component builds. The location of dylibs in a non-component build is already
known so it’s superfluous to specify additional search paths via rpath.
-search_paths_first is the default on ld starting with the Xcode4 toolchain.
-L. isn’t needed since the absolute path of the dylib is being specified at link time.
R=mark,dpranke,thakis
BUG=345021
Review URL: https://codereview.chromium.org/1298783003
Cr-Original-Commit-Position: refs/heads/master@{#343793}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 465929bd9eccfd0de10965867e0378eee4a24dd5
Specify enable_topchrome_md as a grit define, which
will be used to specify new asset IDs which
are only applicable to platforms affected by
the material design refresh in browser top chrome.
BUG=520992
TEST=none
Review URL: https://codereview.chromium.org/1299433002
Cr-Original-Commit-Position: refs/heads/master@{#343415}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 01b7e6102e67d35eb46060f05901f62955ca6e62
now that the required GMSCore client lib has landed.
This compiles in the support for safe browsing, but functionality is
gated by the AndroidSafeBrowsing field trial that is
disabled by default.
BUG=474608
Review URL: https://codereview.chromium.org/1290153002
Cr-Original-Commit-Position: refs/heads/master@{#343306}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1587e02948b25f38f4fb9ecfdec715e3d8e18711
This adds support for some of test binaries needed in the
'archive_gpu_tests=true' config of a GYP build:
- content_gl_tests
- gles2_conform_tests
- gl_tests
- tab_capture_end2end_tests
There is still more work to be done (telemetry_gpu_tests,
angle_end2end_tests, angle_deqp_*_tests).
R=brettw@chromium.org
BUG=519778
Review URL: https://codereview.chromium.org/1285063002
Cr-Original-Commit-Position: refs/heads/master@{#343095}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: dbdd9d8a60cde386ab1ccab51bd2d818c5b45657
Currently gtests have logic for detecting platform errors on the remote device
platform. This moves it up to the base class for remote_device_test_run and
adds this functionality to instrumentation test runs.
BUG=485842
Review URL: https://codereview.chromium.org/1279873004
Cr-Original-Commit-Position: refs/heads/master@{#343052}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f768a19437cfcee351469c104c442bc2be14b6fe
The android_coverage recipe expects a result file to be saved to the --out directory
regardless of if there were files requiring code coverage or not. If no files
require coverage, the script will now save an empty object to the output
file instead of returning early.
BUG=
Review URL: https://codereview.chromium.org/1290593002
Cr-Original-Commit-Position: refs/heads/master@{#342957}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1167cb33649c82a33bd18f8c08333113458939ff
The CFI diagnostic mode requires a runtime library, so we need to disable
-Wl,-z,defs in order to allow DSOs to link with undefined references to the
runtime library, as we do for the other sanitizers which require runtime
libraries.
The diagnostic mode can also issue better diagnostics if RTTI is enabled,
so enable RTTI if the diagnostic mode is enabled.
BUG=512614
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/1243373003
Cr-Original-Commit-Position: refs/heads/master@{#342955}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7f19422b7c2f1ecb2541a510321c9ae9ed1886ca
There are subtle generated dependency issues breaking
several bots. The code is upstream in the Mojo repo
at this point and we have no need for the GYP targets
in the foreseeable future.
BUG=519643
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/1279133006
Cr-Original-Commit-Position: refs/heads/master@{#342920}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 30011cdf506921f51db7113b54803b886ab928f3
If `build/vs_toolchain.py update --force` is run once on non-Windows, the
script will start keeping a Windows toolchain in depot_tools up-to-date, and
it'll copy runtime dlls into the build directory, and so on. (One can delete
build/win_toolchain.json to disable this behavior again.)
Depends on https://codereview.chromium.org/1284723006
BUG=495204
Review URL: https://codereview.chromium.org/1277913006
Cr-Original-Commit-Position: refs/heads/master@{#342917}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4f4b137f26afe39a02f789832e840757b11f088d
Previously, GN was using the sdk version as the deployment target,
which meant gn-built binaries couldn't run on OS X versions
older than 10.10 after updating the SDK to 10.10.
With this fix, mac GN matches the behavior of Mac GYP.
BUG=463170
Review URL: https://codereview.chromium.org/1285493004
Cr-Original-Commit-Position: refs/heads/master@{#342908}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e194adc1f7bdeeb500dcd357283d512651b6bf1b
This is copied from the gyp repo, ninja.py:
https://codereview.chromium.org/1255813005
VS 2015 uses about 20% more memory when linking. This caused a
severe page-fault storm on my development machine and subsequent tests
showed that linking could use ~63 GB of RAM (15 parallel links on a
64 GB machine). This suggests that VS 2013 would also be using a lot
of RAM (52.5 GB?) such that very little was left for other
applications or disk cache.
Linker working sets vary wildly but with VS 2013 there are six links
that use over 6 GB of working set and with VS 2015 there are seven.
This change reduces parallel links by 20% (increase RAM-per-linker by
25%). The value can be overridden by setting GYP_LINK_CONCURRENCY.
Tests with VS 2013 showed no statistically significant change in
build times when link concurrency was reduced from 15 to 10 or 12.
Further reductions may be prudent when we switch to VS 2015.
BUG=440500
R=brettw@chromium.org
Review URL: https://codereview.chromium.org/1261073004
Cr-Original-Commit-Position: refs/heads/master@{#342892}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ad86c6fcef0fbdf26da9165ae8bbbd3748201afc
For historical reasons gyp_chromium.py was launcher script
for gyp_chromium and the python logic lived in the
gyp_chromium. This change moves python code into the
.py file makes the extension-free gyp_chromium a launcher
for gyp_chromium.py.
Review URL: https://codereview.chromium.org/1216863010
Cr-Original-Commit-Position: refs/heads/master@{#342887}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1eeaa328a6e7d621857c0026d0a2dd448dbf0f65
The first reland caused Webkit layout test errors on 10.8 and 10.9. Those
errors have been fixed.
Original issue's description:
> mac: Switch the default build configuration to use the 10.10 SDK.
>
> This change is intended to be temporary. The goal is to release a Canary
> compiled against the 10.10 SDK, and then to revert this CL.
>
> BUG=463170
>
> Committed: https://crrev.com/42ba22e0b8e87f758804537f64db23ff6438e451
> Cr-Commit-Position: refs/heads/master@{#340992}
TBR=thakis@chromium.org,amineer@chromium.org
BUG=463170, 515836
Review URL: https://codereview.chromium.org/1268803004
Cr-Original-Commit-Position: refs/heads/master@{#342870}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a9cbe267748e0360f8c994a1c7209f86f33b944f
On my machine, this brings the time to run:
bin/run_base_unittests --gtest-filter PathUtilsTest.TestGetDataDirectory
from ~18 seconds to ~15 seconds
BUG=
Review URL: https://codereview.chromium.org/1234153004
Cr-Original-Commit-Position: refs/heads/master@{#342860}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 69a68c76ec6d27e8b27eeb0851bbc3247b700a3b
toolchain.gni introduces:
root_shlib_dir, shlib_prefix, and shlib_extension
The original goal of this change was to put shlibs under lib/ for Linux / Android, since that's where GYP puts them. However, the lack of support for loadable_module (or more specifically - per target output directory) in GN makes this infeasible at the moment.
This change also mitigates a subtle bug where on Android the unstripped .so is used mistakenly instead of the lib.stripped/ version. It also fixes shlib's link_output being set to the unstripped .so rather than the stripped .so (on Android).
BUG=509771
Review URL: https://codereview.chromium.org/1236503002
Cr-Original-Commit-Position: refs/heads/master@{#342697}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c3cd5e6fe977af4a3c8b20ccb332896b2c888354
iOS uses the same linker as Mac and thus should use the same linker flags
in Release mode (is_debug=false).
Fix the following error when linking base_unittest in Release mode:
FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++ -arch x86_64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator9.0.sdk -stdlib=libc++ -mios-simulator-version-min=7.0 -Wl,-O1 -Wl,--gc-sections -Wl,--as-needed -o ./base_unittests.app/base_unittests -Wl,-filelist,./base_unittests.app/base_unittests.rsp -framework UIKit -framework QuartzCore -framework OpenGLES -framework CoreFoundation -framework CoreGraphics -framework CoreText -framework Foundation
ld: unknown option: -O1
BUG=459705
Review URL: https://codereview.chromium.org/1274633004
Cr-Original-Commit-Position: refs/heads/master@{#342523}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5d2e00bce19e2fae5e1fa0419d78e92570026304
pvalenzuela
jbudorick
andybons
thakis
estevenson
rnephew
mmaliszkiewicz
dgn
sebmarchand
tdanderson
nparker
navabi
csharp
lizeb
tfarina
dpranke
agrieve
pcc
rockot
erikchen
brucedawson
sbc
dtu
bajones
sdefresne