This partly reverts commit 2a395c69f ("make use of existing gn args in
ui build config").
atk itself does not depend on gconf, and the change introduced in the
commit above was likely created before commit 95ba4446 ("Move linux
pkg_config() calls into separate BUILD.gn files"), when atk and gconf
were part of the same if block in build/config/linux/BUILD.gn.
See also: https://codereview.chromium.org/2241513002R=brettw@chromium.org,dpranke@chromium.org,mostynb@opera.com
BUG=632297
Review-Url: https://codereview.chromium.org/2248043002
Cr-Original-Commit-Position: refs/heads/master@{#412634}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 984335951bbc9b2d9532db8b8d1161494f79a105
Desktop Chromium OS is unable to build with the current wheezy sysroot because
it is missing libbluetooth-dev.
This CL adds libbluetooth to the wheezy sysroot. Eventually we will want to
build Chromium OS with the jessie sysroot, so added libbluetooth there as well.
Finally, added to trusty sysroot for good measure.
BUG=638394
Review-Url: https://codereview.chromium.org/2248973003
Cr-Original-Commit-Position: refs/heads/master@{#412397}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d61be279532de3e797906b26cdbb00516703dd31
The race condition is expected as we're racing the thread reclaim
logic. ThreadLocalStorage happens to not synchronize anything at the
moment. Adding a lock to synchronize usage of g_tls_destructors won't
actually fix the inherent race condition. In production, it's up the
owner to make sure that any references have cleaned up before
releasing the TLS slot.
Given that ThreadLocalStorage will be getting some locks in the future,
so I expect to be able to remove the suppression once that goes
through.
BUG=638378
Review-Url: https://codereview.chromium.org/2256493002
Cr-Original-Commit-Position: refs/heads/master@{#412362}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ad1893a4eeeb1775709005ad7df0081560fa27d3
Currently when the swarming bot cannot connect to a device to get logcats, it errors out with an exception.
Swarming tasks should continue to exectue with the remaining devices. Adding an if statement to check for the existence of device logcats to prevent
exceptions.
BUG=638051
Review-Url: https://codereview.chromium.org/2246863003
Cr-Original-Commit-Position: refs/heads/master@{#412152}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ab7b497976d171ee4d7ceac09e994002de38407b
Reason for revert:
Causing build failures, will update tracking bug with details.
Original issue's description:
> Add dex info and static initializers to resource_sizes.py
>
> The goal is to have a single script that reports all .apk
> size related metrics.
>
> * Uses method_count.py to get dex info.
> * Already had static initializer logic, but now shows it even without
> --so_with_symbols_path.
> * Tweaks the static initializer count logic to sum up rather for all
> .so files rather than report the same metric repeatedly.
>
> BUG=609365
>
> Committed: https://crrev.com/af1b0701484ff33965439440c43e620cf50a6056
> Cr-Commit-Position: refs/heads/master@{#411859}
TBR=rnephew@chromium.org,agrieve@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=609365
Review-Url: https://codereview.chromium.org/2243343004
Cr-Original-Commit-Position: refs/heads/master@{#412064}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 47fd25ce2fc9b8772836d2930de04ec4fa4edc8b
Reason for revert:
This is breaking earl grey tests downstream. I wonder why upstream eg tests aren't on the cq?
Before:
cmd LC_ID_DYLIB
cmdsize 64
name @rpath/EarlGrey.framework/EarlGrey (offset 24)
After:
cmd LC_ID_DYLIB
cmdsize 72
name obj/ios/third_party/earl_grey/x64/EarlGrey (offset 24)
Original issue's description:
> Always enable intermediate source_set.
>
> The _use_intermediate_source_set variable was there to workaround a
> bug in scoped_nsobject_unittest{,_arc}.mm that was exhibited by the
> introduction of an intermediate source_set. Remove the variable and
> consider that it is always set to "true".
>
> BUG=637065
>
> Committed: https://crrev.com/40865bdc7372f779689422a0c36cf8073d050366
> Cr-Commit-Position: refs/heads/master@{#411779}
TBR=dpranke@chromium.org,sdefresne@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=637065
Review-Url: https://codereview.chromium.org/2245903002
Cr-Original-Commit-Position: refs/heads/master@{#411873}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8bcd27585d5c063b9c19aba05ffe310781181402
With Xcode 8, the invocation of actool need to contain the type of
the bundle containing the asset catalog, pass the information from
the create_bundle target to the actool command.
BUG=634373
Review-Url: https://codereview.chromium.org/2236973004
Cr-Original-Commit-Position: refs/heads/master@{#411865}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: bf8b26608b67a274cf7b5ca99446043e9e197394
The goal is to have a single script that reports all .apk
size related metrics.
* Uses method_count.py to get dex info.
* Already had static initializer logic, but now shows it even without
--so_with_symbols_path.
* Tweaks the static initializer count logic to sum up rather for all
.so files rather than report the same metric repeatedly.
BUG=609365
Review-Url: https://codereview.chromium.org/2244653003
Cr-Original-Commit-Position: refs/heads/master@{#411859}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: af1b0701484ff33965439440c43e620cf50a6056
The _use_intermediate_source_set variable was there to workaround a
bug in scoped_nsobject_unittest{,_arc}.mm that was exhibited by the
introduction of an intermediate source_set. Remove the variable and
consider that it is always set to "true".
BUG=637065
Review-Url: https://codereview.chromium.org/2245513002
Cr-Original-Commit-Position: refs/heads/master@{#411779}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 40865bdc7372f779689422a0c36cf8073d050366
Reason for revert:
Broke Android Arm64 builder.
Original issue's description:
> Fail builds when lint warnings are generated.
>
> Suppress all existing lint warnings so that builds will fail when new
> warnings are generated. New lint warnings that are generated in files
> that are ignored in suppressions.xml will not be caught. However, now
> we can remove lint warnings on a file by file basis instead of having to
> fix all lint warnings before making lint break builds.
>
> BUG=607761
>
> Committed: https://crrev.com/49f5130f956057407d2219e37a978437bcdcf7fe
> Committed: https://crrev.com/9a52a7e12ad50f6f85e88c6a5636ce6e0a405dce
> Cr-Original-Commit-Position: refs/heads/master@{#411692}
> Cr-Commit-Position: refs/heads/master@{#411748}
TBR=agrieve@chromium.org,estevenson@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=607761
Review-Url: https://codereview.chromium.org/2236313004
Cr-Original-Commit-Position: refs/heads/master@{#411764}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0b8904601897107f297027eecbb7572bb7bf902d
Suppress all existing lint warnings so that builds will fail when new
warnings are generated. New lint warnings that are generated in files
that are ignored in suppressions.xml will not be caught. However, now
we can remove lint warnings on a file by file basis instead of having to
fix all lint warnings before making lint break builds.
BUG=607761
Committed: https://crrev.com/49f5130f956057407d2219e37a978437bcdcf7fe
Review-Url: https://codereview.chromium.org/2240573004
Cr-Original-Commit-Position: refs/heads/master@{#411748}
Cr-Original-Original-Commit-Position: refs/heads/master@{#411692}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9a52a7e12ad50f6f85e88c6a5636ce6e0a405dce
This cleans up some variable definitions around templates not marking variables used.
The chromevox directory worked around the bug by putting the variables to share
in a .gni file. This file can now be deleted and the contents merged with the
BUILD file (the only place it was included).
The iOS code referencing this bug seems to be mistaken, at least in some of the
cases. The conditions in that file do not trigger the variable used bug. The
build seems to work without this code, so I removed it.
BUG=395883
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2237233002
Cr-Original-Commit-Position: refs/heads/master@{#411738}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 84f93c430207e806a6a3746d4163990391c1fbc1
Reason for revert:
Causing compilation failure:
https://build.chromium.org/p/chromium.linux/builders/Android%20Builder/builds/71177
Original issue's description:
> Fail builds when lint warnings are generated.
>
> Suppress all existing lint warnings so that builds will fail when new
> warnings are generated. New lint warnings that are generated in files
> that are ignored in suppressions.xml will not be caught. However, now
> we can remove lint warnings on a file by file basis instead of having to
> fix all lint warnings before making lint break builds.
>
> BUG=607761
>
> Committed: https://crrev.com/49f5130f956057407d2219e37a978437bcdcf7fe
> Cr-Commit-Position: refs/heads/master@{#411692}
TBR=agrieve@chromium.org,estevenson@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=607761
Review-Url: https://codereview.chromium.org/2245663003
Cr-Original-Commit-Position: refs/heads/master@{#411700}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 71ab99083db4d384fc9ce687c9d1cd5300f3ef89
Suppress all existing lint warnings so that builds will fail when new
warnings are generated. New lint warnings that are generated in files
that are ignored in suppressions.xml will not be caught. However, now
we can remove lint warnings on a file by file basis instead of having to
fix all lint warnings before making lint break builds.
BUG=607761
Review-Url: https://codereview.chromium.org/2240573004
Cr-Original-Commit-Position: refs/heads/master@{#411692}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 49f5130f956057407d2219e37a978437bcdcf7fe
The code was appending grit to the python search path. This leads to
issues in environments where grit is installed as a system package.
Make sure to prepend the grit module from the source tree to the
search path to give it precedence over any other grit modules.
BUG=None
TEST=Build is green.
Review-Url: https://codereview.chromium.org/2228463002
Cr-Original-Commit-Position: refs/heads/master@{#411585}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6222f573984beee1dbdcb9004a0bf367531b318b
In order to roll GN 5822d6c9a8..4838fe571d (r410471:r411399) and pick up
the following changes:
ba1286d GN: Mark all variables used when defining a template.
fcd8d22 Stop pointing to "gn help toolchain" in that very help message.
db9ce41 Fix GN bootstrap
56350de GN: Throw an error overwriting a nonempty scope.
TBR=dpranke@chromium.org
Review-Url: https://codereview.chromium.org/2235373002
Cr-Original-Commit-Position: refs/heads/master@{#411478}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 08912711cf3a444f406777e9d055559b4d208a4e
Add new template lipo_binary that invokes lipo to create a fat binary
from multiple single architecture binaries (supports thin builds too).
Add new template create_signed_bundle that wraps create_bundle and add
the required parameters to create a signed bundle (supports building
with code signature disabled).
Refactor ios_app_bundle, ios_framework_bundle and ios_xctest targets
to use those two templates and reduce the code duplication. Introduce
intermediate source_set target to reduce dependencies on entitlements
generation for simulator builds.
BUG=635302
Review-Url: https://codereview.chromium.org/2219323002
Cr-Original-Commit-Position: refs/heads/master@{#411471}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 17a812f225abd54e84dbe4f74c9619d4bdab3cbf
|use_gconf| was added back in commit 2f4a32e98 ("linux gn config should
check use_gconf before looking for it with pkg-config") back when the
pkg-config calls to atk and gconf were grouped together within a single
if check.
Since then, commit 95ba4446 ("Move linux pkg_config() calls into
separate BUILD.gn files") has split all the pkg-config checks. As atk
itself does not depend on gconf, we can drop use_gconf from the
assertion in atk's BUILD.gn.
R=brettw@chromium.org,dpranke@chromium.org,mostynb@opera.com
BUG=632297
Review-Url: https://codereview.chromium.org/2241513002
Cr-Original-Commit-Position: refs/heads/master@{#411440}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9ca5a503b8f28258126226df203bef7fd316dfad
This comes up when a library / prebuilt has a dependency on apache http,
such as is the case with some play services libraries. If
pre-proguarding is turned off, the final apk proguard() step fails
without this change.
BUG=624324
Review-Url: https://codereview.chromium.org/2227523002
Cr-Original-Commit-Position: refs/heads/master@{#411358}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 71d53fa016887abec5807c7dfcd9e93ec0ab12a5
This is useful to see why /incremental is failing when it does. Also tidy up a bit of 2013 logic we don't need any more.
Review-Url: https://codereview.chromium.org/2234693002
Cr-Original-Commit-Position: refs/heads/master@{#411082}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ccb02e5b095c62d0a799b40a40f9a7ebebb8298d
When building for simulator, embedded.mobileprovision should not be
copied into the bundle, and not entitlement should be passed to the
"codesign" tool.
BUG=634373
Review-Url: https://codereview.chromium.org/2231723002
Cr-Original-Commit-Position: refs/heads/master@{#411006}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: aa4d65708c18e2b407f92654237ab2c1fdc3cea7
On iOS, the resources for an application and a framework bundle are
located in the root of the bundle (as opposed to macOS where they
are located in the Resources sub-directory).
The incorrect location caused code signature failure (when code
signature is enabled, which is only the case on downstream iOS
bots).
BUG=635302
Review-Url: https://codereview.chromium.org/2233663002
Cr-Original-Commit-Position: refs/heads/master@{#410984}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3cbe1a432673431822494cca4b8d662eca112d72
They should be created by default for sanitizer builds (and were w/
GYP), but that setting got lost in the GN migration.
Also, this CL corrects the default logic for enable_dsyms and
enable_stripping so that we only do this for internal official
builds by default, rather than for all "official" builds (
since is_official_build is really an optimization setting, not
a description of how things should be packaged).
R=rsesek@chromium.org, thakis@chromium.org, inferno@chromium.org
BUG=635242
Review-Url: https://codereview.chromium.org/2230723002
Cr-Original-Commit-Position: refs/heads/master@{#410979}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8b0cda7f8d3f9a4f1d53c78600fb0c62c7eec7f9
Reason for revert:
This breaks the stack_tool_for_tombstones step for many bots in https://build.chromium.org/p/chromium.android, like this:
W 0.547s Main No tombstones.
Traceback (most recent call last):
File "/b/c/b/Android_Webview_L__dbg_/src/build/android/tombstones.py", line 304, in <module>
sys.exit(main())
File "/b/c/b/Android_Webview_L__dbg_/src/build/android/tombstones.py", line 300, in main
W 0.547s Main No tombstones to resolve.
for line in resolved_tombstones:
TypeError: 'NoneType' object is not iterable
Please make sure to have proper tests in place before relanding.
Original issue's description:
> Added tombstones in instrumentation tests results.
>
> If an instrumentation test crashes, the cl will grab the tombstones and
> add the tombstones as a part of the result.
>
> BUG=631213
>
> Committed: https://crrev.com/d7dd97f2828447fb9af45ea119e703500b167cb8
> Cr-Commit-Position: refs/heads/master@{#410929}
TBR=mikecase@chromium.org,jbudorick@chromium.org,hzl@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=631213
Review-Url: https://codereview.chromium.org/2231693002
Cr-Original-Commit-Position: refs/heads/master@{#410977}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 691ffafc730315027ce0887c39d2d6393e5b2f26
If an instrumentation test crashes, the cl will grab the tombstones and
add the tombstones as a part of the result.
BUG=631213
Review-Url: https://codereview.chromium.org/2201833002
Cr-Original-Commit-Position: refs/heads/master@{#410929}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d7dd97f2828447fb9af45ea119e703500b167cb8
When targeting iOS, do not enforce a specific version of the macOS
SDK (as the targets build with that SDK are only tool required for
the build using host_toolchain).
BUG=634373
Review-Url: https://codereview.chromium.org/2225203003
Cr-Original-Commit-Position: refs/heads/master@{#410886}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 750b90480e0fcc67e292444cfdc350171bdaed06
The Posix toolchain definitions forwarded the target_cpu and target_os to all secondary toolchains. But the computation of these values should be invariant of the toolchain. This removes the forwarding.
Review-Url: https://codereview.chromium.org/2229063002
Cr-Original-Commit-Position: refs/heads/master@{#410883}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ec467a46f0e8760fae1928e4040d053caae843df
toolchain_args is changing from a function call to a scope that can be passed around. Pipe these args through the various toolchain templates. This adds complexity in some cases, but it eliminates the need for the toolchain templates to know about every build flag they might ever be called with.
BUG=634446
Review-Url: https://codereview.chromium.org/2219953002
Cr-Original-Commit-Position: refs/heads/master@{#410853}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3c38c5cdab9e6fc35852ae79be5351be2bd6d49e
Parse output of actool and discard uninteresting messages and
fail on unexpected warning messages (as actool termines with
a success error code even if some resources are missing).
BUG=635306
Review-Url: https://codereview.chromium.org/2224763002
Cr-Original-Commit-Position: refs/heads/master@{#410824}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5b150b0a5a28f95f651767f901819390fc065676
raphael.kubo.da.costa
mikecase
thomasanderson
robliao
siggi
estevenson
nicholaslin
hzl
amineer
justincohen
agrieve
sdefresne
caseq
brettw
Hans Wennborg
xidachen
mnissler
dpranke
peconn
rsesek
scottmg
phajdan.jr
kjellander