The sysroot are generally useful (for example when
cross compiling) and not limited to use in the installer
or official releases.
Another reason to move this is that it would allow other
projects to more easily share chromium's build setup
without depending on chrome/.
Also, rename the install script to simply install-sysroot.
This way the script can keep the same name and support
multiple different debian releases without needing
to duplicate the script (e.g. when we switch to jessie).
BUG=504446
TEST=cross build chromium for arm and ia32
Review URL: https://codereview.chromium.org/1141003002
Cr-Original-Commit-Position: refs/heads/master@{#336843}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8208b4d81396c11e1f8ca8f6ffe52b9fcea87d05
Introduces aprecompiled_header_type flag on a tool to say whether it supports precompiled headers, and flags on configs/targets that allow one to specify which header is precompiled.
This does not implement GCC precompiled headers, but the type flag will allow future expansion (the implementation will be mostly separate).
Renames SOURCE_CC to SOURCE_CPP to avoid confusion with Toolchain::TYPE_CC (which is actually the C compiler).
BUG=297678
Review URL: https://codereview.chromium.org/1207903002
Cr-Original-Commit-Position: refs/heads/master@{#336674}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3dab5fe87ddb0efe646f6ab393ab07533d75237d
The switch needed to be accessible from ui/base/resources for loading the different assets.
Also defined the ENABLE_TOPCHROME_MD compile time switch on linux builds.
TEST=MaterialDesignControllerTest.NonMaterialModeWhenCompileTimeFlagDisabled
TEST=MaterialDesignControllerTest.EnabledCommandLineValueMapsToMaterialModeWhenCompileTimeFlagEnabled
TEST=MaterialDesignControllerTest.EnabledHybridCommandLineValueMapsToMaterialHybridModeWhenCompileTimeFlagEnabled
TEST=MaterialDesignControllerTest.DisabledCommandLineValueMapsToNonMaterialModeWhenCompileTimeFlagEnabled
TEST=MaterialDesignControllerTest.NoCommandLineValueMapsToNonMaterialModeWhenCompileTimeFlagEnabled
TEST=MaterialDesignControllerTest.InvalidCommandLineValueFails
BUG=501366
Review URL: https://codereview.chromium.org/1188713007
Cr-Original-Commit-Position: refs/heads/master@{#336442}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0d89d6ac4a77feaa44da9cb4abb456ca800981b4
It's already passed unconditionally everywhere if clang is used, there's
no need to pass it again for clang/win.
BUG=82385,428099
Review URL: https://codereview.chromium.org/1208363002
Cr-Original-Commit-Position: refs/heads/master@{#336431}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e0ad0cfd95a0e90bcfb817168cade7bd1143ada4
It's inconclusive if this caused a cold start performance regression -- graphs
went up when this first landed, but they didn't recover after the revert.
And on a zoomed-out scale, the graphs didn't go up much, so maybe that was
just noise. Relanding to see if it has an effect again (if so, I will revert
this again).
BUG=492809,492177
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1211623003
Cr-Original-Commit-Position: refs/heads/master@{#335985}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: eca59926d104516f65793063c6a5c04855a8a3fd
Apply relocation packing to ia32 and mips32 builds.
Deferred for x64 pending migration of an ndk bug fix into the
chromium tree. See b/20532404.
BUG=385553
Review URL: https://codereview.chromium.org/1178573002
Cr-Original-Commit-Position: refs/heads/master@{#335921}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 00ad6ff02565ee933f61b08c7f38723a307d7902
These changes let the errorprone compiler find problems when building Android.
A global flag disabled Errorprone by default.
When enabled, code problems will be shown with suggestions on how to fix them.
BUG=485599
Review URL: https://codereview.chromium.org/1136573002
Cr-Original-Commit-Position: refs/heads/master@{#335509}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6ffb1179d6adf08edd64848b45b7415b6b6de43d
Original issue's description:
> Roll buildtools fa660d47..ecc8e253
>
> fa660d47..ecc8e253
>
> ecc8e25 Roll GN #330790:#333203 (9d04333f..4e3e57b2)
> 46ce8cb Optionally support relative include paths in cpp_checker.py
> b983eee Fix the .gitignore rules to complain about linux32 if need be.
>
> The GN roll contains the following changes to tools/gn:
>
> 9d04333f..4e3e57b2/tools/gn
>
> 56affab Check for inputs not generated by deps
> e903c0f Allow directories for GN data lists.
> ff0986f GN: Make file/dir resolving return errors.
> b73b2de Add support for module-definition files to gn
> 58a1b33 Add base/files/file_tracing.cc to tools/gn/bootstrap/bootstrap.py.
> 92acc5e gn: Add a newline to fix a bulleted list in README.md.
> 81d969a Fix missing print command in a GN error case.
> a9adafe Make GN header checker more lenient about toolchains.
>
> In addition, the Linux build of GN was the first build with
> use_ozone=true use_glib=false in order to not have a runtime
The roll was reverted because #335350 introduced a new target in //chrome/android
that had some missing deps. This attempt at the roll includes a fix for that.
TBR=brettw@chromium.org, agrieve@chromium.org
CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_dbg,mac_chromium_gn_rel;tryserver.chromium.win:win8_chromium_gn_dbg;tryserver.chromium.linux:linux_chromium_gn_chromeos_dbg
Review URL: https://codereview.chromium.org/1198693002
Cr-Original-Commit-Position: refs/heads/master@{#335412}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 55c615dc327046f24354b815e1edc795ed52bccb
This is a prerequisite for having them live within APK splits.
Although pak files need to be renamed to be stored under res/raw,
ResourceExtractor restores their original name during extraction (so no
change to native code).
All sub-locales are stored and extracted together, just as before.
BUG=371610
Review URL: https://codereview.chromium.org/1158053005
Cr-Original-Commit-Position: refs/heads/master@{#335350}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f30e04470453ccd7e6a9abf586185b991d174902
Startup data files are now stored uncompressed within the .apk, increasing size of the apk, but decreasing total disk requirements (since they don't need to be extracted).
BUG=394502
Review URL: https://codereview.chromium.org/1156873002
Cr-Original-Commit-Position: refs/heads/master@{#335271}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6f3002d9e87d690bb368931faa2c3ba4638f811e
Also changes so that browser process caches a FD to the file rather than re-opening it for each child process.
We store icudtl.dat uncompressed in the apk now, increasing the apk size, but saving 6mb on-disk.
BUG=394502
Review URL: https://codereview.chromium.org/1147213004
Cr-Original-Commit-Position: refs/heads/master@{#335261}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f3930cfae7a93c5065588c9ba7be5c6927f46588
Reason for revert:
Unreverting because this CL did not end up being the problem.
Original issue's description:
> Revert of views: Move TOOLKIT_VIEWS definition in //ui/views/ from root. (patchset #6 id:100001 of https://codereview.chromium.org/1175603002/)
>
> Reason for revert:
> Speculative revert to fix win unit_test failures. https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/39651
>
> Original issue's description:
> > views: Move TOOLKIT_VIEWS definition in //ui/views/ from root.
> >
> > If 'toolkit_views' gyp/gn flag is toggled, then it shouldn't cause targets that
> > do not depend on views to be rebuilt. To make this happen, remove the definition
> > of the TOOLKIT_VIEWS flag from the top-level config into a config in views, so
> > that only targets that explicitly depend on views get the define, and are
> > affected by the switch.
> >
> > BUG=500004
> > R=ben@chromium.org, sky@chromium.org
> >
> > Committed: c13fc9ff0a
>
> TBR=ben@chromium.org,sky@chromium.org,sadrul@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=500004
>
> Committed: https://crrev.com/ecbf7e40116d555c11ee958b6339618920d11c2c
> Cr-Commit-Position: refs/heads/master@{#334820}
TBR=ben@chromium.org,sky@chromium.org,sadrul@chromium.org,phoglund@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=500004
Review URL: https://codereview.chromium.org/1182053007
Cr-Original-Commit-Position: refs/heads/master@{#334923}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 27b328bf38b552b1576c0a0368c00a36be5ec781
Reason for revert:
Speculative revert to fix win unit_test failures. https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/39651
Original issue's description:
> views: Move TOOLKIT_VIEWS definition in //ui/views/ from root.
>
> If 'toolkit_views' gyp/gn flag is toggled, then it shouldn't cause targets that
> do not depend on views to be rebuilt. To make this happen, remove the definition
> of the TOOLKIT_VIEWS flag from the top-level config into a config in views, so
> that only targets that explicitly depend on views get the define, and are
> affected by the switch.
>
> BUG=500004
> R=ben@chromium.org, sky@chromium.org
>
> Committed: c13fc9ff0aTBR=ben@chromium.org,sky@chromium.org,sadrul@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=500004
Review URL: https://codereview.chromium.org/1192583002
Cr-Original-Commit-Position: refs/heads/master@{#334820}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ecbf7e40116d555c11ee958b6339618920d11c2c
Reason for revert:
Appears this was innocent after all.
Original issue's description:
> Revert of Sync Windows build flags between GYP and GN (patchset #4 id:60001 of https://codereview.chromium.org/1183613006/)
>
> Reason for revert:
> Speculative revert for Linux GN clobber compile failure:
>
> FAILED: python ../../remoting/webapp/build-webapp.py ...
> Traceback (most recent call last):
> File "../../remoting/webapp/build-webapp.py", line 487, in <module>
> sys.exit(main())
> File "../../remoting/webapp/build-webapp.py", line 483, in main
> return buildWebApp(**vars(args))
> File "../../remoting/webapp/build-webapp.py", line 257, in buildWebApp
> + buildtype + ': ' + service_environment)
> Exception: Invalid service_environment targeted for Release:
> ninja: build stopped: subcommand failed.
>
> Original issue's description:
> > Sync Windows build flags between GYP and GN
> >
> > In GN, turn on omtimize:max for base targets on all platforms, not just Android (matches GYP).
> >
> > In GN, don't duplicate /Os twice, make standard optimize = /O1 (matches GYP). Don't specify redundant optimization flags that are included as part of /O1 or /O2 (doesn't match GYP flag-wise, but should match functionality-wise).
> >
> > In GN, add a min Windows version of XP to x86 architecture binaries (matches GYP).
> >
> > In GYP, remove /GT ("EnableFiberSafeOptimizations"). This flag is super old (pre-dates GYP) and was likely turned on because it has the word "optimization" in it. It was only specified in official builds. However, according to the docs, this is making optimizations fiber safe (i.e. slower, by not caching the TLS pointer), rather than enabling optimizations for fibers. We don't use fibers so this flag is unnecessary and may be making TLS access slightly slower.
> >
> > Committed: https://crrev.com/67021f4d70fe838a5d78133bc6d5b305dfd70d72
> > Cr-Commit-Position: refs/heads/master@{#334742}
>
> TBR=scottmg@chromium.org,brettw@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/1becf72a2d1b5eec4468cc950142b083e9b24fbe
> Cr-Commit-Position: refs/heads/master@{#334782}
TBR=scottmg@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1184953004
Cr-Original-Commit-Position: refs/heads/master@{#334795}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6a18ffd1f1e656bba0d905c30fad6b46ec4ffcff
If 'toolkit_views' gyp/gn flag is toggled, then it shouldn't cause targets that
do not depend on views to be rebuilt. To make this happen, remove the definition
of the TOOLKIT_VIEWS flag from the top-level config into a config in views, so
that only targets that explicitly depend on views get the define, and are
affected by the switch.
BUG=500004
R=ben@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/1175603002.
Cr-Original-Commit-Position: refs/heads/master@{#334785}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c13fc9ff0aedca62ebfdfc27d44c6b5ac204c9d8
Reason for revert:
Speculative revert for Linux GN clobber compile failure:
FAILED: python ../../remoting/webapp/build-webapp.py ...
Traceback (most recent call last):
File "../../remoting/webapp/build-webapp.py", line 487, in <module>
sys.exit(main())
File "../../remoting/webapp/build-webapp.py", line 483, in main
return buildWebApp(**vars(args))
File "../../remoting/webapp/build-webapp.py", line 257, in buildWebApp
+ buildtype + ': ' + service_environment)
Exception: Invalid service_environment targeted for Release:
ninja: build stopped: subcommand failed.
Original issue's description:
> Sync Windows build flags between GYP and GN
>
> In GN, turn on omtimize:max for base targets on all platforms, not just Android (matches GYP).
>
> In GN, don't duplicate /Os twice, make standard optimize = /O1 (matches GYP). Don't specify redundant optimization flags that are included as part of /O1 or /O2 (doesn't match GYP flag-wise, but should match functionality-wise).
>
> In GN, add a min Windows version of XP to x86 architecture binaries (matches GYP).
>
> In GYP, remove /GT ("EnableFiberSafeOptimizations"). This flag is super old (pre-dates GYP) and was likely turned on because it has the word "optimization" in it. It was only specified in official builds. However, according to the docs, this is making optimizations fiber safe (i.e. slower, by not caching the TLS pointer), rather than enabling optimizations for fibers. We don't use fibers so this flag is unnecessary and may be making TLS access slightly slower.
>
> Committed: https://crrev.com/67021f4d70fe838a5d78133bc6d5b305dfd70d72
> Cr-Commit-Position: refs/heads/master@{#334742}
TBR=scottmg@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1185963004
Cr-Original-Commit-Position: refs/heads/master@{#334782}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1becf72a2d1b5eec4468cc950142b083e9b24fbe
In GN, turn on omtimize:max for base targets on all platforms, not just Android (matches GYP).
In GN, don't duplicate /Os twice, make standard optimize = /O1 (matches GYP). Don't specify redundant optimization flags that are included as part of /O1 or /O2 (doesn't match GYP flag-wise, but should match functionality-wise).
In GN, add a min Windows version of XP to x86 architecture binaries (matches GYP).
In GYP, remove /GT ("EnableFiberSafeOptimizations"). This flag is super old (pre-dates GYP) and was likely turned on because it has the word "optimization" in it. It was only specified in official builds. However, according to the docs, this is making optimizations fiber safe (i.e. slower, by not caching the TLS pointer), rather than enabling optimizations for fibers. We don't use fibers so this flag is unnecessary and may be making TLS access slightly slower.
Review URL: https://codereview.chromium.org/1183613006
Cr-Original-Commit-Position: refs/heads/master@{#334742}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 67021f4d70fe838a5d78133bc6d5b305dfd70d72
Remove -gdwarf-4 from GYP build. This is the default for GCC 4.8 which is now required, so this command-line argument is redundant.
Only set use_debug_fission in the GN build in debug mode. This matches GYP. Release mode symbols will be non-fission.
Implement linux_symbols target in GN. Convert dump_app_syms from sh to Python for better GN usability, and it's more readable for normal programmers on the team.
Reland of https://codereview.chromium.org/1179393004/TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/1182663007
Cr-Original-Commit-Position: refs/heads/master@{#334690}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 07d847b1c5451748f16f4e7973ce8ef9078d47a2
Reason for revert:
Broke the Linux GN Clobber bot:
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20Clobber/builds/1271/steps/compile/logs/stdio
ninja: error: '../../build/linux/dump_app_syms', needed by 'obj/chrome/linux_symbols.inputdeps.stamp', missing and no known rule to make it
Original issue's description:
> Fix some build symbol configuration.
>
> Remove -gdwarf-4 from GYP build. This is the default for GCC 4.8 which is now required, so this command-line argument is redundant.
>
> Only set use_debug_fission in the GN build in debug mode. This matches GYP. Release mode symbols will be non-fission.
>
> Implement linux_symbols target in GN. Convert dump_app_syms from sh to Python for better GN usability, and it's more readable for normal programmers on the team.
>
> BUG=
>
> Committed: https://crrev.com/950889c01dd934acf28bce29ea6db75610a8c441
> Cr-Commit-Position: refs/heads/master@{#334510}
TBR=thakis@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/1182783006
Cr-Original-Commit-Position: refs/heads/master@{#334522}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 520e8fd6084a0b3f1ec1011273730c4c6e392d09
Remove -gdwarf-4 from GYP build. This is the default for GCC 4.8 which is now required, so this command-line argument is redundant.
Only set use_debug_fission in the GN build in debug mode. This matches GYP. Release mode symbols will be non-fission.
Implement linux_symbols target in GN. Convert dump_app_syms from sh to Python for better GN usability, and it's more readable for normal programmers on the team.
BUG=
Review URL: https://codereview.chromium.org/1179393004
Cr-Original-Commit-Position: refs/heads/master@{#334510}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 950889c01dd934acf28bce29ea6db75610a8c441
Reason for revert:
Broke some official builds (http://crbug.com/500393). Will roll clang forward instead.
Original issue's description:
> Build: Don't pass /GL to Clang on Windows
>
> Windows Clang's support for LTO isn't ready to take on Chrome yet.
>
> BUG=82385
> R=thakis@chromium.org
> TBR=scottmg
>
> Committed: 4e76e7926eTBR=scottmg@chromium.org,hans@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=82385
Review URL: https://codereview.chromium.org/1185133004
Cr-Original-Commit-Position: refs/heads/master@{#334419}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7ec6a579b7e47f84b384b98b6f04ee65beb55758
sammc
dcheng
sbc
scottmg
agrieve
brettw
Nico Weber
bruthig
dgn
dbeam
simonb
bajones
raywilliams
qinmin
dpranke
hans
paulmeyer
phoglund
Sadrul Habib Chowdhury
mek
thestig
tmoniuszko