Build rule is not hooked up to any targets yet, but will be used in a
future commit to create split APKs.
.gypi also forthcoming.
BUG=447152
Review URL: https://codereview.chromium.org/1118403004
Cr-Original-Commit-Position: refs/heads/master@{#329850}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 81cc62af7059b65fe7d4d6dfd420f7cacd03ddc9
Android executable do not support rpath, and the executable is
displaying a warning on launch if it is present. The warning is :
unused DT entry: type 0xf arg 0xa35
R=dpranke@chromium.org,brettw@chromium.org
Review URL: https://codereview.chromium.org/1141723002
Cr-Original-Commit-Position: refs/heads/master@{#329663}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 90acb0f2b53bfa3ae632f9391a8f8f6e5dcde9eb
SafeBrowsingDatabaseManager: Pure interface
TestSafeBrowsingDatabaseManager: Dummy impl for tests
LocalSafeBrowsingDatabaseManager: Existing full impl.
RemoteSafeBrowsingDatabaseManager: New for Android
Wire up the safe_browsing=3 build-mode to switch Android to
use Remote*. Move SafeBrowsingCheck into Local* and create
the Test* impl that can't accidentally call a real
implementation's methods. Adjust tests to use either Test*
or Local*.
The initial implementation of Remote* does the bookeeping
of requests, but doesn't yet make calls to Java and isn't
tested.
BUG=474608
Review URL: https://codereview.chromium.org/1110723002
Cr-Original-Commit-Position: refs/heads/master@{#329551}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b2cd5eef530be7100274af882af3f5aff4d1c4be
The C++ define OFFICIAL_BUILD wasn't getting set, and the widevine version .rc files was getting linked twice.
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
R=dpranke
TBR=ddorwin@chromium.org
Review URL: https://codereview.chromium.org/1134623003
Cr-Original-Commit-Position: refs/heads/master@{#329308}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 303920e6cd9d352e7a7b4e9bdcc2f28a30ac22fa
Originally landed in crrev.com/1104703003
Reverted in crrev.com/1129103002 due to breaking GN APKs with no
resouces. This now handles the case where aapt doesn't generate an
R.txt (no resources) by creating an empty R.txt.
Generate extra packages' R.java files only containing the resources
listed in their R.txt files. This significantly reduces the number of
DEX field IDs taken up by resources.
BUG=480036
R=cjhopman,yfriedman
Review URL: https://codereview.chromium.org/1136653002
Cr-Original-Commit-Position: refs/heads/master@{#329219}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4b5d0300e3fa2a382ac3c1c157247a82583d7ed0
Since yesterday, it works on Windows. This allows us to not
completely clobber the build from update.py each time, since the
build system tracks the dependency instead.
It should also be possible to use this from gn, so we can delete the
posix-print-revision.py script. The only problem was that the
hack we use for fixing the output in gclient runhooks didn't work.
I've adjusted that to not fail when the hack doesn't work.
BUG=483065
R=scottmg@chromium.org, thakis@chromium.org
Review URL: https://codereview.chromium.org/1127233002
Cr-Original-Commit-Position: refs/heads/master@{#328699}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: cd20b07ab7edf2a7bab8e34362cebe5f92b41a27
Reason for revert:
Looks like this broke the world: http://build.chromium.org/p/chromium.fyi/console?category=win%20clang
Original issue's description:
> Use Clang's update.py --print-revision everywhere.
>
> Since yesterday, it works on Windows. This allows us to not
> completely clobber the build from update.py each time, since the
> build system tracks the dependency instead.
>
> It should also be possible to use this from gn, so we can delete the
> posix-print-revision.py script. The only problem was that the
> hack we use for fixing the output in gclient runhooks didn't work.
> I've adjusted that to not fail when the hack doesn't work.
>
> BUG=483065
>
> Committed: https://crrev.com/828bba82c5ed315cf073ad9599c0d5334a9a403d
> Cr-Commit-Position: refs/heads/master@{#328634}
TBR=scottmg@chromium.org,hans@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=483065
Review URL: https://codereview.chromium.org/1131813002
Cr-Original-Commit-Position: refs/heads/master@{#328672}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 05320c6a7b8695c843c6d4de10261e7a65fafcb3
Reason for revert:
Breaks gn apks with no resources.
Original issue's description:
> Actually use --extra-r-text-files in process_resources.py
>
> Generate extra packages' R.java files only containing the resources
> listed in their R.txt files. This significantly reduces the number of
> DEX field IDs taken up by resources.
>
> BUG=480036
> R=cjhopman
>
> Committed: https://crrev.com/a92cf235709397c737d5d9fdbadfb62e497c0334
> Cr-Commit-Position: refs/heads/master@{#328565}
TBR=yfriedman@chromium.org,msw@chromium.org,cullinan@amazon.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=480036
Review URL: https://codereview.chromium.org/1129103002
Cr-Original-Commit-Position: refs/heads/master@{#328664}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 61ff577cdede4b1e04846ef4af71659d194219b0
Since yesterday, it works on Windows. This allows us to not
completely clobber the build from update.py each time, since the
build system tracks the dependency instead.
It should also be possible to use this from gn, so we can delete the
posix-print-revision.py script. The only problem was that the
hack we use for fixing the output in gclient runhooks didn't work.
I've adjusted that to not fail when the hack doesn't work.
BUG=483065
Review URL: https://codereview.chromium.org/1127233002
Cr-Original-Commit-Position: refs/heads/master@{#328634}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 828bba82c5ed315cf073ad9599c0d5334a9a403d
Generate extra packages' R.java files only containing the resources
listed in their R.txt files. This significantly reduces the number of
DEX field IDs taken up by resources.
BUG=480036
R=cjhopman
Review URL: https://codereview.chromium.org/1104703003
Cr-Original-Commit-Position: refs/heads/master@{#328565}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a92cf235709397c737d5d9fdbadfb62e497c0334
Switch all Android builds to use libc++ instead of stlport.
This change originally landed in crrev.com/315085, but was reverted in
crrev.com/315174 due to CQ execution time regressions.
The root cause of the test time regression was determined to be an issue
with MD5 hash computation, where hashing failed to produce a consistent
result in turn preventing deployment optimizations. This was resolved in
crbug.com/456396, leaving libc++ test runs comparable with stlport runs.
BUG=456396,427718
Review URL: https://codereview.chromium.org/951983002
Cr-Original-Commit-Position: refs/heads/master@{#328296}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9f355f21c4049c622c71fc66a50e0288c5211335
The first pass of moving the other Chrome-specific build flags out of the root build config file and into the new one. This requires both ffmpeg and Blink changes to finish landing.
Originally landed as https://codereview.chromium.org/1120803003/TBR=scottmg@chromium.orgTBR=ddorwin@chromium.org (widevine)
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
Review URL: https://codereview.chromium.org/1123433002
Cr-Original-Commit-Position: refs/heads/master@{#327998}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2b2364bb2c6fbb88e6a4550abeb9141bc7cb949c
When we build 'all' in GN, we can end up building targets that are
defined in various build files even if they are not transitively referenced
from 'gn_all' or 'gn_only'. This is undesirable because it makes it harder
to tell when there might be discrepancies between the GN and GYP builds.
Some of these targets may actually be hidden (using the visibility tag)
and only intended to be depended on by other targets that don't work yet.
By making this targets also visible to a top-level "//:gn_visibility"
target we can ensure that we're tracking them properly without breaking
the normal encapsulation rules.
The two targets affected in this patch are
- //build/config/sanitizers:options_sources
- //ui/resources:repack_ui_test_mac_locale_pack
R=brettw@chromium.org
BUG=431177
CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
Review URL: https://codereview.chromium.org/1121453004
Cr-Original-Commit-Position: refs/heads/master@{#327922}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b6128d057b09ade62d23528b6f919d5007f9defc
This will allow us to flip a flag to enable warnings-as-errors once
the Windows code is cleaned up enough without building a new plugin
binary.
Also, try not to compute the diagnostic level in multiple places.
BUG=467287, 483065
Review URL: https://codereview.chromium.org/1117163002
Cr-Original-Commit-Position: refs/heads/master@{#327852}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a7ae971275f2aa0a7a6501c72b571939c44baa2b
Most importantly, this passes cflags_cc to the C++ compiler.
This fixes some flag differences with the GYP build, especially when running on 64 bit.
It disables a TLS test on static debug x64 builds which also fails in GYP. This configuration is not run on the bots but is the standard GN Windows build.
BUG=251251
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
Review URL: https://codereview.chromium.org/1062743005
Cr-Original-Commit-Position: refs/heads/master@{#326856}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9a19ddbe04e2be759a15c6a70f6585152611af23
An apk may provide instrumentation for itself or another apk. When
providing instrumentation for another apk, the target for that apk
should be added to the android_apk() target as apk_under_test. This
ensures that the instrumentation apk is built correctly.
TBR=yfriedman@chromium.org
BUG=359249
Review URL: https://codereview.chromium.org/1072193011
Cr-Original-Commit-Position: refs/heads/master@{#326723}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d61e56e5b33c3c19db6fd6bf4e2536a982d42ec2
This adds the apk_under_test variable to the android_apk template. When this is
set, we will build the apk as though it is an instrumentation test for the apk
set in apk_under_test. When building an instrumentation test apk, the dex file
should not contain libraries that are already included in the apk_under_test
(the dex files from both apks are loaded into the classloader when running
tests).
The dex files to be included are calculating in write_build_config.py.
BUG=359249
Review URL: https://codereview.chromium.org/1096793003
Cr-Original-Commit-Position: refs/heads/master@{#326398}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7b9ba2e6b4f149845360a6e0f3fa4b0ac459e6be
This switches the USE_OPENSSL Linux and CrOS builds to continue
setting USE_NSS_CERTS. This lets it use BoringSSL for the crypto
and SSL stack and NSS for certificate verification. See design
doc for details on the flags:
https://docs.google.com/document/d/1x4DOCKwFkAxl9MGfd6snIzFigO4ku6Shuci0r5BzasQ/edit
On Linux, only client auth and OCSP stapling are missing. On ChromeOS,
there are some problematic USE_NSS_CERTS APIs in RSAPrivateKey to
resolve. We also still need to resolve crbug.com/347404 to maintain
parity.
As a follow-up, USE_OPENSSL_CERTS on non-Android can now be
removed (it was never supported anyway).
BUG=462040
Review URL: https://codereview.chromium.org/881213004
Cr-Original-Commit-Position: refs/heads/master@{#326222}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2bcbc6bceb6017c762ef01553a55a12fe390de16
Centralize the configuration and break things down into individual sub-systems to enable, rather than referring to feature bundles.
I will in a later CL add safe_browsing==3 for enabling XLB on Android, which will define SAFE_BROWSING_DB_REMOTE. When launched, this will replace mode 2.
SAFE_BROWSING_SERVICE - enable the browser to talk to the server.
SAFE_BROWSING_DB_LOCAL - maintain local database(s) synced from the server.
SAFE_BROWSING_DB_REMOTE - talk via API to an external DB (i.e. XLB).
SAFE_BROWSING_CSD - client-side phishing detection support.
This is nearly a copy of shess@'s 8-month-old
https://codereview.chromium.org/397853002/ which was LGTMed. Diffs: Mostly merge conflicts, a rename, and few files added
BUG=394379,474608
Review URL: https://codereview.chromium.org/1081403002
Cr-Original-Commit-Position: refs/heads/master@{#325775}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 333f169bf09e1c455ea821520010ec8cc9658990
USE_NSS is confusing because it's not actually the analog of USE_OPENSSL; it's
the analog to USE_OPENSSL_CERTS. This is in preparation for the chimera build
which will set USE_OPENSSL and USE_NSS(_CERTS).
This CL was partially done automatically by the following command:
git grep -l USE_NSS | xargs sed -i -e 's/defined(USE_NSS)/defined(USE_NSS_CERTS)/'
The remaining were caught by the following command and fixed manually:
git grep 'USE_NSS\([^_]\|$\)'
Finally, the following command verified nothing in a separate repository was
sensitive to this change:
find . -name '*.cc' -o -name '*.h' | xargs grep 'USE_NSS\([^_]\|$\)'
For now, the old name is still defined, but not used within Chromium.
A follow-up CL will remove deprecated use_nss and USE_NSS #defines
together which will then cause downstream churn. Though from a grep
of known downstreams, the churn seems to be fairly minimal. The
removal is split from this CL so that, if we need to revert, the
CL to revert is small.
TBR=pneubeck@chromium.org
BUG=462040
Review URL: https://codereview.chromium.org/1082123003
Cr-Original-Commit-Position: refs/heads/master@{#325710}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 71f35ff13af84be1b97483307e050d83c2179134
The GN rules for the JNI generator currently generate the --includes
argument (that is, the #include line which gets emitted in the
generated jni.h header) in the following way:
generate_jni: always relative to the src root (e.g., content/foo/bar.h)
this is achieved by rebasing the jni_generator_include against //.
generate_jar_jni: relative to on root_build_dir (typically out/Release,
hence ../../content/foo/bar.h). This is achieved by rebasing the
jni_generator_include against root_build_dir.
generate_jni is fine, but relies on the target having set the root
src/ dir in the include path. The latter, instead, happens to work
only by accident because the targets that currently use it (currently
just surface_jni_headers) happen to have an include path which is at
distance two from the root src/ (so the generated #include
"../../base" happens to work).
This CL fixes both cases and causes the generated include to be always
relative to the destination folder of the generated header
(jni_output_dir). Furthermore, this change removes the dependency on
the generated header path. Rationale: the file itself is not an input
for the generator, the --include string gets just copied and pasted
into the generated file. Hence, the generator should not be re-run if
the contents of the jni_generator_helper.h changes.
Review URL: https://codereview.chromium.org/1093643002
Cr-Original-Commit-Position: refs/heads/master@{#325604}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9d6b1606854a8786e94858e1f65b2ae451e58ddf
Remove the final remaining references to android_webview_build and
delete the variable itself from common.gypi and config.gni.
BUG=440793
Review URL: https://codereview.chromium.org/1086583002
Cr-Original-Commit-Position: refs/heads/master@{#325033}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 62adf72afec378e8e22a8c3f549b86100ebfea2f
Change the example provided in rules.gni for declaring a java executable
target to java_binary instead of java_library.
BUG=476112
Review URL: https://codereview.chromium.org/1075863003
Cr-Original-Commit-Position: refs/heads/master@{#324932}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8c8162e4c9d3cc2310cc290b10b8d509f876b607
In https://codereview.chromium.org/1071573003
the testing/android/ directory was moved into
testing/android/native_test/ which broke the
Opus test_opus_padding target. It's built as
part of the 'all' target, which is why it hasn't
been noticed (Android GN bots build chrome_shell_apk).
Review URL: https://codereview.chromium.org/1079963002
Cr-Original-Commit-Position: refs/heads/master@{#324836}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ac81bcc78bc4a74dc7e4e473c5833d2aad0103df
Adds a new junit_binary template for gyp which makes it easy to
make new Junit test suites by setting a lot of the options and
necessary dependencies for you.
Also, adds a new java_binary.gypi file which uses the
create_java_binary_script.py similiar to how the java_binary
GN template works when main_class is specified. This lets
GYP and GN work similiar when building a junit binary, so
our test runner can run them the same way.
Finally, because of the slightly different way were now running
the junit binary, the java classpath contains all of the jars
instead of just the test jar (before we were running
java -jar test_jar.jar which set the classpath to just be
test_jar.jar). Therefore, we can simplify things and just look
in the classpath for the paths to the Robolectric dependencies
when running Robolectric junit tests.
BUG=
Review URL: https://codereview.chromium.org/1057783002
Cr-Original-Commit-Position: refs/heads/master@{#324093}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1ad64324d470c43b29854282d5ad5b1ff75dfc6c
ChromeOS may use 32bit userspace on 64bit kernel. Make sure all 64bits are used when acessing file.
note: _FILE_OFFSET_BITS is already set to 64 on posix.
BUG=471407
Review URL: https://codereview.chromium.org/1059613002
Cr-Original-Commit-Position: refs/heads/master@{#323688}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f33a81c14818d8cdde53e3dc34f1b1344a4583f3
It requires internal test files, hence it was not tested.
Partially tested on Linux with the following command lines:
$ gn gen out-gn --args='internal_gles2_conform_tests'
Formatted with the following command line:
$ gn format --in-place gpu/gles2_conform_support/BUILD.gn
BUG=432959
TEST=see above
R=dpranke@chromium.org,sievers@chromium.org
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
Review URL: https://codereview.chromium.org/1033373002
Cr-Original-Commit-Position: refs/heads/master@{#323082}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 719f00367465a6b940dc2804be147a0b23546cf4
Remove most references to android_webview_build from the build directory
now that we no longer support that build configuration. Fold conditions
into their parents where appropriate. Leave the variable itself defined
to 0 as not all uses in the tree have been removed yet.
A few references are left alone here and will be removed separately in
later changes that will be larger refactorings to eliminate other
variables.
BUG=440793
Review URL: https://codereview.chromium.org/1043913002
Cr-Original-Commit-Position: refs/heads/master@{#323013}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c6fe7a775af41cd98533e89a902b8b67044caa87
It requires internal test files, hence it was not tested.
Partially tested on Linux with the following command lines:
$ gn gen out-gn --args='internal_gles2_conform_tests'
BUG=432959
TEST=see above
R=dpranke@chromium.org,sievers@chromium.org
Review URL: https://codereview.chromium.org/1041883002
Cr-Original-Commit-Position: refs/heads/master@{#322639}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c0d45b8572d49861651342cb01fd85f956dc3309
Now that os and cpu_arch are no longer needed or used anywhere.
R=brettw@chromium.org, rockot@chromium.org
BUG=344767
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
Review URL: https://codereview.chromium.org/1017273002
Cr-Original-Commit-Position: refs/heads/master@{#322499}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c329085593402937717484c073086cb1c904f37b
Previously the condition was reversed. We can only do incremental linking when symbols are disabled. I was hoping it would work for minimal symbols but I tested and it still fails.
This patch only does incremental linking when symbols are completely disabled.
Review URL: https://codereview.chromium.org/1027543003
Cr-Original-Commit-Position: refs/heads/master@{#322196}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2229d96aae1d38fbdc87455dc10da44ffbfdb1c0
With the recent bugfixes (see BUG=), hi-dpi support on Linux works well enough
to enable it by default.
BUG=143619
Review URL: https://codereview.chromium.org/1028703004
Cr-Original-Commit-Position: refs/heads/master@{#321865}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a27daaff43d65055a62aee8aca3415901ec3eb33
The MacViews browser were missing infobar and background tab assets.
mac_views_browser grit define is added so that we can include infobar assets.
Don't remap theme image ids so that Mac's background tab assets can be
found.
Map IDR_THEME_TAB_BACKGROUND_INCOGNITO to the same asset as
IDR_THEME_TAB_BACKGROUND.
BUG=425229
Review URL: https://codereview.chromium.org/983823004
Cr-Original-Commit-Position: refs/heads/master@{#321602}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c306fb9a8d5179f34589d6ab330a71ebd40eb073
Makes chrome.dll on Windows not use incremental linking since the ilk files get too large.
This refactors the incremental linking configuration to make it easier to change the default.
BUG=
Review URL: https://codereview.chromium.org/1019353004
Cr-Original-Commit-Position: refs/heads/master@{#321585}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8900cf9444fc3e0adf6728926c96337ccadc9674
As announced on chromium-dev: http://goo.gl/NqrmLk (and after
discussions with chrome-eng-review).
This CL shouldn't change any user-visible UI, just change the way Chrome
is built on Mac. Soon, we will explore running ui/app_list/views/ on Mac
rather than the (outdated) ui/app_list/cocoa/.
A ~0.43% sizes regression on Mac is expected with this CL (~652kB
uncompressed). Full details in a doc: http://goo.gl/oHucmf
With this change, toolkit-views test cases in interactive_ui_tests will
start running on bots. views_unittests will be added to the Mac bots in
a follow-up.
BUG=363529
Committed: https://crrev.com/c11ec57849fd579c7a5559413488c018ea532311
Cr-Commit-Position: refs/heads/master@{#321075}
Review URL: https://codereview.chromium.org/984513002
Cr-Original-Commit-Position: refs/heads/master@{#321294}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1ebbc90cc5e90df29fbfc0c72d792c71f09351c1
Reason for revert:
Failing on GN build :(.
Link: http://build.chromium.org/p/chromium.mac/builders/Mac%20GN/builds/5288
E.g. display_change_listener_aura.cc:38:43:error: member access into incomplete type 'NSView'
Original issue's description:
> Enable toolkit_views=1 by default on Mac
>
> As announced on chromium-dev: http://goo.gl/NqrmLk (and after
> discussions with chrome-eng-review).
>
> This CL shouldn't change any user-visible UI, just change the way Chrome
> is built on Mac. Soon, we will explore running ui/app_list/views/ on Mac
> rather than the (outdated) ui/app_list/cocoa/.
>
> A ~0.43% sizes regression on Mac is expected with this CL (~652kB
> uncompressed). Full details in a doc: http://goo.gl/oHucmf
>
> With this change, toolkit-views test cases in interactive_ui_tests will
> start running on bots. views_unittests will be added to the Mac bots in
> a follow-up.
>
> BUG=363529
>
> Committed: https://crrev.com/c11ec57849fd579c7a5559413488c018ea532311
> Cr-Commit-Position: refs/heads/master@{#321075}
TBR=sky@chromium.org,scottmg@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=363529
Review URL: https://codereview.chromium.org/1011363002
Cr-Original-Commit-Position: refs/heads/master@{#321079}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c3bdb1c16c88005acdc0f22394a6780e805ae72f
As announced on chromium-dev: http://goo.gl/NqrmLk (and after
discussions with chrome-eng-review).
This CL shouldn't change any user-visible UI, just change the way Chrome
is built on Mac. Soon, we will explore running ui/app_list/views/ on Mac
rather than the (outdated) ui/app_list/cocoa/.
A ~0.43% sizes regression on Mac is expected with this CL (~652kB
uncompressed). Full details in a doc: http://goo.gl/oHucmf
With this change, toolkit-views test cases in interactive_ui_tests will
start running on bots. views_unittests will be added to the Mac bots in
a follow-up.
BUG=363529
Review URL: https://codereview.chromium.org/984513002
Cr-Original-Commit-Position: refs/heads/master@{#321075}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c11ec57849fd579c7a5559413488c018ea532311
This is checked on startup to ensure that the native lib is the right
version (used to workaround a platform bug that falied to extract the
native lib during updates).
Review URL: https://codereview.chromium.org/1007053002
Cr-Original-Commit-Position: refs/heads/master@{#320617}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 460d30e0297ece99ff070f0a5df9cc9eda25d0ee
Reason for revert:
Caused compile failure on Linux x64 bot (http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/56532)
Output snippet:
FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash ../out/Release/installer/debian/build.sh -o../out/Release -b ../out/Release -a x64 -c unstable
dpkg-shlibdeps: warning: binaries to analyze should already be installed in their package's directory.
2a3
> libatk1.0-0 (>= 1.12.4)
ERROR: Shared library dependencies changed!
If this is intentional, please update:
chrome/installer/linux/debian/expected_deps_ia32
chrome/installer/linux/debian/expected_deps_x64
Original issue's description:
> Resurrect Aura Linux accessibility.
>
> This is based in part on the ATK code we had as part of the Linux GTK port
> that went away, but now rewritten on top of AXPlatformNode. This patch
> successfully exposes an accessibility tree for Views and exposes top-level
> windows and the the role and name of each View. You can test it using
> accerciser. This is just to get the infrastructure in place - we need to
> implement more of the interface for it to be useful for accessibility tools.
>
> BUG=463671
>
> Committed: https://crrev.com/f65bad877350b5f7857d29e4b1b0d4d3f5c7cb6d
> Cr-Commit-Position: refs/heads/master@{#320383}
TBR=plundblad@chromium.org,dpranke@chromium.org,sky@chromium.org,gunsch@chromium.org,dmazzoni@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=463671
Review URL: https://codereview.chromium.org/1002993002
Cr-Original-Commit-Position: refs/heads/master@{#320402}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 999e4c26444e68898d4fa642783263b6e408b7e3
This is based in part on the ATK code we had as part of the Linux GTK port
that went away, but now rewritten on top of AXPlatformNode. This patch
successfully exposes an accessibility tree for Views and exposes top-level
windows and the the role and name of each View. You can test it using
accerciser. This is just to get the infrastructure in place - we need to
implement more of the interface for it to be useful for accessibility tools.
BUG=463671
Review URL: https://codereview.chromium.org/975113002
Cr-Original-Commit-Position: refs/heads/master@{#320383}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f65bad877350b5f7857d29e4b1b0d4d3f5c7cb6d
This also adapts net GN targets to use the new size_t->int warning suppression config in //build/config/compiler instead of a locally defined config.
BUG=
Review URL: https://codereview.chromium.org/936313002
Cr-Original-Commit-Position: refs/heads/master@{#320187}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 707a56a6f0e56138fcef5db3ba7ace1ac3cb83eb
'gn check' for ui/gl:* in an android build currently fails with the
error message:
ERROR at //base/android/jni_generator/jni_generator_helper.h:11:11: Include not allowed.
^-------------------------
It is not in any dependency of //ui/gl:surface_jni_headers__jni_Surface
The include file is in the target(s):
//base:base
which should somehow be reachable from //ui/gl:surface_jni_headers__jni_Surface
This target does not produce files that compile, so checking includes is
less useful.
R=brettw@chromium.org
Review URL: https://codereview.chromium.org/961033003
Cr-Original-Commit-Position: refs/heads/master@{#318983}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 63e12fcc153d47463432954d1826c393c0962600
The bots still use 'cpu_arch' to set the architecture, and the build
file was keying off of build_cpu_arch to determine whether or not
to enable NaCl, so things were failing. Updating the the code to
'current_cpu' fixes the problem correctly.
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/964003002
Cr-Original-Commit-Position: refs/heads/master@{#318585}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1c35162ea310ab09b3bb72fe1bfe95232db5d1a6
mips_dsp_rev specifies the MIPS DSP ASE (Application-Specific
Extension) revision number. Possible values are 0 (unavailable), 1,
and 2. Default to 0.
mips_float_abi specifies whether or not MIPS floating-point coprocessor
instructions should be used. Possible values are "hard" and "soft".
Default to "hard".
mips_fpu_mode specifies the width of MIPS32 floating-point registers.
Possible values are "fp32", "fp64", and "fpxx". Default to "fp32".
The companion webrtc CL is
https://webrtc-codereview.appspot.com/39779004.
R=brettw@chromium.org,kjellander@@chromium.org,petarj@mips.com
BUG=446234
Review URL: https://codereview.chromium.org/883253003
Cr-Original-Commit-Position: refs/heads/master@{#318524}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ff66006e62449071ab87ad01b025dac4a9029d06
I don't think any other config will work at the moment.
Note that this is also totally untested, but should at least compile :).
R=brettw@chromium.org
BUG=432959
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
Review URL: https://codereview.chromium.org/954383002
Cr-Original-Commit-Position: refs/heads/master@{#318329}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2ea95fb51c079912c99ff90a4579e02d802a73e9
This should get most of NaCl and the PPAPI stuff needed
for NaCl building and linking. There is more work to be
done to get some of the test binaries working (and
probably fill out parts of the NaCl SDK) and possibly
some pnacl support work remaining as well.
NaCl is still disabled by default (set enable_nacl=true
to change). Enabling nacl is still mostly untested and
likely doesn't work at all :).
R=ncbray@chromium.org, brettw@chromium.org
BUG=432959
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
Review URL: https://codereview.chromium.org/877553008
Cr-Original-Commit-Position: refs/heads/master@{#318180}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6065cf751340a8a99b670357b2053ed6df12a7af
Since clang has trouble with aliases for static functions, go back to
using a trivial wrapper function instead of an alias. Since there is
only one caller of the wrapped, static function, and its address is no
longer taken to generate the manual JNI registration table (the
wrapper's address is already being taken instead), there's no actual
benefit to using an alias anyway, since the compiler will simply inline
the static function into the wrapper.
BUG=442327,460857
TBR=cjhopman@chromium.org
Review URL: https://codereview.chromium.org/953523003
Cr-Original-Commit-Position: refs/heads/master@{#317787}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: cab875835ac9e39183ba0ac4fe30e96d1bdfec45
Mips builds hit this warning when linking the mesa library with libc++.
Temporarily disable the warning until a permanent solution can be found.
BUG=456380
Review URL: https://codereview.chromium.org/898403003
Cr-Original-Commit-Position: refs/heads/master@{#317709}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c60179098e97dfda6c3fda982a028a27c9235805
Add a new mode to the JNI generator which emits both native JNI exports
and manual registration code, and use this as the default mode (except
when compiling with clang as a clang bug prevents this from working at
present).
Native JNI exports are stripped from binaries by default to enforce that
the correct manual registration code is called (and to save increasing
the dynamic symbol table size), except for binaries that explicitly opt
in to using native exports (i.e. libwebviewchromium). Native exports are
not compatible with the crazy linker, so cannot be used universally.
The WebView-specific call to InitReplacementClassLoader, required by
native export mode, has been moved to base to make it easy for other
binaries to experiment with that mode.
Manual JNI registration can be disabled with a call to
base::android::DisableManualJniRegistration at the beginning of
JNI_OnLoad and this has been added to WebView. We plan to refactor the
Android library entry points to make it possible to avoid needing this
flag by just not calling JNI registration but the work is still ongoing;
the flag gets us the desired WebView startup time improvement in the
meantime.
BUG=442327
Review URL: https://codereview.chromium.org/920883002
Cr-Original-Commit-Position: refs/heads/master@{#317434}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 103bf19477cc121eee7a3c2bdc221f2874c971c3
Fix errors. Most of the problems were in net. Moves CreateAndConnectStreamForTesting's declaration to the header corresponding to the file it's implemented in.
Adds the other directories that don't pass yet to the list commented out so
it's easier to see what's still left.
TBR=armansito@chromium.org
Review URL: https://codereview.chromium.org/936953004
Cr-Original-Commit-Position: refs/heads/master@{#317425}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: bc44c0a95e9904154e2af47fb2dba8c37e169a13
We would like to be able to default to the ARM CPU for
Android builds, not the host cpu (so that you can get the
default Android build by just specifying os="android");
prior to my cpu_arch -> target_cpu changes, this was the
case, but I accidentally broke this.
However, the target_cpu changes at least allow us to remove
the target_arch hack which was how they were accomplishing
this before :).
TBR=brettw@chromium.orgR=cjhopman@chromium.org
BUG=344767
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
Review URL: https://codereview.chromium.org/946683002
Cr-Original-Commit-Position: refs/heads/master@{#317419}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 55187fbe2d3264d4c31432e2f8a77f094d7c986b
The latest GN binaries rename cpu_arch to current_cpu and/or target_cpu
as appropriate, build_cpu_arch to host_cpu, and os to current_os and target_os as appropriate.
R=brettw@chromium.orgTBR=ddorwin@chromium.org
EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
BUG=344767
Review URL: https://codereview.chromium.org/913373002
Cr-Original-Commit-Position: refs/heads/master@{#317223}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4327621a322c964a8bc6d1ef5a4534f0f877d63e
The newest version of GN replaces the 'cpu_arch' and 'os' variables with 'current_cpu', 'target_cpu', 'current_os', and 'target_os', and also replaces 'build_cpu' with 'host_cpu', and 'build_os' with 'host_os'.
The roll also picks up the change to add a new 'gn clean'
command, some absolute path handling fixes, a check_includes fix for action_foreach(), and some minor
internal fixes.
This patch also updates the build config files to accommodate the GN changes in a backwards-compatible manner, i.e., the configs now will set cpu_arch and os correctly in the right contexts. They will also allow the users to continue to set os= and cpu_arch= in an args file, so no user builds (or bots) will break.
Once all of the bots and all of the build files have been updated to refer to the new variables instead of the old ones, we can drop the backwards-compatible versions.
TBR=brettw@chromium.org
BUG=344767
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
Review URL: https://codereview.chromium.org/936103003
Cr-Original-Commit-Position: refs/heads/master@{#317186}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7ee02bed35766535521c8e1f072b98cbf9eef53d
Android binaries were relying on -Wl,--exclude-libs=ALL to prevent
unnecessary symbols from being exported in the final shared libraries
built in Chromium, however several changes were submitted that actually
disabled this linker flag in virtually all binaries, and thus it was not
really being used and many symbols were exported by mistake.
Remove --exclude-libs=ALL entirely from the Android build, as well as
all the places which were previously having to unset it, and instead
exclude the specific libraries which incorporate visible symbols that we
don't want: the NDK libraries which we statically link into the binary,
and a number of components of chromium which contain assembly code which
has not yet been fixed to set symbol visibilities correctly.
This reduces the number of exported symbols in the shared libraries to
only the ones we intended to export, which saves ~120KB binary size.
The GN build does not build the same set of things as static libraries,
so the list is slightly different there and several more symbols are
left in the final binaries which shouldn't be there, but are not pulled
in via a static library and so no --exclude-libs flag will ever fix it;
the symbol visibilities will need to be fixed at source.
BUG=448386
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/806533003
Cr-Original-Commit-Position: refs/heads/master@{#317027}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 813edf0d362baf1a2b01fe54bc27ff4601d59713
Hide JNI exported functions in Android binaries by default, unless the
target in question has explicitly set "use_native_jni_exports" to
indicate that it relies on the JVM's automatic symbol lookup mechanism.
The functions are simply demoted to hidden visibility; the code will
remain unless the linker determines that it is unreferenced and strips
it via --gc-sections.
This ensures that binaries by default actually test the explicit JNI
registration codepaths, which are required for compatibility with the
crazy linker, while still allowing binaries that do not require crazy
linker compatibility to choose to use the automatic mechanism in future.
BUG=442327
Review URL: https://codereview.chromium.org/843103003
Cr-Original-Commit-Position: refs/heads/master@{#316896}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9d90d85f73ca46847047ccbda270f25b637ccc86
Adds a new config to disable size_t -> int truncations and use it in various places where the x64 Windows build currently gives warnings.
This covers Chrome (except for Blink which has a separate patch) and the tests.
We should do a second pass to replace the existing instances of /wd4267 with this config.
Review URL: https://codereview.chromium.org/927363005
Cr-Original-Commit-Position: refs/heads/master@{#316874}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1deb76bc64a51808cd3df93d8166f223241487fe
gn now run with arg target_arch = "x64", arm64 and mips64el
releated changes are added as well but not verified.
BUG=none
Review URL: https://codereview.chromium.org/864173006
Cr-Original-Commit-Position: refs/heads/master@{#315680}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 98de73d11797b1b0ac7ac0b2f4234cb8f57bd2fc
Various bits of Chrome for Android that are being upstreamed
(in particular Cast support) require Google Play Services.
This adds Google Play Services to the Android chrome_java
target.
Note that this uses a variable so that one can use an
alternative version of Google Play Services. This is
required for Chrome for Android development.
TBR=sky@chromium.org
BUG=450675
Review URL: https://codereview.chromium.org/865733002
Cr-Original-Commit-Position: refs/heads/master@{#315538}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c8db3ccbde213d09fac41060c0bf81d4a0020cda
Reason for revert:
Slows down the slowest bot on CQ by 20 minutes.
BUG=456396
Original issue's description:
> Enable libc++ on Android
>
> Switch Chrome on Android to use libc++ instead of stlport. WebView AOSP
> builds will continue to use stlport for the time being.
>
> Note that this change is exploratory, and likely to be reverted before
> branch point (ensuring WebView and Chrome remain in lockstep with
> respect to standard library dependencies).
>
> BUG=427718
> TBR=cpu@chromium.org
>
> Committed: https://crrev.com/8681920fa22ded465054301ce96657a4ddaf2a04
> Cr-Commit-Position: refs/heads/master@{#315085}
TBR=fdegans@chromium.org,pasko@chromium.org,jamesr@chromium.org,thakis@chromium.org,boliu@chromium.org,davidben@chromium.org,cpu@chromium.org,piman@chromium.org,jdduke@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=427718
Review URL: https://codereview.chromium.org/903323002
Cr-Original-Commit-Position: refs/heads/master@{#315174}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f43ab9ce5b48ed622736d96c9fba9e8fa57858a3
Switch Chrome on Android to use libc++ instead of stlport. WebView AOSP
builds will continue to use stlport for the time being.
Note that this change is exploratory, and likely to be reverted before
branch point (ensuring WebView and Chrome remain in lockstep with
respect to standard library dependencies).
BUG=427718
TBR=cpu@chromium.org
Review URL: https://codereview.chromium.org/835633003
Cr-Original-Commit-Position: refs/heads/master@{#315085}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8681920fa22ded465054301ce96657a4ddaf2a04
This declares dcheck_always_on argument (false by default) so users can
override it. If set to true this will make a compiler define
(DCHECK_ALWAYS_ON=1). This mirrors GYP counterpart.
Debug:
$ gn gen out_gn/Debug --args='dcheck_always_on=true'
$ ninja -v -C out_gn/Debug base
Release:
$ gn gen --args='is_debug=false dcheck_always_on=true' out_gn/Release
$ ninja -v -C out_gn/Release base
Manually checked that -DDCHECK_ALWAYS_ON=1 is passed on the command line
to the compiler.
BUG=None
TEST=see above
R=brettw@chromium.org
Review URL: https://codereview.chromium.org/896413003
Cr-Original-Commit-Position: refs/heads/master@{#314867}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a52158d7c0b0c697d1625680fbaf9c2902d26da7
We've had problems with this linker flag in --as-needed a few times now;
just disable it if we're doing a sanitizer build.
BUG=452105
Review URL: https://codereview.chromium.org/882443003
Cr-Original-Commit-Position: refs/heads/master@{#313321}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 009e710e139692929e181400bcc97c71235b892e
This picks up:
-Fix Android ARM Neon build.
-Fix Android GN build.
This also fixes an issue with the GN ARM NEON build.
BUG=451035
Review URL: https://codereview.chromium.org/871433002
Cr-Original-Commit-Position: refs/heads/master@{#312629}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d2a76a150091e5c5f1d9e4a42a27d6f1f7538137
The ffmpeg build on mips is broken which manifests in build errors when
z,defs is specified. The owners of this build would like the compile
time error to be suppressed for now while they work on a proper fix.
BUG=450771,371125
Review URL: https://codereview.chromium.org/864193002
Cr-Original-Commit-Position: refs/heads/master@{#312557}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9267528ad62c796f30c9f51f398fbfa29f0232a1
Compiling with -Wl,-z,defs and asan requires declaring a dependency on
//build/config/sanitizers:deps in every shared_library and executable,
however piles and piles of targets do not do this yet so this flag busts
the asan/etc builds in GN. Disable for now so we can add the
dependencies bit by bit.
R=thakis@chromium.org
BUG=371125
Review URL: https://codereview.chromium.org/810563008
Cr-Original-Commit-Position: refs/heads/master@{#312543}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2eff74b542c9dceb330967c7fa06274a4addf443
This tells the linker to resolve symbols for shared libraries at build
time, not run time. This alerts developers much earlier that their
dependencies are underspecified.
BUG=371125
Review URL: https://codereview.chromium.org/843583006
Cr-Original-Commit-Position: refs/heads/master@{#312317}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4359db72cde4fe4eeb4125d9a88af765fcdf39f1
Other misc fixes including:
Add "data_deps" to the templates in BUILDCONFIG. This was renamed from "datadeps" a while ago but both are still supported.
extension_management_test_util.cc includes a generated file policy_constants. GYP generates this with an extra "policy" directory but GN doesn't. The way GYP has the dirs set up, though, using only one "policy" works (and this is what other files do) so I just changed the include.
TBR=dpranke
Review URL: https://codereview.chromium.org/824373003
Cr-Original-Commit-Position: refs/heads/master@{#310276}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7d6ec24650eb3f6c7ab8dcfcf0c2829095951962
This CL modifies gcc_version.gni to set the gcc_version to the target
GCC toolchain version when building for MIPSEL Linux.
BUG=
TEST=Compile 'chrome' target with 'os="linux" cpu_arch="mipsel"'.
Manually verify that the correct GCC options are used.
Review URL: https://codereview.chromium.org/797593002
Cr-Original-Commit-Position: refs/heads/master@{#308334}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3bb044b814399b1584b8bcdedd8e2ffdb102b17d
This also reverts:
"Re-enable globals instrumentation under ASan on Mac."
964445e21b60278ff6e0de560c4110d8a161be36.
It was causing test failures.
BUG=431803, 440602, 352073
TBR=brettw@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/790263003
Cr-Original-Commit-Position: refs/heads/master@{#307768}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 75812af2fc918c3f22cc79dd83214bc1b2ec187c
cstout
agrieve
qsr
nparker
brettw
cullinan
dpranke
Hans Wennborg
thakis
cjhopman
jam
tmoniuszko
jdduke
jbudorick
rickyz
jdonnelly
davidben
prashantv
primiano
Daniel Cheng
jiangj
torne
jkarp
kjellander
mfoltz
mikecase
oshima
mostynb
tfarina
mdempsky
stapelberg
andresantoso
tapted
Dominic Mazzoni
alexmos
aurimas
rockot
ananta
ncbray
thestig
wtc
jamesr
ulan
cpu
scottmg
eroman
kmarshall
mnaganov
etiennej
halton.huo
aberent
vchigrin
erg
tbarzic
fdegans
pkotwicz
nhiroki
Gordana.Cmiljanovic