When we cross-compile, we do not want any /usr/include paths as that will
conflict with our own system headers. Disable the hardcoded path when we
have an active sysroot.
BUG=chromium:488360
Review URL: https://codereview.chromium.org/1132853010
Cr-Original-Commit-Position: refs/heads/master@{#330514}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 58b42a0c48127c60baad7ea79ea0e5576c6e1d0b
The oilpan plugin requires trunk clang on Windows, but the asan lkgr bot
uses a pinned, slightly older clang and it times out when using head clang.
Disable the plugin on asan until we have resolved this.
BUG=489123,489123
R=hans@chromium.org, rnk@chromium.org
Review URL: https://codereview.chromium.org/1142733003
Cr-Original-Commit-Position: refs/heads/master@{#330432}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1bdb383d4338a68b88bcdb96852592c933544595
You can now delete things by long pressing suggestions in the dropdown (assuming it's the right kind of suggestion).
BUG=486153
Review URL: https://codereview.chromium.org/1134793004
Cr-Original-Commit-Position: refs/heads/master@{#330413}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c806c71f4a9e704d40b14df026a6ebfa0c2fcac1
Removed extra 'dependency' on target 'media_router_test_support'.
Also removed the ':' on some local dependencies.
Original patch: https://codereview.chromium.org/1136623003/
Original patch description:
- Refactor GYP and GN files to share source lists.
- Extract a proper test_support target.
- Fix upstream files with new target structure.
BUG=461815, 464199, 464205
TEST=Linux trybots. It's not clear to be exactly which bot, since
original patch failed after getting through trybots/CQ.
Review URL: https://codereview.chromium.org/1122393005
Cr-Original-Commit-Position: refs/heads/master@{#330204}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b6b09239feb034d546976028a15c75404579d0bb
- This is in preparation for split apks, where we'll need to call
apkbuilder multiple times.
- This also makes including a classes.dex file optional
BUG=484797
Review URL: https://codereview.chromium.org/1138953003
Cr-Original-Commit-Position: refs/heads/master@{#330159}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8dabdfa9a758f7a7ac73fa4f5bbc657183b1a3e2
One of the intermediate steps in the build process for
creating Android APKs depends on the output from another
intermediate step, but that dependency was not *also* declared
in the 'deps' target in the GN build file.
As a result, 'gn refs' (and hence 'mb analyze') would not calculate
the right set of dependencies and we would incorrectly conclude that
no compiles were necessary in cases where they really were needed.
More details in the bug.
R=cjhopman@chromium.org, brettw@chromium.org
BUG=487897
Review URL: https://codereview.chromium.org/1129773004
Cr-Original-Commit-Position: refs/heads/master@{#330152}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0cc8f08b75ed52834b3a8a73bb645865abd9fc55
Reason for revert:
This breaks the asan build. See comments on the original CL.
Original issue's description:
> Non-SFI mode: Build nacl_helper_nonsfi_unittests
>
> This CL starts to build nacl_helper_nonsfi_unittests.
> The binary is not yet enabled to run on bots. It will be done in a following CL.
>
> TEST=Ran locally. Ran build bots. Ran build bots with editing configuration to include nacl_helper_nonsfi_unittests.
> BUG=358465
>
> Committed: https://crrev.com/72c418b09bbf90505f54df2b76285650acd97960
> Cr-Commit-Position: refs/heads/master@{#330069}
TBR=mseaborn@chromium.org,mdempsky@chromium.org,thakis@chromium.org,jln@chromium.org,hidehiko@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=358465
Review URL: https://codereview.chromium.org/1145593002
Cr-Original-Commit-Position: refs/heads/master@{#330147}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: aad01297ee28c48a3021339568cacaf16f37fdc0
This CL starts to build nacl_helper_nonsfi_unittests.
The binary is not yet enabled to run on bots. It will be done in a following CL.
TEST=Ran locally. Ran build bots. Ran build bots with editing configuration to include nacl_helper_nonsfi_unittests.
BUG=358465
Review URL: https://codereview.chromium.org/1137553003
Cr-Original-Commit-Position: refs/heads/master@{#330069}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 72c418b09bbf90505f54df2b76285650acd97960
SetHighPerfMode needs root, but it currently only checks to see if
we already have root rather than trying to enable it.
BUG=478104
Review URL: https://codereview.chromium.org/1135393005
Cr-Original-Commit-Position: refs/heads/master@{#329980}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 83c5ba866887f876d3cd45473a839d60b5036166
Android AAPT 21+ will automatically move attributes to a version
of the XML file with -vXX resource qualifier. So we no longer need
our generate_v14_compatible_resources.py script.
But AAPT only drops the attributes, so if we don't use our script,
we need to put left/right in addition to start/end in our layout xmls.
The plan is, disabling our script for Android support library and
keep using for ourselves, until we can drop the script entirely
when we discontinue support for JB.
TBR=cjhopman@chromium.org
BUG=487391
Review URL: https://codereview.chromium.org/1136953009
Cr-Original-Commit-Position: refs/heads/master@{#329947}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2b7115f8e111708c1e52257c34f91dc1549c298f
Build rule is not hooked up to any targets yet, but will be used in a
future commit to create split APKs.
.gypi also forthcoming.
BUG=447152
Review URL: https://codereview.chromium.org/1118403004
Cr-Original-Commit-Position: refs/heads/master@{#329850}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 81cc62af7059b65fe7d4d6dfd420f7cacd03ddc9
There's a TODO for using split-select, but it won't be necessary until
we have resource splits being generated.
BUG=447152
Review URL: https://codereview.chromium.org/1134353002
Cr-Original-Commit-Position: refs/heads/master@{#329844}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 845f198cd6e47f25d68355898fdff474796e2165
Right now we have no easy visibility on time taken for individual tests, since everything runs under one massive "Sharded Perf Tests" step. We're trying to balance the tests across devices to improve cycle time, so we need a way to see how long each test is actually taking.
BUG=466101
Review URL: https://codereview.chromium.org/1140783002
Cr-Original-Commit-Position: refs/heads/master@{#329722}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8a9efca9b5451c75da244f62f073206c97ef6dd4
Android executable do not support rpath, and the executable is
displaying a warning on launch if it is present. The warning is :
unused DT entry: type 0xf arg 0xa35
R=dpranke@chromium.org,brettw@chromium.org
Review URL: https://codereview.chromium.org/1141723002
Cr-Original-Commit-Position: refs/heads/master@{#329663}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 90acb0f2b53bfa3ae632f9391a8f8f6e5dcde9eb
SafeBrowsingDatabaseManager: Pure interface
TestSafeBrowsingDatabaseManager: Dummy impl for tests
LocalSafeBrowsingDatabaseManager: Existing full impl.
RemoteSafeBrowsingDatabaseManager: New for Android
Wire up the safe_browsing=3 build-mode to switch Android to
use Remote*. Move SafeBrowsingCheck into Local* and create
the Test* impl that can't accidentally call a real
implementation's methods. Adjust tests to use either Test*
or Local*.
The initial implementation of Remote* does the bookeeping
of requests, but doesn't yet make calls to Java and isn't
tested.
BUG=474608
Review URL: https://codereview.chromium.org/1110723002
Cr-Original-Commit-Position: refs/heads/master@{#329551}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b2cd5eef530be7100274af882af3f5aff4d1c4be
This restricts the test apk's resources to just be those not already
included in the tested apk. Because GN apk targets typically don't
include java of their own, this requires supporting javac+jar for the
case where there is no java files.
Fixes deps so that chrome_shell_test_apk actually builds.
TBR=nyquist,dalecurtis,cbentzel
BUG=359249
Review URL: https://codereview.chromium.org/1127233005
Cr-Original-Commit-Position: refs/heads/master@{#329510}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d4910aba370e4e5d55477b4b857c707d07526f7b
Reason for revert:
All linux perf bots red, failing on various blink_perf tests. Speculatively reverting this CL since several bisects pointed to it.
BUG=485590
Original issue's description:
> Linux Aura accessibility is enabled only on GNOME desktops
>
> Linux Aura accessibility is not enabled on desktops different than GNOME2.
> GNOME3 has deprecated gconf in favor of gsettings and dconf.
> AT-SPI (cross-platform framework that provides communication between AT
> and application) bus launcher has a property called org.a11y.Bus.IsEnabled
> that could be easily read by dbus call.
>
> In generall this patch adds an additional check to enable accessibility.
> When gconf is available use gnome's accessibility key otherwise
> org.a11y.Bus.IsEnabled property.
>
> BUG=472183,468989,468112
> TBR=stevenjb@chromium.org,jochen@chromium.org
>
> Committed: https://crrev.com/16e2d5a386e3ddd5be818a0d27610b1e9ee9c08e
> Cr-Commit-Position: refs/heads/master@{#328651}
TBR=dmazzoni@chromium.org,plundblad@chromium.org,l.gombos@samsung.com,jochen@chromium.org,stevenjb@chromium.org,dpranke@chromium.org,k.czech@samsung.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=472183,468989,468112
Review URL: https://codereview.chromium.org/1124173005
Cr-Original-Commit-Position: refs/heads/master@{#329404}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c7c15e712cb77a0fe276166996b2bb787490c896
The C++ define OFFICIAL_BUILD wasn't getting set, and the widevine version .rc files was getting linked twice.
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
R=dpranke
TBR=ddorwin@chromium.org
Review URL: https://codereview.chromium.org/1134623003
Cr-Original-Commit-Position: refs/heads/master@{#329308}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 303920e6cd9d352e7a7b4e9bdcc2f28a30ac22fa
Originally landed in crrev.com/1104703003
Reverted in crrev.com/1129103002 due to breaking GN APKs with no
resouces. This now handles the case where aapt doesn't generate an
R.txt (no resources) by creating an empty R.txt.
Generate extra packages' R.java files only containing the resources
listed in their R.txt files. This significantly reduces the number of
DEX field IDs taken up by resources.
BUG=480036
R=cjhopman,yfriedman
Review URL: https://codereview.chromium.org/1136653002
Cr-Original-Commit-Position: refs/heads/master@{#329219}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4b5d0300e3fa2a382ac3c1c157247a82583d7ed0
The old test runner leaves isolate_deps_dir around while running tests.
gtests remove it at the end of a test run, but instrumentation tests
do not. This CL makes both test types remove isolate_deps_dir
immediately after pushing the data dependencies to the device.
BUG=
Review URL: https://codereview.chromium.org/1135863003
Cr-Original-Commit-Position: refs/heads/master@{#329152}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e9bc362d18529975c5e80193fa2e118fc1acadcf
vapier
dbeam
kkimlabs
Nico Weber
jbudorick
estade
Gordana.Cmiljanovic
sbc
mail
imcheng
agrieve
mnaganov
dpranke
hans
pvalenzuela
henrika
hidehiko
oshima
jam
mfoltz
cstout
dyen
tfarina
simonhatch
qsr
nparker
cjhopman
brettw
chcunningham
aurimas
cullinan
perezju