Before CL: scripts are not installing packages for compiling in Ubuntu 19.10 Disco Dingo.
After CL:
1. it's possible to compile Android version using g++-9 in Ubuntu 19.04
2. there is added proposal about installing Java 8 from Ubuntu 18.04 LTS Bionic Beaver, when it's not available in Ubuntu 19.04
3. there is removed support for Ubuntu 17.10 Artful Aardvark (EoL July 2018)
4. there is added some first code and notes about Java 11
Change-Id: I6c8dd875dbd1e6c67d8d2ff175511bda132b3f4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574718
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Original-Commit-Position: refs/heads/master@{#653765}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 73d9ec504db74c3457c4d7a444e25c26f42f8887
The old code would only sometimes upgrade packages, depending
on whether apt-get had to ask a y/n question before the
upgrade or not. This makes the upgrade more explicit
rather than a side effect of the query command.
This also adds lists libc6-dev as a dependency since it is needed
and without it being listed it might not be upgraded.
Bug: 934256
Change-Id: Iee2aae09374557e77ce9c1ef4b36b9366827015d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1491972
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Auto-Submit: Daniel Bratell <bratell@opera.com>
Cr-Original-Commit-Position: refs/heads/master@{#639964}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8cc92d37858a12b6a09bc96ecaf99076529c9a59
The package was removed from nacl_list in r607986.
BUG=None
TBR=dpranke
Change-Id: I052e3a0fdc5f58834bfec9b38502b5aa60e2edf0
Reviewed-on: https://chromium-review.googlesource.com/c/1354353
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#611947}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 99ffaaeb93e2cd406be3e2eccf5fbde615f364c8
The CL removes libgtk-3-0:i386 from install-build-deps.sh as it fails to be
installed on the freshly installed Google glinux machine.
For more info and the errors installing the package, see
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/ODZ88EuoxK4
Change-Id: I4cf64ef3b98fd2a8a5299d4859da63c7a0c5f4f9
Reviewed-on: https://chromium-review.googlesource.com/c/1332207
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#607986}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7a9a24b45775ace57856ebb7567e497e66f3d289
This became necessary to build Chrome after [1] when building without the
sysroot.
[1] 297928530f
BUG=879147
TBR=dpranke
Change-Id: Iff2d59b247cd764f404f0beeaf232cc8dc8188aa
Reviewed-on: https://chromium-review.googlesource.com/1214699
Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#590093}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1320001a996e8d90162d86cf88ca1f8bc8a23c82
GTK2 code was historically kept around to keep the electron build working. But
as of Nov 26, 2017, electron now uses GTK3 [1], so it should now be safe to
remove all of the old GTK2-only code.
[1] https://github.com/electron/electron/issues/2927#issuecomment-347092515
BUG=876558
R=sky
Change-Id: I78402053ae508ccd8fc7ac73697a861bb1ebacf6
Reviewed-on: https://chromium-review.googlesource.com/1183858
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#585265}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 287339e07364162daa8fd6f90ef1d2338f32bed5
Also:
* Remove an out-of-date comment.
* Add binutils to install-build-deps.sh for readelf and grep. We already use
binutils in many places, and it's likely already installed everywhere, but
it's good to list out direct dependencies.
BUG=850682
R=thakis
Change-Id: I80830ad42fe37f1b93f393f5a6ca5af68ef92998
Reviewed-on: https://chromium-review.googlesource.com/1157436
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#579853}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2b8a836630dcf0d5c5eba4ecdcc71a5f1ebfb914
The latest version of fontconfig requires uuid/uuid.h so
we need to install that in install-build-deps.sh.
(Only tested in Ubuntu 16.04)
Bug: 856666,829890
Change-Id: I586aa703e24a1ea2c10d08948acad37ce177f70f
Reviewed-on: https://chromium-review.googlesource.com/1115129
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#570454}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: bec626a2ddc55ab82001da16d0bfc15fe0e9421f
When the --backwards-compatible option is given, all packages that have been
removed from this script in the past 3 years will be included.
R=dpranke
CC=inferno
BUG=None
Change-Id: I396314c2204c45cfe2a78881e8cfc6838a68c2f5
Reviewed-on: https://chromium-review.googlesource.com/1106648
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#568664}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e9883cd1b7a57dd478164fb8d2974c3a91002b3b
* Changes usages of "test" to "[".
* Removes interactive prompts
* Most developers don't need debug symbols (as indicated by the message that
used to get printed out). Now --syms must be passed. This follows the
convention of all of the other options, like --lib32, --arm, --nacl, etc.
* A message is printed out to rerun the script with --add-deb-cross-tool-repo
if the host machine is Debian Jessie.
* Adds libstdc++ debugging symbols for more versions of gcc including 4.7, 5,
7, and 8.
BUG=None
R=dpranke
Change-Id: Ia6e941b4f78c3fc4540bcfa23c45885dc402db98
Reviewed-on: https://chromium-review.googlesource.com/1100131
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#567452}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8e0a484ed06906d1d3be56e321cd76128c40a813
Debian is in the process of transitioning to automatic debug packages, which
have the -dbgsym suffix. The old debug packages had a -dbg suffix. Due to the
rename, it's becoming unmaintainable to add new cases whenever a package
updates, so this CL switches to an automatic way to determine the right debug
package to use.
R=dpranke
BUG=None
Change-Id: Ica1f6e1e01478510f9ef564c1d945a1666eba076
Reviewed-on: https://chromium-review.googlesource.com/1081233
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#566248}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8206da9ad30ac0015ebcbb21449c87196f6d04c0
*-dbg packages are deprecated in favor of *-dbgsym
(cf https://wiki.debian.org/AutomaticDebugPackages)
Some *-dbg packages may have conflicting version requirements,
which would cause the script to abort.
That's another good reason to favor -dbgsym version.
R=dpranke@chromium.org
the fix to all libraries via refactorization (50 lines saved).
BTW, this leads to more debug-symbols packages to be detected and installed.
NB: it has already been fixed for libglib2 and libpixman, but this extends
Change-Id: I13f252b05ab95fb17eb8851d3b5a2b1b7a7d6295
Reviewed-on: https://chromium-review.googlesource.com/1080607
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Yves Gerey <yvesg@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#565582}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e1fe0dffc89ef789703a45c603c34a30c8d5de22
Use SELECT_EXISTING_FOLDER when choosing an unpacked extension. Disable
folder creation for SELECT_EXISTING_FOLDER and SELECT_UPLOAD_FOLDER (for
all desktop platforms excluding kde). For GTK when selecting a folder,
show only folders.
Bug: 772180
Change-Id: I0f513180ff7f10b5af91e8c518b3d9fd4b0fc8f1
Reviewed-on: https://chromium-review.googlesource.com/1019732
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#561344}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: cc859bf07d39ffb99f1e19827c894327fb4d9849
In order to use AFDO on Linux, we need to be able to locally unpack the
profiles we fetch (which is likely preferable to storing a second,
unpacked version in gs://).
It used to be that we only needed these for Android, since these
profiles were previously only used by Android.
This was split out from
https://chromium-review.googlesource.com/c/chromium/src/+/1025132
Bug: 805098
Test: Ran install-build-deps.sh
Change-Id: I1374b2b84c26f6ef808c00217bfbb51e8fbf980d
Reviewed-on: https://chromium-review.googlesource.com/1054613
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: George Burgess <gbiv@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#557698}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3d20a813bf5977d7cd191597855e50d32276e5e7
There's no longer a dependency on any system fonts when running Linux tests, so
font packages may be removed. The CrOs fonts are kept because, presumably,
folks might still want them when testing Linux CrOs builds, though the CrOs
tests also no longer depend on any system fonts.
BUG=787020
R=dpranke
Change-Id: I6074842eb67eba6194fa90e549e0485b529aa814
Reviewed-on: https://chromium-review.googlesource.com/1036585
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#554930}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6a4c92980d887f00be05ed676a246e81030b0356
Trivial fix for next LTS Ubuntu (similar to the
https://chromium-review.googlesource.com/c/chromium/src/+/736729)
+ adding LTS info to older versions mentioned in changed sh file
+ removing 17.04 info
Change-Id: Ib3889ac68bc41ff90cc6e36d9c60f56e2af76527
Reviewed-on: https://chromium-review.googlesource.com/1034055
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#554836}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d7577c3d87fc74d4eb76b88f2fe2bd75163f3d4f
Apparently this has been required for a while now on ChromeOS. It's
not really required on non-ChromeOS, but no doubt it will soon, so
adding to both.
BUG=831700
TEST=none
Change-Id: I6f859ff4767582c6c2a7155c995347d1963ceebd
Reviewed-on: https://chromium-review.googlesource.com/1008420
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#549987}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: dd7e237ba9b69855adf60e8141b7dc45c613b6a7
BUG=822410
TBR=dpranke
Change-Id: I8b9922029b0b1cfbf327ba4de4dec346bb01a2ca
Reviewed-on: https://chromium-review.googlesource.com/1006168
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#549699}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c9790a3beefb04623d157b88f352422c36af18ca
The mesa packages were originally added because of an issue with installing
libgbm-dev on Saucy. The CL description is inlined below:
------------------------------------------------------------------------
commit: 419a9a64b69f1d113c28d1e78c7117adf510aa95
Author: primiano@chromium.org <primiano@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Thu Jun 19 18:26:18 2014 +0000
Fix installation of libgbm-dev package in install-build-deps.sh
crrev.com/106633002 has recently introduced a dependency on libgbm-dev.
Unfortunatelly, this package is a bit more trickier to install, for the
following reason: it depends on mesa-glx and, conversely to most of the
other packages, only one version of mesa (w.r.t backports) can exist in
the system. Google's workstations are configured to use the -lts-saucy
version of mesa. The right package in this case is libgbm-dev-lts-saucy
and attempting to install just libgbm-dev ends up in a failure.
This change fixes install-build-deps.sh, installing the matching version
of libgbm-dev (w.r.t libgl1-mesa-glx), falling back to libgbm-dev.
------------------------------------------------------------------------
Currently, this is causing issues on Googler's machines (see chrome-linux
mailing list). Since the Saucy days are over, just depend on libgbm-dev
directly. Tested on Ubuntu Trusty, Ubuntu Xenial, Debian Stretch, and Debian
Testing.
R=dpranke
Change-Id: I43568ab8b8c66c2aa6cd394c67f2cf90d6d1762c
Reviewed-on: https://chromium-review.googlesource.com/944047
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#540271}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d4ea25245efc1436926aa2ff4dcd1e72d2faa229
This reverts commit 6e3fb99a7265b2481b9570344de4669f4c26a14c.
Reason for revert: install-build-deps.sh brocken:
The following packages have unmet dependencies:
libappindicator3-1 : Conflicts: libappindicator3-1:i386 but 12.10.1+13.10.20130920-0ubuntu4.1 is to be installed
libappindicator3-1:i386 : Depends: libindicator3-7:i386 (>= 0.4.90) but it is not going to be installed
Conflicts: libappindicator3-1 but 12.10.1+13.10.20130920-0ubuntu4.1 is to be installed
E: Unable to correct problems, you have held broken packages.
Original change's description:
> Add 32-bit version of libappindicator3-1
>
> When doing a 32-bit build on a 64-bit system, the 32-bit version of the
> library is not available. This CL should fix that.
>
> Bug: 799144
> Change-Id: I40c6d16d708db102eb4da90ded7bc336cb9f9b09
> Reviewed-on: https://chromium-review.googlesource.com/940196
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Tim Brown <timbrown@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#539851}
TBR=dpranke@chromium.org,timbrown@chromium.org
Change-Id: Ic6ee1c67eb9c8a5cd438b7f0bc86fbea18125b46
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 799144
Reviewed-on: https://chromium-review.googlesource.com/941614
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dmytro Golovchenko <dgolovchenko@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#539949}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: bcd0c529a6b5c3512b48cc9aad98dd393199066d
When doing a 32-bit build on a 64-bit system, the 32-bit version of the
library is not available. This CL should fix that.
Bug: 799144
Change-Id: I40c6d16d708db102eb4da90ded7bc336cb9f9b09
Reviewed-on: https://chromium-review.googlesource.com/940196
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Tim Brown <timbrown@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#539851}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6e3fb99a7265b2481b9570344de4669f4c26a14c
It's only needed for win/cross builds, but it's a small package and the
only additional package needed for cross builds, so add it unconditionally.
Change a/chrome/tools/build/win/create_installer_archive.py to use
7zr instead of 7za (both suffice for us), so that the smaller p7zip is enough.
Bug: 495204
Change-Id: I5f4c5326dbab2f3a3257c8cad4d3524cb338fca6
Reviewed-on: https://chromium-review.googlesource.com/934686
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#538828}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a9fa6a7144fbd7fdae3d2501b94ac98e5a2bb6eb
/usr/bin/realpath has been moved into coreutils.
Also remove support for Ubuntu Zesty since it has reached EOL.
BUG=814450
R=dpranke
Change-Id: I3081323f36da0ecee72bb487689ed4b346850b88
Reviewed-on: https://chromium-review.googlesource.com/932361
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#538613}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6b2b2ad55f2a221f9ba6064fba5f9f9dae16f14c
dbus_unittests relies on the presence of /usr/bin/dbus-launch, which is provided
by the dbus-x11 package. The absence of this package is currently causing
dbus_unittests to fail on the Linux Xenial bot.
BUG=789768
R=dpranke
NOTRY=true
Change-Id: Ic844648f3651e518e276c1fb764849b09145b34b
Reviewed-on: https://chromium-review.googlesource.com/924693
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#537483}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8bfb0b04662d7cdb4a08240ac30024891aceef91
This adds in both the Gtk+2 and Gtk+3 packages.
TBR=dpranke@chromium.org
Bug: 799144
Change-Id: I692e16bd62ab2120c4855cd75ce6f3260e5d6ece
Reviewed-on: https://chromium-review.googlesource.com/904856
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#535457}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 06ee43ab03a2a91ace88a195865e29cdcd0468c3
This reverts commit 3aeec4449b15c08e97037cb6caf7eb31ac2c3b2e.
Reason for revert: not needed any more as we put the fonts on GCS
(https://crrev.com/c/836549)
Original change's description:
> build: Add Garuda TTF fonts to build deps
>
> Debian builds require this package to be installed in order to build.
>
> Change-Id: I6066fb1f3a39842ec076ec82495f0a44a2e17e93
> Reviewed-on: https://chromium-review.googlesource.com/817649
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Conley Owens <cco3@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#523139}
TBR=dpranke@chromium.org,cco3@chromium.org,thomasanderson@chromium.org,odejesush@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Change-Id: I9c5ecf06c727e762cc95796a23577ae77fd61502
Reviewed-on: https://chromium-review.googlesource.com/840121
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Conley Owens <cco3@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#527290}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3ec36782b480b24e3e7f5185a8e3ad9e6f304aee
Also update the "Notes for other distros" in the build instructions.
All usages of gconf has been removed, and we depend on gsettings, not
dconf directly.
This is the final step in switching from gconf to gsettings.
Bug: 768027
Change-Id: I4430c261ac2c9691838e7dfe9c0d7c6842fa535f
Reviewed-on: https://chromium-review.googlesource.com/831106
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Tim Brown <timbrown@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#524503}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 36312fccc6b5f9bba0fa427d6b9756daad3b94e6
Comment [1] explains that libssl1.0.0 can be manually installed on systems that
are expected to have libssl1.0.2. In this case, libssl1.0.0 will appear to be
available in the repos when it is not.
The fix is to check for newer packages first.
[1] https://bugs.chromium.org/p/chromium/issues/detail?id=785818#c13
BUG=785818
R=dpranke@chromium.org
Change-Id: I52a69adc5271b5485f7d09aabd1a01a24ff10352
Reviewed-on: https://chromium-review.googlesource.com/819976
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#523195}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0524b2b7b70eff655189206acfb599fe9b27c40d
Debian builds require this package to be installed in order to build.
Change-Id: I6066fb1f3a39842ec076ec82495f0a44a2e17e93
Reviewed-on: https://chromium-review.googlesource.com/817649
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Conley Owens <cco3@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#523139}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3aeec4449b15c08e97037cb6caf7eb31ac2c3b2e
This should fix another set of layout tests and make us less dependent
on distribution specific font packages. Add a font usage line in
languages-emoji-rare-glyphs.js to make sure that Noto Sans Khmer is
used.
Bug: 772116
Change-Id: I0acfb2186eeb180a3a464cd6337539cbe1cdf45d
Reviewed-on: https://chromium-review.googlesource.com/779520
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#519621}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 542c9ca65d335166b48ea40d737c1a53b54c5b55
Many *-dbg packages are being replaced with *-dbgsym ones. This CL begins using
those packages when they are available, instead of just skipping the package.
BUG=785818
R=dpranke@chromium.org
Change-Id: If2d3ea398353628caec77b202a1526451d628931
Reviewed-on: https://chromium-review.googlesource.com/792608
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#519560}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 17d6cdd5aa1300f1b00425e36eefc7d809a74e0c
package_exists() used to check if the output of 'apt-cache search' was nonempty
to check if a package is available for install. But it does not work in some
cases. For example, on Debian Testing, libgtk-3-0-dbg is not available, but
libgtk-3-0-dbgsym is. This package would show up in the apt-cache output and we
would incorrectly determine that libgtk-3-0-dbg was available. Additionally,
there can be more than one package that is listed.
This CL does a check for the exact package name.
BUG=785818
R=dpranke@chromium.org
Change-Id: Ic81f1c059223e3cec643e116dea26b30c9ac75f1
Reviewed-on: https://chromium-review.googlesource.com/791371
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#519415}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9c70eb73a314e3f164b0f4ad6ad9bde679f549a0
This should help to run layout tests on a more diverse set of Linux
distributions and avoid running into differences in font target file
name differences for common font packages.
We should move as much as possible of the test fonts for layout tests
from distribution packages to our own mechanism.
Modeled after a previously used approach for blimp fonts, compare
https://codereview.chromium.org/1776133002/
Bug: 772116
Change-Id: Ia1929d3d22a047d540f841741f5e9a369142e1b6
Reviewed-on: https://chromium-review.googlesource.com/725809
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Justin Schuh <jschuh@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#517350}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f49ef761da1fc44dd41589b1ccd32ac54791cecb
Test: Manually installed packages to make sure no conflict
This is a reland of 5b267c0c4ffb22f07bea43853567c0b8a2ab9c21
Original change's description:
> Add libdconf-dev to to install-build-deps.sh
>
> This is the first step in moving from using gconf to dconf.
>
> Bug: 768027
> Change-Id: Ifb05a6679c38e115b322e0a7caa6c3aad309389e
> Reviewed-on: https://chromium-review.googlesource.com/691097
> Commit-Queue: Tim Brown <timbrown@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#505183}
Bug: 768027
Change-Id: I151d1c1e708fa763f3d2d5a4a18b44bfdbe351fd
Reviewed-on: https://chromium-review.googlesource.com/692616
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Tim Brown <timbrown@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#505437}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 357bdbf7f33061d9ecf3052813cced0e9da45498
Script is failing on goobuntu-trusty_desktop-stable-amd64 due to packages conflict:
The following packages have unmet dependencies:
libdconf-dev : Conflicts: libdconf-dev:i386 but 0.20.0-1 is to be installed
libdconf-dev:i386 : Depends: libglib2.0-dev:i386 (>= 2.25.7) but it is not going to be installed
Recommends: libdconf-doc:i386 but it is not installable
Conflicts: libdconf-dev but 0.20.0-1 is to be installed
This reverts commit 5b267c0c4ffb22f07bea43853567c0b8a2ab9c21.
Reason for revert: <INSERT REASONING HERE>
Original change's description:
> Add libdconf-dev to to install-build-deps.sh
>
> This is the first step in moving from using gconf to dconf.
>
> Bug: 768027
> Change-Id: Ifb05a6679c38e115b322e0a7caa6c3aad309389e
> Reviewed-on: https://chromium-review.googlesource.com/691097
> Commit-Queue: Tim Brown <timbrown@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#505183}
TBR=dpranke@chromium.org,thomasanderson@chromium.org,timbrown@chromium.org
Change-Id: Icec37c78711a2016667ee7f134d5db49b918b7d2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 768027
Reviewed-on: https://chromium-review.googlesource.com/692974
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#505391}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3cd469287f3ce7290d3bfe3f1971aa529b6b1303
This is the first step in moving from using gconf to dconf.
Bug: 768027
Change-Id: Ifb05a6679c38e115b322e0a7caa6c3aad309389e
Reviewed-on: https://chromium-review.googlesource.com/691097
Commit-Queue: Tim Brown <timbrown@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#505183}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5b267c0c4ffb22f07bea43853567c0b8a2ab9c21
xdpyinfo from the package x11-utils is necessary for run-webkit-tests.
BUG=749222
R=dpranke@chromium.org
Change-Id: I4ee4d880895e56c947741debdaa2095f03efc91e
Reviewed-on: https://chromium-review.googlesource.com/601354
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#492466}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d79de41d48ab8813d3793d8df5c6bafe4d77b6ab
Raul Tambre
Marcin Wiącek
Elliott Friedman
Daniel Bratell
Tom Anderson
Mihai Sardarescu
Yves Gerey
Esmael El-Moslimany
George Burgess IV
Scott Violet
Dmytro Golovchenko
Tim Brown
Nico Weber
Robert Ma
Conley Owens
Dominik Röttsches
Andrew Grieve