--trace-cc implied cc.debug* which enables a ton of stuff for
ubercompositor. This is bad for recording performance. In the vast
majority of use cases, users of adb_profile_chrome just want a basic
frame viewer-case. So rename the flags accordingly to facilitate
that use case.
R=skyostil
Review URL: https://codereview.chromium.org/166483011
git-svn-id: http://src.chromium.org/svn/trunk/src/build@251673 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
ChannelProxy currently offers messages to all member MessageFilters. It turns
out that a good portion of the most common message types will never be filtered,
making the O(N) filter walk an unnecessary affair. To prevent this, allow
MessageFilters to indicate which (if any) subset of message classes they may
filter, allowing the ChannelProxy to refine the list of filters that are offered
a particular message. This saves ~35us per message received on the browser IO
thread for a typical Android device.
BUG=340881
TBR=asargent@chromium.org
Review URL: https://codereview.chromium.org/142923005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@251622 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Clients should set the host_os gyp variable instead. (As far as I can tell,
this flag was added for the webview build, and this CL updates gyp_webview
to use the gyp define instead. I haven't found other clients.)
Since several gyp targets check the value of host_os in a
target_conditions block and most of the build/common.gypi variables
aren't available during target_conditions processing time, use the same
trick that chromium_code uses to make host_os available at target_conditions
time.
BUG=330631
NOTRY=true
Review URL: https://codereview.chromium.org/153623011
git-svn-id: http://src.chromium.org/svn/trunk/src/build@251138 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
In some cases we have multiple libraries with the same package name
(particularly test+non-test). If one of these depends on the other and
refers to package-private stuff in the second, then it should be rebuilt
if the signature of package-private stuff is changed. To ensure that
happens, the TOC file must include the signatures of package-private
members.
Review URL: https://codereview.chromium.org/161773002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@250956 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Reason for revert:
crbug.com/342539 is likely happening because of the patch that this patch depends on. I need to ensure that logcats work on the bots before relanding (and that the corresponding steps fail if they don't.)
Original issue's description:
> I broke something by removing an apparently unused import that actually was used elsewhere. I addressed the issue by having the client code just call android_commands.GetAttachedDevices explicitly.
>
> BUG=168518
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250206TBR=craigdh@chromium.org,frankf@chromium.org,cjhopman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=168518
Review URL: https://codereview.chromium.org/159453002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@250264 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
build/common.gypi already sets <(android_toolchain) independently of this
env var, and nothing seems to really depend on the env var.
(tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py uses it
to print a better error message if it's available, but that doesn't seem
important.)
BUG=330631
R=torne@chromium.org
Review URL: https://codereview.chromium.org/146723004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@250141 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This allows the test runner to not depend on the STRIP env var, which is going away.
Other approaches considered:
1. Converting the remaining exe-based tests to apk tests. The apk versions
were slower, and didn't pass without other changes though.
2. Just don't strip. But that slows down these two tests by over 100%
(due to copying data to the device is slow, and stripped size is 0.5MB while
unstripped size is on the order of 10MB).
3. Try to get a trip binary from third_party/android_tools/ndk. That's fiddly
since it requires getting the right arch.
Since there are only two exe-based tests left, just strip them from gyp.
Medium-term, maybe gyp/mac's postbuild stuff can be brought to android,
it looks like there are various things that could be made simpler with that.
BUG=142642
TEST=
build/android/test_runner.py gtest -s sandbox_linux_unittests &&
build/android/test_runner.py gtest -s breakpad_unittests
R=bulach@chromium.org, frankf@chromium.org
TBR=jln, thestig
Review URL: https://codereview.chromium.org/157743004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@250035 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This reverts commit dc6d7c9d8d8bd5d29dd7a4fc681bb8c2a0bc3297.
Sorry, we can not commit this without the accompanying downstream change, because without that there are two --disable-stack-tool option strings (one in the downstream script and the newly added one here).
This causes the following error on the clank tot bot:
optparse.OptionConflictError: option --disable-stack-tool: conflicting option string(s): --disable-stack-tool
Link: https://chromegw.corp.google.com/i/clank.tot/builders/instrumentation-yakju-clankium-tot/builds/22826/steps/compile/logs/stdio
Reverting because this is keeping clank from picking up changes, and I'm not sure how to do a quick fix right now. Removing the option from clank requires the public script to have it, which requires clank to roll. Slightly tricky and I don't have the time to do it today.
TBR=craigdh@chromium.org,frankf@chromium.org,navabi@chromium.org,eugenis@chromium.org
NOTRY=true
BUG=325685
Review URL: https://codereview.chromium.org/154553003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@248830 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
It's been unused for two weeks, and should be a noop for everyone who sourced
envsetup since.
If you see an error message like
gyp: buid/all_android.gyp not found (cwd: /path/to/chrome/src)
after this change, open a fresh shell (and source envsetup),
or run `unset CHROMIUM_GYP_FILE`.
Also remove the code for unsetting CHROMIUM_GYP_FIE from envsetup
and fold the one line left in common_gyp_vars into its only caller.
BUG=330631
R=torne@chromium.org
Review URL: https://codereview.chromium.org/150903005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@248748 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Nothing sets this env var. (I checked with the folks who added this line, who
confirmed that this is unused.)
If something like this gets added again in the future, it shouldn't use a global
env var to turn it on but a single gyp define (that's hopefully identical for
desktop and mobile).
BUG=330631
R=torne@chromium.org
Review URL: https://codereview.chromium.org/135493004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@248722 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
If this patch breaks your build, try running `unset ANDROID_SDK_ROOT`.
Before this patch, envsetup checked if
${ANDROID_SDK_ROOT}/platforms/android-${ANDROID_SDK_VERSION} existed and fell
back to the sdk in chromium's third_party if that wasn't the case.
Since most people don't set ANDROID_SDK_ROOT and the ones who do will be
able to realize that they're using an SDK that doesn't have the right toolchain
version, this seems save to do. (The motivation is that I want to move
ANDROID_SDK_VERSION out of envsetup and into common.gypi.)
This reverts part of https://chromiumcodereview.appspot.com/10920094
BUG=330631
Review URL: https://codereview.chromium.org/152173002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@248483 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Instead of the slightly rube-goldbergian approach of giving mips_arch_variant
the default value mips32r2 in common.gypi and then always overriding this with
mips32r1 in envsetup, just set mips_arch_variant to mips32r1 by default and
don't set it in envsetup.
I checked that the generated ninja file for base is identical before and after
this change, and that the mips flags change as expected when manually setting
mips_arch_variant to mips32r2. No behavior change.
BUG=330631
TBR=torne@chromium.org
Review URL: https://codereview.chromium.org/152233002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@248409 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The explicit setting seems to match the default value for host_arch in
build/common.gypi close to line 110, and it's not set explicitly for other
target_archs, so this looks like an oversight. It's been this way since this
file was added in r148790 18 months ago.
No intended behavior change.
BUG=330631
Review URL: https://codereview.chromium.org/142023006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@248188 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
1. Removes obsolete methods.
- DeriveFontList(font_style)
# The method name and argument are not clear compared to other versions. Use DeriveWithStyle(style) below instead.
- DeriveFontListWithSize(absolute_size)
# Don't specify the absolute size.
2. Renames very long named methods.
- DeriveFontListWithSizeDeltaAndStyle => Derive
- DeriveFontListWithSizeDelta => DeriveWithSizeDelta
- new method => DeriveWithStyle
Since DeriveFontListWithSizeDeltaAndStyle is used more often than DeriveFontListWithSizeDelta, so give the former a shorter name.
Review URL: https://codereview.chromium.org/142523003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@248131 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
ContentViewGestureHandler conditionally forwards MotionEvent's to the Android
gesture detection pipeline, depending on the current touch stream handling
disposition. However, this approach is fragile, as the detection pipeline
expects a consistent touch stream for each sequence. Instead, forward all
MotionEvent's immediately for gesture detection, conditionally dispatching the
generated gestures depending on the touch stream ack dispositions.
BUG=295075,334040,327444,240550,234516
NOTRY=true
Review URL: https://codereview.chromium.org/120513005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@248066 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
ui/gfx/ depended on net/ for two things, SortedDisplayURL and gfx::ElideUrl().
SortedDisplayURL was not used by anything other than its own unit test and is
deleted in this patch. ElideUrl() is only used from
chrome/browser/ui/(gtk|cocoa|views), so this patch moves the functionality up
to chrome/browser/ui/elide_url.(h|cc) and the unit test to
chrome/browser/ui/tests/elide_url_unittest.cc.
R=sky
Review URL: https://codereview.chromium.org/143463006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@247820 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This is a quick and dirty fix for a problem that occurs to me when
trying to run instrumentation tests in a simulator.
For some reason 'pm path org.chromium.content_shell_apk.tests' outputs
a warning message in my environment that confuses the python scripts
and they end up calling md5sum for the root directory which is a bit
slow... The real fix would be to be able drop the stderr of the command
but it needs a lot of plumbing and probably there is not that much chance
that something like that will happen again for someone.
BUG=334439
Review URL: https://codereview.chromium.org/138143019
git-svn-id: http://src.chromium.org/svn/trunk/src/build@247742 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
If targets shouldn't be part of the android build, they should be conditional
in gyp instead.
Removing this line leads to 17 more files being compiled and one more binary
(printing_unittests) being linked on the open source bots, and there are no
build errors.
(An internal build of the 'all' target is also successful, and it builds only
183 additional edges too, which add about 1 minute / 5% to build time.)
BUG=330631
NOTRY=true
Review URL: https://codereview.chromium.org/149103002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@247571 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
order_text_section is only used by the chrome_initial target, which isn't
used on android.
(Some internal gyp file explicitly adds -Wl,-section-ordering-file without
going through the order_text_section gyp define, so this setting here is likely
a remnant from when that wasn't the case.)
No intended behavior change.
BUG=330631
NOTRY=true
Review URL: https://codereview.chromium.org/148513002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@247283 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
For a short transition period, let envsetup.sh set the right GYP_DEFINES when
GOMA_DIR is set, so that people aren't broken immediately after this lands.
Also stop setting GOMA_COMPILER_PROXY_THREADS – if the value this sets
is truly better, that should be the default in goma, it shouldn't be set in
envsetup.sh (doing it in goma has the advantage that it works on all
platforms, also abstraction barriers, etc.)
BUG=332697
R=brettw@chromium.org, ilevy@chromium.org
Review URL: https://codereview.chromium.org/142393002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@245801 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
On API level 17 and up, X509TrustManager can export the verified chain. Use it
to populate some of the fields in CertVerifyResult. Also correctly populate
is_issued_by_known_root and enable intranet host checking.
Add a test to make sure non-standard roots get flagged as such. If the APIs
are not available, is_issued_by_known_root is always false.
BUG=116838,147945
TEST=CertVerifyProcTest.PublicKeyHashes
CertVerifyProcTest.VerifyReturnChainBasic
CertVerifyProcTest.VerifyReturnChainFiltersUnrelatedCerts
CertVerifyProcTest.VerifyReturnChainProperlyOrdered
CertVerifyProcTest.IntranetHostsRejected
CertVerifyProcTest.IsIssuedByKnownRootIgnoresTestRoots
CertVerifyProcTest.ExtraneousMD5RootCert
CertVerifyProcTest.NameConstraintsFailure
Review URL: https://codereview.chromium.org/108653013
git-svn-id: http://src.chromium.org/svn/trunk/src/build@245649 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The content browsertests file for WebRTC was growing a bit large. I
extracted the getUserMedia-focused tests into a test of its own and
left the peerconnection tests.
Also renamed all WebRTC content browsertests to use the WebRtc naming
convention, which seems to be the most common in the production code.
Note: this patch will require some filter renames on the WebRTC bots.
R=tommi@chromium.org
Review URL: https://codereview.chromium.org/131203005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@245524 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Adding the content_gl_tests unit tests to the
gtest suite list supported by test_runner.py for Android platform.
BUG=none
R=bulach
TEST= Command to execute the content_gl_tests on Android:
path/to/build/android/test_runner.py gtest -s content_gl_tests <--gtest_filter=[TestFilter]>
Review URL: https://codereview.chromium.org/140623002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@245299 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The emulator sdk root is now downloaded into the source tree (and .gitingore'd).
That means that doing a clobber on the src directory will delete the emulator
SDK downloaded by build/android/install_emulator_deps.py.
This change allows developers to have an emulator SDK located somewhere else
that they can point the avd.py script to. Also, some bots will remove the src
directory between builds. Rather than make the bots re-download the emulator sdk
everytime, this allows them to have an emulator SDK installed somewhere else and
point to it.
BUG=304129
TBR=craigdh@chromium.org
Review URL: https://codereview.chromium.org/132793003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@244637 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Fix a few instances of HashMap to SparseArray in
AwQuotaManagerBridge.java
Pass null locale to String.format, which implies "no
localization is applied".
Pass Locale.ENGLISH toLowerCase as suggested by the
documentation.
Removed some unneeded supressions.
BUG=
Review URL: https://codereview.chromium.org/126453006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@243781 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Rebooting s3 devices causes device to be flaky during the deploy step. This is
likely because WaitForPackageManager() does not wait long enough on the s3
devices. I've verified locally on the bot that without the reboot in the
provision step, the devices are more reliable (i.e. deploy step passes).
BUG=321063
TBR=frankf@chromium.org
Review URL: https://codereview.chromium.org/122313008
git-svn-id: http://src.chromium.org/svn/trunk/src/build@243542 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This adds a build step to generate mirrored images for use in
right-to-left (RTL) languages. Images are mirrored by flipping the
original image over the vertical axis. Every image must be explicitly
listed as mirrorable or non-mirrorable in a config file.
The goal: ensure that our RTL image assets are always up-to-date.
BUG=290225
NOTRY=true
Review URL: https://codereview.chromium.org/106173002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@243332 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
I found that gfx::FontList doesn't carry UNDERLINE flag properly. Even though gfx::RenderText draws underline in a speciall manner, gfx::FontList should properly hold the underline flag. Otherwise, underline info will be dropped somewhere.
TEST=Run ui_unittests.
Review URL: https://codereview.chromium.org/119993002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@242486 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
There's no need to print out a warning about falling back to the
checked-in adb binary every time telemetry is run. Also turn ADB_PATH
into a memoized function to remove side effects from importing
constants.py. This also ensures the right logging level is set before
the path is determined so the warning is still printed in debug mode.
BUG=329317
Review URL: https://codereview.chromium.org/117333008
git-svn-id: http://src.chromium.org/svn/trunk/src/build@241854 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This change runs kvm-ok as root after installing the kvm and qemu-kvm
packages to ensure that KVM can work. This gives better diagnostics in
case of failure, which can happen for one of the following reasons:
- The CPU doesn't support virtualization extensions.
- The extensions have been disabled by the BIOS.
BUG=NONE
R=yfriedman@chromium.org,navabi@chromium.org,tfarina@chromium.org,raphael.kubo.da.costa@intel.com
Review URL: https://codereview.chromium.org/116493002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@241708 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Original CL: https://codereview.chromium.org/110173003/.
Refactor audio manager for Android to avoid heavy tasks at startup.
Main goal of this CL is to avoid all demanding tasks (e.g. initiate audio routing, detect BT devices etc.) at Chrome startup.
All we do now is to populate the list of available devices. BT support has been removed but will be added in an upcoming CL.
NOTRY=True
TBR=bulach, tommi
BUG=324464
TEST=media_unittests --gtest-filter=AudioAndroid*
Review URL: https://codereview.chromium.org/117073002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@241247 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Main goal of this CL is to avoid all demanding tasks (e.g. initiate audio routing, detect BT devices etc.) at Chrome startup.
All we do now is to populate the list of available devices. BT support has been removed but will be added in an upcoming CL. Detection will not require BLUETOOTH permission.
BUG=324464
TEST=media_unittests --gtest-filter=AudioAndroid*
R=bulach@chromium.org, tommi@chromium.org
Review URL: https://codereview.chromium.org/110173003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@240883 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
$ git log aab3a62beb..f89de358c2 --date=short --format="%ad %ae %s" | sed 's/@chromium\.org//'
2013-12-13 maruel Remove the ban on 'command' that are declared in included .isolate file.
2013-12-12 maruel Fix assert occurring on OSX due to already hardlinked files.
2013-12-11 ganetsky Create a .gitignore file and add *.pyc to it
2013-12-11 maruel Stop signalling swarming error on Windows file locking.
2013-12-11 maruel Ensure variables are decoded to unicode.
2013-12-06 maruel Rename --command-variable to --extra-variables.
2013-12-06 maruel Add real variable support and split --variable in 3 different flags.
2013-12-05 vadimsh Add 'offset' parameter to StorageApi.fetch(...) method.
2013-12-05 maruel Change log message to be clearer.
2013-12-05 vadimsh Support custom HTTP headers in net.url_open.
2013-12-03 vadimsh Remove urllib2 support.
2013-12-03 vadimsh Wait for Storage's internal threads to finish before exiting.
2013-12-03 vadimsh Fix swarming_smoke_test.py and isolateserver_test.py.
This commit is done manually, as the breakage caused by the last commit can't be
tested on the Try Server. This is because of the way
build/scripts/slave/runisolatedtest.py modifies the .isolated.state files.
R=vadimsh@chromium.org
BUG=
Review URL: https://codereview.chromium.org/106643010
git-svn-id: http://src.chromium.org/svn/trunk/src/build@240882 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Speculative revert because base_unittests and net_unittests are failing
on almost all of the Windows builders, with errors like:
[------ Swarming Error ------]
Input file E:\b\build\slave\Win7_Tests__3_\build\src\build\Release\chrome_100_percent.pak doesn't exist
> Roll swarm_client @ 9fc05789e3.
>
> Includes revert of r240243.
>
> $ git log aab3a62beb..9fc05789e3 --date=short --format="%ad %ae %s" | sed 's/@chromium\.org//'
> 2013-12-11 ganetsky Create a .gitignore file and add *.pyc to it
> 2013-12-11 maruel Stop signalling swarming error on Windows file locking.
> 2013-12-11 maruel Ensure variables are decoded to unicode.
> 2013-12-06 maruel Rename --command-variable to --extra-variables.
> 2013-12-06 maruel Add real variable support and split --variable in 3 different flags.
> 2013-12-05 vadimsh Add 'offset' parameter to StorageApi.fetch(...) method.
> 2013-12-05 maruel Change log message to be clearer.
> 2013-12-05 vadimsh Support custom HTTP headers in net.url_open.
> 2013-12-03 vadimsh Remove urllib2 support.
> 2013-12-03 vadimsh Wait for Storage's internal threads to finish before exiting.
> 2013-12-03 vadimsh Fix swarming_smoke_test.py and isolateserver_test.py.
>
> R=vadimsh@chromium.org
> NOTRY=true
> BUG=
>
> Review URL: https://codereview.chromium.org/113553003TBR=maruel@chromium.org
Review URL: https://codereview.chromium.org/101143003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@240528 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Includes revert of r240243.
$ git log aab3a62beb..9fc05789e3 --date=short --format="%ad %ae %s" | sed 's/@chromium\.org//'
2013-12-11 ganetsky Create a .gitignore file and add *.pyc to it
2013-12-11 maruel Stop signalling swarming error on Windows file locking.
2013-12-11 maruel Ensure variables are decoded to unicode.
2013-12-06 maruel Rename --command-variable to --extra-variables.
2013-12-06 maruel Add real variable support and split --variable in 3 different flags.
2013-12-05 vadimsh Add 'offset' parameter to StorageApi.fetch(...) method.
2013-12-05 maruel Change log message to be clearer.
2013-12-05 vadimsh Support custom HTTP headers in net.url_open.
2013-12-03 vadimsh Remove urllib2 support.
2013-12-03 vadimsh Wait for Storage's internal threads to finish before exiting.
2013-12-03 vadimsh Fix swarming_smoke_test.py and isolateserver_test.py.
R=vadimsh@chromium.org
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/113553003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@240460 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Instead of keeping the Android GPU pixel test reference images inside
the source tree, store them under the top level build bot directory,
e.g.,
/b/build/slave/<slave_name>/build/content_gpu_data/telemetry/{gpu_reference,generated}
This matches the location used on the non-Android GPU bots.
This patch also gives the current SVN revision to the test runner so the
reference images will get updated correctly.
TBR=navabi@chromium.org
Review URL: https://codereview.chromium.org/105183002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@240338 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This requires small changes in build/isolate.gypi, the isolate.py --variable
flag was split in three.
$ git log aab3a62beb..9cc42c3d4d --date=short --format="%ad %ae %s" | sed 's/@chromium\.org//'
2013-12-11 maruel Ensure variables are decoded to unicode.
2013-12-06 maruel Rename --command-variable to --extra-variables.
2013-12-06 maruel Add real variable support and split --variable in 3 different flags.
2013-12-05 vadimsh Add 'offset' parameter to StorageApi.fetch(...) method.
2013-12-05 maruel Change log message to be clearer.
2013-12-05 vadimsh Support custom HTTP headers in net.url_open.
2013-12-03 vadimsh Remove urllib2 support.
2013-12-03 vadimsh Wait for Storage's internal threads to finish before exiting.
2013-12-03 vadimsh Fix swarming_smoke_test.py and isolateserver_test.py.
R=vadimsh@chromium.org
BUG=324911
Review URL: https://codereview.chromium.org/105933002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@240155 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This fleshes out the reviewer list as I will no longer be
a primary reviewer.
Changes which could reduce android cq throughput, or which modify the
steps run by stable bots (add, removal, rename) should still go to
an infra contact in case it negatively affects the tree.
R=cmp@chromium.org
Review URL: https://codereview.chromium.org/111983004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@240133 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> Make page_cycler.py fully measure memory for each page.
>
> Telemetry makes the distinction between metrics collected for each page and for
> each page set. The fine-grained memory metrics were collected only per page set
> (although there was some histogram data collected per page).
>
> This CL makes the memory metric module systematically report the whole data per
> page (and not only per page set) so that we can measure pages independently.
> The per page set memory metric collection is now a no-op.
>
> BUG=323494
>
> Review URL: https://codereview.chromium.org/91573003TBR=pliard@chromium.org
Review URL: https://codereview.chromium.org/111773002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@239791 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Telemetry makes the distinction between metrics collected for each page and for
each page set. The fine-grained memory metrics were collected only per page set
(although there was some histogram data collected per page).
This CL makes the memory metric module systematically report the whole data per
page (and not only per page set) so that we can measure pages independently.
The per page set memory metric collection is now a no-op.
BUG=323494
Review URL: https://codereview.chromium.org/91573003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@239784 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This speeds up PushIfNeeded() execution times on a same instance of
AndroidCommands for repetitive files. This can be achieved by mapping host file
paths to their mtime at push time as tonyg@ pointed out although this assumes
that the device doesn't modify the files.
This is needed to make PurgeUnpinnedAshmem() reasonably fast to execute in
Telemetry. This CL decreases by 40 secs the execution time of netsim.top_10
whem memory is measured for each page (and PurgeUnpinnedAshmem() is called
before each measurement).
BUG=323494,326929
R=bulach@chromium.org, craigdh@chromium.org, tonyg@chromium.org
Review URL: https://codereview.chromium.org/97133002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@239757 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The sync tests failure seems to have to do with port unmapping. Not unmapping
ports let most of the sync tests pass (only 2 failures remain for an unrelated
reason apparently).
Note that port unmapping was added to avoid exceeding the file descriptor limit
in net_unittests since each test server was listening on a different port. The
sync tests use a server always listening on a same port so unmapping the port
is not strictly needed.
BUG=313809
Review URL: https://codereview.chromium.org/106533002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@239467 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Calling sys.exit() in a thread spawned by
multiprocessing.pool.ThreadPool causes an infinite hang that even SIGINT
can't fix. This is bad. Instead of calling sys.exit(), raise an
exception, crafted so that the important information (the failed
command's stdout and stderr) comes after the stacktrace and the copyable
command.
This also renames CheckCallDie() to CheckOutput() and changes it to
print stderr but not stdout by default. Suppressing stderr has hid bugs
in the past (e.g. aapt crunch failures), and hiding stdout is what we
usually want anyway.
R=cjhopman@chromium.org
Review URL: https://codereview.chromium.org/106923002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@239276 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
dirname outputs "." when given an empty argument, which gyp rules then
interpret as goma being available.
Remove ANDROID_GOMA_WRAPPER which is no longer used, and use GOMA_DIR
directly for android build.
BUG=
NOTRY=true
Review URL: https://codereview.chromium.org/104563004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@238718 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This is a reland of crrev.com/62953024 which was reverted because
it broke other platforms.
Refactoring common cleanup code required by both
android_browser_finder.py and perf/setup.py and moving it into
pyblib/utils/test_environment.py.
Also, this change avoids killing twice the adb server when running
in a bot environment, where the adb restart is already invoked by
the bot steps.
BUG=268450
R=bulach@chromium.org,tonyg@chromium.org
Review URL: https://codereview.chromium.org/94683002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@237815 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This CL modifies the build to incorporate the expected C++ library version
in the Java code. This is then checked when the library is loaded, to
make sure that the C++ and Java builds match.
This CL also implements error handling when library loads fail or the
loaded version doesn't match the expected version.
BUG=311644
Review URL: https://codereview.chromium.org/59533009
git-svn-id: http://src.chromium.org/svn/trunk/src/build@237779 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28amd64%29/builds/12649/steps/BuildPackages/logs/stdio
autotest-chrome-0.0.1-r3242: ERROR:root:bluetooth_RegressionClient import error: No module named telemetry.core. Skipping bluetooth_RegressionClient
autotest-chrome-0.0.1-r3242: Traceback (most recent call last):
autotest-chrome-0.0.1-r3242: File "/build/amd64-generic/tmp/portage/chromeos-base/autotest-chrome-0.0.1-r3242/work/autotest-work/client/bin/setup_job.py", line 72, in init_test
autotest-chrome-0.0.1-r3242: exec import_stmt + '\n' + init_stmt in locals_dict, globals_dict
autotest-chrome-0.0.1-r3242: File "<string>", line 1, in <module>
autotest-chrome-0.0.1-r3242: File "/build/amd64-generic/tmp/portage/chromeos-base/autotest-chrome-0.0.1-r3242/work/autotest-work/client/site_tests/bluetooth_RegressionClient/bluetooth_RegressionClient.py", line 7, in <module>
autotest-chrome-0.0.1-r3242: from autotest_lib.client.cros.bluetooth import bluetooth_semiauto_helper
autotest-chrome-0.0.1-r3242: File "/build/amd64-generic/tmp/portage/chromeos-base/autotest-chrome-0.0.1-r3242/work/autotest-work/client/cros/bluetooth/bluetooth_semiauto_helper.py", line 10, in <module>
autotest-chrome-0.0.1-r3242: from autotest_lib.client.cros import semiauto_framework
autotest-chrome-0.0.1-r3242: File "/build/amd64-generic/tmp/portage/chromeos-base/autotest-chrome-0.0.1-r3242/work/autotest-work/client/cros/semiauto_framework.py", line 9, in <module>
autotest-chrome-0.0.1-r3242: from autotest_lib.client.common_lib.cros import chrome
autotest-chrome-0.0.1-r3242: File "/build/amd64-generic/tmp/portage/chromeos-base/autotest-chrome-0.0.1-r3242/work/autotest-work/client/common_lib/cros/chrome.py", line 7, in <module>
autotest-chrome-0.0.1-r3242: from telemetry.core import browser_finder, browser_options, exceptions
autotest-chrome-0.0.1-r3242: ImportError: No module named telemetry.core
> [Telemetry] Refactor common Android test harness functions.
>
> Refactoring common cleanup code required by both
> android_browser_finder.py and perf/setup.py and moving it into
> pyblib/utils/test_environment.py.
> Also, this change avoids killing twice the adb server when running
> in a bot environment, where the adb restart is already invoked by
> the bot steps.
>
> BUG=268450
> R=bulach@chromium.org,tonyg@chromium.org
> NOTRY=true
>
> Review URL: https://codereview.chromium.org/62953024TBR=primiano@chromium.org
Review URL: https://codereview.chromium.org/93793002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@237674 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Refactoring common cleanup code required by both
android_browser_finder.py and perf/setup.py and moving it into
pyblib/utils/test_environment.py.
Also, this change avoids killing twice the adb server when running
in a bot environment, where the adb restart is already invoked by
the bot steps.
BUG=268450
R=bulach@chromium.org,tonyg@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/62953024
git-svn-id: http://src.chromium.org/svn/trunk/src/build@237667 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
1) Verify that setLocalDescription fails when trying to negotiate an unsupported video codec
- Verify that setLocalDescription fails when trying to negotiate with a client that does not support encryption
BUG=303035
Review URL: https://codereview.chromium.org/47923023
git-svn-id: http://src.chromium.org/svn/trunk/src/build@235798 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Changes:
* Decouple the version of the SDK that is installed from
the version of the Android API that will be used.
* Upgrade the SDK to Android-19 while we are at it.
* Allow an "--api-level" argument to choose system images.
* Automagically download and install platform libraries for
any --api-level
BUG=
Review URL: https://codereview.chromium.org/59943011
git-svn-id: http://src.chromium.org/svn/trunk/src/build@235782 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
We use the SurfaceFlinger data to compute the lengths of the frames (normalized
to vsyncs). Sometimes the data is inconsistent and we get two frames that are
less than 1 vsync apart. Filter out these frame lengths (threshold length is
currently 0.5 vsyncs) and print a warning.
BUG=318093
Review URL: https://codereview.chromium.org/71353006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@235675 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The script's output is "buffered" so it can be retried on case of failures
without messing up the higher level log parsing.
This however triggers the buildbot watchdog, which kills the tests since
it doesn't produce any output.
Print a hearbeat message to indicate the --single-step step script is
alive and kicking.
BUG=318369
NOTRY=True
Review URL: https://codereview.chromium.org/68503009
git-svn-id: http://src.chromium.org/svn/trunk/src/build@234884 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This is the src/ part of trying to make android up and downstream run more or
less the same stack for perf tests.
Instead of requiring all steps listed (which allows sharding), this instead
allows running a single step, with retries and other niceties such as adb
restarting, device fail over, etc..
BUG=
Review URL: https://codereview.chromium.org/66373004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@234493 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Rather than (un)mapping the ports on each one of the internal instrumentation
tests, do it higher up at the host driven level.
Ensure the test server is fully setup and tear down.
Ensure the adb port is fully unmapped at the host forwarder level.
Add more log information to the forwarder, and add them to TestResult.log in case of failure.
Kill the device forwarder when unmapping all ports.
BUG=313809
Review URL: https://codereview.chromium.org/59313003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@234486 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
We're seeing a lot of red builds due to tests out of
our control for our Android builder running
content_browsertests in
http://build.chromium.org/p/chromium.webrtc.fyi/waterfall
By filtering out our WebRTC specific tests, we'll get
a better signal of if changes in WebRTC ToT is causing
trouble in Chrome on Android.
NOTRY=True
BUG=305749
TEST=Android trybots passing +
built with a workspace setup as https://code.google.com/p/webrtc/issues/detail?id=1882#c11:
. build/android/envsetup.sh
GYP_DEFINES="$GYP_DEFINES enable_tests=1" android_gyp
ninja -C out/Debug android_builder_chromium_webrtc
build/android/buildbot/bb_run_bot.py --bot-id=webrtc-chromium-tests --testing
Verified the output and ran the produced command line locally:
build/android/test_runner.py gtest -s content_browsertests --verbose '--gtest-filter=Webrtc*:WebRTC*' --num_retries=1
Verified that only the WebRTC test were excuted.
Review URL: https://codereview.chromium.org/59593003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@234467 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This patch modifies the implementation if SysUtils.isLowEndDevice() to
not rely on any native code, which is required to run it before the native
libraries are actually loaded (e.g. when running certain tests).
+ Simplify the content linker that doesn't need a specific native method
anymore to replicate the yet-unloaded native SysUtils::IsLowEndDevice().
BUG=309926
R=dtrainor@chromium.org,tedchoc@chromium.org,frankf@chromium.org,bulach@chromium.org
TEST=build/android/test_runner.py linker
Review URL: https://codereview.chromium.org/59033008
git-svn-id: http://src.chromium.org/svn/trunk/src/build@233739 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Add a tool to record screen capture videos from Android devices. This
patch introduces both a standalone tool as well as a telemetry profiler
which captures a video of a telemetry run.
Note that the screen recording functionality requires Android KitKat or
later.
TEST=tools/perf/run_benchmark run --profiler=android-screen-recorder --browser=android-chrome smoothness.top_25 --page-filter=news.yahoo
Review URL: https://codereview.chromium.org/54123005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@233686 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Eliminate the short period of time between the tap timeout and long
press causing onSingleTapConfirmed not to be dispatched when apps
expect.
Note: This is a cherry-pick of the upstream Android fix for b/8124095.
BUG=315124
NOTRY=true
Review URL: https://codereview.chromium.org/59173006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@233192 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Use the one defined in constants.py instead.
BUG=
TEST=build/android/test_runner.py instrumentation --test-apk ChromiumTestShellTest --test_data chrome:chrome/test/data/android/device_files --verbose --host-driven-root=chrome/android -f testDisableAndEnableSync --python-only
Review URL: https://codereview.chromium.org/59713002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@233057 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
WebRTC is running the content_browsertests test
for ToT WebRTC revisions to track regressions on an
early stage. In order to save compile time and
build artifacts, we want to build only what's needed
(i.e. not the All target).
In https://codereview.chromium.org/27622005/ an
attempt was made to make content_browsertests_apk
to be enough of target to build (that CL made it also
build android_tools). Since that approach was having
bad sideffects, this helper target should give us
everything needed for our build.
NOTRY=True
TEST=local compile, verifying the apk and host_forwarder is built.
BUG=305749
Review URL: https://codereview.chromium.org/43463004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@232956 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Add support for html-packaged trace files to adb_profile_chrome. The
--html option will cause the trace file to be serialized into an html
file that contains a snapshot of the Trace Viewer from the Chromium
source tree. The resulting file has no other dependencies and therefore
does not require a specific version of Chrome for viewing.
This patch also adds the --view option for automatically opening the
written trace file in a browser.
NOTRY=true
Review URL: https://codereview.chromium.org/48733003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@231333 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This CL lets us supply an app URL to mojo_shell on Android. To load an app, you
can use the adb_run_mojo_shell script:
$ ./build/android/adb_run_mojo_shell http://127.0.0.1:4444/libsample_app.so
This script starts the MojoShellActivity on the device and passes the URL to
mojo_shell via an Android Intent. We're currently using the VIEW intent, but we
might want to switch to a different intent at some point.
R=darin@chromium.org,aa@chromium.org
Review URL: https://codereview.chromium.org/47343002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@231260 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Third retry on crrev.com/226762.
Adds "wait-for-device".
There's some data indicating that adbd on the device sometimes
spontaneously restores its connection.
After running a test, let's kill adbd and wait for bit.
This is a speculative change to try to make the bots healthier.
BUG=268450
Review URL: https://codereview.chromium.org/32163002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@229931 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This patch adds a new Chrome-specific dynamic linker for Android,
that implements RELRO section sharing in order to save about 1.3 MB
of RAM per renderer process in content-based programs (ContentShell,
ChromiumTestShell, Chrome, etc...)
The linker is disabled by default. For more details, see the corresponding bug entry.
This introduces a new test package (content_linker_test_apk) as well as a new test category. To build and test this feature, do the following:
ninja -C out/Debug content_linker_test_apk
build/android/test_runner.py linker
BUG=287739
R=qsr@chromium.org
Review URL: https://codereview.chromium.org/23717023
git-svn-id: http://src.chromium.org/svn/trunk/src/build@229921 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Restart USB has been known to bring back offline devices. Add option to device
status check to restart usb ports before performing the check. This requires
restart_usb to be installed (see
https://code.google.com/p/chromium/issues/detail?id=305769). Prints warning if
the utility has not been installed on the host.
We will add this first to perf bots. Restarting usb has fixed device issues on these bots. If we find it works and does not have unseen consequences, we will deploy on all bots (i.e. make default of --restart-usb to True).
BUG=299891
Review URL: https://codereview.chromium.org/26747004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@229553 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
nduca@chromium.org
skyostil@chromium.org
bulach@chromium.org
jdduke@chromium.org
thakis@chromium.org
jbudorick@chromium.org
dfalcantara@chromium.org
yukishiino@chromium.org
cjhopman@chromium.org
aberent@chromium.org
thestig@chromium.org
phajdan.jr@chromium.org
wibling@chromium.org
zty@chromium.org
eugenis@chromium.org
navabi@google.com
pasko@chromium.org
dpranke@chromium.org
qsr@chromium.org
plundblad@chromium.org
jamesr@chromium.org
b.kelemen@samsung.com
kjellander@chromium.org
frankf@chromium.org
maruel@chromium.org
davidben@chromium.org
phoglund@chromium.org
r.kasibhatla@samsung.com
aurimas@chromium.org
jshin@chromium.org
dalecurtis@google.com
boliu@chromium.org
newt@chromium.org
kbr@chromium.org
iancottrell@chromium.org
mahesh.kk@samsung.com
tonyg@chromium.org
digit@chromium.org
pliard@chromium.org
davemoore@chromium.org
henrika@chromium.org
szym@chromium.org
dmazzoni@google.com
ckocagil@chromium.org
ilevy@chromium.org
johnme@chromium.org
wjia@chromium.org
craigdh@chromium.org
primiano@chromium.org
creis@chromium.org
andrewhayden@chromium.org
jyasskin@chromium.org
elham@google.com
mnaganov@chromium.org
rileya@chromium.org
dominikg@chromium.org
rockot@google.com
mek@chromium.org
xhwang@chromium.org
rmcilroy@chromium.org
mkosiba@chromium.org
wangxianzhu@chromium.org
abarth@chromium.org
skobes@chromium.org
fischman@chromium.org