75e7e2b4f8
reland of intsafe precompiled header fix from https://codereview.chromium.org/14201003/
...
With fixed include path.
TBR=cpu@chromium.org
BUG=225822
Review URL: https://codereview.chromium.org/14096011
git-svn-id: http://src.chromium.org/svn/trunk/src/build@194620 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-04-17 17:25:34 +00:00
476249982b
Revert 194506 "intsafe workaround to separate header"
...
Broke x64 compile.
> intsafe workaround to separate header
>
> Allows workaround to work without precompiled headers (as in
> buildtype=Official)
>
> R=cpu@chromium.org
> BUG=225822
>
> Review URL: https://codereview.chromium.org/14201003
TBR=scottmg@chromium.org
Review URL: https://codereview.chromium.org/13977005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@194507 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-04-17 01:37:20 +00:00
ec9bc6068d
intsafe workaround to separate header
...
Allows workaround to work without precompiled headers (as in
buildtype=Official)
R=cpu@chromium.org
BUG=225822
Review URL: https://codereview.chromium.org/14201003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@194506 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-04-17 01:13:21 +00:00
59703c396f
workaround for building with express toolchain on windows
...
intsafe.h and stdint.h both define INT8_MIN et al. with no guards,
and so can't both be included. Because dependencies do this deep
in their internals, avoid this problem by including intsafe.h,
and then #undef'ing the conflicts in precompile.h (which is included
in all .cc files). intsafe.h's include guard symbol stays defined
so that any subsequent inclusions do not cause problems.
R=thestig@chromium.org
BUG=225822
Review URL: https://chromiumcodereview.appspot.com/13484002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@192341 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-04-04 16:13:44 +00:00
6ebbee87d3
Change a couple of TODOs to plain comments.
...
BUG=none
Review URL: http://codereview.chromium.org/10204018
git-svn-id: http://src.chromium.org/svn/trunk/src/build@133741 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-04-24 19:04:41 +00:00
e89cde8103
Eliminate headers from precompile.h that define 'interface' to avoid compile failures on Windows that would not be seen on Mac or Linux. I didn't do an exact measurement but I think we lose very little in terms of build time from this; Windows.h is the big Windows-specific header and it's still precompiled.
...
BUG=none
TEST=it builds
Review URL: http://codereview.chromium.org/7888030
git-svn-id: http://src.chromium.org/svn/trunk/src/build@101059 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-09-14 10:55:18 +00:00
2869c0a819
Use precompiled headers for most large projects where the .gyp file
...
is not a third party file.
On my machine, this speeds up a full recompile of the 'chrome' target
in Debug mode by about 18%.
BUG=none
TEST=it builds, existing tests pass
Review URL: http://codereview.chromium.org/7706011
git-svn-id: http://src.chromium.org/svn/trunk/src/build@99949 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-09-07 14:14:54 +00:00
scottmg@chromium.org
joi@chromium.org