Move the include of the Mac TargetConditionals.h file to after we've
checked if we're building for Android. Apparently this file doesn't
exist on all macs used to build android and the rest of android builds
fine without it, so including it there causes the build to fail. It
appears to only be used to test TARGET_OS_IPHONE which will never be
true on android.
BUG=
Review URL: https://codereview.chromium.org/538563002
Cr-Original-Commit-Position: refs/heads/master@{#293495}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ecb23485e511b4c9eaf6e20ee48c21f216abe523
Background: I am currently trying to test NaCl in clank by setting disable_nacl=0 and enable_plugins=1 in gyp. Some of the code required to get this to work is guarded under overly-specific OS==android and similar constructs. This first CL enables a coherent build with the flags set to gyp, but does not yet turn the functionality on completely. A sampling of issues fixed:
1) std:: prefix is more strictly observed on android
2) define NACL_LINUX, etc., is needed for nacl code
3) properly guard flag-setting code
BUG= https://code.google.com/p/nativeclient/issues/detail?id=3032R=bradnelson@google.com, darin@chromium.org
Review URL: https://codereview.chromium.org/299703016
git-svn-id: http://src.chromium.org/svn/trunk/src/build@274839 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Add support for the architecture to build/build_config.h (define
new macro ARCH_CPU_ARM64 to identify the CPU architecture and
set the other appropriate macros to 1).
Fix DEBUG_BREAK_ASM() macro to expand to the correct instruction
on arm64 cpu (as instruction set is not compatible with previous
version of ARM instruction sets).
BUG=339477
R=mark@chromium.org
Review URL: https://codereview.chromium.org/145273028
git-svn-id: http://src.chromium.org/svn/trunk/src/build@249246 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
An "#ifdef" statement is more confusing than using C++ syntax and
"if (XXX)". They should be used only when strictly necessary (i.e. when
code cannot compile).
For the cases where #ifdef are not strictly necessary, these new helpers can
be used.
Thanks to compiler optimization, the final compiled code will be the
same when these helpers are used instead of #ifdef.
R=rsesek@chromium.org
Review URL: https://codereview.chromium.org/103293003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@239079 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
uClibc pretends to be glibc, so just checking for __GLIBC__ doesn't always
work. Rather than check for defined(__GLIBC__) && !defined(__UCLIBC__) in
multiple places, do it once and define LIBC_GLIBC if we're certain that we're
really using glibc.
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/15405003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@201761 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This is part of the effort to bring TCMalloc to android.
The first goal is to get instrumentation to facilitate
integration with DMP and memory profiling.
This is not yet intended for full production usage as the
default allocator.
BUG=162208
Review URL: https://chromiumcodereview.appspot.com/14321006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@201524 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The Android port relies on the global define ANDROID to identify that
we are crosscompiling for Android, but __APPLE__ was being checked first
in build_config.h, and so builds on a Mac sometimes ended up with the
wrong OS_* macro defined. Reorder the list so that ANDROID is tested
first, as it will only be set manually when crosscompiling (__APPLE__ is
set internally by the compiler).
BUG=
Review URL: https://chromiumcodereview.appspot.com/13541003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@192303 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This was a #define that was added when we were deciding
whether we should use the bytecode interpreter or FreeType's
autohinter when rendering UI text on Chrome OS. The text
had different heights depending on which setting was used,
so a bunch of constants were special-cased when BCI was
enabled. We've been using the autohinter for a long time,
and we'll need to update lots of newer code if we decide to
switch to BCI someday.
BUG=none
TEST=UI text looks the same as before
TBR=tony@chromium.org,davemoore@chromium.org,zork@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10828336
git-svn-id: http://src.chromium.org/svn/trunk/src/build@151928 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
There are basically three categories of changes here:
1) Most OS==mac becomes OS==mac or OS==ios
2) Some Xcode-related settings move into OS==mac blocks since Xcode is no longer Mac-only
3) Addition of iOS-specific settings (SDK, compile flags, etc)
BUG=None
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10704039
git-svn-id: http://src.chromium.org/svn/trunk/src/build@145008 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Rather than globally defining NO_HEAPCHECKER and then checking
that in build_config.h, let builds that opt in to heap checking
directly set USE_HEAPCHECKER.
Result should be equivalent builds but less stuff in the build
files.
Review URL: http://codereview.chromium.org/9146022
git-svn-id: http://src.chromium.org/svn/trunk/src/build@118823 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Explicitly disable GTK by setting TOOLKIT_USES_GTK. This is the first in a series of changes required to have chrome on aura build and link without GTK. This CL makes base/ build without GTK. Subsequent CLs will do this for other components.
BUG=97131
TEST=none
Review URL: http://codereview.chromium.org/7904034
git-svn-id: http://src.chromium.org/svn/trunk/src/build@102005 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This patch gets a bunch of the IPC and Base libraries compiling (but not
linking) in NaCl. There's obviously a bunch more work to do, but this patch is
a starting point.
Original patch by Eric Seidel.
Review URL: http://codereview.chromium.org/4812002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@65920 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
- that is, defining use_openssl=1 will now remove all dependency on NSS.
This does not impact any of the standard, non-openssl builds.
Adds stub implementations of several files that need to be fully implemented in follow up patchs.
Firefox import code will need some more substatial refactoring, as it makes little sense to be
attempting a firefox import without NSS libraries to hand, however the UI etc has numerous assumption
about the presence of this importer.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3855004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@63506 4ff67af0-8c30-449e-8e8b-ad334ec8d88c