Includes a Fuchsia SDK update, and a lot of mx_ -> zx_, et al.
Sets CHROMIUM_ROLLING_MAGENTA_TO_ZIRCON=1 as a global define
temporarily to support for 3-sided rolls of third_party DEPS.
Requires https://chromium-review.googlesource.com/c/v8/v8/+/668751 to
have landed and rolled.
Requires boringssl roll with similar change to have landed
https://chromium-review.googlesource.com/c/chromium/src/+/668704.
R=dcheng@chromium.org,nick@chromium.org,tsepez@chromium.org,rockot@chromium.org
TBR=nick@chromium.org
Bug: 765754, 707030
Change-Id: I6c2ad37b3c5b13c2a3a98da6e1ff9160ad2de949
Reviewed-on: https://chromium-review.googlesource.com/669139
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502678}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fe0e9f46ab247ff5a28a823f344c93230953018f
It breaks CrOS builds which use a different version of Clang, which
doesn't support this flag.
This is a stop-gap fix; Linux CrOS builds do use the Chromium version of
Clang, and we want them to have this flag, but there doesn't seem to be
a straight-forward way to distinguish between these compiler versions
from the build system.
Landing to unbreak the build for now until a better solution is found.
TBR=llozano
Bug: 766311,765793
Change-Id: I3e040161f6987b502b28e97f41fcde2d464da72c
Reviewed-on: https://chromium-review.googlesource.com/671810
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502668}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 308178955214516b259876b56fff9bfc78b97e7f
Trying harder to exclude CrOS build configs that don't use
Chromium's Clang.
Note to CrOS folks: If this breaks build configs that are not
tested upstream, please ping me and/or llozano before reverting.
This is a reland of 32750c1251012624a87fb97098bd0f6a60ffa8ed
Original change's description:
> Clang: enable -instcombine-lower-dbg-declare=1
>
> This enables better optimized debug info for address-taken values
> at the cost of potentially inaccurate debug info in some situations.
>
> We believe turning this on is the right trade-off for developers
> debugging Chromium on all platforms, but especially on Windows where
> values that are available in MSVC's debug info would otherwise show
> as unavailable when using Clang.
>
> The goal (crbug.com/765793) is to make Clang's optimized
> debug info good enough in all cases that this compromise is not
> necessary.
>
> Note: This requires Clang r313108 or later.
>
> Bug: 761633, 753736, 765793
> Change-Id: Ia0ed38c499fac282a3c8ab27c5fd5571fdfab84d
> Reviewed-on: https://chromium-review.googlesource.com/669314
> Commit-Queue: Hans Wennborg <hans@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#502428}
TBR=thakis
Bug: 761633, 753736, 765793
Change-Id: I2c3670873f1bd1d75cf1c41191b170983f41e0d0
Reviewed-on: https://chromium-review.googlesource.com/671523
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502646}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 074fa51f85b15ad2e2d6c804a03825d48dbeb063
This is a no-op for now. Also rename the initialization method to be
more specific.
Bug: 765428
Change-Id: I7cc24844de89a888df13c31141b476da71196304
Reviewed-on: https://chromium-review.googlesource.com/671026
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502630}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 10da07c8de893d2d1dc5de5df5f4c3afd43bf35c
The asset catalog compiler may generate a partial Info.plist file
to merge with the bundle Info.plist; add support for creating the
bundle Info.plist to codesign.py script.
Bug: 764286
Change-Id: Ie2664f7b81907deca9c65dfb37834da8dcb15e69
Reviewed-on: https://chromium-review.googlesource.com/671224
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502605}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 54d19130114243bc339f5fb256dcff7ea99a5b7a
Add additional templates to compiled .appiconset and .launchimage
asset catalog types and rename the file defining the templates to
build/config/ios/asset_catalog.gni.
Leave a forwarding .gni named build/config/ios/imageset.gni as the
downstream code still reference this path. The file will be removed
in a followup CL once the downstream code has been fixed to use the
new path.
TBR=yuweih@chromium.org (for remoting/ios/app/resources/BUILD.gn)
Bug: 764286
Change-Id: Ia229d1bcbbcbeb828103ff283197120da2a21b85
Reviewed-on: https://chromium-review.googlesource.com/671264
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502603}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 39ee46494805e717c7aca8f35f4d7acadaf43ce0
This CL adds "vectorDrawables.useSupportLibrary = true" to build.gradle
that is used by Android Studio to fix warning issued for XML
app:srcCompat attribute. Chromium build already uses support library
for vector drawables.
Bug: 620034
Change-Id: I92fb56f83f854de42577a13c3fe8d51b5d1fe263
Reviewed-on: https://chromium-review.googlesource.com/668401
Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502590}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c182fd2bbdaedfe3caa046fcb849ae5c35745b0c
This reverts commit 8707de2d756841d799483ceff0427e316961f468.
Reason for revert: media_unittests is crashing in vpx_internal_error
https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64/builds/15967
Original change's description:
> Make VS 2017 the default compiler on Windows
>
> All known blockers for VS 2017 as the default compiler for Chrome on
> Windows have been addressed. Switching to VS 2017 will give us:
>
> - Better C++ conformance and various bug fixes, especially around
> constexpr
> - Faster fastlink links and fixes to linker bugs which can cause
> incremental linking to fail
> - Newer STL header files for increased STL conformance
> - Debugger stability fixes (it is quite possible to debug VS 2015
> binaries with VS 2017 but using the same toolchain for both is
> preferable)
>
> Note that many of these benefits apply even in the context of switching
> to clang - faster links are always good, and increased VS conformance
> makings switching between VS and clang easier.
>
> Test switches to VS 2017 have been done enough times to make us
> reasonably confident that the switch will go smoothly. If not then it
> can be easily reverted. If the switch sticks then the documentation
> pages will need to be updated.
>
> Note that the Windows 10 Creators Update SDK will be made required soon
> after this change.
>
> Bug: 683729
> Change-Id: I79fdd9e44c6bb7ef25ab6bcb88845ac18e5cf56f
> Reviewed-on: https://chromium-review.googlesource.com/665637
> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Scott Graham <scottmg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#502421}
TBR=dpranke@chromium.org,brucedawson@chromium.org,scottmg@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 683729
Change-Id: Icf40a84f30941980b1c9e038cc4336b057ea10c0
Reviewed-on: https://chromium-review.googlesource.com/670283
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502535}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: eaccacb6302f7b0ea235fd7d1ff3aa7eaf8b20ef
This reverts commit 32750c1251012624a87fb97098bd0f6a60ffa8ed.
Reason for revert: This CL breaks most of the informational builds https://uberchromegw.corp.google.com/i/chromeos.chrome/waterfall?reload=300. See an example here: https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/veyron_minnie-tot-chrome-pfq-informational/builds/6039
Original change's description:
> Clang: enable -instcombine-lower-dbg-declare=1
>
> This enables better optimized debug info for address-taken values
> at the cost of potentially inaccurate debug info in some situations.
>
> We believe turning this on is the right trade-off for developers
> debugging Chromium on all platforms, but especially on Windows where
> values that are available in MSVC's debug info would otherwise show
> as unavailable when using Clang.
>
> The goal (crbug.com/765793) is to make Clang's optimized
> debug info good enough in all cases that this compromise is not
> necessary.
>
> Note: This requires Clang r313108 or later.
>
> Bug: 761633, 753736, 765793
> Change-Id: Ia0ed38c499fac282a3c8ab27c5fd5571fdfab84d
> Reviewed-on: https://chromium-review.googlesource.com/669314
> Commit-Queue: Hans Wennborg <hans@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#502428}
TBR=thakis@chromium.org,hans@chromium.org,rnk@chromium.org
Change-Id: I4fea2ab8ec9571d4afb66cd3912c5975e0b9395c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 761633, 753736, 765793
Reviewed-on: https://chromium-review.googlesource.com/669825
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502484}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5487d51f9175a69613e7b715be437ece3c1d88e5
And also add a special case to ReTrace regex to deobfuscate a junit
message.
Bug: 765714
Change-Id: I2ba53b00a563f67eef7eb1910b2f894746abfb3a
Reviewed-on: https://chromium-review.googlesource.com/669011
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502476}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fc9e7a90fdeb4371bfc97e13a8d1db5217697576
This enables better optimized debug info for address-taken values
at the cost of potentially inaccurate debug info in some situations.
We believe turning this on is the right trade-off for developers
debugging Chromium on all platforms, but especially on Windows where
values that are available in MSVC's debug info would otherwise show
as unavailable when using Clang.
The goal (crbug.com/765793) is to make Clang's optimized
debug info good enough in all cases that this compromise is not
necessary.
Note: This requires Clang r313108 or later.
Bug: 761633, 753736, 765793
Change-Id: Ia0ed38c499fac282a3c8ab27c5fd5571fdfab84d
Reviewed-on: https://chromium-review.googlesource.com/669314
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502428}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 32750c1251012624a87fb97098bd0f6a60ffa8ed
All known blockers for VS 2017 as the default compiler for Chrome on
Windows have been addressed. Switching to VS 2017 will give us:
- Better C++ conformance and various bug fixes, especially around
constexpr
- Faster fastlink links and fixes to linker bugs which can cause
incremental linking to fail
- Newer STL header files for increased STL conformance
- Debugger stability fixes (it is quite possible to debug VS 2015
binaries with VS 2017 but using the same toolchain for both is
preferable)
Note that many of these benefits apply even in the context of switching
to clang - faster links are always good, and increased VS conformance
makings switching between VS and clang easier.
Test switches to VS 2017 have been done enough times to make us
reasonably confident that the switch will go smoothly. If not then it
can be easily reverted. If the switch sticks then the documentation
pages will need to be updated.
Note that the Windows 10 Creators Update SDK will be made required soon
after this change.
Bug: 683729
Change-Id: I79fdd9e44c6bb7ef25ab6bcb88845ac18e5cf56f
Reviewed-on: https://chromium-review.googlesource.com/665637
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502421}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8707de2d756841d799483ceff0427e316961f468
This is the last step in removing the task profiler code.
A number of files were depending on this to get the LazyInstance
declaration so includes for lazy_instance are added.
BUG=739505
Change-Id: I5cc4dde74b40f33d274215e62fbcd72ca7df6aea
Reviewed-on: https://chromium-review.googlesource.com/665969
Commit-Queue: Brett Wilson <brettw@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502415}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0241e02bedc445db6bce2e909d386ed9c1386d6b
With this I can build a working chrome.exe with ThinLTO on Windows
using LLVM trunk plus a few under-review patches.
Bug: 598772
Change-Id: Ida40f0367e03326fe03d4880395103c12008b34a
Reviewed-on: https://chromium-review.googlesource.com/656262
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502378}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 908df7cd424db006e1a068f1548cbf739d9aa142
With the exception of ChromeOS, we only intend to support POSIX-style
LTO and CFI in Chromium when using LLD, so make it the default in
those configurations.
Bug: 469376, 507755
Change-Id: I9e9b1b3a3495402cc4429c3cfb72006712f68bee
Reviewed-on: https://chromium-review.googlesource.com/662603
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502365}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5261eb13619f0e7d20de5a5b784da04bf3b03bec
resources.arsc normalization expects a single .arsc file, so use the
resource packaged APK instead. This requires the output directory to be
set (if not, normalization is skipped).
Bug: 764827
Change-Id: Ic17d5350eb07f48f490bde78f0cd8c664f178e82
Reviewed-on: https://chromium-review.googlesource.com/667721
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502347}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0cd4fc80316b8c17edd3bd770e6d0aa561d00293
Currently running into a problem with compiling chromecast source with
aarch64 toolchain. Since I can't provide asm flags, the CC looks for an
assembler to compile with in my PATH, which ends up picking my host
assembler, which doesn't work.
Need to pass -B/path/to/toolchain so the CC may find the proper -as
BUG= None
TEST=Build
Change-Id: Ifa3790954e7779e44272f48f46521295f57422d0
Reviewed-on: https://chromium-review.googlesource.com/646733
Commit-Queue: Mina Almasry <almasrymina@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502304}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ed4edf011bd04a489d805d30a1742c28d1e1cd16
This script runs swarming_xcode_install on the bots. It should be run when
we need to upgrade all the swarming testers. It:
1) Packages two python files into an isolate.
2) Runs the isolate on swarming machines that satisfy certain dimensions.
This version will remove Xcode9-b4 and replace it with Xcode 9.
Bug:
Change-Id: Ia86f4d963b43af175445da428be8920899e7e05e
Reviewed-on: https://chromium-review.googlesource.com/641379
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502238}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ae7265ca4bbe7bce5d1f13d8856ec06513883813
SSH, virtio, hostfwd, tun/tap and many other options are either flaky,
require sudo, are excruciatingly slow, or some combination of these.
While writing to a disk and extracting the file on the host is a bit
silly, it's also fast and reliable, and doesn't require host
configuration or elevation.
Bug: 763992,761182,764567
Change-Id: Ia66c54ba0879b9edb9725b074d489b58d7415948
Reviewed-on: https://chromium-review.googlesource.com/667867
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502100}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b80bdac0e830ce759d9a04d816b75a40ea85853e
Measured runtime of chrome_public_test_apk with -f "*TabModel*" with and
without deobfuscation enabled and found no difference in runtime (3
attached devices took 1:12 for both runs without and for both runs with)
NOTRY=true # All bots passed except windows.
Bug: 713710
Change-Id: I5847bcdc913bb37cfdf9a37ac6f4bf24d172b4da
Reviewed-on: https://chromium-review.googlesource.com/656003
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#501971}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1e43e5781d5f59ed7b011f3dc46c268b23094908
Adds a script that runs resource_sizes.py on two given APKs, diffing
the results. This is being added with the intention of using it to
measure the size impact of including VR, but should be usable to
measure the impact of any build flags, etc.
Bug: 759087
Change-Id: I1db06594d3c02cc6a0d90c44343e5c25281d6f4e
Reviewed-on: https://chromium-review.googlesource.com/657460
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#501739}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 20e696b8cf4c1e0c941a8bcb113e99109a2f7379
This CL adds support for modifying resources before they are used. This is
done by changing the bytecode of places where regular resources are
used to use custom methods in BuildHooksAndroid. More specifically, we
rewrite all classes that meet the following three conditions:
* Descendant of Context
* Direct subclass of a framework class
* Not a subclass of ContextWrapper
Rewriting existing methods currently isn't supported (we don't have
any places where this is required yet); this CL just adds support for
adding methods.
This CL also introduces a number of helper classes/methods that
provide utilities for verifying the above criteria.
Currently, custom resources aren't enabled so the added methods just
call their respective super methods (i.e. a no-op). This bytecode
transformation is performed for all targets that require android and
have not opted out.
Bug: 762157
Change-Id: I038075681afec1ed2dddbcfe1e981b2bf8a084f3
Reviewed-on: https://chromium-review.googlesource.com/652770
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#501698}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 84c2780fa4fc60ede5895834956413e6fea1d7e9
Applicable only when building release.
Disable via --no-deobfuscate
Bug: 620323, 758670
Change-Id: Ib1289e6eae6bb326a1879c791e673cdeba331eab
Reviewed-on: https://chromium-review.googlesource.com/656720
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#501645}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 52668623db4ab636e6631b7a3598ad48f3bb292a
Also adds a test, and a --logcat flag for better matching of logcat
lines.
Bug: 713710
Change-Id: Ie21030b3c4e68d02cfb2e0d65d2c4c4f00624a80
Reviewed-on: https://chromium-review.googlesource.com/657265
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#501535}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 90ef3855eec0a4ed5252a308b9c08cd3efef1014
Note this keeps xcode_clang builders on beta 6 until GOMA is updated.
This also updates the ability to override the toolchain revision
with [IOS|MAC]_TOOLCHAIN_REVISION instead of simply
MAC_TOOLCHAIN_REVISION.
Bug:
Change-Id: I88ba7b1a8c96cf3399e4397bf05611a57bc15b04
Reviewed-on: https://chromium-review.googlesource.com/663410
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Mike Baxley <baxley@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Reviewed-by: Shenghua Zhang <shenghuazhang@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#501529}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 170c409b7c6029eff4ff5e62387e17565578e058
This reverts commit ab6406625331e73b54e0c6a70b195efb3101cfae.
Reason for revert: ArticleSnippetsTest has failed consistently
on KitKat Tablet Tester since this landed. Specifically the
following tests are failing:
ArticleSnippetsTest#testDownloadSuggestion__ChromeHomeEnabled
ArticleSnippetsTest#testSigninPromo__ChromeHomeEnabled
ArticleSnippetsTest#testSnippetAppearance__ChromeHomeEnabled
Additionally, many other test suites that follow
chrome_public_test_apk started failing when this landed; not
sure if that's related.
Original change's description:
> Render snippets in ArticleSnippetsTest in isolation
>
> Remove the "snippets" render that shows all cards together, because
> multiple, non-article sections are not realistic in the modern design
> anymore.
>
> Rebaseline other renders:
> * Use relative timestamp instead of Jan 17, 1970
> * Use only single-card backgrounds for pre-modern cards
> * Update modern card background color after https://crrev.com/497799
> * Update pre-modern text color after https://crrev.com/500684
>
> Also move card contents in the modern layout except for the rounded
> corners into a RelativeLayout, to avoid a circular dependency between
> the height of the containing layout and the position of the bottom
> corner (see https://developer.android.com/reference/android/widget/RelativeLayout.html).
>
> Bug: 757735
> Change-Id: I81add3d5bdd8ffec61b9e8aa2ff3a9caa44ccf91
> Reviewed-on: https://chromium-review.googlesource.com/628562
> Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
> Reviewed-by: Peter Conn <peconn@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#500975}
TBR=bauerb@chromium.org,skyostil@chromium.org,perezju@chromium.org,peconn@chromium.org
Change-Id: Iedb4e042448a8e4c8090d8af5fbdbb6e2f19a6b7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 757735
Reviewed-on: https://chromium-review.googlesource.com/663382
Reviewed-by: John Mellor <johnme@chromium.org>
Commit-Queue: John Mellor <johnme@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#501269}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fddbc77926f40bd924b00661433b9c82e2c910c9
Else lld gets confused about `/LIBPATH:..../DIA\ SDK/lib` in the rsp
file for dump_syms.exe and fails to link it.
See https://bugs.chromium.org/p/chromium/issues/detail?id=600223#c8
for discussion about the approach taken.
lld-lib doesn't understand --rsp-quoting yet, so only pass this to
link, not to lib. Luckily, we don't have files with spaces in their
path in lib files in the build.
Bug: 761850
Change-Id: I628439fa4103c8150a324ee314c4cfe5b259adb5
Reviewed-on: https://chromium-review.googlesource.com/659162
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#501228}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e7d403ebcfc4038241483370bd3bebb2ee606ee1
Does a grabbag of things to get swarming tests working on trybots:
- Include support .py (runner script, testserver, sdk for bootfs) in
data for runner so they're available on the bot
- Include filter files for now while the test binaries need test filters
- Use netcp to copy json results summary
- Make MB run the right command (i.e. out/Release/bin/run_blah) rather
than trying to run a binary directly on the host
- Now that we can know when the process is done, shutdown of the target
happens without a 3s delay.
This doesn't yet actually flip the bools of
can_use_on_swarming_builders: true for any binaries, as we need the
TUN/TAP device available on swarming bots, so that will happen in
follow ups.
This builds on testing and ssh setup work that jbudorick did in
https://chromium-review.googlesource.com/c/chromium/src/+/581429.
Bug: 761182, 734230,763992
Change-Id: I9d2caf35658b7c8fae8c13e841cd464b225654e8
Reviewed-on: https://chromium-review.googlesource.com/645774
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#501123}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3be4b416ed8a0c6cb5024ac90af8b978f706a018
The sdk version in platforms doesn't always match the api level,
unfortunately.
Bug: 763725
Change-Id: I88b992430f2637f4b568da4943c53afc73589d9c
Reviewed-on: https://chromium-review.googlesource.com/660658
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#501007}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 23a5fd789d27b1c37c33f45705883f2c8d43416a
Remove the "snippets" render that shows all cards together, because
multiple, non-article sections are not realistic in the modern design
anymore.
Rebaseline other renders:
* Use relative timestamp instead of Jan 17, 1970
* Use only single-card backgrounds for pre-modern cards
* Update modern card background color after https://crrev.com/497799
* Update pre-modern text color after https://crrev.com/500684
Also move card contents in the modern layout except for the rounded
corners into a RelativeLayout, to avoid a circular dependency between
the height of the containing layout and the position of the bottom
corner (see https://developer.android.com/reference/android/widget/RelativeLayout.html).
Bug: 757735
Change-Id: I81add3d5bdd8ffec61b9e8aa2ff3a9caa44ccf91
Reviewed-on: https://chromium-review.googlesource.com/628562
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#500975}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ab6406625331e73b54e0c6a70b195efb3101cfae
This way, DISABLE_NACL isn't defined globally, but only where
it's needed (chrome, some extensions, some content/). This also means
toggling nacl on and off doesn't require rebuilding the world (in
particular, blink. On my linux build, toggling the flag now reruns
697 build steps, compared to 56274 before). It also gets rid of a ton
of confusing `if !DISABLED` double negation.
No intended behavior change.
Bug: none
Change-Id: Iaad97b4590524a15f7be8565d5722cb2b1b81845
Reviewed-on: https://chromium-review.googlesource.com/659241
Reviewed-by: Brett Wilson <brettw@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#500971}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: af3b00bd3eb00a9daecd3a1ce6525f6eb72b1668
Now that platform-tools is rolled to version 26, we no longer need to
ignore lint failures due to platform differences. Prevents hard to debug
failures down the line due to API level mismatch.
Added suppressions and filed bugs for errors that crept in during the
time this was disabled. Effort should be put in next upgrade to not
allow this time to elapse.
BUG=739746,762551
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: I28b1fa0e17a361bef8bfb522fb3ed59147b05d32
Reviewed-on: https://chromium-review.googlesource.com/652964
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#500917}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 41228577f586871e139fe554d532e4938cca9d6e
Removing iTunes support from media_gallery API on Windows and Mac, as it is
not maintained and has been broken on Windows since iTunes changed its
configuration file locations more than a year ago.
Bug: 762991,758355
Tbr: tsepez, bbudge
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_dbg_ng
Change-Id: I258659e5241f27f5ad2b0cc86ba8f902f77a32e7
Reviewed-on: https://chromium-review.googlesource.com/646801
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Michael Nordman <michaeln@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#500748}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: cf99550c9df48abf9c6b32a062320a26bf1624cd
1. Added ws server type in test server spawner.
2. Fixed a bug in testserver.py which prevented it from loading certs
with relative paths (because it has to chdir to the working dir)
3. Enabled some tests on Android and Fuchsia. The two tests that are
still disabled depend on basic-auth-proxy mode in testserver, which
doesn't work with RemoteTestServer.
Bug: 441711, 731302
Change-Id: Id8346111f260ead648a98b0854669d1211fe3393
Reviewed-on: https://chromium-review.googlesource.com/656758
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#500722}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4c786d33ad7886c8d656ded42b68b4d0746b6881
Now that WebView stores compressed locale paks in a different directory
(assets/stored-locales), we can compute the number of relevant
translations for resources.arsc normalization.
Bug: 691850
Change-Id: I13a0810ab5a1bb4a96dd3bcba20caac07e05b049
Reviewed-on: https://chromium-review.googlesource.com/658101
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#500667}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 62bfb2cb402c599f9942344fa9c31b8955e13930
Not sure about this choice of home for this method.
This CL also deletes CSSPropertyMetadata class.
Bug: 751373
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_dbg_ng
Change-Id: I812df195574ee38f2e798dd7fdb7986b15efad22
Reviewed-on: https://chromium-review.googlesource.com/652207
Commit-Queue: Renée Wright <rjwright@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#500540}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6d76d1aeb62ce848e5d74fc6a21011e4a04d304a
Was causing infinite output in one case, and crash in another.
Bug: 762912
Change-Id: I8a8eb306d274f34684b06ca3df722800413fb776
Reviewed-on: https://chromium-review.googlesource.com/655121
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#500480}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 33f43bb9c944ad7549cdf8d77f0f38f45ae39f9a
Removing Picasa support from the MediaGalleries API and removing any
Picasa related file.
Bug: 762985, 758355, 567212
Tbr: sky, bbudge
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_dbg_ng
Change-Id: I9612d2ad2407d167ac8462b51d1eddee5d70cf9e
Reviewed-on: https://chromium-review.googlesource.com/650948
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Michael Nordman <michaeln@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#500420}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 67522843fc18901d1c95fc35671b085677680f68
We saw a steep increase of runtime of gtests after we started
symbolizing stdout of gtests.
This is a trivial change that removes about 75% of the unnecessary regex
match that checks whether the line is a line in stack or not.
Bug:
Change-Id: I232d6815d7cae9cad05b85f5dc736784b2294fb8
Reviewed-on: https://chromium-review.googlesource.com/651355
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Zhiling Huang <hzl@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#500103}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b73321e501bdaafc4660612dc87dd3df9fe2d301
Scott Graham
Hans Wennborg
Eric Stevenson
Sylvain Defresne
Boris Sazonov
Bruce Dawson
Xiaoqian Dai
Andrew Grieve
Brett Wilson
John Budorick
Peter Collingbourne
Mina Almasry
Justin Cohen
inglorion
Ivica Bogosavljevic
bsheedy
John Mellor
Nico Weber
Bernhard Bauer
Peter Wen
Jay Civelli
Sergey Ulanov
Renee Wright
Matt Mueller
Jean-François Geyelin
Zhiling Huang