Previously //build/config/sanitizer:deps unconditionally depended on
//third_party/instrumented_libraries:deps. This dependency is only necessary
//when compiling with a sanitizer, and in standalone other projects like nacl,
//instrumented_libraries doesn't exist.
This patch makes all contents of sanitizer:deps conditional on using a
sanitizer, which matches what the documentation explicitly says.
BUG=
Review URL: https://codereview.chromium.org/1341043005
Cr-Original-Commit-Position: refs/heads/master@{#348719}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: bc6f9a5b1858c70d852029f77020cabd3db879f6
An "adb install" always terminates the app, so when skipping the step,
we should terminate the app to have consistent behaviour.
BUG=
Review URL: https://codereview.chromium.org/1334303003
Cr-Original-Commit-Position: refs/heads/master@{#348712}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a87495be3a6a5be1ac0d1175898efa54689a99ff
This also moves the config out of the template. Otherwise this will generate an
error if there is more than one MIDL target in the same directory.
Use forward_variables_from in the MIDL template.
TBR=dpranke@chromium.org
Review URL: https://codereview.chromium.org/1335283002
Cr-Original-Commit-Position: refs/heads/master@{#348664}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7c0c67ed3859656cb869fb517527938f70ed0cc6
Uses forward_variables_from for the gcc_toolchain and nacl_toolchain templates
when applicable.
Add the ability to clear the sanitizer flags and use this for nacl.
Review URL: https://codereview.chromium.org/1338803004
Cr-Original-Commit-Position: refs/heads/master@{#348522}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f5d97233985fac498ada3def2c2b3f4e8bbaafd9
Motivated by Install() getting a new permissions attribute without
InstallSplitApk() being updated (http://crrev.com/de468d72d9e)
There is also a sematic change:
- When a previous install is present and reinstall=False, we used to
check if the install on-device was identical and no-op in this case.
Now, we do an uninstall + install regardless of whether the on-device
version is identical. This new behaviour is more correct since it
guarantees that no stale data will be present when reinstall=False.
BUG=
Review URL: https://codereview.chromium.org/1337073002
Cr-Original-Commit-Position: refs/heads/master@{#348419}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 307cf30fea5e791de2ebac395b1d9a154afc637b
//build/config/compiler/BUILD.gn has the following lines which make the declarations in the toolchains superfluous:
# Pass the same C/C++ flags to the objective C/C++ compiler.
cflags_objc += cflags_c
cflags_objcc += cflags_cc
R=brettw@chromium.org
BUG=none
Review URL: https://codereview.chromium.org/1335503006
Cr-Original-Commit-Position: refs/heads/master@{#348197}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: bd1aafe5d735405a27266a38a0af38be2d17d0bd
Also doing a fork() changes thread id (syscall gettid), which breaks the
assumptions in cygprofile.cc, disabled a fork in library_prefetcher.
Verified: with these changes the instrumented build is able to display the
contents of 'https://google.com'. It does not finish loading though, which is
probably due to some other timeouts.
BUG=503613
Review URL: https://codereview.chromium.org/1325053009
Cr-Original-Commit-Position: refs/heads/master@{#347918}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e3a753f17bac62738b0dbf0b36510f767b081e4b
Reason for revert:
Caused check_licenses to fail:
https://build.chromium.org/p/chromium/builders/Linux/builds/66701
Original issue's description:
> Fix typo in install-sysroot.py
>
> install-sysroot.py was intended to default to installing
> the sysroot ia32, but within this script 'i386' is used to
> refer to this architecture.
>
> This most likely went unnoticed since the ia32 builder
> either use branding=Official, or explicitly set
> use_sysroot=1, or have a complete set of packages for
> cross building on the host system.
>
> BUG=504446
>
> Committed: https://crrev.com/1d62049b4c176fbd43bed90fc9a76273b11ad406
> Cr-Commit-Position: refs/heads/master@{#347821}
TBR=dpranke@chromium.org,sbc@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=504446
Review URL: https://codereview.chromium.org/1315773003
Cr-Original-Commit-Position: refs/heads/master@{#347839}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3b27a2de111759359162bcad49753e17ee1cf002
install-sysroot.py was intended to default to installing
the sysroot ia32, but within this script 'i386' is used to
refer to this architecture.
This most likely went unnoticed since the ia32 builder
either use branding=Official, or explicitly set
use_sysroot=1, or have a complete set of packages for
cross building on the host system.
BUG=504446
Review URL: https://codereview.chromium.org/1317973005
Cr-Original-Commit-Position: refs/heads/master@{#347821}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1d62049b4c176fbd43bed90fc9a76273b11ad406
Currently, it will double report test failures, and
will improperly report crashes without a long message.
BUG=512305
Review URL: https://codereview.chromium.org/1311783005
Cr-Original-Commit-Position: refs/heads/master@{#347785}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2347b0e01194f15e2c4fecaaea4b2e84a0ba058a
The default depot_tools pylintrc disables some checks that we can
reasonably enable in build/android/. This CL does so.
BUG=
Review URL: https://codereview.chromium.org/1315743004
Cr-Original-Commit-Position: refs/heads/master@{#347720}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 58b4d3677418a2360c23e118199f5cf8992d4178
If use_concatenated_impulse_responses is set (in config.gni), then
grit needs to have it defined as well. This is needed to reference
the appropriate response files for the HRTF panner in WebAudio.
BUG=528424
TEST=webaudio panner tests pass
Review URL: https://codereview.chromium.org/1311013010
Cr-Original-Commit-Position: refs/heads/master@{#347534}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4c50633b258d948b7d28f4bb7af3a787ac8b7079
libevdev-cros is not needed for the host tooling, and is not availale for
the host in a chroot chromeos building environment.
BUG=527996
Review URL: https://codereview.chromium.org/1322343002
Cr-Original-Commit-Position: refs/heads/master@{#347531}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 97739b5fcf32a746c38d8142bff56d0072953dbf
This CL adds support for overriding android_keystore_path,
android_keystore_name, android_keystore_password from other config
files.
It also adds documentation to these arguments and removes 'default'
from their name.
The chromium debug key is still used by default for all builds.
BUG=479253
Review URL: https://codereview.chromium.org/1311043014
Cr-Original-Commit-Position: refs/heads/master@{#347521}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fbc342116e60698aae09bf4175a30bf8ccc14704
- Defers running of a few adb commands so that they happen while the host zip is being constructed.
- Combines unzip & chmod into a single command
Reduces time to re-push all .so files from 23s->21s
BUG=520082
Review URL: https://codereview.chromium.org/1325893002
Cr-Original-Commit-Position: refs/heads/master@{#347478}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ff506f629332dbeb3efb3df73cf8ff5b168312e8
This deletes the no-longer-used ChromeShell. Its raison d'être has been
supplanted by ChromePublic (the chrome_public_apk build target).
Goodbye, ChromeShell!
BUG=510220
Review URL: https://codereview.chromium.org/1314413004
Cr-Original-Commit-Position: refs/heads/master@{#347454}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 44ce026f8450c71f6592beb02c7db825c1c4e82c
I went through and did some flag auditing to try to get GN's official build mini_installer target as small as GYP's. It's still 512 bytes too large.
Adds the custom mini_installer flags to the "lib" target as well as the main mini_installer target. This removes some imports around exception handling.
Sync some official build flags: LTCG should go on all optimized targets in official builds, not just "optimize max" ones. Doing this on optimize max has no effect because we only set optimize_max on individual libraries that need to be fast, rather than anything that gets linked.
Convert /OPT:REF to /OPT:ICF. GYP specifies both, but ICF seems to imply REF according to MSDN.
Added some missing release mode flags "/d2Zi+", "/Zc:inline", and "/cgthreads:8", which I found missing from GN.
Removed a dependency on "setup" from mini installer, this is captured by the dependency on ":archive" (which already includes the setup dependency).
Review URL: https://codereview.chromium.org/1329833002
Cr-Original-Commit-Position: refs/heads/master@{#347447}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7cb45ce734f09f358e62fd982c8fa288673b2ab5
Android is the last remaining platform that has not yet converted to CLDv2.
Sheriffs: expect to see APK size changes in the range of [-122K, +98K] bytes.
See the bug for more information.
As on iOS, use the smallest data tables to minimize the binary size impact.
This brings language detection on Android into parity with iOS (which also uses
the smallest data tables).
BUG=528257
Review URL: https://codereview.chromium.org/1327543003
Cr-Original-Commit-Position: refs/heads/master@{#347418}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9a70dc32d62dc1a0e9a8885f2258fe612aeb1f06
brettw
jbudorick
agrieve
dpranke
stip
yfriedman
thakis
pcc
rnephew
andybons
pasko
akuegel
chrishtr
sbc
megjablon
andrewhayden
rtoy
petermayo
nparker
nyquist
robertocn
newt