Reason for revert:
Failed due to mysterious failures on the Google Chrome Linux bot.
Example:
FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash ../out/Release/installer/debian/build.sh -o../out/Release -b ../out/Release -a ia32 -c stable
Staging common install files in '/tmp/deb.build.AEvway'...
eu-strip: while computing checksum for debug information: Invalid argument
Cleaning...
BUG=335451
Original issue's description:
> Reenable linux_aura on the main builders.
>
> We fixed the browser test slowdown that lead to linux_aura being
> disabled in r235280. (Different test suites are faster or slower, but
> overall, tests run faster.)
>
> We are turning this on primarily to get perf data; if things look
> acceptable, we hope to cut a dev channel this week.
>
> BUG=319075,125106,303342,318961
> NOTRY=True
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245415
TBR=
NOTREECHECKS=true
NOTRY=true
BUG=319075,125106,303342,318961
Review URL: https://codereview.chromium.org/140823008
git-svn-id: http://src.chromium.org/svn/trunk/src/build@245429 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Reason for revert:
Didn't actually help with the build failures on Google Chrome Linux.
Original issue's description:
> linux_aura: Attempt to green the official builder by reverting unwind support.
>
> This effectively reverts in r243919 and r244331 in a desperate attempt
> to fix the tree.
>
> Build fail output:
>
> FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash ../out/Release/installer/rpm/build.sh -o../out/Release -b ../out/Release -a ia32 -c beta
> Staging common install files in '/tmp/rpm.build.XtJRbJ'...
> eu-strip: while computing checksum for debug information: Invalid argument
> FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash ../out/Release/installer/rpm/build.sh -o../out/Release -b ../out/Release -a ia32 -c unstable
> Staging common install files in '/tmp/rpm.build.t4jNp4'...
> eu-strip: while computing checksum for debug information: Invalid argument
> FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash ../out/Release/installer/debian/build.sh -o../out/Release -b ../out/Release -a ia32 -c unstable
> Staging common install files in '/tmp/deb.build.CxnH9l'...
> eu-strip: while computing checksum for debug information: Invalid argument
> Cleaning...
> FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash ../out/Release/installer/debian/build.sh -o../out/Release -b ../out/Release -a ia32 -c stable
> Staging common install files in '/tmp/deb.build.9Zyie1'...
> eu-strip: while computing checksum for debug information: Invalid argument
> Cleaning...
> FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash ../out/Release/installer/debian/build.sh -o../out/Release -b ../out/Release -a ia32 -c beta
> Staging common install files in '/tmp/deb.build.xUB39X'...
> eu-strip: while computing checksum for debug information: Invalid argument
> Cleaning...
> FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash ../out/Release/installer/rpm/build.sh -o../out/Release -b ../out/Release -a ia32 -c stable
> Staging common install files in '/tmp/rpm.build.aN0PGV'...
> eu-strip: while computing checksum for debug information: Invalid argument
> ../out/Release/chrome, section '.eh_frame': the call frame entry at offset 0x18 uses a DWARF expression to describe how to recover register '.cfa', but this translator cannot yet translate DWARF expressions to Breakpad postfix expressions
> ninja: build stopped: subcommand failed.
>
> BUG=180975
> TBR=spang@chromium.org, stip@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245421TBR=spang@chromium.org,stip@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=180975
Review URL: https://codereview.chromium.org/141273005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@245428 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This effectively reverts in r243919 and r244331 in a desperate attempt
to fix the tree.
Build fail output:
FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash ../out/Release/installer/rpm/build.sh -o../out/Release -b ../out/Release -a ia32 -c beta
Staging common install files in '/tmp/rpm.build.XtJRbJ'...
eu-strip: while computing checksum for debug information: Invalid argument
FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash ../out/Release/installer/rpm/build.sh -o../out/Release -b ../out/Release -a ia32 -c unstable
Staging common install files in '/tmp/rpm.build.t4jNp4'...
eu-strip: while computing checksum for debug information: Invalid argument
FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash ../out/Release/installer/debian/build.sh -o../out/Release -b ../out/Release -a ia32 -c unstable
Staging common install files in '/tmp/deb.build.CxnH9l'...
eu-strip: while computing checksum for debug information: Invalid argument
Cleaning...
FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash ../out/Release/installer/debian/build.sh -o../out/Release -b ../out/Release -a ia32 -c stable
Staging common install files in '/tmp/deb.build.9Zyie1'...
eu-strip: while computing checksum for debug information: Invalid argument
Cleaning...
FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash ../out/Release/installer/debian/build.sh -o../out/Release -b ../out/Release -a ia32 -c beta
Staging common install files in '/tmp/deb.build.xUB39X'...
eu-strip: while computing checksum for debug information: Invalid argument
Cleaning...
FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash ../out/Release/installer/rpm/build.sh -o../out/Release -b ../out/Release -a ia32 -c stable
Staging common install files in '/tmp/rpm.build.aN0PGV'...
eu-strip: while computing checksum for debug information: Invalid argument
../out/Release/chrome, section '.eh_frame': the call frame entry at offset 0x18 uses a DWARF expression to describe how to recover register '.cfa', but this translator cannot yet translate DWARF expressions to Breakpad postfix expressions
ninja: build stopped: subcommand failed.
BUG=180975
TBR=spang@chromium.org, stip@chromium.org
Review URL: https://codereview.chromium.org/141013009
git-svn-id: http://src.chromium.org/svn/trunk/src/build@245421 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
We fixed the browser test slowdown that lead to linux_aura being
disabled in r235280. (Different test suites are faster or slower, but
overall, tests run faster.)
We are turning this on primarily to get perf data; if things look
acceptable, we hope to cut a dev channel this week.
BUG=319075,125106,303342,318961
NOTRY=True
Review URL: https://codereview.chromium.org/136813004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@245415 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The toolchain directory inside depot_tools will only exist if
"set DEPOT_TOOLS_WIN_TOOLCHAIN=1" so this is currently a no-op.
It will break the "dogfood" of 'GYP_MSVS_USE_SYSTEM_TOOLCHAIN'
now renamed per above, but I think only a few people tested
that (cc'd here).
R=dpranke@chromium.org
BUG=323300, 326357
Review URL: https://codereview.chromium.org/137573002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@245412 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This CL removes a number of functions from the sync debugging framework
in order to prepare for some upcoming changes to sync debugging (due to
328606).
This CL removes the following functions:
- GetRootNodeDetails
- GetNodeSummaries
- GetNodeDetails
- GetChildNodeIds
It also adds the function 'getListOfKnownTypes' to help replace some old
functionality required by the 'data' tab and to fix issue 329013.
Rather than having that tab fetch a list of children of the root node,
it now asks for a list of all known data types. This is a better
solution, since it does not require sync to be fully initialized in
order to properly populate the set of checkboxes.
The most significant user of the removed functionality is the node
browser. Its javascript code has been modified in order to transition
it to relying on the getAllNodes function. Rather than fetching node
data on demand by a series of asynchronous callbacks, the tab now
fetches a list of all known sync nodes at once. This has the advantage
of providing a more consistent (though more stale) snapshot. This CL
adds a refresh button to the node browser tab in order to give users
some control over its staleness.
This change had some minor side-effects. The node browser now relies on
items' string-based IDs rather than their metahandles when determining
the nodes' hierarchy. We've also had to add a 'positionIndex' field to
the output of getAllNodes to make it easier for the node browser to sort
its entries. In part to make it easier to fetch this field, most of the
code associated with getAllNodes has been moved into the
syncable::Directory.
In addition to all these changes, this CL adds some webui tests to help
prevent regressions in about:sync functionality. For now, they only
cover the node browser. More tests will be added in future CLs.
BUG=110517,329013,328606
Review URL: https://codereview.chromium.org/134443004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@245313 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Adding the content_gl_tests unit tests to the
gtest suite list supported by test_runner.py for Android platform.
BUG=none
R=bulach
TEST= Command to execute the content_gl_tests on Android:
path/to/build/android/test_runner.py gtest -s content_gl_tests <--gtest_filter=[TestFilter]>
Review URL: https://codereview.chromium.org/140623002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@245299 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
1) To match the gyp dependencies, move clearkeycdmadapter binaries, plugins/,
lib32/ and lib64/ from chrome.isolate to browser_tests.isolate.
2) On Windows, include <(version_full).manifest in chrome.isolate to be able
to execute chrome.exe. Add needed chrome_child.dll and chrome_elf.dll.
3) Add libEGL.dll and libGLESv2.dll dependencies to gpu.gyp:gl_tests and a
new angle.isolate; refer to it from gl_tests.isolate and
gles2_conform_test.isolate.
4) Copy run_gpu_test to run_gpu_test.py, and invoke that instead in
telemetry_gpu_test.isolate, to make this isolate work on Windows.
BUG=321878,334539
Review URL: https://codereview.chromium.org/140263002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@245283 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This reverts commit 17dad9d57df1acd108e32169ffc9584988c9d9d6.
Although simple in principle, the Python C extension approach does not fit the
diversity of our infrastructure.
We will need a better method to address the speed requirements for
ColorHistogram.
BUG=333606,323813,334097,333361,334523
TBR=tonyg,maruel
Review URL: https://codereview.chromium.org/138143010
git-svn-id: http://src.chromium.org/svn/trunk/src/build@245145 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This emulates optimize=max from GYP. One difference is that this applies for all build types. The GYP one only applied optimize=max for the Official build. I can't think of why this should be the case, and it seems confusing to have such arbitrary official build differences.
R=bbudge@chromium.org
Review URL: https://codereview.chromium.org/138903002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@244839 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The `file` program follows POSIX as outlined here:
http://pubs.opengroup.org/onlinepubs/9699919799/utilities/file.html
Specifically, this part causes troubles:
If the file named by the file operand does not exist, cannot be read, or
the type of the file named by the file operand cannot be determined, this
shall not be considered an error that affects the exit status.
With older versions of `file` (that does not conform to POSIX), this
script will exit 0 with "unknown" as its output when "$1" does not exist.
But with recent releases (that conform to POSIX), this script will exit 1
and can break the build.
Have the script explicitly check for the existence of $1 and if it does
not exist, then runt he unknown logic like normal.
BUG=chromium:332547
TEST=ran python_arch.sh on bogus files with new & old `file` programs
Review URL: https://codereview.chromium.org/137433002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@244778 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The emulator sdk root is now downloaded into the source tree (and .gitingore'd).
That means that doing a clobber on the src directory will delete the emulator
SDK downloaded by build/android/install_emulator_deps.py.
This change allows developers to have an emulator SDK located somewhere else
that they can point the avd.py script to. Also, some bots will remove the src
directory between builds. Rather than make the bots re-download the emulator sdk
everytime, this allows them to have an emulator SDK installed somewhere else and
point to it.
BUG=304129
TBR=craigdh@chromium.org
Review URL: https://codereview.chromium.org/132793003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@244637 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
caitkp@chromium.org
ycheo@chromium.org
erg@chromium.org
scottmg@chromium.org
andrewhayden@chromium.org
brettw@chromium.org
tedchoc@chromium.org
phajdan.jr@chromium.org
mcgrathr@chromium.org
rlarocque@chromium.org
thakis@chromium.org
r.kasibhatla@samsung.com
aurimas@chromium.org
kbr@chromium.org
ager@chromium.org
frankf@chromium.org
petarj@mips.com
thestig@chromium.org
szym@chromium.org
jshin@chromium.org
earthdok@chromium.org
bbudge@chromium.org
dstockwell@chromium.org
raymes@google.com
vapier@chromium.org
bolian@chromium.org
navabi@google.com
jam@chromium.org
spang@chromium.org