> PPAPI: Remove threading options; it's always on
>
> This also re-enables thread checking for the host side resource and var trackers. Before, checking was disabled everywhere.
>
> BUG=159240,92909
>
>
> Committed: r186925
> Reverted: r186939 due to build errors
>
> Committed: r187340
>
> Committed: r187427
> Reverted: r187668 due to a failing check in Canary, which was fixed here: r187681
>
> Committed: r189518
> Reverted: r189682, due to regression in Kraken (see crbug.com/222741)
>
> Review URL: https://chromiumcodereview.appspot.com/12378050TBR=dmichael@chromium.org
Review URL: https://codereview.chromium.org/13328006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@191441 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This also re-enables thread checking for the host side resource and var trackers. Before, checking was disabled everywhere.
BUG=159240,92909
Committed: r186925
Reverted: r186939 due to build errors
Committed: r187340
Committed: r187427
Reverted: r187668 due to a failing check in Canary, which was fixed here: r187681
Committed: r189518
Reverted: r189682, due to regression in Kraken (see crbug.com/222741)
Review URL: https://chromiumcodereview.appspot.com/12378050
git-svn-id: http://src.chromium.org/svn/trunk/src/build@191420 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The python build scripts use subprocess.check_call() for external
commands (aapt, javac, etc). On a failure, it prints the python
stacktrace, followed by the command being run (in a form that can be
copy-pasted and actually work), followed by the output from the command.
Previously, it was printing command output, then command, then
stacktrace which is much less useful.
Review URL: https://chromiumcodereview.appspot.com/12913028
git-svn-id: http://src.chromium.org/svn/trunk/src/build@191300 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
A frame with a timestamp of INT64_MAX actually means that the fence
object associated with the frame is still pending or that the frame has
not yet been displayed. Update the comment in SurfaceStatsCollector to
make this more obvious.
No functional changes.
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/13188002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@191158 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Libraries could previously access dependencies' resources in Java code
but not in XML layout files. This enables accessing these resources in
layout files as well, with the compromise that resources can now be
accessed using the wrong package name in Java code. Since resource
names are global anyway (an APK can't contain two resources with the
same name), this is deemed OK.
BUG=176069
Review URL: https://chromiumcodereview.appspot.com/13107002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@190896 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Proguard should only be run in Release mode (in gyp, proguard_enabled is
not set based on the configuration). This is the way that we had
been determining whether or not to run proguard before recent Ant
refactoring.
Also, proguard needs the path to the android.jar
BUG=224079
Review URL: https://chromiumcodereview.appspot.com/12922004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@190876 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The close button in download pane should be the tab close button asset : tab_close_*.png (this was originally reported as part of BUG=173251).
By the same logic the same smaller bitmap with red hover background should be used for all infobars
such as translate bar, save password bar, etc. It should also be used for find-in-page bar on all
platforms (Mac was missed with the previous implementation).
The close button in the chrome UI and Web UI bubbles was left the same as before (this needs to be regression-tested).
Code was rearranged to make explicit the disrepancy between the IDR_CLOSE_BAR and IDR_CLOSE_BUBBLE.
IDR_TAB_CLOSE was renamed IDR_CLOSE_1.
IDR_CLOSE_BAR was renamed IDR_CLOSE_2.
png files were also renamed (this is handled by two separate committs to work around restriction on binary committs by newbies).
See https://codereview.chromium.org/12703022/ for added resources.
BUG=217094
TEST=Open any page that downloads an attachment such as gmail email with an attachment or a page with images. Download an image or an attachment. Verify that the close button in download bar at the bottom of the screen has a red circular background when mouse hovers over it - same as the close tab button.
TEST=Open find-in-page (Ctrl+F) box on Mac, Linux and Windows and check that the close button is same as tab close (has a red circular background when mouse hovers over it).
TEST=Open any infobar (translate / save password) on both ChromeOS and linux and check that the close button is same as tab close (has a red circular background when mouse hovers over it). Opening a non-English news page is usually the easiest way.
TEST=Trigger chrome to show a toolbar bubble such as extension installed bubble that shows when an extension is installed from chrome web store (see bitmaps in comments attached to BUG=217094). Confirm that the close buttons in those bubbles are NOT changed from before the change (they should NOT have the red circular background when mouse hovers over).
Review URL: https://chromiumcodereview.appspot.com/12703039
git-svn-id: http://src.chromium.org/svn/trunk/src/build@190844 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
In preparation for rewriting these actions in python, split apk-build.xml into smaller ant scripts. This should not change the functionality and mostly is just splitting the file and identifying the properties and defines required for each of the new files.
Some of the configuration is moved out of ant and into gyp (i.e. the android_manifest_path is now gyp-configurable).
Also, the ant scripts now use the correct basedir! That is, these ant scripts actually understand relative paths. To go along with this, resource_dir is the relative path to the resource directory (rather than a path relative to java_in_dir).
BUG=158821
TBR=torne@chromium.org, brettw@chromium.org
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/12963009
git-svn-id: http://src.chromium.org/svn/trunk/src/build@190712 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This enables Android layouts and Java code to use strings from
generated_resources.grd directly. Strings tagged with
formatter_data="android_java" in generated_resources.grd are used to produce an
Android strings xml file.
BUG=176069
Review URL: https://chromiumcodereview.appspot.com/12529025
git-svn-id: http://src.chromium.org/svn/trunk/src/build@190573 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> Inconsistent use of [x] close panel icon
> The close button in download pane should be the tab close button asset : tab_close_*.png
> (this was originally reported as part of BUG=173251).
>
> By the same logic the same smaller bitmap with red hover background should be used for all infobars
> such as translate bar, save password bar, etc. It should also be used for find-in-page bar on all
> platforms (Mac was missed with the previous implementation).
>
> The close button in the chrome UI and Web UI bubbles was left the same as before (this needs to be regression-tested).
>
> Code was rearranged to make explicit the disrepancy between the IDR_CLOSE_BAR and IDR_CLOSE_BUBBLE.
> IDR_TAB_CLOSE was renamed IDR_CLOSE_1.
> IDR_CLOSE_BAR was renamed IDR_CLOSE_2.
> png files were also renamed.
>
> BUG=217094
> TEST=Open any page that downloads an attachment such as gmail email with an attachment or a page with images. Download an image or an attachment. Verify that the close button in download bar at the bottom of the screen has a red circular background when mouse hovers over it - same as the close tab button.
>
> TEST=Open find-in-page (Ctrl+F) box on Mac, Linux and Windows and check that the close button is same as tab close (has a red circular background when mouse hovers over it).
>
> TEST=Open any infobar (translate / save password) on both ChromeOS and linux and check that the close button is same as tab close (has a red circular background when mouse hovers over it). Opening a non-English news page is usually the easiest way.
>
> TEST=Trigger chrome to show a toolbar bubble such as extension installed bubble that shows when an extension is installed from chrome web store (see bitmaps in comments attached to BUG=217094). Confirm that the close buttons in those bubbles are NOT changed from before the change (they should NOT have the red circular background when mouse hovers over).
>
> Review URL: https://codereview.chromium.org/12634025TBR=flackr@chromium.org
git-svn-id: http://src.chromium.org/svn/trunk/src/build@190432 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The close button in download pane should be the tab close button asset : tab_close_*.png
(this was originally reported as part of BUG=173251).
By the same logic the same smaller bitmap with red hover background should be used for all infobars
such as translate bar, save password bar, etc. It should also be used for find-in-page bar on all
platforms (Mac was missed with the previous implementation).
The close button in the chrome UI and Web UI bubbles was left the same as before (this needs to be regression-tested).
Code was rearranged to make explicit the disrepancy between the IDR_CLOSE_BAR and IDR_CLOSE_BUBBLE.
IDR_TAB_CLOSE was renamed IDR_CLOSE_1.
IDR_CLOSE_BAR was renamed IDR_CLOSE_2.
png files were also renamed.
BUG=217094
TEST=Open any page that downloads an attachment such as gmail email with an attachment or a page with images. Download an image or an attachment. Verify that the close button in download bar at the bottom of the screen has a red circular background when mouse hovers over it - same as the close tab button.
TEST=Open find-in-page (Ctrl+F) box on Mac, Linux and Windows and check that the close button is same as tab close (has a red circular background when mouse hovers over it).
TEST=Open any infobar (translate / save password) on both ChromeOS and linux and check that the close button is same as tab close (has a red circular background when mouse hovers over it). Opening a non-English news page is usually the easiest way.
TEST=Trigger chrome to show a toolbar bubble such as extension installed bubble that shows when an extension is installed from chrome web store (see bitmaps in comments attached to BUG=217094). Confirm that the close buttons in those bubbles are NOT changed from before the change (they should NOT have the red circular background when mouse hovers over).
Review URL: https://codereview.chromium.org/12634025
git-svn-id: http://src.chromium.org/svn/trunk/src/build@190431 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This change is to fix resource-related issues with the current approach.
We can't include resources in the test_java target to share them between
the shell and test apks, so we need one apk to contain the shell and run
tests against.
To achieve this we apply the same trick as testshell does and build the
test code against the .jar created as a side-effect of building the shell
apk target.
This change completely removes the test_apk target.
BUG=None
TEST=AndroidWebViewTests
TBR=bulach@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12609013
git-svn-id: http://src.chromium.org/svn/trunk/src/build@190404 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Output a warning instead of a failure when the layout test command
fails. We'll revert this when we've got a stable base, and it will
be easier for others to track webkit_unit_tests and TestWebKitAPI
failurse until that happens.
BUG=218257
Review URL: https://chromiumcodereview.appspot.com/12709003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@190135 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
old design was causing many spurious messages to be sent to the UI thread.
- CleanupReference now triggers when GC sees the object has become weakly rather than
phantom reachable, as this can occur earlier but if sufficient for knowing we must
perform native cleanup.
- added some basic GC cleanup tests in CleanupReferenceTest.
Review URL: https://chromiumcodereview.appspot.com/12658010
git-svn-id: http://src.chromium.org/svn/trunk/src/build@190110 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
rlarocque@chromium.org
dmichael@chromium.org
siggi@chromium.org
jayjang@chromium.org
boliu@chromium.org
ilevy@chromium.org
shouqun.liu@intel.com
sivachandra@chromium.org
cjhopman@chromium.org
nyquist@chromium.org
skyostil@chromium.org
tfarina@chromium.org
navabi@google.com
frankf@chromium.org
mkosiba@chromium.org
newt@chromium.org
nileshagrawal@chromium.org
varkha@chromium.org
jln@chromium.org
bulach@chromium.org
thakis@chromium.org
dhollowa@chromium.org
ygorshenin@chromium.org
thestig@chromium.org
ycheo@chromium.org
flackr@chromium.org
peter@chromium.org
joth@chromium.org
rtoy@google.com