Some checkouts have the build directory mounted, which causes the script
to throw an exception when it attempts to remove the directory itself.
Review URL: https://codereview.chromium.org/532323002
Cr-Original-Commit-Position: refs/heads/master@{#293199}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: bb04e1054366543cb554531c728b33525a5dae8c
The iOS6-style APIs have been deprecated, but the replacements are
more verbose and brittle so this category wraps the replacements in
methods similar to the iOS6-style APIs.
This category lives in a new target and directory: src/ui/ios, so
this CL sets up all the gyp/DEPS stuff and only adds a single
method. There will be more methods added in subsequent CLs.
BUG=364419
Review URL: https://codereview.chromium.org/497503004
Cr-Original-Commit-Position: refs/heads/master@{#293193}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c018ddc14ace7181edda4d4be225cf6e88e44d2c
Original description from commit 63e36e6bdaa65d1152dd62f9831128c752bc0408:
ui: Move ui_unittests.gyp into ui/base.
ui_unittests.gyp -> ui_base_tests.gyp (follow gfx_tests.gyp pattern).
ui_unittests_bundle.gypi -> ui/base/ui_base_tests_bundle.gypi
ui_unittests.isolate -> ui_base_tests.isolate
Add a TODO assigned to me to rename ui_unittests target to
ui_base_unittests when buildbot is updated.
It was reverted in commit 6297a2f1e441c46d6f8ca37a3798fe6fbdd6cc4c,
because a test from ui_unittests in ios_dbg_simulator started to
failing.
BUG=331829,373148,299841,103304
TEST=ui_unittests
R=sky@chromium.org,rohitrao@chromium.org
Review URL: https://codereview.chromium.org/518423002
Cr-Original-Commit-Position: refs/heads/master@{#293134}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2148b92f9cc676bf2b64dc7e47ef65daac393031
To support unbundled updates we need to stop depending on system
libraries. Disable using the system version of libexpat and instead link
Chromium's copy, and stop removing the expat sources from the checkout.
This increases binary size by ~64KB.
Also remove an obsolete comment about using the system version of
sqlite; this was never implemented and now will not be.
BUG=409851
Review URL: https://codereview.chromium.org/534603002
Cr-Original-Commit-Position: refs/heads/master@{#293115}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: eac62b75ce57c1689a48fadd4229c1346509a170
Reason for revert:
Breaks some workflows and also should get new quota.
Original issue's description:
> Add support for Java nano protocol buffers for Android.
>
> This CL adds a new dependency on the protocol buffer compiler
> from the android source tree, since this compiler supports
> generating Java files using the nano runtime.
>
> The initial version of this dependency is 2.2.0a, but checked
> out as what the Android 4.4.4 Release 2.0.1 tag points to.
>
> This CL adds a new protoc binary (for compiling protos) that supports
> this, and also adds a Java library with the runtime.
>
> To simplify use of this, it also updates build/protoc_java.gypi to
> support generating nano protos by specifying an optional
> proto_runtime argument. The argument defaults to 'lite' which does
> the same thing as before this change, and setting it to 'nano'
> generates the new style Java files.
>
> The plan is to quickly deprecate the 'lite' runtime for Java, since
> it is too big and uses too many methods.
>
> BUG=377891
>
> Committed: d8ae0a7983TBR=cjhopman@chromium.org,darin@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=377891
Review URL: https://codereview.chromium.org/534703004
Cr-Original-Commit-Position: refs/heads/master@{#293028}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e3f2241bc1235a54254f165db374f6013e037233
There are more work needs to be finished, but this should at least allow us to implement login UI
* Added chrome version of ExtensionsDelegate and AppActivity
* introduce use_athena gyp flag
* disabled features/code path that does not work yet on athena. Filed bugs to keep track of them.
BUG=397167
R=mukai@chromium.org, yoz@chromium.org
Review URL: https://codereview.chromium.org/514293003
Cr-Original-Commit-Position: refs/heads/master@{#293023}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 963c8527b331983a8f8ccb7d11aec2a50a6fcf77
This CL adds a new dependency on the protocol buffer compiler
from the android source tree, since this compiler supports
generating Java files using the nano runtime.
The initial version of this dependency is 2.2.0a, but checked
out as what the Android 4.4.4 Release 2.0.1 tag points to.
This CL adds a new protoc binary (for compiling protos) that supports
this, and also adds a Java library with the runtime.
To simplify use of this, it also updates build/protoc_java.gypi to
support generating nano protos by specifying an optional
proto_runtime argument. The argument defaults to 'lite' which does
the same thing as before this change, and setting it to 'nano'
generates the new style Java files.
The plan is to quickly deprecate the 'lite' runtime for Java, since
it is too big and uses too many methods.
BUG=377891
Review URL: https://codereview.chromium.org/511283003
Cr-Original-Commit-Position: refs/heads/master@{#292965}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a076bf3d5a204c2e2db473a687b34c17830866bc
The reasons for reverting the CL hadn't been documented. I'm going to reland and update the bugs.
Unce upon a time the ASan runtime library used to be statically linked into
the executables on OSX.
Because that library provided a number of API functions needed by the shared
libraries, we had custom ASan-specific .saves files that told the `strip`
utility to preserve those functions when stripping the executables.
Then ASan switched to using dynamic runtime library, which instantly broke the
stripping step, because the executables weren't necessarily referencing all the
ASan API functions (issue 242503).
As a result, stripping has been disabled, and we haven't had .dSYM debug info
for ASan builds for more than a year now (issue 148383).
Because the ASan API functions are now undefined in the executables, it's
actually senseless to use the .saves files to preserve those functions.
This CL deletes the .saves files and turns mac_strip_release on for ASan
builds.
BUG=148383, 242503, 170739, 166857
TBR=mark@chromium.org
Review URL: https://codereview.chromium.org/517803004
Cr-Original-Commit-Position: refs/heads/master@{#292872}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5750a97fd179642548e6add77aafc1cdb0eec7e8
Remove a bunch of code that is already longer used or
will become unused when https://review.webrtc.org/22149004/
and https://codereview.chromium.org/505153002/ are landed.
Remove hardcoded paths to the WebRTC isolate files to make
it easier for us to make changes to them, since we can pass
the path to the .isolate file on test execution instead
(keeping the configuration in the WebRTC buildbot recipe instead).
Previously we had to roll our Chromium revision in WebRTC DEPS
every time a change was made before it became used.
Add support for a CHECKOUT_SOURCE_ROOT environment variable
used to make it possible to override the hardcoded path traversal
that is done to find the src/ directory (since it's different for
WebRTC bots). I considered passing a flag into the test_runner.py
scripts instead of using an environment variable, but my opinion is
that it would pollute the code too much since
constants.DIR_SOURCE_ROOT is used in 70 different places.
BUG=webrtc:3741
TEST=local building and test execution using command lines like this:
cd /path/to/webrtc/src
export CHECKOUT_SOURCE_ROOT=`pwd`
build/android/test_runner.py gtest -s tools_unittests --isolate-file-path=webrtc/tools/tools_unittests.isolate
R=navabi@chromium.org
Review URL: https://codereview.chromium.org/500423004
Cr-Original-Commit-Position: refs/heads/master@{#292861}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f0a439da1aba8e22b30ede87087418e806f7fa75
Sort the list of input java files for the aidl build step so that
the contents of generated makefiles in WebView have a stable ordering.
BUG=
Review URL: https://codereview.chromium.org/323803003
Cr-Original-Commit-Position: refs/heads/master@{#292686}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8eff03f99038a90198095d0bab3363a249357cb5
This reverts commit f1dc118635a18587a35b3d6f5092878467c261dd.
Reverting due to inconsistent behavior across toolchains, and lack of
clarity on whether armv7s is actually necessary.
BUG=407295,408027
R=rohitrao@chromium.org
Review URL: https://codereview.chromium.org/507423005
Cr-Original-Commit-Position: refs/heads/master@{#292624}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7c31daaf4d36113ca2602d1887566a1ad5214a03
The GLIB_DISABLE_DEPRECATION_WARNINGS define disables the deprecation
warnings which is caused by the usage of the g_settings_list_schemas
method. Moving the define to the build scripts avoids any future build
errors (-Werror) and warning reports.
BUG=391250
TEST=ninja -C out/Release chrome
Review URL: https://codereview.chromium.org/367113004
Cr-Original-Commit-Position: refs/heads/master@{#292608}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3a31d8e495b1d04a01f9e6c57fac608fee0285e3
We don't support msvs any more anyway, and clobbering all of build/ is
always a bad idea. (I'm not sure this'll fix anything, but maybe we'll
get a better error.)
R=kbr@chromium.org,iannucci@chromium.org
BUG=408839
Review URL: https://codereview.chromium.org/519503002
Cr-Original-Commit-Position: refs/heads/master@{#292554}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e72944be164918acb81933d0742e1369e51f2958
Previously "component" was a built-in function that forwarded to source_set, static_library, or shared_library depending on the value of component_mode. And test was a built-in function that forwarded to executable.
These can be expressed as templates instead. This patch removes the built-in versions and implements the templates in the master build config file.
Forwarding all of the variables for these is somewhat tedious, but I still prefer not to add a new concept for this, since it will be rarely used and less clear what is happening.
With the updated BUILDCONFIG.gn file, the build will work with both the old and new GN version (the built-in version of component and test take precedence). When the new GN binary is pushed, we can remove the references to component_mode.
BUG=
R=hclam@chromium.org
Review URL: https://codereview.chromium.org/516703005
Cr-Original-Commit-Position: refs/heads/master@{#292500}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 60a5bf4a8a5d1a2dad8e7a67f81e72756e886266
It seems that the cons are fairly weak and the benefits might be worth it.
This flag breaks WebView builds.
BUG=None
Review URL: https://codereview.chromium.org/502743002
Cr-Original-Commit-Position: refs/heads/master@{#292458}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 23668752ea266ca59e788510fc9e4baaf0397895
The yasm uses of compiled action used sources instead of inputs. Sources applies to the _foreach version but not the plain "compiled_action". These did not trigger an unused variable warning because the declarations themselves dereferenced the sources variable for computing args to the script.
This adds some extra documentation and assertion to the compiled action template. It also adds the binary itself as an input. This should be strictly unnecessary since there should be an implicit dependency on the target, but I like this since it makes things more explicit.
R=ajwong@chromium.org
Review URL: https://codereview.chromium.org/505403002
Cr-Original-Commit-Position: refs/heads/master@{#292447}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4b04efb439a19c6dfef213a2fe51751b223f9cbd
The android webview build now uses clang when building for host; update
the gyp variables appropriately to make sure we use reasonable compiler
flags.
BUG=377684
Review URL: https://codereview.chromium.org/516723004
Cr-Original-Commit-Position: refs/heads/master@{#292418}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ed51a58fb7366557e5dc3b874aa9821d8c5d5343
Changed implementation to make a single shell call, rather than
pushing files and executing several shell calls.
When running telemetry unittests on android, reduces total execution
time about 12%.
BUG=379378
Review URL: https://codereview.chromium.org/514123005
Cr-Original-Commit-Position: refs/heads/master@{#292405}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4bda9f96e6edbc4c208abde787c842f828f2f798
Add missing variables (android_ndk_*) for building Chromium for MIPS64.
In addition to this, set default mips_arch_variant-s for different MIPS
platforms.
BUG=400684
Review URL: https://codereview.chromium.org/494713002
Cr-Original-Commit-Position: refs/heads/master@{#292148}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c8a5da7455b57b2399e4a69e8100c098d9870052
ui_unittests.gyp -> ui_base_tests.gyp (follow gfx_tests.gyp pattern).
ui_unittests_bundle.gypi -> ui/base/ui_base_tests_bundle.gypi
ui_unittests.isolate -> ui_base_tests.isolate
Add a TODO assigned to me to rename ui_unittests target to
ui_base_unittests when buildbot is updated.
BUG=331829,373148,299841,103304
TEST=ui_unittests
R=sky@chromium.org
Review URL: https://codereview.chromium.org/506483002
Cr-Original-Commit-Position: refs/heads/master@{#292146}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 63e36e6bdaa65d1152dd62f9831128c752bc0408
* Fixed in this version: dependencies for *_api_registration on *_api.
Split bundle generation steps so that API registration is generated in browser, not common.
We now have schema generation, schema bundle generation, and schema bundle registration generation; the last of these is generated in a separate build target and output to browser rather than common.
Fix a couple of dangling gyp issues also.
BUG=405226
TBR=scottmg@chromium.org,sky@chromium.org
Review URL: https://codereview.chromium.org/513633002
Cr-Original-Commit-Position: refs/heads/master@{#292090}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 774dcda2d369584b2e964fa4971dda71cf819677
The mp2t mimetype is now supported when the mpeg2 TS stream parser is enabled.
This change is required since isTypeSupported involves
that CanPlayType for the same mime type is at least maybe.
This condition is now enforced at Blink level.
BUG=None
Review URL: https://codereview.chromium.org/478043005
Cr-Original-Commit-Position: refs/heads/master@{#292073}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a6c976378bd6485a520f0806e82126b25047d1c9
Causing build failure in Android due to failed include for extensions/common/api/runtime.h.
This reverts commit 3b70ef14be986a3252428cc6d9553bf2c69deb70.
BUG=none
TBR=yoz
Review URL: https://codereview.chromium.org/506253003
Cr-Original-Commit-Position: refs/heads/master@{#292059}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8f65982274893958898690b22e1c0c9ed4968857
We now have schema generation, schema bundle generation, and schema bundle registration generation; the last of these is generated in a separate build target and output to browser rather than common.
Fix a couple of dangling gyp issues also.
BUG=405226
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/489153003
Cr-Original-Commit-Position: refs/heads/master@{#292057}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3b70ef14be986a3252428cc6d9553bf2c69deb70
App Store rules require shipping armv7s with arm64, so this is required
for the "both" configuration.
Also adds it to the 32-bit configuration so that local testing will
better match actual builds, but we can revisit if that turns out to be
onerous in practice.
BUG=407295
Review URL: https://codereview.chromium.org/489713003
Cr-Original-Commit-Position: refs/heads/master@{#291930}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f1dc118635a18587a35b3d6f5092878467c261dd
Previously it put all toolchains' main link output into the root build directory, which doesn't work when there are multiple toolchains generating the same targets.
BUG=405686
R=jamesr@chromium.org
Review URL: https://codereview.chromium.org/502163002
Cr-Original-Commit-Position: refs/heads/master@{#291927}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d40ebfebd18d8fc41a0f5af61d28b6c252b66bea
scherkus
lliabraa
Hans Wennborg
tfarina
torne
nyquist
Nico Weber
oshima
Brett Wilson
bratell
Scott Violet
agable
treib
glider
Henrik Kjellander
qsr
leilei
phajdan.jr
dalecurtis
timurrrr
Stuart Morgan
pgal.u-szeged
scottmg
lfg
vitalybuka
mlamouri
perezju
svenpanne
Sadrul Habib Chowdhury
mikecase
petarj
yoz
damienv
Albert J. Wong
Jeffrey Yasskin