The --extra-variable FOO BAR format is not supported by the Go implementation.
Switch to --extra-variable FOO=BAR. Using the second form is only a problem when
the value has spaces and only on Windows and this case is OSX only.
TBR=vadimsh@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1152243003
Cr-Original-Commit-Position: refs/heads/master@{#331218}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ed6da5c8c4695faeb54aa354f48616cfd8207f71
We don't need a virtual X server for ozone testing, and it is causing
problems running the tests with swarming. This changes all isolate files
to only run Xvfb if use_x11==1 is set in GYP_DEFINES, and merges ozone
with Windows & Mac (none of which need to run their own display server).
BUG=440882
TEST=isolate.py run -s out_ozone/Debug/<various>
TBR=maruel
Review URL: https://codereview.chromium.org/908313004
Cr-Original-Commit-Position: refs/heads/master@{#319919}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 386febffff89e5b08b7dc0a5d6bd992df385e0b8
We don't need a virtual X server for ozone testing, and it is causing
problems running the tests with swarming. This changes all isolate files
to only run Xvfb if use_x11==1 is set in GYP_DEFINES, and merges ozone
with Windows & Mac (none of which need to run their own display server).
BUG=440882
TEST=isolate.py run -s out_ozone/Debug/<various>
TBR=maruel@chromium.org
Review URL: https://codereview.chromium.org/813363003
Cr-Original-Commit-Position: refs/heads/master@{#310434}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8a7be0714892c0c6360c45d0d602c119873b468e
Make the isolate generation aware that the NaCl
can be disabled and don't try to use those files
if it is disabled.
BUG=428264
R=maruel@chromium.org
TEST=./build/gyp_chromium -Ddisable_nacl=1 && ninja -C out/Release
Review URL: https://codereview.chromium.org/687173002
Cr-Original-Commit-Position: refs/heads/master@{#302257}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4b8c1e64ccae3a73fbf454ac33cd0879bbbdfa01
This copies the logic from tools/build/scripts/slave/runtest.py in swarming.
I changed test_env.py so that it sets CHROME_DEVEL_SANDBOX to be an empty string, instead of unsetting it. The latter doesn't work as Chrome triggers checks in content/browser/browser_main_loop.cc. This is what runtest.py does.
BUG=414808,336218
Review URL: https://codereview.chromium.org/605063004
Cr-Original-Commit-Position: refs/heads/master@{#297330}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 92ee4a3cbd8284c6f63cf8ca3eed384ca70b939e
In that mode isolate_driver.py will collect all arguments needed for
isolate.py invocation into *.isolated.gen.json file, but won't actually
run the isolation itself.
It's a feature of isolate_driver.py. Isolate client itself knows nothing about
this mode.
BUG=389227
R=maruel@chromium.org
Review URL: https://codereview.chromium.org/555553002
Cr-Original-Commit-Position: refs/heads/master@{#293885}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8556ebdc21ada4753aa6798a240c83101f212dcf
This should make it possible to get rid of the ugly
relative paths in the isolate files.
I'm including an example for base_unittests.isolate for
demonstrative purposes only. I can remove it (or convert all
.isolate files in Chromium) before landing.
BUG=343106
TEST=Successful compile+test on Linux using:
ninja -C out/Release base_unittests_run xdisplaycheck
tools/swarming_client/isolate.py run -s out/Release/base_unittests.isolated
Review URL: https://codereview.chromium.org/322403003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@276671 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This tool will ultimately process the .ninja files, in the meantime it archives
all the DLLs. It's cheezy but this will unblock the component build short term.
This is very crude but this will get folks going. This means once it's done, we
can remove all the .isolate representing the dynamic libraries.
Remove swarming_client/ as a dependency in the .isolate files, it's not needed
anymore.
R=vadimsh@chromium.org
BUG=333473
Review URL: https://codereview.chromium.org/196283016
git-svn-id: http://src.chromium.org/svn/trunk/src/build@261652 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This split the commands 'archive' and 'hashtable'. Now only 'archive' is
supported with ninja. This command only supports --isolate-server, so change
isolate.gypi accordingly. Remove support for test_isolation_outdir=='', it
doesn't make sense.
$ git log b39e8cf08..f9538eebbc --date=short --format="%ad %ae %s" | sed 's/@chromium\.org//'
2014-01-30 maruel isolate.py: split commands hashtable and archive so each have different behavior
2014-01-24 kmg Default to env vars for swarming.py server URLs
2014-01-23 maruel Fix tools/run_swarm_tests_on_swarm.py to run at all.
2014-01-23 maruel No need for me in WATCHLISTS.
R=vadimsh@chromium.org
BUG=
Review URL: https://codereview.chromium.org/131503009
git-svn-id: http://src.chromium.org/svn/trunk/src/build@247999 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
1) To match the gyp dependencies, move clearkeycdmadapter binaries, plugins/,
lib32/ and lib64/ from chrome.isolate to browser_tests.isolate.
2) On Windows, include <(version_full).manifest in chrome.isolate to be able
to execute chrome.exe. Add needed chrome_child.dll and chrome_elf.dll.
3) Add libEGL.dll and libGLESv2.dll dependencies to gpu.gyp:gl_tests and a
new angle.isolate; refer to it from gl_tests.isolate and
gles2_conform_test.isolate.
4) Copy run_gpu_test to run_gpu_test.py, and invoke that instead in
telemetry_gpu_test.isolate, to make this isolate work on Windows.
BUG=321878,334539
Review URL: https://codereview.chromium.org/140263002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@245283 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
$ git log aab3a62beb..f89de358c2 --date=short --format="%ad %ae %s" | sed 's/@chromium\.org//'
2013-12-13 maruel Remove the ban on 'command' that are declared in included .isolate file.
2013-12-12 maruel Fix assert occurring on OSX due to already hardlinked files.
2013-12-11 ganetsky Create a .gitignore file and add *.pyc to it
2013-12-11 maruel Stop signalling swarming error on Windows file locking.
2013-12-11 maruel Ensure variables are decoded to unicode.
2013-12-06 maruel Rename --command-variable to --extra-variables.
2013-12-06 maruel Add real variable support and split --variable in 3 different flags.
2013-12-05 vadimsh Add 'offset' parameter to StorageApi.fetch(...) method.
2013-12-05 maruel Change log message to be clearer.
2013-12-05 vadimsh Support custom HTTP headers in net.url_open.
2013-12-03 vadimsh Remove urllib2 support.
2013-12-03 vadimsh Wait for Storage's internal threads to finish before exiting.
2013-12-03 vadimsh Fix swarming_smoke_test.py and isolateserver_test.py.
This commit is done manually, as the breakage caused by the last commit can't be
tested on the Try Server. This is because of the way
build/scripts/slave/runisolatedtest.py modifies the .isolated.state files.
R=vadimsh@chromium.org
BUG=
Review URL: https://codereview.chromium.org/106643010
git-svn-id: http://src.chromium.org/svn/trunk/src/build@240882 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Speculative revert because base_unittests and net_unittests are failing
on almost all of the Windows builders, with errors like:
[------ Swarming Error ------]
Input file E:\b\build\slave\Win7_Tests__3_\build\src\build\Release\chrome_100_percent.pak doesn't exist
> Roll swarm_client @ 9fc05789e3.
>
> Includes revert of r240243.
>
> $ git log aab3a62beb..9fc05789e3 --date=short --format="%ad %ae %s" | sed 's/@chromium\.org//'
> 2013-12-11 ganetsky Create a .gitignore file and add *.pyc to it
> 2013-12-11 maruel Stop signalling swarming error on Windows file locking.
> 2013-12-11 maruel Ensure variables are decoded to unicode.
> 2013-12-06 maruel Rename --command-variable to --extra-variables.
> 2013-12-06 maruel Add real variable support and split --variable in 3 different flags.
> 2013-12-05 vadimsh Add 'offset' parameter to StorageApi.fetch(...) method.
> 2013-12-05 maruel Change log message to be clearer.
> 2013-12-05 vadimsh Support custom HTTP headers in net.url_open.
> 2013-12-03 vadimsh Remove urllib2 support.
> 2013-12-03 vadimsh Wait for Storage's internal threads to finish before exiting.
> 2013-12-03 vadimsh Fix swarming_smoke_test.py and isolateserver_test.py.
>
> R=vadimsh@chromium.org
> NOTRY=true
> BUG=
>
> Review URL: https://codereview.chromium.org/113553003TBR=maruel@chromium.org
Review URL: https://codereview.chromium.org/101143003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@240528 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Includes revert of r240243.
$ git log aab3a62beb..9fc05789e3 --date=short --format="%ad %ae %s" | sed 's/@chromium\.org//'
2013-12-11 ganetsky Create a .gitignore file and add *.pyc to it
2013-12-11 maruel Stop signalling swarming error on Windows file locking.
2013-12-11 maruel Ensure variables are decoded to unicode.
2013-12-06 maruel Rename --command-variable to --extra-variables.
2013-12-06 maruel Add real variable support and split --variable in 3 different flags.
2013-12-05 vadimsh Add 'offset' parameter to StorageApi.fetch(...) method.
2013-12-05 maruel Change log message to be clearer.
2013-12-05 vadimsh Support custom HTTP headers in net.url_open.
2013-12-03 vadimsh Remove urllib2 support.
2013-12-03 vadimsh Wait for Storage's internal threads to finish before exiting.
2013-12-03 vadimsh Fix swarming_smoke_test.py and isolateserver_test.py.
R=vadimsh@chromium.org
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/113553003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@240460 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This requires small changes in build/isolate.gypi, the isolate.py --variable
flag was split in three.
$ git log aab3a62beb..9cc42c3d4d --date=short --format="%ad %ae %s" | sed 's/@chromium\.org//'
2013-12-11 maruel Ensure variables are decoded to unicode.
2013-12-06 maruel Rename --command-variable to --extra-variables.
2013-12-06 maruel Add real variable support and split --variable in 3 different flags.
2013-12-05 vadimsh Add 'offset' parameter to StorageApi.fetch(...) method.
2013-12-05 maruel Change log message to be clearer.
2013-12-05 vadimsh Support custom HTTP headers in net.url_open.
2013-12-03 vadimsh Remove urllib2 support.
2013-12-03 vadimsh Wait for Storage's internal threads to finish before exiting.
2013-12-03 vadimsh Fix swarming_smoke_test.py and isolateserver_test.py.
R=vadimsh@chromium.org
BUG=324911
Review URL: https://codereview.chromium.org/105933002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@240155 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This moves run_test_cases.py into a subdirectory named googletest/ so the
.isolate files had to be updated.
$ git log $(git svn find-rev r212588)..$(git svn find-rev r213621) --format="%an %ai %s" | sed 's/\+0000 //' | sed 's/@chromium\.org//'
maruel 2013-07-25 13:34:09 Move all googletest related scripts into googletest/
maruel 2013-07-24 15:54:29 Fix two layering violations between run_test_cases and non googletest tools.
maruel 2013-07-24 13:04:30 Remove automatic copying fallback in run_isolated.
maruel 2013-07-19 19:26:18 Remove references to vlan.
TBR=csharp@chromium.org
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/20104003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@213624 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
tommi
sebmarchand
maruel
erikwright
thakis
jrummell
machenbach
gunsch
earthdok
spang
jam
Paweł Hajdan, Jr
pgal.u-szeged
baixo
vadimsh
kbr@chromium.org
maruel@chromium.org
scheib@chromium.org
kjellander@chromium.org
mad@chromium.org
plundblad@chromium.org
scottmg@chromium.org
jshin@chromium.org
dmazzoni@google.com
ckocagil@chromium.org
thakis@chromium.org