Reason for revert:
Async request for zoom level doesn't work in all cases https://crbug.com/614348https://crbug.com/613979.
I thought https://www.chromium.org/developers/design-documents/mojo/chrome-ipc-to-mojo-ipc-cheet-sheet#TOC-Threading-Model implied the ordering would be correct, but it seems that was too hopeful.
Original issue's description:
> Add FrameHost mojo service
>
> Adds new frame-level service with one initial method to handle host zoom
> level.
>
> This moves zoom level supply from async_resource_handler.cc to being a
> request made when render_frame_impl handles a willSendRequest.
>
> The goal of this change is to remove the dependency of
> content/browser/loader on the rest of content/browser in particular
> here, removing the use of c/b/host_zoom_map_impl.h in
> content/browser/loader/async_resource_handler.cc.
>
> BUG=598073,609607
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
>
> Committed: https://crrev.com/68c6f2ce16d9807b5cb82679099c82c40f39e911
> Cr-Commit-Position: refs/heads/master@{#394547}
TBR=dcheng@chromium.org,ben@chromium.org,jam@chromium.org,nasko@chromium.org,wjmaclean@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=598073,609607,614348,613979
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2007203002
Cr-Original-Commit-Position: refs/heads/master@{#395761}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 34ce95dd9c2ca3b90fc87169f1e4ed266e7bb94b
--screenshot option was broken for instrumentation tests. In this cl,
the option is enabled. With argument --screenshot, the device will take
a screenshot whenever an instrumentation test fails.
BUG=613405
Review-Url: https://codereview.chromium.org/1998383002
Cr-Original-Commit-Position: refs/heads/master@{#395662}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 35d5e3dd14ae616db29806f3052b400f2de1945a
I killed an ongoing build and a zip file got corrupted. Then all
subsequent builds were failing, but I didn't know where.
This adds/clears up the message IMO.
Previous output:
File "/...../src/build/android/gyp/util/build_utils.py", line 228, in
ExtractAll
with zipfile.ZipFile(zip_path) as z:
File "/usr/lib/python2.7/zipfile.py", line 770, in __init__
self._RealGetContents()
File "/usr/lib/python2.7/zipfile.py", line 811, in _RealGetContents
raise BadZipfile, "File is not a zip file"
zipfile.BadZipfile: File is not a zip file
New output:
File "../../build/android/gyp/javac.py", line 90, in
_ExtractClassFiles
build_utils.ExtractAll(jar_path, path=dest_dir,
predicate=extract_predicate)
File "/...../src/build/android/gyp/util/build_utils.py", line 229, in
ExtractAll
raise Exception('Invalid zip file: %s' % zip_path)
Exception: Invalid zip file: gen/base/base_java__compile_java.javac.jar
BUG=
Review-Url: https://codereview.chromium.org/2001353002
Cr-Original-Commit-Position: refs/heads/master@{#395545}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e8198a4d058fb88e7d4314587a0f0e8992a31c15
Print preview needs pdf module enabled to function. Also, the
utility component depends on pdf module only when print_preview is
enabled implicitly (on Windows only) or explicitly. Make the gn build
file changes to reflect these dependencies.
BUG=609726
Review-Url: https://codereview.chromium.org/1994713002
Cr-Original-Commit-Position: refs/heads/master@{#395519}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5addafe27695c6caf4f6d1b757b4cef54b6b598b
This delay loads additional libraries so the set of delay-loaded and non-delay-loaded libraries is the same between GYP and GN for 32-bit Windows official builds of chrome.exe and chrome.dll. I checked the imported libraries but not the individual functions.
Remove user32 delay imports. This was a hack for Windows XP. I checked all the functions in the list of imports and they are all available on Windows 7. There was a lot of machinery required for this that was removed.
BUG=512861
Reland of https://crrev.com/080e7e885be49295f8373eb0fa54e6772206bc64 with fix.
Review-Url: https://codereview.chromium.org/2008643002
Cr-Original-Commit-Position: refs/heads/master@{#395432}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: cc84b6cdb2ba06927c498632c86cb0c81e50e9ec
Fixed coverage dir option for instrumentation tests, so that we should
be able to pull run time coverage data from devices to bot.
BUG=608072
Review-Url: https://codereview.chromium.org/1964183003
Cr-Original-Commit-Position: refs/heads/master@{#395419}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 111b5841249ab4c8e14ed1b0af2328d5e739a140
This is an old gitlink entry referring to a revision in another git repository,
but it doesn't appear to be used, and causes git submodule to fail.
$ git ls-files -s third_party/html_office
160000 1d04f3dfbd8bd604190dfb6f5a030d30233ba6ea 0 third_party/html_office
(mode 160000 is a gitlink, see git-fast-import(1))
R=agable@chromium.orgTBR=agable@chromium.org
Review URL: https://codereview.chromium.org/2004183002 .
Cr-Original-Commit-Position: refs/heads/master@{#395409}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ac0106a1dd9ea8c3c0b829985d257c4592872e06
Remove enable_topchrome_md build flag
Actually use of MD is still controlled by a runtime flag.
Also get rid of Material Design resource build step (on !osx). These drop-in png replacements are no longer used (they've all been converted to vectorized images).
BUG=613980
TBR=sky@chromium.org,scottmg@chromium.org,blundell@chromium.org
Review-Url: https://codereview.chromium.org/2004143002
Cr-Original-Commit-Position: refs/heads/master@{#395392}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 476ef356a5b0d6fb075844a4099d1f38c811301f
This CL turns on Link-Time Optimization for official
builds, which makes the resulting binaries to run faster.
On the dark side, the change increases the link time by 3x-5x,
and is also very memory-hungry. All official bots were
upgraded to have 200+ GB RAM to handle LTO builds. Timeouts
were also accordingly increased.
This CL might cause timeouts / OOMs, if some slaves still
have not enough RAM. Please, revert the CL with pointing
out to the slaves / bots broken by this change.
BUG=453195
Review-Url: https://codereview.chromium.org/2003733004
Cr-Original-Commit-Position: refs/heads/master@{#395365}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7c163521444b7277f2c33bc7bc05667673db7d48
According to a comment in the code, switches::kReduceSecurityForTesting
(which is the only requirement for this class to be in content) was used
for requestAutocomplete testing. Now that requestAutocomplete has been
removed, these functions can be moved out of components/autofill/content
into components/autofill/core.
Also, remove the kWalletServiceUrl and kWalletSecureServiceUrl switches.
The former isn't referenced by any code and the while the latter is still
referenced, the only mention I can find for the use of that flag is in a
3 year old thread* that later goes on to specify a different set of
instructions that don't include the use of the flag.
Finally, make some progress on s/Wallet/Payments.
BUG=613281
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/1999923002
Cr-Original-Commit-Position: refs/heads/master@{#395343}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 65639ea0c7f964b96243603dec17ec449ec2ced4
CoordinatorLayout in android design support library makes it possible to
coordinate views' animation. This CL makes CompositorViewHolder a
CoordinatorLayout, and adds several behaviors to control the interaction
between snackbars and infobars.
After this change, CompositorViewHolder will first check if a touch
event is handled by behaviors in the children views, then give the
touchevent to fullscreen manager and layout manager afterwards.
BUG=581227
Review-Url: https://codereview.chromium.org/1983353002
Cr-Original-Commit-Position: refs/heads/master@{#395210}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 87ee877992e41f3037a23a164abf4689c1ba603c
If delete_dir or os.mkdir throw an exception then the code to restore
args.gn, build.ninja, and build.ninja.d will not run. This breaks a
design goal of gn which is that the args.gn files should not be
deleted.
The fix is to catch the exception and raise it after the files have
been restored.
To test the code leave chrome.exe or base_unittests.exe running in one
window and run this in another:
python build\clobber.py d:\src\chromium\src\out
Note that if you do this without the patch applied then all args.gn
files may be deleted, so consider backing them up. Also note that
args.gn files won't be restored unless build.ninja and build.ninja.d
files are also present, so back them up.
Just apply the patch first - it's easier.
BUG=612940
Review-Url: https://codereview.chromium.org/1996833002
Cr-Original-Commit-Position: refs/heads/master@{#395177}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 562df4f33e0a29669b83d451d33c81648a9e023e
Actually use of MD is still controlled by a runtime flag.
Also get rid of Material Design resource build step (on !osx). These drop-in png replacements are no longer used (they've all been converted to vectorized images).
BUG=none
Review-Url: https://codereview.chromium.org/1991573002
Cr-Original-Commit-Position: refs/heads/master@{#395146}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2b0e51237fa07b4fb9f6c20edcefce094f6cf5f5
Uses the variables defined in build/config/locales.gni to simplify
the grit invocations and remove the conditional to deal with the
different names for the "es-419" and "pt-BR" locales on iOS.
BUG=525492
Review-Url: https://codereview.chromium.org/2003433003
Cr-Original-Commit-Position: refs/heads/master@{#395127}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: de51485fd1db9d4a22ce90764f767ad80e823acf
Currently, the deps of the internal targets are setup inccorrectly:
ERROR Input to target not generated by a dependency.
BUG=none
Review-Url: https://codereview.chromium.org/2001573003
Cr-Original-Commit-Position: refs/heads/master@{#395113}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 76d9b76939631c27efafd994fbebef6bdafb4696
Chrome on iOS only ships with a subset of locales compared to Chrome
(as the corresponding locales are not supported by the system) and
uses different names for "es-419" and "pt-BR".
BUG=459705,525492
Review-Url: https://codereview.chromium.org/2000603002
Cr-Original-Commit-Position: refs/heads/master@{#395095}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 23deef3518c543a32ef86a5839d778931b37fef3
Allowing the invoker of ios_info_plist output can help remove one
intermediate target when generating some bundles.
BUG=459705
Review-Url: https://codereview.chromium.org/1996913003
Cr-Original-Commit-Position: refs/heads/master@{#395073}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 59302f49921ea20fe7b6a722892c912f8ca84656
Reason for revert:
breaks downstream
Original issue's description:
> Added the --screenshot option.
>
> --screenshot option was broken for instrumentation tests. In this cl,
> the option is enabled. With argument --screenshot, the device will take
> a screenshot whenever an instrumentation test fails.
>
> BUG=611538
>
> Committed: https://crrev.com/09891bc02742f34a11a6d8ffd8993066f6c1b62c
> Cr-Commit-Position: refs/heads/master@{#394843}
TBR=mikecase@chromium.org,hzl@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=611538
Review-Url: https://codereview.chromium.org/1998903002
Cr-Original-Commit-Position: refs/heads/master@{#394956}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5a6fa1e0d268e6ef3f15aff3bb63fae8b94396cd
The libcxx_proxy target used to set the link-time configuration to
correctly link libc++ sets it as a public_config. However, the sanitizer
deps targets have only private dependencies on libcxx_proxy so the
config does not apply to their dependents. This changes those
dependencies to be public.
This disables sanitizers for all non-default gcc_toolchain toolchains;
the android host toolchain build does not support building with libc++
and the GYP build does not use sanitizers for building host targets.
BUG=573288
Review-Url: https://codereview.chromium.org/1979973002
Cr-Original-Commit-Position: refs/heads/master@{#394910}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 34099cc1fb570af8990d5fad1b1e11fe4290680b
Using the 'is_official_build' gn flag pulls in a bunch of debugging
symbols that we don't need for the engine, and in fact will bloat the
binary size. Using a symbol level of 0 has no effect on the breakpad
symbol file generated by dump_app_syms.py, so we don't lose any of our
desired debugging capabilities.
Tested by building with the buildbot configuration, uploading symbols,
and causing an engine crash with 'kill -6'.
BUG=613186
Review-Url: https://codereview.chromium.org/1987313004
Cr-Original-Commit-Position: refs/heads/master@{#394906}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 379f3f501b387fae1d2807b096f993015dbb3d68
Chromecast builds require that target toolchains not use gold. Other
options do not work:
1) toolchain_args are ignored when the toolchain is default, so
setting use_gold explicitly for our target toolchains is infeasible.
2) We want host toolchains to take the default value for use_gold, so
overriding with a GN arg is infeasible.
Setting use_gold on a per-toolchain basis is ideal, but until the issue
in (1) is resolved, this will need to be our workaround.
BUG=NONE
Review-Url: https://codereview.chromium.org/1994623004
Cr-Original-Commit-Position: refs/heads/master@{#394872}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2dcea1128cc5021fc1baef55fd78166397712817
Turn down app_list_unittests on Mac. Moves app_list_unittests and
app_list_presenter_unittests to the same place as ash_unittests on other
non-ChromeOS bots.
BUG=600915
Review-Url: https://codereview.chromium.org/1934213002
Cr-Original-Commit-Position: refs/heads/master@{#394856}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 87ca2d6836730fb7cacf7c76e33e100df599b754
--screenshot option was broken for instrumentation tests. In this cl,
the option is enabled. With argument --screenshot, the device will take
a screenshot whenever an instrumentation test fails.
BUG=611538
Review-Url: https://codereview.chromium.org/1981043004
Cr-Original-Commit-Position: refs/heads/master@{#394843}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 09891bc02742f34a11a6d8ffd8993066f6c1b62c
GCC doesn't turn on rtti by default, while clang does.
Setting it explicitly to make sure we always compile as
desired.
BUG=chromium:474921
Review-Url: https://codereview.chromium.org/1992083003
Cr-Original-Commit-Position: refs/heads/master@{#394819}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 819abfc903928d84bebbef58fe53ca86843d4531
This also fixes Android setting -Wl,--icf=all in a different spot.
Reason for reland:
Removed --icf=safe for x86
BUG=606749,576197,611668
Review-Url: https://codereview.chromium.org/1996433002
Cr-Original-Commit-Position: refs/heads/master@{#394655}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 10371eae8d24d0ea7efa880571d51d62ce8f197c
I haven't heard of this causing issues for us yet, but I realized that
filtering after proguarding could have the result that proguard renames
a class to "R.class", and then filtering strips it out.
BUG=585576
Review-Url: https://codereview.chromium.org/1993893002
Cr-Original-Commit-Position: refs/heads/master@{#394638}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2142bcde69837585c1571a46cf59715a81d573f9
Replace checks for Build.VERSION.CODENAME.equals("N") wieth
Build.VERSION.CODENAMES.equals("N") || Build.VERSION.SDK_INT > Build.VERSION_CODES.M.
Eventually we will want the check to be just for SDK_INT, but for M51 we'll
use the ||.
BUG=586703
Review-Url: https://codereview.chromium.org/1989203003
Cr-Original-Commit-Position: refs/heads/master@{#394615}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 96a31a443985b11f125797d32f837eff42f2efb3
Use xcrun instead of xcodebuild if --print_sdk_path is passed. Reduces time
to run `gn gen` from 2.2s to 1.95s on my MacBook Pro.
(In the gyp build, we don't pass --print_sdk_path to this script, so I didn't
notice this script had this slow path until now.)
While here, also stop pretending that we support Xcodes older than 4.3.
BUG=609541
Review-Url: https://codereview.chromium.org/1988023006
Cr-Original-Commit-Position: refs/heads/master@{#394565}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d50140bae570f519cea29a8b20e58511032cbfd7
Adds new frame-level service with one initial method to handle host zoom
level.
This moves zoom level supply from async_resource_handler.cc to being a
request made when render_frame_impl handles a willSendRequest.
The goal of this change is to remove the dependency of
content/browser/loader on the rest of content/browser in particular
here, removing the use of c/b/host_zoom_map_impl.h in
content/browser/loader/async_resource_handler.cc.
BUG=598073,609607
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/1964273002
Cr-Original-Commit-Position: refs/heads/master@{#394547}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 68c6f2ce16d9807b5cb82679099c82c40f39e911
This CL reworks the way ChromiumOS toolchains work in GN, in such a way
that they might actually have all the flags they need for the
ChromiumOS ebuild files to be able to set all of the flags it needs
(though there are still some missing GN build_args).
Specifically, the ebuild will now need to set the following in args.gn:
host_toolchain = "//build/toolchain/cros:host"
v8_snapshot_toolchain = "//build/toolchain/cros:v8_snapshot"
in order to support boards other than the amd64-generic build. The
ebuild should actually set these variables all the time; it just
happens that the amd64-generic build will work at the moment without
the variables, but that will not be guaranteed to remain true in the future.
This CL also adds the following optional build args that do pretty
much what you'd expect them to do:
cros_target_ld, cros_target_extra_cflags, cros_target_extra_cppflags,
cros_target_extra_cxx_flags, cros_target_extra_ldflags,
cros_host_ar, cros_host_cc, cros_host_cxx, cros_host_ld,
cros_host_is_clang, cros_host_extra_cflags, cros_host_extra_cppflags,
cros_host_extra_cxx_flags, cros_host_extra_ldflags,
cros_v8_snapshot_ar, cros_v8_snapshot_cc, cros_v8_snapshot_cxx,
cros_v8_snapshot_ld, cros_v8_snapshot_extra_cflags,
cros_v8_snapshot_extra_cppflags, cros_v8_snapshot_extra_cxx_flags,
cros_v8_snapshot_extra_ldflags
This CL should be backwards-compatible with the existing linux desktop
ChromiumOS builds and the amd64-generic simplechrome/ebuild (i.e., it
can be landed and reverted w/o requiring any other changes to be made).
It is a big hammer intended to un-block the ChromiumOS GN migration
while we continue thinking about how to best support ChromiumOS.
R=stevenjb@chromium.org, brettw@chromium.org
BUG=608596, 595653
Review-Url: https://codereview.chromium.org/1983613002
Cr-Original-Commit-Position: refs/heads/master@{#394534}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8ad2f49335feaddddbd3f318fc6f4d13eb52760b
Use "xcrun" instead of "xcodebuild" as it is much faster and available
on all version of OS X supported for building Chrome.
Reduce running time of "gn gen" from 2.5 to 2.2s on MacBook Pro
laptop.
BUG=609541
Review-Url: https://codereview.chromium.org/1993653002
Cr-Original-Commit-Position: refs/heads/master@{#394505}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 268142df3c289fcd2605cd68f41e04ebade1067b
Tried to set arm_fpu to "cortex-a57+simd+crypto+fp+crc" for clang
These lines also affect GCC which is used to ship official chrome,
All ARMv8 implementations would support SIMD and FP by default, but
crypto is optional, so the code generated might fail on devices which
do not support crypto also adding cortex-a57 and using on cortex-a53
or vice versa might generate code that is going to be slower.
So we decided to revert this patch.
BUG : http://crbug.com/539781
BUG=539781
R=thakis@chromium.org
TEST=download apk to ARMv8 board and launch
Review-Url: https://codereview.chromium.org/1987733002
Cr-Original-Commit-Position: refs/heads/master@{#394334}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5d3069f38c1bbacbfc9d1ef672ea8c8dc9d12b3f
This is modeled after what is done for the official Chrome linux build.
As it stands right now, the breakpad symbol file is roughly 300MB and
takes a couple of minutes to run, so the action should only be triggered
if this is an official release.
BUG=597454
Review-Url: https://codereview.chromium.org/1979773002
Cr-Original-Commit-Position: refs/heads/master@{#394191}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 060ef497fef78501475548ec61dbc8c290f02a9b
scottmg
hzl
tedchoc
weili
dpranke
brettw
pkotwicz
Aaron Gable
estade
krasin
jdonnelly
jbudorick
kolos
yhirano
ianwen
brucedawson
Hans Wennborg
sdefresne
agrieve
jmadill
sammc
marcinjb
slan
tapted
machenbach
haibinlu
twellington
vadimsh
thakis
Robert Sesek
Gordana.Cmiljanovic
khasim.mohammed