Leaves the previous version in place but updates BUILD.gn and libvpx.gn to point to the new version. This allows decoupling the WebRTC update which is also in DEPS.
libvpx DEPS changes ac1772e:0d6551
https://codereview.chromium.org/1339033002https://chromium-review.googlesource.com/299759https://codereview.chromium.org/1350853003https://codereview.chromium.org/1353433003
Copy directory to libvpx_new to avoid breaking bisecting. This allows the user to move between and older and newer revision. A followup to rename libvpx_new to libvpx will come in some ~months because there are additional complications if one tries to sync directly from pre-move to post-rename or the other way around.
Remove WATCHLISTS and codereview.settings from _new and use the parent versions.
Add DEPS file to enumerate the #include paths.
Check out third_party/libvpx_new/source/libvpx directly from upstream project
Update all the easy clients of libvpx to depend on the new tree directly.
ac1772e3db
BUG=481034
R=tomfinegan@chromium.org,brettw@chromium.org,phajdan.jr@chromium.org
Review URL: https://codereview.chromium.org/1323333002
Cr-Original-Commit-Position: refs/heads/master@{#349789}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5238138a422157576799266228c0c9ee174936ae
This fixes a build break for linux chromeos:
gyp: Dependency '/b/build/slave/linux_chromeos/build/src/build/linux/system.gyp:libdrm#target' not found while trying to load target /b/build/slave/linux_chromeos/build/src/content/content_shell_and_tests.gyp:vaapi_jpeg_decoder_unittest#target
BUG=531814
TEST=gclient runhooks with "use_ozone=1 chromeos=1"
Review URL: https://codereview.chromium.org/1346003002 .
Cr-Original-Commit-Position: refs/heads/master@{#349057}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 35ecf40fb75893838295418d07fa5d37bcca10d7
This is a software-only platform that was used early in the process
of bringing up the Chrome OS ozone/freon (no X11) build. It's time to
remove it because it now requires not only scary flags to get it going,
but also a patch (https://codereview.chromium.org/1216303004/).
If we need a build with software rasterization let's use vgem+swrast like
our VMtests do.
BUG=531814
TEST=link still works fine with platform=gbm
Review URL: https://codereview.chromium.org/1345703002
Cr-Original-Commit-Position: refs/heads/master@{#349012}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d0620b8a4b025b5d808644068d155e07dcaa0276
This library is used by Chrome on Chrome OS to allocate accelerated
graphics buffers. The version avaiable on Ubuntu is too old, and as a
result we can't run unit tests for the gbm platform code on developer
workstations or on the waterfall.
This adds the library to third_party and fixes up the build files to use
either the OS copy (for Chrome OS release builds) or gardened copy (for
testing on the waterfall) depending on the value of "use_system_minigbm".
BUG=530712
TEST=
GYP_DEFINES="use_ozone=1 chromeos=1 ozone_platform_gbm=1 use_system_minigbm=0" gclient runhooks
ninja -C out/Release ozone_unittests
./out/Release/ozone_unittests
gn gen out_gn_ozone --args='target_os="chromeos" use_ozone=true ozone_platform_gbm=true use_system_minigbm=false'
ninja -C out_gn_ozone ozone_unittests
./out_gn_ozone/Release/ozone_unittests
Review URL: https://codereview.chromium.org/1341473003
Cr-Original-Commit-Position: refs/heads/master@{#348758}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c231bffd37754a1ab09fbbb4a1260438be638df4
Reason for revert:
Caused check_licenses to fail:
https://build.chromium.org/p/chromium/builders/Linux/builds/66701
Original issue's description:
> Fix typo in install-sysroot.py
>
> install-sysroot.py was intended to default to installing
> the sysroot ia32, but within this script 'i386' is used to
> refer to this architecture.
>
> This most likely went unnoticed since the ia32 builder
> either use branding=Official, or explicitly set
> use_sysroot=1, or have a complete set of packages for
> cross building on the host system.
>
> BUG=504446
>
> Committed: https://crrev.com/1d62049b4c176fbd43bed90fc9a76273b11ad406
> Cr-Commit-Position: refs/heads/master@{#347821}
TBR=dpranke@chromium.org,sbc@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=504446
Review URL: https://codereview.chromium.org/1315773003
Cr-Original-Commit-Position: refs/heads/master@{#347839}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3b27a2de111759359162bcad49753e17ee1cf002
install-sysroot.py was intended to default to installing
the sysroot ia32, but within this script 'i386' is used to
refer to this architecture.
This most likely went unnoticed since the ia32 builder
either use branding=Official, or explicitly set
use_sysroot=1, or have a complete set of packages for
cross building on the host system.
BUG=504446
Review URL: https://codereview.chromium.org/1317973005
Cr-Original-Commit-Position: refs/heads/master@{#347821}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1d62049b4c176fbd43bed90fc9a76273b11ad406
This adds a "use_gtk3" gyp/gn flag, along with a separate gtk2/gtk3
targets in system.gyp and //build/config/linux/gtk[23] in gn.
BUG=132847
Review URL: https://codereview.chromium.org/1293073006
Cr-Original-Commit-Position: refs/heads/master@{#346742}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b8f8f682a82bce992edb35c3030214ede236d3ba
The //build/config/linux library defined a number of targets
built through the generate_library_loader target. All of these
are fairly chrome-specific, so having them defined in the
//build/config/linux file made it harder to reuse that file
in non-chrome GN builds (like native_client).
This CL moves the targets out to a new //build/linux directory
and updates the callers accordingly.
R=brettw@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1314163005
Cr-Original-Commit-Position: refs/heads/master@{#346242}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ad0c1f495eca0968601ea74254b86fb91d412eb0
I found this issue, while trying to use libdrm with some custom changes
and not installed in the default system path. We are already checking
drm system library and cflags using pkg, this patch extends it for
the directory too.
Review URL: https://codereview.chromium.org/1254133009
Cr-Original-Commit-Position: refs/heads/master@{#342229}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d1c9e302bc024e90299771d20b59bc6b5d18d999
The only semantic change here is that the sysroot will
be installed for ia32 cross builds by default, like
it is for arm and mips already.
BUG=504446
Review URL: https://codereview.chromium.org/1240123004
Cr-Original-Commit-Position: refs/heads/master@{#339343}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: dd181aed3e76b963564500fe6f28731c9e33700c
The sysroot are generally useful (for example when
cross compiling) and not limited to use in the installer
or official releases.
Another reason to move this is that it would allow other
projects to more easily share chromium's build setup
without depending on chrome/.
Also, rename the install script to simply install-sysroot.
This way the script can keep the same name and support
multiple different debian releases without needing
to duplicate the script (e.g. when we switch to jessie).
BUG=504446
TEST=cross build chromium for arm and ia32
Review URL: https://codereview.chromium.org/1141003002
Cr-Original-Commit-Position: refs/heads/master@{#336843}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8208b4d81396c11e1f8ca8f6ffe52b9fcea87d05
Remove -gdwarf-4 from GYP build. This is the default for GCC 4.8 which is now required, so this command-line argument is redundant.
Only set use_debug_fission in the GN build in debug mode. This matches GYP. Release mode symbols will be non-fission.
Implement linux_symbols target in GN. Convert dump_app_syms from sh to Python for better GN usability, and it's more readable for normal programmers on the team.
Reland of https://codereview.chromium.org/1179393004/TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/1182663007
Cr-Original-Commit-Position: refs/heads/master@{#334690}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 07d847b1c5451748f16f4e7973ce8ef9078d47a2
Reason for revert:
Broke the Linux GN Clobber bot:
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20Clobber/builds/1271/steps/compile/logs/stdio
ninja: error: '../../build/linux/dump_app_syms', needed by 'obj/chrome/linux_symbols.inputdeps.stamp', missing and no known rule to make it
Original issue's description:
> Fix some build symbol configuration.
>
> Remove -gdwarf-4 from GYP build. This is the default for GCC 4.8 which is now required, so this command-line argument is redundant.
>
> Only set use_debug_fission in the GN build in debug mode. This matches GYP. Release mode symbols will be non-fission.
>
> Implement linux_symbols target in GN. Convert dump_app_syms from sh to Python for better GN usability, and it's more readable for normal programmers on the team.
>
> BUG=
>
> Committed: https://crrev.com/950889c01dd934acf28bce29ea6db75610a8c441
> Cr-Commit-Position: refs/heads/master@{#334510}
TBR=thakis@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/1182783006
Cr-Original-Commit-Position: refs/heads/master@{#334522}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 520e8fd6084a0b3f1ec1011273730c4c6e392d09
Remove -gdwarf-4 from GYP build. This is the default for GCC 4.8 which is now required, so this command-line argument is redundant.
Only set use_debug_fission in the GN build in debug mode. This matches GYP. Release mode symbols will be non-fission.
Implement linux_symbols target in GN. Convert dump_app_syms from sh to Python for better GN usability, and it's more readable for normal programmers on the team.
BUG=
Review URL: https://codereview.chromium.org/1179393004
Cr-Original-Commit-Position: refs/heads/master@{#334510}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 950889c01dd934acf28bce29ea6db75610a8c441
The sysroot variable is set conditionally in common.gypi
but not at the nesting level required for other conditional
to depend on it like the one in hardbuzz does. This means
that sysroot always appeared to be empty to harfbuzz.gyp,
and hence the special handling for ARM linux was required.
This change moves the setting of 'sysroot' up one level of
nesting and defines 'pkg-config' in common.gypi so it can
be shared.
This is the third attempt at a landing. First attempt was
reverted: https://codereview.chromium.org/1151753002
This is a re-land of the second attempt which was
reverted speculatively (wrongly as it turned out):
https://codereview.chromium.org/1158283003
TBR=cpu
Review URL: https://codereview.chromium.org/1146303007
Cr-Original-Commit-Position: refs/heads/master@{#332982}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: dea1c634b5328b1e171ba22698fb7027f338453f
The sysroot variable is set conditionally in common.gypi
but not at the nesting level required for other conditional
to depend on it like the one in hardbuzz does. This means
that sysroot always appeared to be empty to harfbuzz.gyp,
and hence the special handling for ARM linux was required.
This change moves the setting of 'sysroot' up one level of
nesting and defines 'pkg-config' in common.gypi so it can
be shared.
Second attempt at landing this. First attempt was here:
https://codereview.chromium.org/1151753002
TBR=cpu
Review URL: https://codereview.chromium.org/1158283003
Cr-Original-Commit-Position: refs/heads/master@{#332311}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fa36d7041817ddd299c89ca5ecef432c9210fda9
Reason for revert:
Breaks GYP for Chrome OS builds. Repro steps:
cros chrome-sdk --board=amd64-generic
gclient runhooks
Updating projects from gyp files...
/bin/sh: /build/amd64-generic/build/bin/pkg-config: No such file or directory
gyp: Call to '/build/amd64-generic/build/bin/pkg-config --libs-only-l nss | sed -e "s/-lssl3//"' returned exit status 0.
/bin/sh: /build/amd64-generic/build/bin/pkg-config: No such file or directory
gyp: Call to '/build/amd64-generic/build/bin/pkg-config --libs libcras' returned exit status 127.
/bin/sh: /build/amd64-generic/build/bin/pkg-config: No such file or directory
gyp: Call to '/build/amd64-generic/build/bin/pkg-config --cflags x11' returned exit status 127.
Error: Command /usr/bin/python src/build/gyp_chromium returned non-zero exit status 1 in /ssd/src/chromium
TEST=cros chrome-sdk --board=amd64-generic && gclient runhooks
Original issue's description:
> Fix use of 'sysroot' variable in harfbuzz.gyp
>
> The sysroot variable is set conditionally in common.gypi
> but not at the nesting level required for other conditional
> to depend on it like the one in hardbuzz does. This means
> that sysroot always appeared to be empty to harfbuzz.gyp,
> and hence the special handling for ARM linux was required.
>
> This change moves the setting of 'sysroot' up one level of
> nesting and defines 'pkg-config' in common.gypi so it can
> be shared.
>
> Committed: https://crrev.com/6a80b32f309490f44347f2925589a6f0fc23c3ff
> Cr-Commit-Position: refs/heads/master@{#331506}
TBR=mazda@chromium.org,dpranke@chromium.org,cpu@chromium.org,sbc@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1154213004
Cr-Original-Commit-Position: refs/heads/master@{#331642}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8505ef356013ec9239f295501a283ec9fd43b08a
The sysroot variable is set conditionally in common.gypi
but not at the nesting level required for other conditional
to depend on it like the one in hardbuzz does. This means
that sysroot always appeared to be empty to harfbuzz.gyp,
and hence the special handling for ARM linux was required.
This change moves the setting of 'sysroot' up one level of
nesting and defines 'pkg-config' in common.gypi so it can
be shared.
Review URL: https://codereview.chromium.org/1151753002
Cr-Original-Commit-Position: refs/heads/master@{#331506}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6a80b32f309490f44347f2925589a6f0fc23c3ff
Reason for revert:
All linux perf bots red, failing on various blink_perf tests. Speculatively reverting this CL since several bisects pointed to it.
BUG=485590
Original issue's description:
> Linux Aura accessibility is enabled only on GNOME desktops
>
> Linux Aura accessibility is not enabled on desktops different than GNOME2.
> GNOME3 has deprecated gconf in favor of gsettings and dconf.
> AT-SPI (cross-platform framework that provides communication between AT
> and application) bus launcher has a property called org.a11y.Bus.IsEnabled
> that could be easily read by dbus call.
>
> In generall this patch adds an additional check to enable accessibility.
> When gconf is available use gnome's accessibility key otherwise
> org.a11y.Bus.IsEnabled property.
>
> BUG=472183,468989,468112
> TBR=stevenjb@chromium.org,jochen@chromium.org
>
> Committed: https://crrev.com/16e2d5a386e3ddd5be818a0d27610b1e9ee9c08e
> Cr-Commit-Position: refs/heads/master@{#328651}
TBR=dmazzoni@chromium.org,plundblad@chromium.org,l.gombos@samsung.com,jochen@chromium.org,stevenjb@chromium.org,dpranke@chromium.org,k.czech@samsung.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=472183,468989,468112
Review URL: https://codereview.chromium.org/1124173005
Cr-Original-Commit-Position: refs/heads/master@{#329404}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c7c15e712cb77a0fe276166996b2bb787490c896
Linux Aura accessibility is not enabled on desktops different than GNOME2.
GNOME3 has deprecated gconf in favor of gsettings and dconf.
AT-SPI (cross-platform framework that provides communication between AT
and application) bus launcher has a property called org.a11y.Bus.IsEnabled
that could be easily read by dbus call.
In generall this patch adds an additional check to enable accessibility.
When gconf is available use gnome's accessibility key otherwise
org.a11y.Bus.IsEnabled property.
BUG=472183,468989,468112
TBR=stevenjb@chromium.org,jochen@chromium.org
Review URL: https://codereview.chromium.org/1028553003
Cr-Original-Commit-Position: refs/heads/master@{#328651}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 16e2d5a386e3ddd5be818a0d27610b1e9ee9c08e
Regarding the latest code on linux,
It was always setting by default language even if value of language was existed.
So we need to add routine for setting language via "spd_set_language".
BUG=289548
Review URL: https://codereview.chromium.org/1043933002
Cr-Original-Commit-Position: refs/heads/master@{#326764}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ff4018b80395433657222d6eb0483b2349b1e007
This switches the USE_OPENSSL Linux and CrOS builds to continue
setting USE_NSS_CERTS. This lets it use BoringSSL for the crypto
and SSL stack and NSS for certificate verification. See design
doc for details on the flags:
https://docs.google.com/document/d/1x4DOCKwFkAxl9MGfd6snIzFigO4ku6Shuci0r5BzasQ/edit
On Linux, only client auth and OCSP stapling are missing. On ChromeOS,
there are some problematic USE_NSS_CERTS APIs in RSAPrivateKey to
resolve. We also still need to resolve crbug.com/347404 to maintain
parity.
As a follow-up, USE_OPENSSL_CERTS on non-Android can now be
removed (it was never supported anyway).
BUG=462040
Review URL: https://codereview.chromium.org/881213004
Cr-Original-Commit-Position: refs/heads/master@{#326222}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2bcbc6bceb6017c762ef01553a55a12fe390de16
I think it's safe to re-enable this warning now. The bug was
fixed upstream in 3.15.1 and there have been several NSS upgrades since then.
BUG=255201
Review URL: https://codereview.chromium.org/1028863002
Cr-Original-Commit-Position: refs/heads/master@{#321711}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 86ebf48be903b226d068b08efa16fe3725babb8c
This makes it possible to refer to the platform as DRI and DRM. We need
this intermediate state so we can update the CrOS builds to use DRM
rather than DRI.
BUG=none
TEST=Build ozone with DRI & DRM platform and without to verify build
(GYP and GN)
Review URL: https://codereview.chromium.org/957253005
Cr-Original-Commit-Position: refs/heads/master@{#320788}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d89b572673f0fd352ae9d14e69b79e0430c87fbd
Reason for revert:
Caused compile failure on Linux x64 bot (http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/56532)
Output snippet:
FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash ../out/Release/installer/debian/build.sh -o../out/Release -b ../out/Release -a x64 -c unstable
dpkg-shlibdeps: warning: binaries to analyze should already be installed in their package's directory.
2a3
> libatk1.0-0 (>= 1.12.4)
ERROR: Shared library dependencies changed!
If this is intentional, please update:
chrome/installer/linux/debian/expected_deps_ia32
chrome/installer/linux/debian/expected_deps_x64
Original issue's description:
> Resurrect Aura Linux accessibility.
>
> This is based in part on the ATK code we had as part of the Linux GTK port
> that went away, but now rewritten on top of AXPlatformNode. This patch
> successfully exposes an accessibility tree for Views and exposes top-level
> windows and the the role and name of each View. You can test it using
> accerciser. This is just to get the infrastructure in place - we need to
> implement more of the interface for it to be useful for accessibility tools.
>
> BUG=463671
>
> Committed: https://crrev.com/f65bad877350b5f7857d29e4b1b0d4d3f5c7cb6d
> Cr-Commit-Position: refs/heads/master@{#320383}
TBR=plundblad@chromium.org,dpranke@chromium.org,sky@chromium.org,gunsch@chromium.org,dmazzoni@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=463671
Review URL: https://codereview.chromium.org/1002993002
Cr-Original-Commit-Position: refs/heads/master@{#320402}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 999e4c26444e68898d4fa642783263b6e408b7e3
This is based in part on the ATK code we had as part of the Linux GTK port
that went away, but now rewritten on top of AXPlatformNode. This patch
successfully exposes an accessibility tree for Views and exposes top-level
windows and the the role and name of each View. You can test it using
accerciser. This is just to get the infrastructure in place - we need to
implement more of the interface for it to be useful for accessibility tools.
BUG=463671
Review URL: https://codereview.chromium.org/975113002
Cr-Original-Commit-Position: refs/heads/master@{#320383}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f65bad877350b5f7857d29e4b1b0d4d3f5c7cb6d
Since the BoringSSL switch, this cannot possibly work. (There isn't an
openssl.gyp to swap out anyway.)
BUG=none
Review URL: https://codereview.chromium.org/859073002
Cr-Original-Commit-Position: refs/heads/master@{#312452}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2b60792760a1291c50594f213a0bc5e71d020e4d
This adds a use_xkbcommon variable that allows usage of libxkbcommon in
the build. Turn this on for linux ozone builds (except embedded builds).
BUG=430194
TEST=build
Review URL: https://codereview.chromium.org/751623003
Cr-Original-Commit-Position: refs/heads/master@{#308204}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 304529e882cd79826c1b8f222a0e855da2ba8a59
Add a new gyp variable: use_libpci (default value is 1).
Add a new define when use_libpci==1: USE_LIBPCI.
Don't call specific PCI code in gpu_info_collector_linux.cc if USE_LIBPCI isn't defined.
BUG=427401
R=piman@chromium.org
Review URL: https://codereview.chromium.org/692893004
Cr-Original-Commit-Position: refs/heads/master@{#302613}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 65ce5accb99908e292b9766c3da6cf54d6cc337f
install-debian.wheezy.sysroot.py is now use for ARM
also, removing duplication. sysroot location is also
now consistent.
Review URL: https://codereview.chromium.org/664383004
Cr-Original-Commit-Position: refs/heads/master@{#300746}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 41d0e08a38f6cc0cb32a2596953a7262c4a9ab02
We are checking gbm system library and cflags using pkg, therefore its
directory ought to be checked in the same way.
I spotted this problem in a Ubuntu 12.04 system where my custom pkg directory
is rather clean, without superfluous libraries. Probably no other developer
noticed this bug before because in the working pkg directory was already being
pulled in by libgestures or any other configuration that uses --libs-only-L
in system.gyp.
BUG=none
TEST=embedded=1 ozone_platform_gbm=1, linking content_shell
Review URL: https://codereview.chromium.org/553793002
Cr-Original-Commit-Position: refs/heads/master@{#293903}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5cdbf79d872e2bbdcf8994da76ef156bc9bacbbc
The GLIB_DISABLE_DEPRECATION_WARNINGS define disables the deprecation
warnings which is caused by the usage of the g_settings_list_schemas
method. Moving the define to the build scripts avoids any future build
errors (-Werror) and warning reports.
BUG=391250
TEST=ninja -C out/Release chrome
Review URL: https://codereview.chromium.org/367113004
Cr-Original-Commit-Position: refs/heads/master@{#292608}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3a31d8e495b1d04a01f9e6c57fac608fee0285e3
So we don't break builds that don't use it by running pkg-config, and so
we don't accidently link against it when it is disabled.
The embedded=1 build has OS=="linux" use_udev==0 for small devices such
as the chromecast.
BUG=403162
Review URL: https://codereview.chromium.org/467983002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@290377 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Reason for revert:
Breaks builds where use_udev==0 since certain targets just assume udev and never check against use_udev.
Udev package should be wrapped in a use_udev confitional altogether and all the locations using Udev should check against use_udev.
Original issue's description:
> Run pkg-config for Udev only if use_udev==1
>
> Some embedded platforms do not have udev support. The change will skip
> running pkg-config if use_udev=0.
>
> BUG=none
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288770TBR=brettw@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/469763002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@289280 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
When CL 430573002 landed, it forced the use of libpci on linux, but
many embedded systems lack this library (and probably lack a pci bus
altogether). Let's add a new config variable to make it possible to
disable the use of libpci.
BUG=398416
Review URL: https://codereview.chromium.org/462433002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@289262 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This is a reland of r284079 which was reverted in r284248 for components build
issues. That, in turn, was a reland of r283813 which was reverted in r283845
because it broke WebRTC tests on Android. That, in turn, was a reland of
r283542 which was reverted in r283591 because it broke the WebView build.
This is a much larger change than its diff suggests. If it breaks
something, please revert first and ask questions later.
BUG=393317
R=agl@chromium.org, jam@chromium.org
Review URL: https://codereview.chromium.org/401153002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@284729 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
(This is a reland of r283813 which was reverted in r283845 because it broke
WebRTC tests on Android. That, in turn, was a reland of of r283542 which was
reverted in r283591 because it broke the WebView build.)
This is a much larger change than its diff suggests. If it breaks
something, please revert first and ask questions later.
BUG=none
Review URL: https://codereview.chromium.org/401613008
git-svn-id: http://src.chromium.org/svn/trunk/src/build@284079 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The //build directory in GN shouldn't refer to anything outside of itself so that non-Chrome projects can copy it and re-use the build configuration. speechd relies on third_party/speech-dispatcher. This patch just moves the loader to the speech-dispatcher target, which makes more sense anyway.
TBR=grunell@chromium.org
Review URL: https://codereview.chromium.org/377403002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@282138 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
We ran "python detect_host_arch.py" ~15 times from gyp. Run
detect_host_arch.py directly from from within gyp for faster execution
and since the path is no longer part of the command, the result will
also be cached more often.
The total gain is at best 0.3 seconds. For most people it will be less.
BUG=362075
Review URL: https://codereview.chromium.org/256303003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@275361 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
We already have a variable for tracking the system libdir name in the
gyp files, so let's use that instead of hardcoding the logic based on
the arch.
BUG=chromium:219015
TEST=`cbuildbot amd64-generic-tot-chrome-pfq-informational` works
Review URL: https://codereview.chromium.org/244593002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@272792 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Speculative revert because we think this might have caused Mac Build bot
failure "gyp: Call to 'python ../../../build/mac/find_sdk.py 10.6' returned exit status -9."
> ozone: Add egltest platform
>
> This supports testing rendering using EGL. Creation of the
> EGLNativeWindowType is punted to a separate library, which has an
> interface defined in eglplatform_shim.h.
>
> TEST=content_shell --ozone-platform=egltest --ignore-gpu-blacklist
> BUG=none
> NOTRY=true
>
> Review URL: https://codereview.chromium.org/288603002TBR=spang@chromium.org
Review URL: https://codereview.chromium.org/288013002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@270474 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This supports testing rendering using EGL. Creation of the
EGLNativeWindowType is punted to a separate library, which has an
interface defined in eglplatform_shim.h.
TEST=content_shell --ozone-platform=egltest --ignore-gpu-blacklist
BUG=none
NOTRY=true
Review URL: https://codereview.chromium.org/288603002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@270471 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The status quo was unmaintainable. These 'component build specific .isolate
files' are superseeded by tools/isolate_driver.py which packages dynamic
libraries automatically.
The new way is much more sane and dynamic, isolate_driver.py is currently very
crude but 'does the job', the expected way to make it work is to read the .ninja
files to extract all the dynamic libraries marked as a dependency to the main
target being executed.
TBR=csharp@chromium.org
BUG=333473
Review URL: https://codereview.chromium.org/226123004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@261871 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Since r257419, linker warning starts to cause the build failure.
This CL is fixing some linker warnings on cross compilation build so that build with target_arch=ia32 option works properly.
Here are the error logs:
/usr/bin/ld: skipping incompatible /lib/x86_64-linux-gnu/libgcrypt.so when searching for -lgcrypt
/usr/bin/ld: skipping incompatible /lib/x86_64-linux-gnu/libgcrypt.a when searching for -lgcrypt
/usr/bin/ld: skipping incompatible /lib/x86_64-linux-gnu/libcap.so when searching for -lcap
/usr/bin/ld: skipping incompatible /lib/x86_64-linux-gnu/libcap.a when searching for -lcap
/usr/bin/ld: warning: libgnutls.so.26, needed by /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../lib32/libcups.so, may conflict with libgnutls.so.28
BUG=n/a
TEST=build with GYP_DEFINES=target_arch=ia32, run trybot.
Review URL: https://codereview.chromium.org/202633008
git-svn-id: http://src.chromium.org/svn/trunk/src/build@259463 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Right now when supplying a 32-bit sysroot via the 'sysroot' GYP flag on a 64-bit host arch,
pkg-config (and pkg-config-wrapper) fail to generate the correct 32-bit paths within that sysroot.
The solution is to chroot into that directory and run pkg-config from there.
This is intended to work with schroot scripts like 'precise32' generated when running build/install-chroot.sh
BUG=324207
R=piman@chromium.org
Review URL: https://codereview.chromium.org/163583003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@251353 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
chrome/browser/extensions/extension_commands_global_registry_apitest.cc,
which is linked into interactive_ui_tests, uses some functions from libXtst
and thus should declare a dependency on xtst. The only other file that uses
the XTest.h header is in remoting, which declares an xtst dependency already.
This lets us drop the dependency from glib on xtst since most targets don't need
it.
R=phajdan.jr
BUG=339518
Review URL: https://codereview.chromium.org/153893011
git-svn-id: http://src.chromium.org/svn/trunk/src/build@250585 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This converts the remaining targets that depend on X11 libraries over to
depending on targets from build/linux/system.gyp instead of adding the
libraries manually to the link line. This ensures that the link line is
generated with pkg-config and makes the dependencies a bit tighter by
getting rid of the all_dependent_settings entry in ui/ui.gyp
BUG=339518
Review URL: https://codereview.chromium.org/151713003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@250311 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This sets up gyp targets for the various X11 libraries we use and uses
pkg-config to determine the correct cflags/ldflags incantations to use to
link against them instead of listing out -lXfoo lines in libraries sections
in gyp targets throughout the tree. This is more likely to generate the right
lines and makes the dependencies a bit more explicit.
BUG=339518
Review URL: https://codereview.chromium.org/153223002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@248939 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The `file` program follows POSIX as outlined here:
http://pubs.opengroup.org/onlinepubs/9699919799/utilities/file.html
Specifically, this part causes troubles:
If the file named by the file operand does not exist, cannot be read, or
the type of the file named by the file operand cannot be determined, this
shall not be considered an error that affects the exit status.
With older versions of `file` (that does not conform to POSIX), this
script will exit 0 with "unknown" as its output when "$1" does not exist.
But with recent releases (that conform to POSIX), this script will exit 1
and can break the build.
Have the script explicitly check for the existence of $1 and if it does
not exist, then runt he unknown logic like normal.
BUG=chromium:332547
TEST=ran python_arch.sh on bogus files with new & old `file` programs
Review URL: https://codereview.chromium.org/137433002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@244778 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The dependency is unnecessary and causes build error in the standalone webrtc project due to missing base.gyp when SCTP is enabled (it depends on usrsctp.gyp, which depends on system.gyp). All system.typ needs from base.gyp is the "include_dirs" pointing to ".." relative to "base". So we can remove the dependency on base.gyp and add "include_dirs":["../.."] instead.
BUG=
Review URL: https://codereview.chromium.org/128933005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@243863 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
slan
johannkoenig
Michael Spang
akuegel
chrishtr
sbc
erg
dpranke
kalyan.kondapally
tfarina
dnicoara
brettw
thestig
simonhatch
k.czech
djmix.kim
davidben
Paweł Hajdan, Jr
sigbjornf
mostynb
Dominic Mazzoni
alexmos
agoode
sfunkenhauser
bedupont
derat
tiago.vignatti
pgal.u-szeged
spang@chromium.org
sbc@chromium.org
dnicoara@chromium.org
mostynb@opera.com
phajdan.jr@chromium.org
davidben@chromium.org
agl@chromium.org
vitalybuka@chromium.org
brettw@chromium.org
bratell@opera.com
thestig@chromium.org
vapier@chromium.org
plundblad@chromium.org
vrk@chromium.org
sadrul@chromium.org
joone.hur@intel.com
maruel@chromium.org
hidehiko@chromium.org
glider@chromium.org
petarj@mips.com
kalyan.kondapally@intel.com
jamesr@chromium.org
elan.ruusamae@gmail.com
rsleevi@chromium.org
hinoka@google.com
jiayl@chromium.org
thakis@chromium.org
jln@chromium.org