This is the initial landing of a component extension to handle file open, save-as, and file management user interfaces. This is just the basic plumbing, minus any useful functionality.
I've tested this by building with...
$ export GYP_DEFINES='file_manager_extension=1'
$ make chrome -j16
Then launch the result and visit chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/main.html, and verify that the <h1> tab is blue, and the document contains "Hello World".
BUG=chromium-os:11988
TEST=
Review URL: http://codereview.chromium.org/6588053
git-svn-id: http://src.chromium.org/svn/trunk/src/build@76408 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
To make it possible to change the exact plugin command line without a master restart, the command line is loaded from a bash script. This script is used if clang_use_chrome_plugins and clang are both set in GYP_DEFINES when runhooks runs.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6461026
git-svn-id: http://src.chromium.org/svn/trunk/src/build@74597 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
V8 hosts the actual extension code under src/extensions/experimental/i18n-extension.{cc,h}.
This CL passes command line switches to WebKit (disabled by default) and test shell (enabled by default), using WebRuntimeFeatures. It also sets some gyp variables to point to ICU source path, and defines a guard for a new feature.
It should be submitted only after corresponding WebKit CL (https://bugs.webkit.org/show_bug.cgi?id=49414) lands.
BUG=28604
TEST=LayoutTests/fast/js/i18n-bindings-locale.html
Review URL: http://codereview.chromium.org/6366021
git-svn-id: http://src.chromium.org/svn/trunk/src/build@74491 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
I was confused why we were getting warnings related to format
strings, since they are off in gcc unless you use -Wall or
explicitly enable it, but it turns out that the man page calls
out that it is specially enabled on Ubuntu.
Review URL: http://codereview.chromium.org/6469002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@74351 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
- Turned support for EGL image ON for OpenMAX decoding.
- Added simple fix for compilation issue due to missing definition for MessageLoop.
- Added changes to GLES Video Renderer to use EGL image.
- Added H264BitstreamConverter and H264BitstreamConverterFFmpegAdaptor classes to Chromium.
- Introduced new h264 bitstream converter to FFmpegDemuxer
- Added h264 bitstream converter related classes to media targets and introduced new target for unit testing bitstream converter.
Patch by vmr@chromium.org:
http://codereview.chromium.org/6260010/
BUG=None
TEST=Test H.264 decode clip with player_x11 OpenMAX enabled.
git-svn-id: http://src.chromium.org/svn/trunk/src/build@73839 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
6 new languages on Linux if gyp is run with with
use_third_party_translations=1.
I also moved the translations from src/chrome/third_party to
src/third_party, since the translations cover more than chrome/.
Review URL: http://codereview.chromium.org/6410010
git-svn-id: http://src.chromium.org/svn/trunk/src/build@73381 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Turn it off by default and add conditions to chromium_strings.grd
for third_party specific outputs.
Add the ability to filter xtb files (translations) using if nodes.
TEST=still able to compile chrome
Review URL: http://codereview.chromium.org/6392033
git-svn-id: http://src.chromium.org/svn/trunk/src/build@73314 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
With this CL, one can run
GYP_DEFINES='clang=1 clang_load=/Users/thakis/src/llvm-svn/tools/clang/examples/PrintFunctionNames/libPrintFunctionNames.dylib clang_plugin=print-fns' gclient runhooks
and then the normal build will run with the clang example plugin.
I'm not sure if this is the best way to run Elliot's plugin, but it's useful for local one-off runs.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6355010
git-svn-id: http://src.chromium.org/svn/trunk/src/build@72924 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
-Wbool-conversion warns about EXPECT_EQ(false, blah), so replace
that with EXPECT_FALSE(blah). Do the same with EXPECT_EQ(true, blah)
for good measure (even though that doesn't generate warnings).
Also remove the one instance of an unused variable.
BUG=69421
TEST=buildbots all compile and all tests pass
Review URL: http://codereview.chromium.org/6300001
git-svn-id: http://src.chromium.org/svn/trunk/src/build@71431 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
of 32/64 bits, as they have been causing out of memory errors even on
64-bit builders.:
chrome_frame_tests
chrome_frame_perftests
chrome_dll_nacl_win64
browser_tests
nacl_ui_tests
nacl_sandbox_tests
sync_integration_tests
interactive_ui_tests
BUG=none
TEST=it builds
Review URL: http://codereview.chromium.org/6113006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@71077 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
There are two issues fixed:
1. Code didn't compile.
2. The remoting section in option was shown even without --enable-remoting.
BUG=None
TEST=Try to compile with remoting=0 and verify that Remoting doesn't show up in advanced options
Review URL: http://codereview.chromium.org/6174005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@70976 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
have to repeat the logic for it in a bunch of different places.
I had to add another level of variables{} so I could use use_titlecase_in_grd_files in a condition. I also removed some quotes around default values since that seems to be the more common way to express boolean values.
BUG=68028
Review URL: http://codereview.chromium.org/6070011
git-svn-id: http://src.chromium.org/svn/trunk/src/build@70757 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
(from inside the renderer sandbox).
(Only enabled on ChromeOS, since it opens a hole in the renderer. This should be
revisited, with controls tightened, once Flapper runs out of process.)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5098002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@70687 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
- Organizing variables dicts as
1) vars copied from inner scopes
2) new vars defined in current scope
3) conditions
- moving variables out of inner scopes when possible
- cleaning up/consolidating some comments
This is just a refactoring and shouldn't change any of the logic.
Review URL: http://codereview.chromium.org/6015016
git-svn-id: http://src.chromium.org/svn/trunk/src/build@70667 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This checks in harbuzz-ng b0d396aa88b3cdf8cea896bfeeba197656e1cdb1.
Setting use_harfbuzz_ng to 1 in gyp will cause us to build
harfbuzz-ng in place of harfbuzz. So far this currently fails to
compile due to all our other code relying on the old API.
BUG=68551
TEST=./build/gyp_chromium -Duse_harfbuzz_ng=1, verify build breaks
Review URL: http://codereview.chromium.org/6052008
git-svn-id: http://src.chromium.org/svn/trunk/src/build@70539 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Adjusting seccomp through the .gyp file is error-prone and confusing.
Instead, because all callers call SeccompSandboxEnabled(), if I
want to enable it for some build configuration I can adjust just that
function.
This change removes all the build-time seccomp configuration and
leaves it defaulted off. It should have no change on whether seccomp
is enabled.
Review URL: http://codereview.chromium.org/5844001
git-svn-id: http://src.chromium.org/svn/trunk/src/build@69208 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This allows us to test experimental library features, and to track a known openssl version.
Also bumps OpenSSL 65717:68738, to fix up the default CA root path in the reference library.
BUG=None
TEST=Still builds & runs!
Review URL: http://codereview.chromium.org/5625012
git-svn-id: http://src.chromium.org/svn/trunk/src/build@68749 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The shared build is a quick hack for quick links; we don't need
to optimize the link line and, in fact, doing so breaks the v8
link.
(Fix from Craig Schlenter <craig.schlenter@chromium.org>.)
BUG=61430
TEST=build chrome with GYP_DEFINES=library=shared_library and BUILDTYPE=Release
Review URL: http://codereview.chromium.org/5578007
git-svn-id: http://src.chromium.org/svn/trunk/src/build@68542 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This change is the Chromium-side change that integrates libjpeg-turbo into Chromium. (We need another change for WebKit.) It adds a GYP option 'libjpeg_turbo' so we can switch from libjpeg to libjpeg-turbo and use libjpeg-turbo when its value is 1. (Unfortunately, its value must be 0 for now to avoid build breaks until we land all changes required for libjpeg-turbo.)
BUG=48789
TEST=build Chromium.
Review URL: http://codereview.chromium.org/5292007
git-svn-id: http://src.chromium.org/svn/trunk/src/build@68453 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
the *first* element in the pathname (ie- mac/foo.mm). But luckily, the
other rules have caught the places where this bug would have hit, but
nothing says that will always be true.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4915001
git-svn-id: http://src.chromium.org/svn/trunk/src/build@66118 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Turn on use_cups for the Mac, add in the required library, and tweak the code
to get it linking. There is still more work to do; this is just a gyp-oriented
change to get things started.
BUG=none
TEST=All targets still build on all platforms.
Review URL: http://codereview.chromium.org/4167006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@64441 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This is early in-progress implementation, no cert handling supported. So only available under a build-time flag. (GYP_DEFINES="'use_openssl=1'")
Adds a new build dependency for system OpenSSL libraries, and a new USE_OPENSSL define. Eventually this will disable USE_NSS but for now the two coexist.
BUG=none
TEST=build with use_openssl=1. Goto some https:// pages.
Review URL: http://codereview.chromium.org/3495005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@60936 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
To build, set the clang=1 gyp_define.
This patch is the culmination of many months of effort and many
patches. It contains the minimal changes to Chrome that
are Clang-specific.
With this, I can build the "chrome" target. Once this patch
is in, we can incrementally fix bits of Chrome and various
tests and remove the Clang-specific workarounds.
Review URL: http://codereview.chromium.org/522020
git-svn-id: http://src.chromium.org/svn/trunk/src/build@59882 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Add 'fa' entry to all the grd files.
For *locale_settings*, create new xtb files for Farsi (copied from Arabic).
Also, pulls in ICU @r=58904 (with Farsi data).
locale_settings_fa.xtb has a lot of UI dimensions that may not work
well in Farsi. We need LQA to take a look at them.
terms_FOO.html is not yet available for Farsi as well as Amharic and Swahili. Tentatively, use
terms_en.html.
BUG=45505
TEST='chrome --lang=fa' on Windows should bring up Chrome in Farsi. 'LANGUAGE=fa chrome' should do the same on Linux. (on Ubuntu, 'language-pack-gnome-fa' and 'language-pack-fa' have be installed to get Chrome in Farsi with the UI mirrored).
Review URL: http://codereview.chromium.org/3296013
git-svn-id: http://src.chromium.org/svn/trunk/src/build@58998 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Add the policy templates generated from chrome/app/policy_templates.json to the Mac application bundle. (The template generator for Mac is implemented in CL 3116027) Also remove the old manifest file and references to translations that are not there yet.
The problem with the previous landing attempt was that in Release mode build, the following script was looking for binary files that were not there: build/mac/strip_from_xcode
BUG=49316
TEST=add Chromium to the managed applications' list in the OSX Workgroup Manager, and see if it shows the manageable preferences with English descriptions
Review URL: http://codereview.chromium.org/3287003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@58366 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
heap leak checker to unwind the memory allocation stacks better.
Currently, if a memory region is allocated from a library built without frame
pointers heapchecker is unable to unwind the stack and records only the top
frame. This is inconvenient, because:
-- several leaks from different places are treated as leaks from the same
source
-- it's hard to suppress such leaks, because a one-line suppression is
uninformative
linux_shadow_stacks.cc keeps the threads' IP and SP values in thread-local
stacks upon each function entry/exit using gcc function instrumentation
(-finstrument-functions).
The GetStackTrace routine from stacktrace_shadow-inl.h unwinds the stack as
usual (using frame pointers), but then updates the result with the shadow stack
frames which SP values are below the bottom frame of the unwind result.
Note that -finstrument-functions affects only Chromium code, not the libraries.
This means that we cannot get more than one library function frame at the top
of the stack.
For example, consider a libfoo library that has a public foo_do_something()
routine which allocates memory via foo_alloc(). If Chromium calls
foo_do_something() from ChromeCallFoo(), then the following call chain
effectively happens:
main -> ChromeCallFoo -> foo_do_something -> foo_alloc
If libfoo is built with -fomit-frame-pointers, heapcheck can unwind only the
last stack frame:
foo_alloc
On the other hand, the shadow stack at the allocation site contains everything
below the libfoo calls:
main -> ChromeCallFoo
As a result the following allocation stack is recorded:
main -> ChromeCallFoo -> foo_alloc
This is enough to distinguish between e.g. ChromeCallFoo1 and ChromeCallFoo2
Review URL: http://codereview.chromium.org/3120017
git-svn-id: http://src.chromium.org/svn/trunk/src/build@57658 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
For example, there are differences between unit_tests and browser_tests,
which cause ridiculous problems when moving a test between those.
We're using the symbols anyway, so let's centralize it for maintainability.
TEST=compile
BUG=none
Review URL: http://codereview.chromium.org/3173044
git-svn-id: http://src.chromium.org/svn/trunk/src/build@57555 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Having -rdynamic breaks some plugins since it exports more symbols into
the dynamic symbol table than wanted. In particular, this breaks users of
ppapi's C++ wrappers. It was added to make StaceTraces resolve to symbols
on linux. But now we use the symbolize library from glog so it isn't needed
anymore.
BUG=52105
TEST=Compiles and StackTrace.* test in base_unittests will work.
Review URL: http://codereview.chromium.org/3119033
git-svn-id: http://src.chromium.org/svn/trunk/src/build@56924 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
chrome: create an option for using libcros provided by the system; fix all
includes referring to libcros to not include third_party/
* Headers fix is needed to support using system libcros (installed to /usr/include)
* All includes are "", and therefore a local variant in third_party/cros/ is
always preferred, but system will also get picked up as a secondary target
* Fixed chrome/browser/chromeos/cros/synaptics_library.h comments to better
reflect the header placement
* Added a variable system_libcros defaulting to 0
* Gotten rid of duplicate cros_api.gyp
* Changed both places to either link against cros_api or libcrosapi
TEST=build in the following scenarios:
1) libcros not installed, libcros sources in third_party/, !defined system_libcros
- sucess
2) installed libcros, put #error into /usr/include/cros/chromeos_cros_api.h, repeat 1)
- success
3) BUILD_DEFINES+=system_libcros=1, removed libcros from third_party, repeat 2)
- fail (on #error in chromeos_cros_api.h)
4) Installed clean libcros, repeat 3)
- success
Review URL: http://codereview.chromium.org/3043010
git-svn-id: http://src.chromium.org/svn/trunk/src/build@53288 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Defined TOUCH_UI flag to wrap touch-related code
Added a gyp flag touchui that enables a TOUCH_UI cpp define to wrap
forthcoming touch-related code.
BUG=NONE
TEST=Compiled with and without touchui set via include.gypi
Review URL: http://codereview.chromium.org/3026001
git-svn-id: http://src.chromium.org/svn/trunk/src/build@52551 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Add in two extra libraries needed for building Chromium-for-Chromium OS on a fresh install Ubuntu Lucid 64-bit. Also, start checking for header differences between the 32-bit and 64-bit packages, adding those headers into the 32-bit cons'ed up package install (on Lucid Lynx, the current libcurl4-gnutls-dev package needs this). Clean up any leftover symbolic links that point nowhere. Also take any declared package conflicts and remove them from the Provides line to allow the cons'ed up package to always install (the package derived from libcurl4-gnutls-dev).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2865032
git-svn-id: http://src.chromium.org/svn/trunk/src/build@51863 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
points to avoid the need to link against opengl32.lib. Added
_ATL_NO_OPENGL #define in build/common.gypi to prevent link directive
from forcibly pulling in opengl32.lib for any Chrome code using ATL.
Once upstream code in WebKit is changed to use the new wglew entry
points and remove opengl32.lib from the link line, chrome.dll will no
longer depend on opengl32.dll.
BUG=45586
TEST=ran WebGL with --in-process-webgl
Review URL: http://codereview.chromium.org/2856022
git-svn-id: http://src.chromium.org/svn/trunk/src/build@51277 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
rginda@chromium.org
hbono@chromium.org
jshin@chromium.org
hans@chromium.org
thakis@chromium.org
jschuh@chromium.org
evan@chromium.org
cira@chromium.org
scherkus@chromium.org
tony@chromium.org
erg@google.com
davemoore@chromium.org
timurrrr@chromium.org
petkov@chromium.org
agl@chromium.org
joi@chromium.org
sergeyu@chromium.org
viettrungluu@chromium.org
joth@chromium.org
thomasvl@chromium.org
phajdan.jr@chromium.org
mirandac@chromium.org
maruel@chromium.org
scottbyer@google.com
scottbyer@chromium.org
vangelis@chromium.org
thestig@chromium.org
cbentzel@chromium.org
nsylvain@google.com
bulach@chromium.org
gfeher@chromium.org
pmehta@chromium.org
glider@chromium.org
ajwong@chromium.org
nirnimesh@chromium.org
sky@chromium.org
zelidrag@chromium.org
kbr@google.com