Currently all 1x art files are repacked into chrome.pak files.
This is a problem on Windows where we want to choose which pak file to load based on metro and DPI scale.
As a first step this CL does the following:
- add a new enable_hidpi build flag. This allows us to test HiDPI mode on Windows Chrome.
- stop packing theme_resources_standard.pak and ui_resources_standard.pak into chrome.pak
- update the Mac and Windows installer code to package the extra pak files.
Note, I'll be updating the Linux installer script in a separate CL. I'm still looking into the ChromeOS situation.
BUG=114311
TEST=Ran on Windows, and Mac and Linux.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132517
Review URL: http://codereview.chromium.org/10024050
git-svn-id: http://src.chromium.org/svn/trunk/src/build@132760 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Currently all 1x art files are repacked into chrome.pak files.
This is a problem on Windows where we want to choose which pak file to load based on metro and DPI scale.
As a first step this CL does the following:
- add a new enable_hidpi build flag. This allows us to test HiDPI mode on Windows Chrome.
- stop packing theme_resources_standard.pak and ui_resources_standard.pak into chrome.pak
- update the Mac and Windows installer code to package the extra pak files.
Note, I'll be updating the Linux installer script in a separate CL. I'm still looking into the ChromeOS situation.
BUG=114311
TEST=Ran on Windows, and Mac and Linux.
Review URL: http://codereview.chromium.org/10024050TBR=sail@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10103022
git-svn-id: http://src.chromium.org/svn/trunk/src/build@132529 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Currently all 1x art files are repacked into chrome.pak files.
This is a problem on Windows where we want to choose which pak file to load based on metro and DPI scale.
As a first step this CL does the following:
- add a new enable_hidpi build flag. This allows us to test HiDPI mode on Windows Chrome.
- stop packing theme_resources_standard.pak and ui_resources_standard.pak into chrome.pak
- update the Mac and Windows installer code to package the extra pak files.
Note, I'll be updating the Linux installer script in a separate CL. I'm still looking into the ChromeOS situation.
BUG=114311
TEST=Ran on Windows, and Mac and Linux.
Review URL: http://codereview.chromium.org/10024050
git-svn-id: http://src.chromium.org/svn/trunk/src/build@132517 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Interesting changes in this range:
* The tooling infrastructure landed. Not observable, but it makes it easier
to write clang tools.
* Honor -fno-pic, pie support
* Better diagnostics for several c++11 features
* Cross-compiler changes that hopefully make CrOs clang builds simpler
* Many LTO fixes
Also pick up a minor change to the style plugin: Instead of ignoring
problems below out/, it now ignores them below gen/ and geni/. This
should make it work better with custom build directories.
BUG=none
TEST=none
TBR=mark
Review URL: http://codereview.chromium.org/10081013
git-svn-id: http://src.chromium.org/svn/trunk/src/build@132350 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
While we sort out the remaining linker errors, this at least ensures we
can add compliation of a bunch of chrome code for Android to gatekeeper.
This is motivated by having the android unit_tests compilation step
broken 4 out of 4 days this week.
BUG=117407
Review URL: http://codereview.chromium.org/10065018
git-svn-id: http://src.chromium.org/svn/trunk/src/build@132154 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
When Chrome is built with -fprofile-generate in *_extra_cflags, it needs to link
against gcov. Adding -lgcov to the link line doesn't help because it occurs
before -Wl,--start-group. This flag correctly adds the required library if used
like the test case described below.
BUG=102550
TEST=GYP_DEFINES="debug_extra_cflags=-fprofile-generate libraries_for_target=-lgcov" ./build/gyp_chromium
make -j5 chrome # passes.
Review URL: http://codereview.chromium.org/10054022
git-svn-id: http://src.chromium.org/svn/trunk/src/build@132061 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This work is useful to make sure at build time that we are not accessing prefs that are not registered.
This CL addresses the prefs registered by:
BrowserInit::RegisterUserPrefs
PinnedTabCodec::RegisterUserPrefs
PluginsUI::RegisterUserPrefs
PromoResourceService::RegisterUserPrefs
Later CL:
Browser::RegisterUserPrefs
SyncPromoUI::RegisterUserPrefs
*::RegisterPrefs
BUG=120802
TEST=Compiled and made diff-ed the link error to make sure they are the same.
Review URL: http://codereview.chromium.org/9949033
git-svn-id: http://src.chromium.org/svn/trunk/src/build@131994 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Most of the included changes are minor. After this roll, we
have what went into the 1.6 release, and gmock now supports
being build as a DLL. (I want this roll for one of the minor
changes, which makes it possible to reenable
-Wnull-dereference for clang)
Turn -Wnull-dereference back on, fix one instance where a
violation snuck in.
BUG=111806
TEST=none
TBR=tony
Review URL: https://chromiumcodereview.appspot.com/9999025
git-svn-id: http://src.chromium.org/svn/trunk/src/build@131656 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Speculatively reverting due to gyp update error on official bots:
KeyError: 'src/breakpad/breakpad.gyp:dump_syms#target while trying to load target src/remoting/remoting.gyp:remoting_linux_symbols#target'
This is the only patch in the regression range that touches breakpad.gyp.
---
Upstream Android native crash handling changes.
This is actulaly the second time.
Revert "Revert 131404 - Upstream native crash handling changes for Android."
This reverts commit 421df96aab6267e963ddff16c9f738aa903a2cba.
Conflicts:
chrome/browser/chrome_browser_main.cc
BUG=
TEST=
Review URL: http://codereview.chromium.org/9967017TBR=carlosvaldivia@google.com
Review URL: https://chromiumcodereview.appspot.com/10037013
git-svn-id: http://src.chromium.org/svn/trunk/src/build@131600 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This is copied from integer version, instead of using
template, to minimize conflict with m19 branch, as
using template requires updating forward declaration
of these classes in many places.
I put this behind gyp flag for now so that we can move forward without breaking non DIP build until we can get aura
working with DIP.
BUG=114664
TEST=none
Review URL: http://codereview.chromium.org/10025004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@131405 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Android native crash handling is almost identical to linux handling with
some differences.
Note that even after this change Chrome on Android will not compile with
the USE_LINUX_BREAKPAD flag. Forthcomming changes in breakpad should
remedy this state of affairs.
BUG=
TEST=
Review URL: http://codereview.chromium.org/9838033
git-svn-id: http://src.chromium.org/svn/trunk/src/build@131404 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
dlldata.c is a generated file name that a bunch of idl build rules output but most do not actually compile it AFAICT. This was causing some targets in isimpledom (that contain multiple idl files) to output to the same name (dlldata.c), so uniquize it based on InputName. For the one target that seems to actually build dlldata.c, override back to the original name to keep things the same (iaccessible2).
Review URL: http://codereview.chromium.org/10008061
git-svn-id: http://src.chromium.org/svn/trunk/src/build@131232 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Move files in chrome/browser/chromeos/dbus/ to chromeos/dbus
Add chromeos/dbus/DEPS
Add chromeos.gyp:chromeos_test_support and chromeos.gyp:chromeos_unittests
Add CHROMEOS_EXPORT to classes
Move power related proto targets to chromeos.gyp
Rewrite and sort #includes
BUG=119583
TEST=component chromeos build success, checkdeps success
Review URL: https://chromiumcodereview.appspot.com/9838085
git-svn-id: http://src.chromium.org/svn/trunk/src/build@131065 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Before this change, if some test failed before the last test succeeded,
because of the return value, the buildbot will show that the last test also
failed. Add a summary build step to avoid that.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/9989001
git-svn-id: http://src.chromium.org/svn/trunk/src/build@130823 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Some of these suppressed tests no longer exist or were renamed. They
have not been failing since they were renamed, so it should be fine.
Additionally, in the case of the CertVerifier tests, these tests now
use a mock stub for testing caching behaviour, and thus no longer
block dependent on the system libraries.
R=wtc
BUG=117372, 67599
TEST=net_unittests
Review URL: https://chromiumcodereview.appspot.com/9965036
git-svn-id: http://src.chromium.org/svn/trunk/src/build@130419 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
sail@chromium.org
yfriedman@chromium.org
sky@chromium.org
zmo@google.com
hbono@chromium.org
thakis@chromium.org
jgreenwald@chromium.org
jrg@chromium.org
asharif@chromium.org
jscholler@chromium.org
alexeypa@chromium.org
carlosvaldivia@google.com
gdk@chromium.org
erg@google.com
maruel@chromium.org
msw@chromium.org
oshima@chromium.org
scottmg@chromium.org
hashimoto@chromium.org
wangxianzhu@chromium.org
rogerta@chromium.org
asvitkine@chromium.org
estade@chromium.org
rsleevi@chromium.org
olonho@google.com
apavlov@chromium.org
sergeyu@chromium.org
ericu@google.com
joi@chromium.org
bevc@google.com
cmp@chromium.org