gyp considers a shell variable substitution to have failed if it
generates any output to stderr, even if the exit status was zero.
This causes problems when gomacc automatically starts its proxy,
which helpfully reports "GOMA: Starting compiler proxy" to stderr.
Fixed by dropping stderr unless the underlying process returns
a non-zero exit status.
BUG=chromium-os:28670
TEST=Ran hooks normally and inside CrOS chroot, with and without
$CXX pointing to goma. A $CXX which writes to stderr and then
exits with failure still prints its output before the exception.
Review URL: http://codereview.chromium.org/10288005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@135663 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
How to native debug:
- apply the patch listed in the code review description
- adb_run_content_shell
- gdb_content_shell
- attach Eclipse; continue
- now boom! SEGV in gdb.
Sadly the native library crashes while loading so it's not registered
with gdb yet (e.g no symbols or stack).
This CL also adds in a file that got lost
(testing/android/README.chromium).
BUG=
TEST=
Review URL: http://codereview.chromium.org/10254028
git-svn-id: http://src.chromium.org/svn/trunk/src/build@135652 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Currently, the '-mfloat-abi=soft' is hard coded in the gyp file, but what we need is "-mfloat-abi=hard", since it is hard-coded, we no way to change it.
So this CL removed this hard-coded value, replaced it with variable arm_float_abi, which has a default value of 'soft'. Later in the ebuild file, we can easily override this value to be 'hard', thus make the build hardfp.
BUG=None
TEST=build manually in chromium
Review URL: http://codereview.chromium.org/10351018
git-svn-id: http://src.chromium.org/svn/trunk/src/build@135388 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This follows the same pattern for theme_resources_touch_1x as we used for ui_resources_touch. I also introduced a gyp flag for enable_touch_ui at sky's suggestion.
BUG=115234
TEST=visual, run with --touch-optimized-ui and see bigger tabstrip and toolbar assets
Review URL: https://chromiumcodereview.appspot.com/10320002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@134942 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Current Service can register and unrerister itself as a Windows Service.
This service is not part of the Chrome browser, but belongs to the
place as virtual print driver for cloud print.
BUG=125026
TEST=Build and verify service gets registered with "/Service" command. And unregistered with "/UninstallService" command.
Review URL: https://chromiumcodereview.appspot.com/10222011
git-svn-id: http://src.chromium.org/svn/trunk/src/build@134298 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This CL does the following:
- add a new enable_metro build flag
- if the build flag is set then add a new metro icon resource pak to chrome
- at run time if Chrome is running in metro mode AND ENABLE_METRO is set then use the metro icon resource pak
BUG=114311
TEST=
Review URL: http://codereview.chromium.org/10082020
git-svn-id: http://src.chromium.org/svn/trunk/src/build@133843 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Command for running with a test filter:
./build/android/run_tests.py -s
out/Release/base_unittests_apk/base_unittests-debug.apk -f
FileUtilTest.*
The _disabled file should be base_unittests-debug_disabled
BUG=
TEST=
Review URL: http://codereview.chromium.org/10214002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@133838 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Currently all 1x art files are repacked into chrome.pak files.
This is a problem on Windows where we want to choose which pak file to load based on metro and DPI scale.
As a first step this CL does the following:
- add a new enable_hidpi build flag. This allows us to test HiDPI mode on Windows Chrome.
- stop packing theme_resources_standard.pak and ui_resources_standard.pak into chrome.pak
- update the Mac and Windows installer code to package the extra pak files.
Note, I'll be updating the Linux installer script in a separate CL. I'm still looking into the ChromeOS situation.
BUG=114311
TEST=Ran on Windows, and Mac and Linux.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132517
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132760
Review URL: https://chromiumcodereview.appspot.com/10024050
git-svn-id: http://src.chromium.org/svn/trunk/src/build@133613 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
OFF by default; enable with a gyp var. E.g.
GYP_DEFINES="$GYP_DEFINES gtest_target_type=shared_library" android_gyp
Some useful commands:
adb uninstall org.chromium.native_test
adb install -r out/Release/base_unittests_apk/ChromeNativeTests-debug.apk
adb shell am start -n org.chromium.native_test/org.chromium.native_test.ChromeNativeTestActivity
For the moment, all apks can be built simultaneously but use the same
activity name. Thus you cannot have more than one installed at the
same time.
BUG=None
TEST=
Review URL: http://codereview.chromium.org/10051021
git-svn-id: http://src.chromium.org/svn/trunk/src/build@133053 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Currently all 1x art files are repacked into chrome.pak files.
This is a problem on Windows where we want to choose which pak file to load based on metro and DPI scale.
As a first step this CL does the following:
- add a new enable_hidpi build flag. This allows us to test HiDPI mode on Windows Chrome.
- stop packing theme_resources_standard.pak and ui_resources_standard.pak into chrome.pak
- update the Mac and Windows installer code to package the extra pak files.
Note, I'll be updating the Linux installer script in a separate CL. I'm still looking into the ChromeOS situation.
BUG=114311
TEST=Ran on Windows, and Mac and Linux.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132517
Review URL: http://codereview.chromium.org/10024050TBR=sail@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10115031
git-svn-id: http://src.chromium.org/svn/trunk/src/build@132804 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
cwolfe@chromium.org
jrg@chromium.org
tfarina@chromium.org
nsylvain@chromium.org
wangxianzhu@chromium.org
rvargas@google.com
simonmorris@chromium.org
csharp@chromium.org
ben@chromium.org
shenhan@google.com
alexeypa@chromium.org
james.wei@intel.com
rsleevi@chromium.org
jamescook@chromium.org
joi@chromium.org
maruel@chromium.org
dfalcantara@chromium.org
gene@chromium.org
dpranke@chromium.org
tedchoc@chromium.org
sail@chromium.org
nileshagrawal@chromium.org
yfriedman@chromium.org
petermayo@chromium.org
akalin@chromium.org
bryeung@chromium.org
gman@chromium.org
thakis@chromium.org
varunjain@chromium.org