Reason for revert:
Speculative revert to try to fix chrome_elf_unittests on Win7 x64.
http://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%282%29/builds/18370
AddDllsFromRegistryToBlacklist
LoadBlacklistedLibrary
I'll reland if that's not it.
Original issue's description:
> Disable exceptions on Windows also in the shared_library build
>
> They were previously only disabled in static_library builds. This is believed
> to have been due to problems with old MSVC versions, but it should work now.
>
> This change is relevant for Clang, which currently doesn't support exceptions
> on Windows.
>
> Last time I attempted to do this, it broke some tests due to a debug assertion.
> Gtest had previously been catching the exception, but with exceptions disabled
> it crashed. Those tests were actually broken in static_library Debug builds
> too, but we don't seem to have bots for that. After Blink r176189, we no longer
> hit that debug assertion, so the tests now pass.
>
> BUG=82385
> TEST=blink_platform_unittests --gtest_filter=DateTimeFormatTest.CommonPattern,
> content_browsertests --gtest_filter=RenderViewImplTest.SetEditableSelectionAndComposition
> webkit_unit_tests
>
> R=thakis@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284519TBR=maruel@chromium.org,thakis@chromium.org,hans@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=82385
Review URL: https://codereview.chromium.org/410613002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@284626 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
They were previously only disabled in static_library builds. This is believed
to have been due to problems with old MSVC versions, but it should work now.
This change is relevant for Clang, which currently doesn't support exceptions
on Windows.
Last time I attempted to do this, it broke some tests due to a debug assertion.
Gtest had previously been catching the exception, but with exceptions disabled
it crashed. Those tests were actually broken in static_library Debug builds
too, but we don't seem to have bots for that. After Blink r176189, we no longer
hit that debug assertion, so the tests now pass.
BUG=82385
TEST=blink_platform_unittests --gtest_filter=DateTimeFormatTest.CommonPattern,
content_browsertests --gtest_filter=RenderViewImplTest.SetEditableSelectionAndComposition
webkit_unit_tests
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/404853002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@284519 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This adds the missing conditions to the chrome/common GN build file (previously
only the basic files were there). Some refactoring of the GYP file to make this
possible.
Renames the enable_printing flag to printing_mode since this is an integer
tri-state.
Minor improvements to chrome/renderer
R=jamesr@chromium.org
Review URL: https://codereview.chromium.org/400243003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@284508 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
There had some CLs landed before to try fixing the flakiness of those webrtc tests on Android bot. But since the flakiness only happens on bots but not locally, so I enabled it again to see if those CLs help or not.
If any of the WebRTC tests still flake on bots, this CL should be reverted.
BUG=343604
TEST=bots
Review URL: https://codereview.chromium.org/408463002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@284413 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The ICU update does the following among other things:
- Update EUC-JP (no more JIS X 212 round-trip coverage) per WHATWG
encoding spec.
- Add CP866
- Add far better/more extensive support for plural, format, etc
- Numerous locale data update
- Khmer/Lao line/word-breaking support
- More compact Chinese/Japanese dictionary (now a part of the upstream
instead of our local patch)
- Better plural support that we plan to use right away.
- Update icu/BUILD.gn : file list update, new defines, etc.
- Update tests
a. icu_string_conversions_unittests : drop iscii (nobody uses it) and
remove JIS X 212 code points from the round-trip test
b. l10n_util_unittests: Display names for zh-*.
c. ThaiSnippet's expected result. (due to a Unicode grapheme definition change).
d. Update Expected results in file_manager_browsertest/test_util.js
(see http://crbug.com/383930)
- Update SpellcheckerWordIterator
a. Add U+0027 back to MidNumLet
b. Add Lao and Khmer scripts to the list of scripts requiring dictionary-based
word-breaking.
- l10n_util : alias 'tl' to 'fil' (Tagalog to Filipino)
- Update IdentityInternalsSingleTokenWebUITest.verifyGetters (DateTimeFormat-Full
has 'at' before time, which is not handled by Date.parse()
- update license.py because we don't have a separate Chinese/Japanese
dictionary any more. It's now a part of ICU
Note to Sheriff :
1. 140 ~ 200 kB size increase is expected for all platforms.
This size increase was singed off by laforge@.
The expected size has to be updated with both reva/revb pointing to the
revision corresponding to this CL.
2. http://codereview.chromium.org/348913002 has to be applied before running make_expectations.py to update tools/perf_expectations/perf_expectations.json
after this CL is landed.
BUG=132145,277023,136148,360433,364072
TEST=base_unittests:*ICU*, net_unittests:*IDN*, ui_unittests:*Lang*,
browser_tests (encoding related, Iden*verifyGet*),
unit_tests:Ext*L10*, unit_tests:*Lang*, component_tests:*Snipp*,
layout tests (encoding, date/calendar, line breaking, and others),
build 'base_i18n_nacl', GN build bots.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277111R=arv@chromium.org, brettw@chromium.org, fgorski@chromium.org, groby@chromium.org, hirono@chromium.org, tony@chromium.org, toyoshim@chromium.org
Review URL: https://codereview.chromium.org/265613002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@284167 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Previously the GN Windows build specified the symbol file $pdbfile but this variable was never defined, so the command like would just say "/Fd" and the default one would be used.
This patch defines some per-target variables in the ninja file for the toolchain to use. The Windows toolchain uses these to construct C- and C++-specific pdb files (the MS tools can't share between these two) for the current target.
BUG=
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/406453002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@284137 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This pulls in the following CLs:
- r1346 Don't free pointer in BasicCodeModules::BasicCodeModules before possibly using it
- r1347 Stringify minidump stream_type constants in minidump_dump output
- r1348 Ensure C:/Dumps/ exists in crash_generation_app
- r1349 Change some ELF utils to return the length as a size_t
- r1350 Add frame pointer recovery to the AMD64 Stackwalker.
- r1351 [Android]: Remove __system_property_get(ro.build.fingerprint) from
WriteOSInformation.
BUG=394841,393903
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284101R=mark@chromium.org
Review URL: https://codereview.chromium.org/400203002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@284134 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
(This is a reland of r283813 which was reverted in r283845 because it broke
WebRTC tests on Android. That, in turn, was a reland of of r283542 which was
reverted in r283591 because it broke the WebView build.)
This is a much larger change than its diff suggests. If it breaks
something, please revert first and ask questions later.
BUG=none
Review URL: https://codereview.chromium.org/401613008
git-svn-id: http://src.chromium.org/svn/trunk/src/build@284079 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Reason for revert:
This appears to have broken mojotest_instrumentation_tests with the errors like the ones listed below.
http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29/builds/20270
C 52.086s Main [FAIL] org.chromium.mojo.bindings.ConnectorTest#testErrors:
C 52.086s Main java.lang.NoClassDefFoundError: java.util.Objects
C 52.086s Main at org.chromium.mojo.bindings.MessageHeader.equals(MessageHeader.java:189)
C 52.086s Main at org.chromium.mojo.bindings.MessageWithHeader.<init>(MessageWithHeader.java:29)
C 52.086s Main at org.chromium.mojo.bindings.MessageWithHeader.<init>(MessageWithHeader.java:39)
C 52.086s Main at org.chromium.mojo.bindings.BindingsTestUtils.newRandomMessageWithHeader(BindingsTestUtils.java:85)
C 52.086s Main at org.chromium.mojo.bindings.ConnectorTest.setUp(ConnectorTest.java:53)
C 52.086s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
C 52.086s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
C 52.086s Main at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
C 52.086s Main at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
C 52.091s Main [CRASH] org.chromium.mojo.bindings.RouterTest#testReceivingViaRouterWithResponse:
C 52.091s Main Native crash: Segmentation fault
Original issue's description:
> Adding a router class to handle messages that expect responses.
>
> This also introduce the notion of message header to allow routing.
>
> R=rmcilroy@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283767
TBR=qsr
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/392223004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@284059 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
N.B. I had to move the sawbuck_provider in the .wxs out of the
installation directory. Even though it only contains registry changes,
candle will complain if it is not inside a directory, but the
application directory is platform specific, whereas sawbuck_provider is
always 32-bit.
BUG=394467
Review URL: https://codereview.chromium.org/398173002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@284007 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Otherwise if the devices are gone lots of tests will just fail.
Already fixed this for recipe based builders in crbug.com/393681
I don't know how to test this, but happy to write one if shown.
BUG=393681
NOTRY=True
Review URL: https://codereview.chromium.org/390993003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@283890 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
- Add explicit support for EnormousTest
- Warn at runtime if a test size annotation isn't recognized
(see: http://www.chromium.org/developers/testing/android-tests)
- Remove EnormousTest annotation from a test that wasn't actually using it
(it was effectively using the SmallTest timeout value at runtime).
- Add SmallTest annotation to InstallerDelegateTest (it was the only
set of tests that did not include these annotations).
TEST=ChromeShellTest instrumentation tests
BUG=392297
Review URL: https://codereview.chromium.org/376873008
git-svn-id: http://src.chromium.org/svn/trunk/src/build@283684 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This code is subtle. Since killing the host forwarder is a global operation, it
keeps a temp file with the shared pid and process start time so that it knows
whether the forwarder is the correct one that should be shared or a stray one
that should be killed.
This failed because not all of the sharded perf test processes had the same
parent pid. This caused the sharded tests to stomp on the global forwarder.
We didn't notice this previously because we only had narrow sharding, and 3
retries so the flake was papered over. When we added 8-way sharding on
chromium.perf, the flake rose to the level where it appeared every run.
This patch fixes it by using the process group instead of using the parent
process ID as a proxy.
BUG=163503
Review URL: https://codereview.chromium.org/391383005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@283683 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This changes the syntax from:
@(filepath:key0:key1)
to:
@FileArg(filepath:key0:key1)
This should make it much easier for someone who encounters this syntax
to figure out what it is (currently a `git grep FileArg` returns only
results about/using this feature).
Also changes it to use a simple regex search instead of adhoc stuff.
BUG=359249
Review URL: https://codereview.chromium.org/377803003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@283484 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
ART does check covariance of types passed via JNI anyway, causing the VM to
crash if they doesn't. We'd better check this in Java Bridge and throw a
JavaScript exception, as LiveConnect spec suggests.
BUG=392489
Review URL: https://codereview.chromium.org/393733002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@283457 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
ksakamoto@chromium.org
zhaoqin@google.com
sebmarchand@chromium.org
hans@chromium.org
brettw@chromium.org
xians@chromium.org
thakis@chromium.org
agl@chromium.org
byoungyoung@chromium.org
alokp@chromium.org
qsr@chromium.org
jshin@chromium.org
rmcilroy@chromium.org
aurimas@chromium.org
johnme@chromium.org
jochen@chromium.org
scottmg@chromium.org
dcaiafa@chromium.org
tzik@chromium.org
dpranke@chromium.org
derat@chromium.org
eseidel@chromium.org
cmumford@chromium.org
vitalybuka@chromium.org
jbudorick@chromium.org
simonb@chromium.org
mckev@amazon.com
tonyg@chromium.org
petarj@mips.com
andrewhayden@chromium.org
cjhopman@chromium.org
mnaganov@chromium.org
tnagel@chromium.org