mozilla
/
experimenter
зеркало из https://github.com/mozilla/experimenter.git
1
0
Форкнуть 0
Код Задачи Пакеты Проекты Релизы Вики Активность
experimenter/Makefile

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

341 строка
14 KiB
Makefile
Исходник Постоянная ссылка Обычный вид История

fix #5967 chore(project): set shell in makefile (#5968) Because * The makefile depends on /bin/bash to run correctly * That is not the default on all environments This commit * Explicitly sets SHELL = /bin/bash in the Makefile
2021-07-15 20:47:16 +03:00
SHELL = /bin/bash
fix #8360 feat(nimbus): Change root folder app to experimenter (#8375) Because - We will be adding cirrus in experimenter This commit - Rename `app` to `experimenter` and make necessary changes
2023-03-09 00:36:51 +03:00
WAIT_FOR_DB = /experimenter/bin/wait-for-it.sh -t 30 db:5432 &&
WAIT_FOR_RUNSERVER = /experimenter/bin/wait-for-it.sh -t 30 localhost:7001 &&
Reduce duplication in makefile fixes #1966 (#2021)
2019-12-03 21:26:20 +03:00
chore(project): add a flag to disable/enable cirrus (#9916) Because * Building Cirrus can be time consuming * Cirrus is not necessary for many integration tests or local workflows * We can add a flag to enable/disable cirrus to speed up the integration tests or local workflows that don't involve Cirrus This commit * Adds a flag to enable/disable Cirrus in the Makefile * Sets the flag automatically for all Cirrus make commands * Sets the flag for Cirrus integration tests fixes #9910
2023-12-07 22:50:36 +03:00
COMPOSE_CIRRUS = [[ -n $$CIRRUS ]] && echo "-f docker-compose-cirrus.yml"
COMPOSE = docker compose -f docker-compose.yml $$(${COMPOSE_CIRRUS})
chore(project): docker run with --rm (#11664) Because: - we are creating many short-lived containers for commands; and - we are not cleaning them up except in `make kill` This commit: - updates all docker run commands to use the `--rm` flag so that they are automatically deleted after the container exits. Fixes #11662
2024-11-08 22:47:05 +03:00
COMPOSE_RUN = ${COMPOSE} run --rm
fix #6828 chore(project): disable legacy tests and dev services (#6829) Because * The legacy workflow is in maintenance only mode and has not had any changes or failures in over a year This commit * Moves the legacy tests out of make check but preserves them in make check_legacy * Moves the legacy dev services out of make up but preserves them in make up_legacy * Removes the integration_legacy job from circle
2022-01-04 01:43:53 +03:00
COMPOSE_LEGACY = ${COMPOSE} -f docker-compose-legacy.yml
fix #9391 chore(project): use docker hydrobuild (#9392) Because * We now have access to Docker Hydrobuild * This allows us to use a shared cloud builder for our docker images so we can share a build cache between CI and local dev This commit * Updates the makefile to explicitly use docker buildx * Updates the circle config to install the latest docker client and setup a cloud builder
2023-09-15 23:17:24 +03:00
COMPOSE_TEST = docker compose -f docker-compose-test.yml
chore(project): docker run with --rm (#11664) Because: - we are creating many short-lived containers for commands; and - we are not cleaning them up except in `make kill` This commit: - updates all docker run commands to use the `--rm` flag so that they are automatically deleted after the container exits. Fixes #11662
2024-11-08 22:47:05 +03:00
COMPOSE_TEST_RUN = ${COMPOSE_TEST} run --rm
chore(project): add a flag to disable/enable cirrus (#9916) Because * Building Cirrus can be time consuming * Cirrus is not necessary for many integration tests or local workflows * We can add a flag to enable/disable cirrus to speed up the integration tests or local workflows that don't involve Cirrus This commit * Adds a flag to enable/disable Cirrus in the Makefile * Sets the flag automatically for all Cirrus make commands * Sets the flag for Cirrus integration tests fixes #9910
2023-12-07 22:50:36 +03:00
COMPOSE_PROD = docker compose -f docker-compose-prod.yml $$(${COMPOSE_CIRRUS})
COMPOSE_INTEGRATION = ${COMPOSE_PROD} -f docker-compose-integration-test.yml $$(${COMPOSE_CIRRUS})
chore(project): docker run with --rm (#11664) Because: - we are creating many short-lived containers for commands; and - we are not cleaning them up except in `make kill` This commit: - updates all docker run commands to use the `--rm` flag so that they are automatically deleted after the container exits. Fixes #11662
2024-11-08 22:47:05 +03:00
COMPOSE_INTEGRATION_RUN = ${COMPOSE_INTEGRATION} run --rm
bug(nimbus): don't use multiplatform builds in CI (#9697) Because - the default docker builder does not support multi-platform builds This commit - removes multi-platform build support from our Makefile.
2023-11-08 19:37:48 +03:00
DOCKER_BUILD = docker buildx build
Reduce duplication in makefile fixes #1966 (#2021)
2019-12-03 21:26:20 +03:00
Run pytest in parallel fixes #2001 (#2504) * Optimize and parallelize tests fixes #2001 * Gotta update the js for the new radio values * Increase to xlarge circle instance fixes #2516 * Default to 4 processes * Lets go nuts and try 16 * Separate docker building into its own step * Revert "Lets go nuts and try 16" This reverts commit 5af5b87907ffe2f98eefdaa43af8005a1a929c79. * Use a constant for the radio values * Set default survey value to fix integration test * Make jobs a constant in makefile * Need env to build for integration tests
2020-04-07 21:59:30 +03:00
JOBS = 4
PARALLEL = parallel --halt now,fail=1 --jobs ${JOBS} {} :::
chore(project): add colour output to make check (#4288) Because * GNU Parallel suppresses the colourized output of all the tests/lints * I keep missing failed python tests because of the way pytest formats the end of its output it's hard to visually distinguish between passes and failures This commit * Adds a bright green PASSED and bright red FAILED to the end of make check
2020-12-16 23:47:00 +03:00
NOCOLOR= \033[0m
RED = \033[0;31m
GREEN = \033[0;32m
PAD = -------------------------------------------------\n
fix(all): fix check; address various broken tests, outdated docs, failing lints (#4325)
2020-12-22 23:33:57 +03:00
COLOR_CHECK = && echo "${GREEN}${PAD}All Checks Passed\n${PAD}${NOCOLOR}" || (echo "${RED}${PAD}Some Checks Failed\n${PAD}${NOCOLOR}";exit 1)
Add pytest conf to pytest.ini fixes #2579 (#2580)
2020-04-22 23:43:42 +03:00
PYTHON_TEST = pytest --cov --cov-report term-missing
fix #8206 chore(nimbus): add python static typechecking (#8208) Because * The Python static type checking environment is maturing * Django has been historically very difficult to statically type check * The django-types package now seems to add benefit without requiring a significant investment This commit * Adds the pyright type checker to our check suite * Adds the django-types extension to get automatic type inference * Enables some checks that will provide value without requiring massive refactors * Cleans up some existing failures that this type checking has already caught
2023-01-31 21:13:26 +03:00
PYTHON_TYPECHECK = pyright experimenter/
fix #8755 bug(nimbus): Revert "feat(nimbus): check Remote Settings connectivity in heartbeat (#8734)" (#8756) Because * The new health check is failing during canary startup, deploys are being blocked This commit * Reverts the new health check until we can find a better solution This reverts commit 5f9743f76ca0f8af8eaad6822ed1599b9a15f701.
2023-04-27 22:17:24 +03:00
PYTHON_CHECK_MIGRATIONS = python manage.py makemigrations --check --dry-run --noinput
PYTHON_MIGRATE = python manage.py migrate
fix #6828 chore(project): disable legacy tests and dev services (#6829) Because * The legacy workflow is in maintenance only mode and has not had any changes or failures in over a year This commit * Moves the legacy tests out of make check but preserves them in make check_legacy * Moves the legacy dev services out of make up but preserves them in make up_legacy * Removes the integration_legacy job from circle
2022-01-04 01:43:53 +03:00
ESLINT_LEGACY = yarn workspace @experimenter/core lint
Add TS/React skeleton for Rapid Experiments (#2712)
2020-06-02 21:36:10 +03:00
ESLINT_FIX_CORE = yarn workspace @experimenter/core lint-fix
fix #3844 chore(nimbus): add eslint/prettier (#3848) Because * We want the code to be auto formatted in a consistent way to prevent noisy PRs from individual editor formatting settings This commit * Adds eslint/prettier and attaches it to the make code_format and make check commands
2020-10-30 00:23:19 +03:00
ESLINT_NIMBUS_UI = yarn workspace @experimenter/nimbus-ui lint
ESLINT_FIX_NIMBUS_UI = yarn workspace @experimenter/nimbus-ui lint-fix
chore(nimbus): setup webpack for nimbus_ui_new (#10834) Because * Now that all of the functionality is finished for the new nimbus ui list page * We can setup webpack to bundle all the dependencies This commit * Adds webpack to nimbus_ui_new * Move scripts from being inline to actually stored as static assets with proper linting * Setup SASS so we can have some proper styling for bootstrap-select with dark mode fixes #10708
2024-06-13 20:57:54 +03:00
ESLINT_NIMBUS_UI_NEW = yarn workspace @experimenter/nimbus_ui_new lint
ESLINT_FIX_NIMBUS_UI_NEW = yarn workspace @experimenter/nimbus_ui_new format
feat(nimbus-ui): Init nimbus-ui with CRA Typescript, remove cruft, add tests, linting, workspace, README (#3519) * feat(nimbus-ui): Init nimbus-ui with CRA Typescript, remove cruft, add tests, linting, workspace, README" * Add optional label parameter to babel plugins for core * Copy nimbus-ui into container before yarn build commands * Only eslint ts source files * Use container paths for nimbus-ui node_modules and built assets * Upgrade TS version to latest * Install eslint dev dependencies so we can lint outside react-scripts * Rebuild yarn.lock file * Use jsdom-sixteen jest test env for 'core' * Use jsdom-sixteen jest test env for 'rapid' * fix yarn deps issue, silence babel warning * CI=yes not CI=true * Add MPL license to missed file and add newline to package.json * Fix dependabot spacing * Move testing lib to dev dep instead of dep * Fix double quotes in docker compose Co-authored-by: Jared Lockhart <119884+jaredlockhart@users.noreply.github.com> Co-authored-by: Jody Heavener <j.heavener@gmail.com>
2020-09-24 20:30:15 +03:00
TYPECHECK_NIMBUS_UI = yarn workspace @experimenter/nimbus-ui lint:tsc
chore(nimbus): add django template formatting (#10657) Because * We will now be switching nimbus ui to use django templates * We need a way to keep the formatting/linting consistent across PRs This commit * Adds djlint to the makefile to format/lint django templates locally and in ci fixes #10656
2024-05-07 21:11:49 +03:00
DJLINT_CHECK = djlint --check experimenter/nimbus_ui_new/
DJLINT_FIX = djlint --reformat experimenter/nimbus_ui_new/
fix #6828 chore(project): disable legacy tests and dev services (#6829) Because * The legacy workflow is in maintenance only mode and has not had any changes or failures in over a year This commit * Moves the legacy tests out of make check but preserves them in make check_legacy * Moves the legacy dev services out of make up but preserves them in make up_legacy * Removes the integration_legacy job from circle
2022-01-04 01:43:53 +03:00
JS_TEST_LEGACY = yarn workspace @experimenter/core test
fix #7750 chore(nimbus): add env var for printing more DOM during testing (#7751) * fix #7750 chore(nimbus): add env var for printing more DOM during testing * Bump default print limit This should cover printing the entire DOM for (almost?) all tests.
2022-09-14 22:36:36 +03:00
JS_TEST_NIMBUS_UI = DEBUG_PRINT_LIMIT=999999 CI=yes yarn workspace @experimenter/nimbus-ui test:cov
fix #3907 chore(nimbus): make types_check should fail with graphql changes (#3915) Because * We'd like to make sure that the apollo client generated code stays in sync with the server This commit * Uses the schema.graphql to check whether the backend is in sync with the frontend codebase * regenerates the schema.graphql and typescript stubs together so they stay in sync
2020-11-09 22:57:03 +03:00
NIMBUS_SCHEMA_CHECK = python manage.py graphql_schema --out experimenter/nimbus-ui/test_schema.graphql&&diff experimenter/nimbus-ui/test_schema.graphql experimenter/nimbus-ui/schema.graphql || (echo GraphQL Schema is out of sync please run make generate_types;exit 1)
NIMBUS_TYPES_GENERATE = python manage.py graphql_schema --out experimenter/nimbus-ui/schema.graphql&&yarn workspace @experimenter/nimbus-ui generate-types
chore(deps-dev): Bump ruff from 0.4.1 to 0.5.0 in /schemas (#10927) Bumps [ruff](https://github.com/astral-sh/ruff) from 0.4.1 to 0.5.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/astral-sh/ruff/releases">ruff's releases</a>.</em></p> <blockquote> <h2>0.5.0</h2> <h2>Release Notes</h2> <p>Check out the <a href="https://astral.sh/blog/ruff-v0.5.0">blog post</a> for a migration guide and overview of the changes!</p> <h3>Breaking changes</h3> <p>See also, the &quot;Remapped rules&quot; section which may result in disabled rules.</p> <ul> <li>Follow the XDG specification to discover user-level configurations on macOS (same as on other Unix platforms)</li> <li>Selecting <code>ALL</code> now excludes deprecated rules</li> <li>The released archives now include an extra level of nesting, which can be removed with <code>--strip-components=1</code> when untarring.</li> <li>The release artifact's file name no longer includes the version tag. This enables users to install via <code>/latest</code> URLs on GitHub.</li> <li>The diagnostic ranges for some <code>flake8-bandit</code> rules were modified (<a href="https://redirect.github.com/astral-sh/ruff/pull/10667">#10667</a>).</li> </ul> <h3>Deprecations</h3> <p>The following rules are now deprecated:</p> <ul> <li><a href="https://docs.astral.sh/ruff/rules/syntax-error/"><code>syntax-error</code></a> (<code>E999</code>): Syntax errors are now always shown</li> </ul> <h3>Remapped rules</h3> <p>The following rules have been remapped to new rule codes:</p> <ul> <li><a href="https://docs.astral.sh/ruff/rules/blocking-http-call-in-async-function/"><code>blocking-http-call-in-async-function</code></a>: <code>ASYNC100</code> to <code>ASYNC210</code></li> <li><a href="https://docs.astral.sh/ruff/rules/open-sleep-or-subprocess-in-async-function/"><code>open-sleep-or-subprocess-in-async-function</code></a>: <code>ASYNC101</code> split into <code>ASYNC220</code>, <code>ASYNC221</code>, <code>ASYNC230</code>, and <code>ASYNC251</code></li> <li><a href="https://docs.astral.sh/ruff/rules/blocking-os-call-in-async-function/"><code>blocking-os-call-in-async-function</code></a>: <code>ASYNC102</code> has been merged into <code>ASYNC220</code> and <code>ASYNC221</code></li> <li><a href="https://docs.astral.sh/ruff/rules/trio-timeout-without-await/"><code>trio-timeout-without-await</code></a>: <code>TRIO100</code> to <code>ASYNC100</code></li> <li><a href="https://docs.astral.sh/ruff/rules/trio-sync-call/"><code>trio-sync-call</code></a>: <code>TRIO105</code> to <code>ASYNC105</code></li> <li><a href="https://docs.astral.sh/ruff/rules/trio-async-function-with-timeout/"><code>trio-async-function-with-timeout</code></a>: <code>TRIO109</code> to <code>ASYNC109</code></li> <li><a href="https://docs.astral.sh/ruff/rules/trio-unneeded-sleep/"><code>trio-unneeded-sleep</code></a>: <code>TRIO110</code> to <code>ASYNC110</code></li> <li><a href="https://docs.astral.sh/ruff/rules/trio-zero-sleep-call/"><code>trio-zero-sleep-call</code></a>: <code>TRIO115</code> to <code>ASYNC115</code></li> <li><a href="https://docs.astral.sh/ruff/rules/repeated-isinstance-calls/"><code>repeated-isinstance-calls</code></a>: <code>PLR1701</code> to <code>SIM101</code></li> </ul> <h3>Stabilization</h3> <p>The following rules have been stabilized and are no longer in preview:</p> <ul> <li><a href="https://docs.astral.sh/ruff/rules/mutable-fromkeys-value/"><code>mutable-fromkeys-value</code></a> (<code>RUF024</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/default-factory-kwarg/"><code>default-factory-kwarg</code></a> (<code>RUF026</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/django-extra/"><code>django-extra</code></a> (<code>S610</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/manual-dict-comprehension/"><code>manual-dict-comprehension</code></a> (<code>PERF403</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/print-empty-string/"><code>print-empty-string</code></a> (<code>FURB105</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/readlines-in-for/"><code>readlines-in-for</code></a> (<code>FURB129</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/if-expr-min-max/"><code>if-expr-min-max</code></a> (<code>FURB136</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/bit-count/"><code>bit-count</code></a> (<code>FURB161</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/redundant-log-base/"><code>redundant-log-base</code></a> (<code>FURB163</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/regex-flag-alias/"><code>regex-flag-alias</code></a> (<code>FURB167</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/isinstance-type-none/"><code>isinstance-type-none</code></a> (<code>FURB168</code>)</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md">ruff's changelog</a>.</em></p> <blockquote> <h2>0.5.0</h2> <p>Check out the <a href="https://astral.sh/blog/ruff-v0.5.0">blog post</a> for a migration guide and overview of the changes!</p> <h3>Breaking changes</h3> <p>See also, the &quot;Remapped rules&quot; section which may result in disabled rules.</p> <ul> <li>Follow the XDG specification to discover user-level configurations on macOS (same as on other Unix platforms)</li> <li>Selecting <code>ALL</code> now excludes deprecated rules</li> <li>The released archives now include an extra level of nesting, which can be removed with <code>--strip-components=1</code> when untarring.</li> <li>The release artifact's file name no longer includes the version tag. This enables users to install via <code>/latest</code> URLs on GitHub.</li> <li>The diagnostic ranges for some <code>flake8-bandit</code> rules were modified (<a href="https://redirect.github.com/astral-sh/ruff/pull/10667">#10667</a>).</li> </ul> <h3>Deprecations</h3> <p>The following rules are now deprecated:</p> <ul> <li><a href="https://docs.astral.sh/ruff/rules/syntax-error/"><code>syntax-error</code></a> (<code>E999</code>): Syntax errors are now always shown</li> </ul> <h3>Remapped rules</h3> <p>The following rules have been remapped to new rule codes:</p> <ul> <li><a href="https://docs.astral.sh/ruff/rules/blocking-http-call-in-async-function/"><code>blocking-http-call-in-async-function</code></a>: <code>ASYNC100</code> to <code>ASYNC210</code></li> <li><a href="https://docs.astral.sh/ruff/rules/open-sleep-or-subprocess-in-async-function/"><code>open-sleep-or-subprocess-in-async-function</code></a>: <code>ASYNC101</code> split into <code>ASYNC220</code>, <code>ASYNC221</code>, <code>ASYNC230</code>, and <code>ASYNC251</code></li> <li><a href="https://docs.astral.sh/ruff/rules/blocking-os-call-in-async-function/"><code>blocking-os-call-in-async-function</code></a>: <code>ASYNC102</code> has been merged into <code>ASYNC220</code> and <code>ASYNC221</code></li> <li><a href="https://docs.astral.sh/ruff/rules/trio-timeout-without-await/"><code>trio-timeout-without-await</code></a>: <code>TRIO100</code> to <code>ASYNC100</code></li> <li><a href="https://docs.astral.sh/ruff/rules/trio-sync-call/"><code>trio-sync-call</code></a>: <code>TRIO105</code> to <code>ASYNC105</code></li> <li><a href="https://docs.astral.sh/ruff/rules/trio-async-function-with-timeout/"><code>trio-async-function-with-timeout</code></a>: <code>TRIO109</code> to <code>ASYNC109</code></li> <li><a href="https://docs.astral.sh/ruff/rules/trio-unneeded-sleep/"><code>trio-unneeded-sleep</code></a>: <code>TRIO110</code> to <code>ASYNC110</code></li> <li><a href="https://docs.astral.sh/ruff/rules/trio-zero-sleep-call/"><code>trio-zero-sleep-call</code></a>: <code>TRIO115</code> to <code>ASYNC115</code></li> <li><a href="https://docs.astral.sh/ruff/rules/repeated-isinstance-calls/"><code>repeated-isinstance-calls</code></a>: <code>PLR1701</code> to <code>SIM101</code></li> </ul> <h3>Stabilization</h3> <p>The following rules have been stabilized and are no longer in preview:</p> <ul> <li><a href="https://docs.astral.sh/ruff/rules/mutable-fromkeys-value/"><code>mutable-fromkeys-value</code></a> (<code>RUF024</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/default-factory-kwarg/"><code>default-factory-kwarg</code></a> (<code>RUF026</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/django-extra/"><code>django-extra</code></a> (<code>S610</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/manual-dict-comprehension/"><code>manual-dict-comprehension</code></a> (<code>PERF403</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/print-empty-string/"><code>print-empty-string</code></a> (<code>FURB105</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/readlines-in-for/"><code>readlines-in-for</code></a> (<code>FURB129</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/if-expr-min-max/"><code>if-expr-min-max</code></a> (<code>FURB136</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/bit-count/"><code>bit-count</code></a> (<code>FURB161</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/redundant-log-base/"><code>redundant-log-base</code></a> (<code>FURB163</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/regex-flag-alias/"><code>regex-flag-alias</code></a> (<code>FURB167</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/isinstance-type-none/"><code>isinstance-type-none</code></a> (<code>FURB168</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/type-none-comparison/"><code>type-none-comparison</code></a> (<code>FURB169</code>)</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/astral-sh/ruff/commit/244b923f615c2c162278fc0e06051853614760f3"><code>244b923</code></a> Add necessary permissions for cargo-dist Docker build (<a href="https://redirect.github.com/astral-sh/ruff/issues/12072">#12072</a>)</li> <li><a href="https://github.com/astral-sh/ruff/commit/a8b48fce7e32b35538072ccd55dac64e158d1e34"><code>a8b48fc</code></a> Release v0.5.0 (<a href="https://redirect.github.com/astral-sh/ruff/issues/12068">#12068</a>)</li> <li><a href="https://github.com/astral-sh/ruff/commit/04c8597b8ab1a459d77058b6899571095092bc2d"><code>04c8597</code></a> [<code>flake8-simplify</code>] Stabilize detection of Yoda conditions for &quot;constant&quot; col...</li> <li><a href="https://github.com/astral-sh/ruff/commit/4029a25ebd88a26424f45b20aba20c8e56a54d62"><code>4029a25</code></a> [Ruff v0.5] Stabilise 15 pylint rules (<a href="https://redirect.github.com/astral-sh/ruff/issues/12051">#12051</a>)</li> <li><a href="https://github.com/astral-sh/ruff/commit/0917ce16f477f20b60d6d6f96462d4c83168f6f6"><code>0917ce1</code></a> Update documentation to mention <code>etcetera</code> crate instead of <code>dirs</code> for user c...</li> <li><a href="https://github.com/astral-sh/ruff/commit/22cebdf29b79c9bb39b341149b2764730de72d97"><code>22cebdf</code></a> Add server config to filter out syntax error diagnostics (<a href="https://redirect.github.com/astral-sh/ruff/issues/12059">#12059</a>)</li> <li><a href="https://github.com/astral-sh/ruff/commit/72b6c26101ca920137202d455b014f9e680712f7"><code>72b6c26</code></a> Simplify <code>LinterResult</code>, avoid cloning <code>ParseError</code> (<a href="https://redirect.github.com/astral-sh/ruff/issues/11903">#11903</a>)</li> <li><a href="https://github.com/astral-sh/ruff/commit/73851e73ab0629461fbec84ee35ea91948d0c474"><code>73851e7</code></a> Avoid displaying syntax error as log message (<a href="https://redirect.github.com/astral-sh/ruff/issues/11902">#11902</a>)</li> <li><a href="https://github.com/astral-sh/ruff/commit/e7b49694a795e3347ffc6f499245dfcbbb4b28ed"><code>e7b4969</code></a> Remove <code>E999</code> as a rule, disallow any disablement methods for syntax error (#...</li> <li><a href="https://github.com/astral-sh/ruff/commit/c98d8a040fbcd3428f1b0189ebdc9fbb8183b215"><code>c98d8a0</code></a> [<code>pyflakes</code>] Stabilize detection of is comparisons to lists, etc. (<code>F632</code>) (#...</li> <li>Additional commits viewable in <a href="https://github.com/astral-sh/ruff/compare/v0.4.1...0.5.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=ruff&package-manager=pip&previous-version=0.4.1&new-version=0.5.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jared Lockhart <119884+jaredlockhart@users.noreply.github.com>
2024-07-03 23:32:25 +03:00
RUFF_CHECK = ruff check experimenter/ tests/
bug(nimbus): update ruff fix command (#10993) Because * Ruff deprecated the `ruff <path>` interface for `ruff check <path>` * We updated the check call but not the fix call This commit * Updates the ruff fix call in the Makefile to use the `ruff check --fix` interface fixes #10990
2024-07-11 19:35:27 +03:00
RUFF_FIX = ruff check --fix experimenter/ tests/
feat(nimbus-ui): add bootstrap setup, stylelint, document how to write styles (#3553) Co-authored-by: Lauren Zugai <lauren@zugai.com>
2020-09-28 22:36:37 +03:00
BLACK_CHECK = black -l 90 --check --diff . --exclude node_modules
fix #3680 chore(project): ignore node_modules in black fix (#3681) Because * We now have python files in node_modules This commit * Ignores node_modules in make black fix * Run independent code fixes in parallel, just a nice little enhancement
2020-10-06 21:46:40 +03:00
BLACK_FIX = black -l 90 . --exclude node_modules
fix #8755 bug(nimbus): Revert "feat(nimbus): check Remote Settings connectivity in heartbeat (#8734)" (#8756) Because * The new health check is failing during canary startup, deploys are being blocked This commit * Reverts the new health check until we can find a better solution This reverts commit 5f9743f76ca0f8af8eaad6822ed1599b9a15f701.
2023-04-27 22:17:24 +03:00
CHECK_DOCS = python manage.py generate_docs --check=true
GENERATE_DOCS = python manage.py generate_docs
LOAD_COUNTRIES = python manage.py loaddata ./experimenter/base/fixtures/countries.json
LOAD_LOCALES = python manage.py loaddata ./experimenter/base/fixtures/locales.json
LOAD_LANGUAGES = python manage.py loaddata ./experimenter/base/fixtures/languages.json
LOAD_FEATURES = python manage.py load_feature_configs
LOAD_DUMMY_EXPERIMENTS = [[ -z $$SKIP_DUMMY ]] && python manage.py load_dummy_experiments || python manage.py load_dummy_projects
Reduce duplication in makefile fixes #1966 (#2021)
2019-12-03 21:26:20 +03:00
fix #6430 feat(nimbus): load desktop features from mozilla central (#6436) Because * We'd like to consume feature manifests directly from client repos instead of storing them in the database This commit * Downloads the desktop feature manifest at container build time * Adds a features app that parses the desktop feature manifest into memory
2021-09-17 18:37:57 +03:00
Update jetstream config url to new endpoint #8178 (#8199) Jetstream configs and outcomes have moved to https://github.com/mozilla/metric-hub/tree/main/jetstream This updates the config URLs to the new location. Fixes #8178 --------- Co-authored-by: Jared Lockhart <119884+jaredlockhart@users.noreply.github.com>
2023-01-27 18:56:37 +03:00
JETSTREAM_CONFIG_URL = https://github.com/mozilla/metric-hub/archive/main.zip
Use pre-built nimbus-cli for FML transformations (#9331) Because - prebuilt versions of nimbus-cli include FML are available for linux-musl This commit - Installs the nimbus-cli as part of deployment - Uses this to fetch and transform FML files from the Firefox Mobile, Focus and Monitor apps This means: - Faster deploy times - We can remove the .experimenter.yaml files from the apps' repos and build scripts. --------- Co-authored-by: Jared Lockhart <119884+jaredlockhart@users.noreply.github.com>
2023-08-31 19:22:38 +03:00
CLI_DIR = experimenter/experimenter/features/manifests/application-services
CLI_INSTALLER = $(CLI_DIR)/install-nimbus-cli.sh
NIMBUS_CLI = $(CLI_DIR)/nimbus-cli
fix #6430 feat(nimbus): load desktop features from mozilla central (#6436) Because * We'd like to consume feature manifests directly from client repos instead of storing them in the database This commit * Downloads the desktop feature manifest at container build time * Adds a features app that parses the desktop feature manifest into memory
2021-09-17 18:37:57 +03:00
Implement most trivial rules from our quality standards (#9711) Because - We are trying to promote [Quality Standards](https://mozilla.github.io/syseng-pod/quality-standards/) across Mozilla's repositories - Experimenter has a [very good score already](https://mozilla.github.io/syseng-pod/quality-standards/#service-Experimenter) This PR - Implements a few of the harmless ones to improve even the score :) --------- Co-authored-by: Jared Lockhart <119884+jaredlockhart@users.noreply.github.com> Co-authored-by: Yashika Khurana <yashikakhuranayashika@gmail.com>
2023-11-10 04:18:05 +03:00
help:
@echo "Please use 'make <target>' where <target> is one of the following commands."
@echo
@grep -E '^[a-zA-Z_-]+:.*?## .*$$' Makefile | sort | awk 'BEGIN {FS = ":.*?## "}; {printf "\033[36m%-30s\033[0m %s\n", $$1, $$2}'
@echo
@echo "Check the Makefile to know exactly what each target is doing."
ssl: nginx/key.pem nginx/cert.pem ## Generate all SSL certificates
fix #3687 chore(project): run integration tests against deploy image (#3822) Because * We split the docker image into two images, one for local dev and one for deploying to prod so that the prod one would be small ~100mb * We should find some way to test that the deploy image is working correctly * A good candidate is to run the integration tests against it This commit * Adds a new make up_prod command that sets up an environment that more closely mirrors prod ie - Use the prod image - Disable all the yarn watchers * Reorganizes the dockerfile to move frontend asset building out of the dev container to increase docker cache hits for local dev
2020-10-26 19:26:09 +03:00
nginx/key.pem:
openssl genrsa -out nginx/key.pem 4096
nginx/cert.pem: nginx/key.pem
openssl req -new -x509 -nodes -sha256 -key nginx/key.pem \
-subj "/C=US/ST=California/L=Mountain View/O=Mozilla/CN=experiment_local" \
> nginx/cert.pem
Implement most trivial rules from our quality standards (#9711) Because - We are trying to promote [Quality Standards](https://mozilla.github.io/syseng-pod/quality-standards/) across Mozilla's repositories - Experimenter has a [very good score already](https://mozilla.github.io/syseng-pod/quality-standards/#service-Experimenter) This PR - Implements a few of the harmless ones to improve even the score :) --------- Co-authored-by: Jared Lockhart <119884+jaredlockhart@users.noreply.github.com> Co-authored-by: Yashika Khurana <yashikakhuranayashika@gmail.com>
2023-11-10 04:18:05 +03:00
secretkey: ## Generate random key
fix #3687 chore(project): run integration tests against deploy image (#3822) Because * We split the docker image into two images, one for local dev and one for deploying to prod so that the prod one would be small ~100mb * We should find some way to test that the deploy image is working correctly * A good candidate is to run the integration tests against it This commit * Adds a new make up_prod command that sets up an environment that more closely mirrors prod ie - Use the prod image - Disable all the yarn watchers * Reorganizes the dockerfile to move frontend asset building out of the dev container to increase docker cache hits for local dev
2020-10-26 19:26:09 +03:00
openssl rand -hex 24
Implement most trivial rules from our quality standards (#9711) Because - We are trying to promote [Quality Standards](https://mozilla.github.io/syseng-pod/quality-standards/) across Mozilla's repositories - Experimenter has a [very good score already](https://mozilla.github.io/syseng-pod/quality-standards/#service-Experimenter) This PR - Implements a few of the harmless ones to improve even the score :) --------- Co-authored-by: Jared Lockhart <119884+jaredlockhart@users.noreply.github.com> Co-authored-by: Yashika Khurana <yashikakhuranayashika@gmail.com>
2023-11-10 04:18:05 +03:00
auth_gcloud: ## Login to GCloud
fix #7469 chore(nimbus): simplify google auth process for local jetstream dev (#7470)
2022-06-30 00:01:11 +03:00
gcloud auth login --update-adc
fix #7351 chore(project): add make command for gcloud auth (#7361) Because certain local dev requires authenticating to GCP GCP expires authentication periodically This commit adds a helpful make auth command to run the required commands
2022-06-03 21:35:11 +03:00
fix #4569 feat(nimbus): load outcomes from jetstream config (#4746) Because * Rather than storing probesets in the experimenter db we will now consume outcome definitions from the jetstream config repo This commit * Adds the jetstream config repo as a git submodule * Updates the makefile to update the jetstream config submodule on every docker container build * Adds an outcomes python module that loads the TOML files into memory and provides some handy dandy lookup methods * Tests for the outcomes module * Module docs explaining outcomes and their relationship to experiments and use
2021-03-03 02:03:43 +03:00
jetstream_config:
fix #8360 feat(nimbus): Change root folder app to experimenter (#8375) Because - We will be adding cirrus in experimenter This commit - Rename `app` to `experimenter` and make necessary changes
2023-03-09 00:36:51 +03:00
curl -LJ -o experimenter/experimenter/outcomes/metric-hub.zip $(JETSTREAM_CONFIG_URL)
unzip -o -d experimenter/experimenter/outcomes experimenter/experimenter/outcomes/metric-hub.zip
rm -Rf experimenter/experimenter/outcomes/metric-hub-main/.script/
feat(project): Retrieve metric-hub segments in Experimenter (#11243) Because * Experimenter needs to retrieve the segments from metric-hub as they are currently not available there This commit * allows Experimenter to retrieve segments from metric-hub Fixes #11242
2024-08-30 19:42:38 +03:00
unzip -o -d experimenter/experimenter/segments experimenter/experimenter/outcomes/metric-hub.zip
rm -Rf experimenter/experimenter/segments/metric-hub-main/.script/
fix #4569 feat(nimbus): load outcomes from jetstream config (#4746) Because * Rather than storing probesets in the experimenter db we will now consume outcome definitions from the jetstream config repo This commit * Adds the jetstream config repo as a git submodule * Updates the makefile to update the jetstream config submodule on every docker container build * Adds an outcomes python module that loads the TOML files into memory and provides some handy dandy lookup methods * Tests for the outcomes module * Module docs explaining outcomes and their relationship to experiments and use
2021-03-03 02:03:43 +03:00
fix #9538 bug(project): build dev container before running manifest tool (#9540) Because * We recently moved our FML parsing into the Experimenter Docker container * This requires that the experimenter:dev container is built before running the make fetch_external_resources command * This was ommitted and the hourly CircleCI task is broken This commit * Adds build_dev as a pre requisite to make fetch_external_resources
2023-10-04 00:16:35 +03:00
feature_manifests: build_dev
chore(project): docker run with --rm (#11664) Because: - we are creating many short-lived containers for commands; and - we are not cleaning them up except in `make kill` This commit: - updates all docker run commands to use the `--rm` flag so that they are automatically deleted after the container exits. Fixes #11662
2024-11-08 22:47:05 +03:00
$(COMPOSE_RUN) -e GITHUB_BEARER_TOKEN=$(GITHUB_BEARER_TOKEN) experimenter /experimenter/bin/manifest-tool.py fetch $(FETCH_ARGS)
chore(nimbus): reorganize manifests into directories (#9395) Because - feature versioning means vendoring several nimbus.fml, experimenter.yaml, and JSON schema files per application This commit - moves apps.yaml into the manifests directory; and - renames {app}.yaml to {app}/experimenter.yaml because each app will have multiple manifests.
2023-09-15 23:28:15 +03:00
Implement most trivial rules from our quality standards (#9711) Because - We are trying to promote [Quality Standards](https://mozilla.github.io/syseng-pod/quality-standards/) across Mozilla's repositories - Experimenter has a [very good score already](https://mozilla.github.io/syseng-pod/quality-standards/#service-Experimenter) This PR - Implements a few of the harmless ones to improve even the score :) --------- Co-authored-by: Jared Lockhart <119884+jaredlockhart@users.noreply.github.com> Co-authored-by: Yashika Khurana <yashikakhuranayashika@gmail.com>
2023-11-10 04:18:05 +03:00
install_nimbus_cli: ## Install Nimbus client
Use pre-built nimbus-cli for FML transformations (#9331) Because - prebuilt versions of nimbus-cli include FML are available for linux-musl This commit - Installs the nimbus-cli as part of deployment - Uses this to fetch and transform FML files from the Firefox Mobile, Focus and Monitor apps This means: - Faster deploy times - We can remove the .experimenter.yaml files from the apps' repos and build scripts. --------- Co-authored-by: Jared Lockhart <119884+jaredlockhart@users.noreply.github.com>
2023-08-31 19:22:38 +03:00
mkdir -p $(CLI_DIR)
curl --proto '=https' --tlsv1.2 -sSf https://raw.githubusercontent.com/mozilla/application-services/main/install-nimbus-cli.sh > "$(CLI_INSTALLER)"
$(SHELL) $(CLI_INSTALLER) --directory "$(CLI_DIR)"
Implement most trivial rules from our quality standards (#9711) Because - We are trying to promote [Quality Standards](https://mozilla.github.io/syseng-pod/quality-standards/) across Mozilla's repositories - Experimenter has a [very good score already](https://mozilla.github.io/syseng-pod/quality-standards/#service-Experimenter) This PR - Implements a few of the harmless ones to improve even the score :) --------- Co-authored-by: Jared Lockhart <119884+jaredlockhart@users.noreply.github.com> Co-authored-by: Yashika Khurana <yashikakhuranayashika@gmail.com>
2023-11-10 04:18:05 +03:00
fetch_external_resources: jetstream_config install_nimbus_cli feature_manifests ## Fetch all external resources
fix #6430 feat(nimbus): load desktop features from mozilla central (#6436) Because * We'd like to consume feature manifests directly from client repos instead of storing them in the database This commit * Downloads the desktop feature manifest at container build time * Adds a features app that parses the desktop feature manifest into memory
2021-09-17 18:37:57 +03:00
echo "External Resources Fetched"
Implement most trivial rules from our quality standards (#9711) Because - We are trying to promote [Quality Standards](https://mozilla.github.io/syseng-pod/quality-standards/) across Mozilla's repositories - Experimenter has a [very good score already](https://mozilla.github.io/syseng-pod/quality-standards/#service-Experimenter) This PR - Implements a few of the harmless ones to improve even the score :) --------- Co-authored-by: Jared Lockhart <119884+jaredlockhart@users.noreply.github.com> Co-authored-by: Yashika Khurana <yashikakhuranayashika@gmail.com>
2023-11-10 04:18:05 +03:00
update_kinto: ## Update latest Kinto/Remote Settings container
fixes #5943 chore(project): add make command to pull in latest kinto docker image (#5962)
2021-07-15 19:33:57 +03:00
docker pull mozilla/kinto-dist:latest
Implement most trivial rules from our quality standards (#9711) Because - We are trying to promote [Quality Standards](https://mozilla.github.io/syseng-pod/quality-standards/) across Mozilla's repositories - Experimenter has a [very good score already](https://mozilla.github.io/syseng-pod/quality-standards/#service-Experimenter) This PR - Implements a few of the harmless ones to improve even the score :) --------- Co-authored-by: Jared Lockhart <119884+jaredlockhart@users.noreply.github.com> Co-authored-by: Yashika Khurana <yashikakhuranayashika@gmail.com>
2023-11-10 04:18:05 +03:00
compose_build: ## Build containers
fix #9391 chore(project): use docker hydrobuild (#9392) Because * We now have access to Docker Hydrobuild * This allows us to use a shared cloud builder for our docker images so we can share a build cache between CI and local dev This commit * Updates the makefile to explicitly use docker buildx * Updates the circle config to install the latest docker client and setup a cloud builder
2023-09-15 23:17:24 +03:00
$(COMPOSE) build
fix #3687 chore(project): run integration tests against deploy image (#3822) Because * We split the docker image into two images, one for local dev and one for deploying to prod so that the prod one would be small ~100mb * We should find some way to test that the deploy image is working correctly * A good candidate is to run the integration tests against it This commit * Adds a new make up_prod command that sets up an environment that more closely mirrors prod ie - Use the prod image - Disable all the yarn watchers * Reorganizes the dockerfile to move frontend asset building out of the dev container to increase docker cache hits for local dev
2020-10-26 19:26:09 +03:00
feat(nimbus): Upgrade sdk integration tests to modern application-services (#10148) Because - The sdk integration test image was stuck on application-services v97.5.1 due to build system changes, which prevented landing any new targeting using new targeting attributes from v98 onwards. - The current system of periodically pushing a integration test image and pulling that pre-built image in tests lead to headaches and issues. - I discovered several oddities in the current integration-test-nimbus-rust setup (specifying a webdriver driver, sudo commands that never ran because sudo was not installed). - The new application services has a very different NimbusClient interface from the one currently used in tests. This commit - Adds a `experimenter:megazords` container, which is responsible for downloading a tagged nightly of the Cirrus and Nimbus-Experimenter megazords. - Adds a new `experimenter:integration-tests` container, which takes the place of the old "nimbus-rust-image" container. This container is very barebones, and only includes the application services megazord (copied from the other container) and tox. - Removes the old `Dockerfile-rust-image` and its publishing steps from CI. - Configures our integration tests to build the image on the fly instead of pulling a pre-built image from a registry. - Cleans up a few things in the `test_mobile_targeting.py` suite and updates the code to match the new interfaces. - Updates the `integration_test_nimbus_rust` task to run tox with `-vv`, which includes the output of any commands issued. Fixes #9820
2024-01-26 22:16:00 +03:00
build_megazords:
$(DOCKER_BUILD) -f application-services/Dockerfile -t experimenter:megazords application-services/
feat(nimbus): auto-update application-services (#10182) Because: - we have standardized on using a single version of application-services across all Experimenter, Cirrus, and integration tests; and - we do not want to manually manage updating this version This commit: - adds a CI task to open a new PR for new application-services nightlies. Fixes https://github.com/mozilla/experimenter/issues/9688
2024-02-01 01:19:56 +03:00
update_application_services: build_megazords
docker run \
-v ./application-services/application-services.env:/application-services/application-services.env \
experimenter:megazords \
/application-services/update-application-services.sh
feat(nimbus): Use pre-built A-S in Cirrus and Experimenter (#10151) feat(nimbus): Use pre-built A-S in Cirrus and Experimenter Because: - our integration tests have been updated to use pre-built application-services artifacts; - the Cirrus and Experimenter Dockerfiles are currently building application-services from source; - Cirrus was using a Debian buster (oldoldstable); and - Cirrus and Experimenter were using a pinned minor version of Python, which prevents them from getting security upgrades in minor patches. This commit: - updates the Cirrus and Experimenter Dockerfiles to reference the `experimenter:megazords` image, which contains the pre-built binaries; - updates Cirrus to use a Debian bullseye (oldstable) image; and - updates Cirrus and Experimenter to not pin the minor verison of Python (3.11.2 to 3.11). Fixes #10150
2024-01-31 00:08:02 +03:00
build_dev: ssl build_megazords
fix #9451 chore(project): build multiple docker platforms in circle (#9452) Because * We can now target multiple platforms in our Docker builds in Circle This commit * Enables multiplatform builds for Docker in Circle
2023-09-20 23:30:37 +03:00
$(DOCKER_BUILD) --target dev -f experimenter/Dockerfile -t experimenter:dev experimenter/
chore(project): disable deprecated tests (#4043) Because * We are now migrating all visualization work out of rapid and into nimbus * All of the legacy/core ui is in maintenance mode * Tests take up a lot of circle credits This commit * Disables all but the end to end integration tests for the legacy workflow * Disables all of the rapid/visualization js tests/linting * Disables the rapid/visualization dev yarn processes * Decreases the size of the make check circle instance * This should make the local dev lighter, make our tests faster, and reduce circle usage
2020-11-19 20:14:29 +03:00
feat(nimbus): Upgrade sdk integration tests to modern application-services (#10148) Because - The sdk integration test image was stuck on application-services v97.5.1 due to build system changes, which prevented landing any new targeting using new targeting attributes from v98 onwards. - The current system of periodically pushing a integration test image and pulling that pre-built image in tests lead to headaches and issues. - I discovered several oddities in the current integration-test-nimbus-rust setup (specifying a webdriver driver, sudo commands that never ran because sudo was not installed). - The new application services has a very different NimbusClient interface from the one currently used in tests. This commit - Adds a `experimenter:megazords` container, which is responsible for downloading a tagged nightly of the Cirrus and Nimbus-Experimenter megazords. - Adds a new `experimenter:integration-tests` container, which takes the place of the old "nimbus-rust-image" container. This container is very barebones, and only includes the application services megazord (copied from the other container) and tox. - Removes the old `Dockerfile-rust-image` and its publishing steps from CI. - Configures our integration tests to build the image on the fly instead of pulling a pre-built image from a registry. - Cleans up a few things in the `test_mobile_targeting.py` suite and updates the code to match the new interfaces. - Updates the `integration_test_nimbus_rust` task to run tox with `-vv`, which includes the output of any commands issued. Fixes #9820
2024-01-26 22:16:00 +03:00
build_integration_test: ssl build_megazords
$(DOCKER_BUILD) -f experimenter/tests/integration/Dockerfile -t experimenter:integration-tests experimenter/
feat(nimbus): Use pre-built A-S in Cirrus and Experimenter (#10151) feat(nimbus): Use pre-built A-S in Cirrus and Experimenter Because: - our integration tests have been updated to use pre-built application-services artifacts; - the Cirrus and Experimenter Dockerfiles are currently building application-services from source; - Cirrus was using a Debian buster (oldoldstable); and - Cirrus and Experimenter were using a pinned minor version of Python, which prevents them from getting security upgrades in minor patches. This commit: - updates the Cirrus and Experimenter Dockerfiles to reference the `experimenter:megazords` image, which contains the pre-built binaries; - updates Cirrus to use a Debian bullseye (oldstable) image; and - updates Cirrus and Experimenter to not pin the minor verison of Python (3.11.2 to 3.11). Fixes #10150
2024-01-31 00:08:02 +03:00
build_test: ssl build_megazords
fix #9451 chore(project): build multiple docker platforms in circle (#9452) Because * We can now target multiple platforms in our Docker builds in Circle This commit * Enables multiplatform builds for Docker in Circle
2023-09-20 23:30:37 +03:00
$(DOCKER_BUILD) --target test -f experimenter/Dockerfile -t experimenter:test experimenter/
fix #8360 feat(nimbus): Change root folder app to experimenter (#8375) Because - We will be adding cirrus in experimenter This commit - Rename `app` to `experimenter` and make necessary changes
2023-03-09 00:36:51 +03:00
bug(nimbus): Fix integration tests by reverting #9694 (#9712) Because: - #9694 broke integration tests; This commit - reverts #9694; and - adds an explicit pull of our integration test image in our CI workflow. Fixes #9707
2023-11-10 00:23:19 +03:00
build_ui: ssl
fix #9451 chore(project): build multiple docker platforms in circle (#9452) Because * We can now target multiple platforms in our Docker builds in Circle This commit * Enables multiplatform builds for Docker in Circle
2023-09-20 23:30:37 +03:00
$(DOCKER_BUILD) --target ui -f experimenter/Dockerfile -t experimenter:ui experimenter/
fix #6038 chore(project): cache docker ui layer (#6092) Because * We have a fourth layer in our Dockerfile that we're not remotely caching which slows down local builds/ci This commit * Builds and pushes the ui build target in our Dockerfile in circle
2021-07-30 20:50:12 +03:00
feat(nimbus): Use pre-built A-S in Cirrus and Experimenter (#10151) feat(nimbus): Use pre-built A-S in Cirrus and Experimenter Because: - our integration tests have been updated to use pre-built application-services artifacts; - the Cirrus and Experimenter Dockerfiles are currently building application-services from source; - Cirrus was using a Debian buster (oldoldstable); and - Cirrus and Experimenter were using a pinned minor version of Python, which prevents them from getting security upgrades in minor patches. This commit: - updates the Cirrus and Experimenter Dockerfiles to reference the `experimenter:megazords` image, which contains the pre-built binaries; - updates Cirrus to use a Debian bullseye (oldstable) image; and - updates Cirrus and Experimenter to not pin the minor verison of Python (3.11.2 to 3.11). Fixes #10150
2024-01-31 00:08:02 +03:00
build_prod: ssl build_megazords
fix #9451 chore(project): build multiple docker platforms in circle (#9452) Because * We can now target multiple platforms in our Docker builds in Circle This commit * Enables multiplatform builds for Docker in Circle
2023-09-20 23:30:37 +03:00
$(DOCKER_BUILD) --target deploy -f experimenter/Dockerfile -t experimenter:deploy experimenter/
Add project skeleton
2016-11-09 23:06:28 +03:00
Simplify integration test workflow fixes #1914 (#2354) * Simplify integration test workflow fixes #1914 * Separate kill into two commands for the full stack with normandy/dc * Suppress errors from failing to remove volumes * Try again to suppress volume rm errors * Integration tests need a bugzilla host to pass * Fixed vnc up detached command * Restore and skip failing test * Update README
2020-03-17 20:35:06 +03:00
compose_stop:
fix #5912 chore(project): suppress errors from docker compose commands (#5913) Because * As Docker continues to update and change the semantics of its commands, we must update the Makefile to adapt * Attempting to kill or remove already stopped/removed container entries can exit non-zero This commit * Suppresses non zero exit codes from kill/rm docker compose commands
2021-07-08 18:33:10 +03:00
$(COMPOSE) kill || true
$(COMPOSE_INTEGRATION) kill || true
$(COMPOSE_PROD) kill || true
Send experiment review email fixes #397
2018-06-06 01:34:43 +03:00
Use separate docker stack for integration tests fixes #1641 (#1644) * Use separate docker instances for integration tests fixes #1641 * Some cleanup * Oops gotta use the right env file * Use docker layer caching for the integration tests * Gotta add ssl to integration test run * Do we need to set the path owner to the circle user? * Use the correct user/group on circle * Lets try setting owner to ubuntu
2019-09-11 17:28:22 +03:00
compose_rm:
fix #5912 chore(project): suppress errors from docker compose commands (#5913) Because * As Docker continues to update and change the semantics of its commands, we must update the Makefile to adapt * Attempting to kill or remove already stopped/removed container entries can exit non-zero This commit * Suppresses non zero exit codes from kill/rm docker compose commands
2021-07-08 18:33:10 +03:00
$(COMPOSE) rm -f -v || true
$(COMPOSE_INTEGRATION) rm -f -v || true
$(COMPOSE_PROD) rm -f -v || true
Use separate docker stack for integration tests fixes #1641 (#1644) * Use separate docker instances for integration tests fixes #1641 * Some cleanup * Oops gotta use the right env file * Use docker layer caching for the integration tests * Gotta add ssl to integration test run * Do we need to set the path owner to the circle user? * Use the correct user/group on circle * Lets try setting owner to ubuntu
2019-09-11 17:28:22 +03:00
fix #8997 chore(project): remove unused containers (#8999) Because * Starting, stopping, and rebuilding docker containers can result in a growing number of old images, containers, and volumes * Eventually this can fill the disk allocated to docker and prevent new containers from starting * We have commands built into the Makefile for removing old and unused images and containers but it doesn't catch everything This commit * Updates the Makefile to remove more old and unused containers and images without impacting the build cache
2023-06-19 23:35:16 +03:00
docker_prune:
docker container prune -f
docker image prune -f
fix #3692 chore(project): reorganize static asset paths (#3693) Because * We now have 4 different frontend builds we should better organize where they are hosted and stored to disambiguate import paths This commit * Uses /static/ as the root path for all static assets for legacy and nimbus * Explicitly copies only the built assets of each into /served/ rather than all source * Updates import paths of affected assets in legacy * Fixes a bug in the volumes_rm command * Removes legacy unused served and asset volumes from docker compose * Removes legacy unused images * Removes legacy unused project templates
2020-10-08 00:12:56 +03:00
docker volume prune -f
fix #9287 chore(project): remove anonymous volumes in make kill (#9297) Becuase * Restarting docker containers can cause images, containers, volumes, etc to start piling up * Eventually you run out of disk space and have to docker system prune -a * We added some prune commands to remove temporary data on refresh * This was catching a bunch of things but missing 'anonymous volumes' This commit * Adds an additional step to docker_prune to remove anonymous volumes and prevent them from filling the disk
2023-08-18 23:50:04 +03:00
docker volume rm $$(docker volume ls -qf dangling=true) || true
Remove volumes in make kill fixes #1924 (#1925)
2019-11-16 03:08:21 +03:00
Implement most trivial rules from our quality standards (#9711) Because - We are trying to promote [Quality Standards](https://mozilla.github.io/syseng-pod/quality-standards/) across Mozilla's repositories - Experimenter has a [very good score already](https://mozilla.github.io/syseng-pod/quality-standards/#service-Experimenter) This PR - Implements a few of the harmless ones to improve even the score :) --------- Co-authored-by: Jared Lockhart <119884+jaredlockhart@users.noreply.github.com> Co-authored-by: Yashika Khurana <yashikakhuranayashika@gmail.com>
2023-11-10 04:18:05 +03:00
static_rm: ## Remove statically generated files
fix #8360 feat(nimbus): Change root folder app to experimenter (#8375) Because - We will be adding cirrus in experimenter This commit - Rename `app` to `experimenter` and make necessary changes
2023-03-09 00:36:51 +03:00
rm -Rf experimenter/node_modules
rm -Rf experimenter/experimenter/legacy/legacy-ui/core/node_modules/
rm -Rf experimenter/experimenter/nimbus-ui/node_modules/
rm -Rf experimenter/experimenter/legacy/legacy-ui/assets/
rm -Rf experimenter/experimenter/nimbus-ui/build/
fix #3687 chore(project): run integration tests against deploy image (#3822) Because * We split the docker image into two images, one for local dev and one for deploying to prod so that the prod one would be small ~100mb * We should find some way to test that the deploy image is working correctly * A good candidate is to run the integration tests against it This commit * Adds a new make up_prod command that sets up an environment that more closely mirrors prod ie - Use the prod image - Disable all the yarn watchers * Reorganizes the dockerfile to move frontend asset building out of the dev container to increase docker cache hits for local dev
2020-10-26 19:26:09 +03:00
Implement most trivial rules from our quality standards (#9711) Because - We are trying to promote [Quality Standards](https://mozilla.github.io/syseng-pod/quality-standards/) across Mozilla's repositories - Experimenter has a [very good score already](https://mozilla.github.io/syseng-pod/quality-standards/#service-Experimenter) This PR - Implements a few of the harmless ones to improve even the score :) --------- Co-authored-by: Jared Lockhart <119884+jaredlockhart@users.noreply.github.com> Co-authored-by: Yashika Khurana <yashikakhuranayashika@gmail.com>
2023-11-10 04:18:05 +03:00
kill: compose_stop compose_rm docker_prune ## Stop, remove, and prune containers
Use separate docker stack for integration tests fixes #1641 (#1644) * Use separate docker instances for integration tests fixes #1641 * Some cleanup * Oops gotta use the right env file * Use docker layer caching for the integration tests * Gotta add ssl to integration test run * Do we need to set the path owner to the circle user? * Use the correct user/group on circle * Lets try setting owner to ubuntu
2019-09-11 17:28:22 +03:00
echo "All containers removed!"
Implement most trivial rules from our quality standards (#9711) Because - We are trying to promote [Quality Standards](https://mozilla.github.io/syseng-pod/quality-standards/) across Mozilla's repositories - Experimenter has a [very good score already](https://mozilla.github.io/syseng-pod/quality-standards/#service-Experimenter) This PR - Implements a few of the harmless ones to improve even the score :) --------- Co-authored-by: Jared Lockhart <119884+jaredlockhart@users.noreply.github.com> Co-authored-by: Yashika Khurana <yashikakhuranayashika@gmail.com>
2023-11-10 04:18:05 +03:00
lint: build_test ## Running linting on source code
chore(project): docker run with --rm (#11664) Because: - we are creating many short-lived containers for commands; and - we are not cleaning them up except in `make kill` This commit: - updates all docker run commands to use the `--rm` flag so that they are automatically deleted after the container exits. Fixes #11662
2024-11-08 22:47:05 +03:00
$(COMPOSE_TEST_RUN) experimenter sh -c '$(WAIT_FOR_DB) (${PARALLEL} "$(NIMBUS_SCHEMA_CHECK)" "$(PYTHON_CHECK_MIGRATIONS)" "$(CHECK_DOCS)" "$(BLACK_CHECK)" "$(RUFF_CHECK)" "$(DJLINT_CHECK)" "$(ESLINT_LEGACY)" "$(ESLINT_NIMBUS_UI)" "$(ESLINT_NIMBUS_UI_NEW)" "$(TYPECHECK_NIMBUS_UI)" "$(PYTHON_TYPECHECK)" "$(PYTHON_TEST)" "$(JS_TEST_LEGACY)" "$(JS_TEST_NIMBUS_UI)" "$(JS_TEST_REPORTING)") ${COLOR_CHECK}'
Implement most trivial rules from our quality standards (#9711) Because - We are trying to promote [Quality Standards](https://mozilla.github.io/syseng-pod/quality-standards/) across Mozilla's repositories - Experimenter has a [very good score already](https://mozilla.github.io/syseng-pod/quality-standards/#service-Experimenter) This PR - Implements a few of the harmless ones to improve even the score :) --------- Co-authored-by: Jared Lockhart <119884+jaredlockhart@users.noreply.github.com> Co-authored-by: Yashika Khurana <yashikakhuranayashika@gmail.com>
2023-11-10 04:18:05 +03:00
check: lint
chore(nimbus): add make kill to all make test commands (#4990) Because * I just noticed while debugging another issue that circle only has app and db containers running while it runs tests, and if you make bash or up and have other containers running like redis or kinto or autograph, those can cause stateful changes to the test environment such as if a test is attempting to invoke a celery that hasn't been mocked out, having redis running in the background will allow that test to pass, so then it looks like the test is failing in circle and passing locally becuase you have redis up which can be confusing This commit * Runs make kill before starting any test so that if we hit a situation like that again, local testing should more closely replicate circle
2021-04-06 20:36:36 +03:00
Implement most trivial rules from our quality standards (#9711) Because - We are trying to promote [Quality Standards](https://mozilla.github.io/syseng-pod/quality-standards/) across Mozilla's repositories - Experimenter has a [very good score already](https://mozilla.github.io/syseng-pod/quality-standards/#service-Experimenter) This PR - Implements a few of the harmless ones to improve even the score :) --------- Co-authored-by: Jared Lockhart <119884+jaredlockhart@users.noreply.github.com> Co-authored-by: Yashika Khurana <yashikakhuranayashika@gmail.com>
2023-11-10 04:18:05 +03:00
test: build_test ## Run tests
chore(project): docker run with --rm (#11664) Because: - we are creating many short-lived containers for commands; and - we are not cleaning them up except in `make kill` This commit: - updates all docker run commands to use the `--rm` flag so that they are automatically deleted after the container exits. Fixes #11662
2024-11-08 22:47:05 +03:00
$(COMPOSE_TEST_RUN) experimenter sh -c '$(WAIT_FOR_DB) $(PYTHON_TEST)'
Implement most trivial rules from our quality standards (#9711) Because - We are trying to promote [Quality Standards](https://mozilla.github.io/syseng-pod/quality-standards/) across Mozilla's repositories - Experimenter has a [very good score already](https://mozilla.github.io/syseng-pod/quality-standards/#service-Experimenter) This PR - Implements a few of the harmless ones to improve even the score :) --------- Co-authored-by: Jared Lockhart <119884+jaredlockhart@users.noreply.github.com> Co-authored-by: Yashika Khurana <yashikakhuranayashika@gmail.com>
2023-11-10 04:18:05 +03:00
pytest: test
chore(nimbus): add make kill to all make test commands (#4990) Because * I just noticed while debugging another issue that circle only has app and db containers running while it runs tests, and if you make bash or up and have other containers running like redis or kinto or autograph, those can cause stateful changes to the test environment such as if a test is attempting to invoke a celery that hasn't been mocked out, having redis running in the background will allow that test to pass, so then it looks like the test is failing in circle and passing locally becuase you have redis up which can be confusing This commit * Runs make kill before starting any test so that if we hit a situation like that again, local testing should more closely replicate circle
2021-04-06 20:36:36 +03:00
Implement most trivial rules from our quality standards (#9711) Because - We are trying to promote [Quality Standards](https://mozilla.github.io/syseng-pod/quality-standards/) across Mozilla's repositories - Experimenter has a [very good score already](https://mozilla.github.io/syseng-pod/quality-standards/#service-Experimenter) This PR - Implements a few of the harmless ones to improve even the score :) --------- Co-authored-by: Jared Lockhart <119884+jaredlockhart@users.noreply.github.com> Co-authored-by: Yashika Khurana <yashikakhuranayashika@gmail.com>
2023-11-10 04:18:05 +03:00
start: build_dev ## Start containers
Reduce duplication in makefile fixes #1966 (#2021)
2019-12-03 21:26:20 +03:00
$(COMPOSE) up
chore(project): add a flag to disable/enable cirrus (#9916) Because * Building Cirrus can be time consuming * Cirrus is not necessary for many integration tests or local workflows * We can add a flag to enable/disable cirrus to speed up the integration tests or local workflows that don't involve Cirrus This commit * Adds a flag to enable/disable Cirrus in the Makefile * Sets the flag automatically for all Cirrus make commands * Sets the flag for Cirrus integration tests fixes #9910
2023-12-07 22:50:36 +03:00
Implement most trivial rules from our quality standards (#9711) Because - We are trying to promote [Quality Standards](https://mozilla.github.io/syseng-pod/quality-standards/) across Mozilla's repositories - Experimenter has a [very good score already](https://mozilla.github.io/syseng-pod/quality-standards/#service-Experimenter) This PR - Implements a few of the harmless ones to improve even the score :) --------- Co-authored-by: Jared Lockhart <119884+jaredlockhart@users.noreply.github.com> Co-authored-by: Yashika Khurana <yashikakhuranayashika@gmail.com>
2023-11-10 04:18:05 +03:00
up: start
Add project skeleton
2016-11-09 23:06:28 +03:00
fix #6828 chore(project): disable legacy tests and dev services (#6829) Because * The legacy workflow is in maintenance only mode and has not had any changes or failures in over a year This commit * Moves the legacy tests out of make check but preserves them in make check_legacy * Moves the legacy dev services out of make up but preserves them in make up_legacy * Removes the integration_legacy job from circle
2022-01-04 01:43:53 +03:00
up_legacy: build_dev
$(COMPOSE_LEGACY) up
fix #5946 chore(project): cache docker layers in dockerhub (#5948) Because * It would save time if we push the docker build layers from circleci to dockerhub to reuse locally This commit * Uses the new buildkit --cache-from flag to pull in build layers from dockerhub when applicable * Builds all stages and pushes them with their layers to dockerhub on every merge to main * Configures local builds to pull those layers from dockerhub * Removes the build circle stage since each circle task will now be able to pull from dockerhub rather than the local circle docker cache
2021-07-15 18:37:09 +03:00
up_prod: build_prod
fix #3687 chore(project): run integration tests against deploy image (#3822) Because * We split the docker image into two images, one for local dev and one for deploying to prod so that the prod one would be small ~100mb * We should find some way to test that the deploy image is working correctly * A good candidate is to run the integration tests against it This commit * Adds a new make up_prod command that sets up an environment that more closely mirrors prod ie - Use the prod image - Disable all the yarn watchers * Reorganizes the dockerfile to move frontend asset building out of the dev container to increase docker cache hits for local dev
2020-10-26 19:26:09 +03:00
$(COMPOSE_PROD) up
fix #5946 chore(project): cache docker layers in dockerhub (#5948) Because * It would save time if we push the docker build layers from circleci to dockerhub to reuse locally This commit * Uses the new buildkit --cache-from flag to pull in build layers from dockerhub when applicable * Builds all stages and pushes them with their layers to dockerhub on every merge to main * Configures local builds to pull those layers from dockerhub * Removes the build circle stage since each circle task will now be able to pull from dockerhub rather than the local circle docker cache
2021-07-15 18:37:09 +03:00
up_prod_detached: build_prod
fix #3687 chore(project): run integration tests against deploy image (#3822) Because * We split the docker image into two images, one for local dev and one for deploying to prod so that the prod one would be small ~100mb * We should find some way to test that the deploy image is working correctly * A good candidate is to run the integration tests against it This commit * Adds a new make up_prod command that sets up an environment that more closely mirrors prod ie - Use the prod image - Disable all the yarn watchers * Reorganizes the dockerfile to move frontend asset building out of the dev container to increase docker cache hits for local dev
2020-10-26 19:26:09 +03:00
$(COMPOSE_PROD) up -d
fix #5946 chore(project): cache docker layers in dockerhub (#5948) Because * It would save time if we push the docker build layers from circleci to dockerhub to reuse locally This commit * Uses the new buildkit --cache-from flag to pull in build layers from dockerhub when applicable * Builds all stages and pushes them with their layers to dockerhub on every merge to main * Configures local builds to pull those layers from dockerhub * Removes the build circle stage since each circle task will now be able to pull from dockerhub rather than the local circle docker cache
2021-07-15 18:37:09 +03:00
up_db: build_dev
fix #3411 refactor(docker): move dev containers to host network (#3420) feat: move dev containers to host network Because: * allow processes on host machine (django runserver, yarn watcher) to talk to containerized processes * more flexibility for dev environments to run combinations of local and containerized processes This commit: * remove network definitions from all compose files * remove docker-compose-full.yml (used for setting up a complete stack with normandy but isn't used anymore) * remove unused makefile commands (nobody uses all the individual test/lint commands) * add new make commands up_db up_django * update README.md
2020-09-12 00:12:46 +03:00
$(COMPOSE) up db redis kinto autograph
fix #5946 chore(project): cache docker layers in dockerhub (#5948) Because * It would save time if we push the docker build layers from circleci to dockerhub to reuse locally This commit * Uses the new buildkit --cache-from flag to pull in build layers from dockerhub when applicable * Builds all stages and pushes them with their layers to dockerhub on every merge to main * Configures local builds to pull those layers from dockerhub * Removes the build circle stage since each circle task will now be able to pull from dockerhub rather than the local circle docker cache
2021-07-15 18:37:09 +03:00
up_django: build_dev
fix #8360 feat(nimbus): Change root folder app to experimenter (#8375) Because - We will be adding cirrus in experimenter This commit - Rename `app` to `experimenter` and make necessary changes
2023-03-09 00:36:51 +03:00
$(COMPOSE) up nginx experimenter worker beat db redis kinto autograph
fix #3411 refactor(docker): move dev containers to host network (#3420) feat: move dev containers to host network Because: * allow processes on host machine (django runserver, yarn watcher) to talk to containerized processes * more flexibility for dev environments to run combinations of local and containerized processes This commit: * remove network definitions from all compose files * remove docker-compose-full.yml (used for setting up a complete stack with normandy but isn't used anymore) * remove unused makefile commands (nobody uses all the individual test/lint commands) * add new make commands up_db up_django * update README.md
2020-09-12 00:12:46 +03:00
fix #5946 chore(project): cache docker layers in dockerhub (#5948) Because * It would save time if we push the docker build layers from circleci to dockerhub to reuse locally This commit * Uses the new buildkit --cache-from flag to pull in build layers from dockerhub when applicable * Builds all stages and pushes them with their layers to dockerhub on every merge to main * Configures local builds to pull those layers from dockerhub * Removes the build circle stage since each circle task will now be able to pull from dockerhub rather than the local circle docker cache
2021-07-15 18:37:09 +03:00
up_detached: build_dev
Simplify integration test workflow fixes #1914 (#2354) * Simplify integration test workflow fixes #1914 * Separate kill into two commands for the full stack with normandy/dc * Suppress errors from failing to remove volumes * Try again to suppress volume rm errors * Integration tests need a bugzilla host to pass * Fixed vnc up detached command * Restore and skip failing test * Update README
2020-03-17 20:35:06 +03:00
$(COMPOSE) up -d
fix #5946 chore(project): cache docker layers in dockerhub (#5948) Because * It would save time if we push the docker build layers from circleci to dockerhub to reuse locally This commit * Uses the new buildkit --cache-from flag to pull in build layers from dockerhub when applicable * Builds all stages and pushes them with their layers to dockerhub on every merge to main * Configures local builds to pull those layers from dockerhub * Removes the build circle stage since each circle task will now be able to pull from dockerhub rather than the local circle docker cache
2021-07-15 18:37:09 +03:00
generate_docs: build_dev
chore(project): docker run with --rm (#11664) Because: - we are creating many short-lived containers for commands; and - we are not cleaning them up except in `make kill` This commit: - updates all docker run commands to use the `--rm` flag so that they are automatically deleted after the container exits. Fixes #11662
2024-11-08 22:47:05 +03:00
$(COMPOSE_RUN) experimenter sh -c "$(GENERATE_DOCS)"
Update make commands after removing volume mapping from test compose fixes #2295 (#2301)
2020-02-21 21:45:39 +03:00
chore(project): disable deprecated tests (#4043) Because * We are now migrating all visualization work out of rapid and into nimbus * All of the legacy/core ui is in maintenance mode * Tests take up a lot of circle credits This commit * Disables all but the end to end integration tests for the legacy workflow * Disables all of the rapid/visualization js tests/linting * Disables the rapid/visualization dev yarn processes * Decreases the size of the make check circle instance * This should make the local dev lighter, make our tests faster, and reduce circle usage
2020-11-19 20:14:29 +03:00
generate_types: build_dev
chore(project): docker run with --rm (#11664) Because: - we are creating many short-lived containers for commands; and - we are not cleaning them up except in `make kill` This commit: - updates all docker run commands to use the `--rm` flag so that they are automatically deleted after the container exits. Fixes #11662
2024-11-08 22:47:05 +03:00
$(COMPOSE_RUN) experimenter sh -c "$(NIMBUS_TYPES_GENERATE)"
fix #3907 chore(nimbus): make types_check should fail with graphql changes (#3915) Because * We'd like to make sure that the apollo client generated code stays in sync with the server This commit * Uses the schema.graphql to check whether the backend is in sync with the frontend codebase * regenerates the schema.graphql and typescript stubs together so they stay in sync
2020-11-09 22:57:03 +03:00
Implement most trivial rules from our quality standards (#9711) Because - We are trying to promote [Quality Standards](https://mozilla.github.io/syseng-pod/quality-standards/) across Mozilla's repositories - Experimenter has a [very good score already](https://mozilla.github.io/syseng-pod/quality-standards/#service-Experimenter) This PR - Implements a few of the harmless ones to improve even the score :) --------- Co-authored-by: Jared Lockhart <119884+jaredlockhart@users.noreply.github.com> Co-authored-by: Yashika Khurana <yashikakhuranayashika@gmail.com>
2023-11-10 04:18:05 +03:00
format: build_dev ## Format source tree
chore(project): docker run with --rm (#11664) Because: - we are creating many short-lived containers for commands; and - we are not cleaning them up except in `make kill` This commit: - updates all docker run commands to use the `--rm` flag so that they are automatically deleted after the container exits. Fixes #11662
2024-11-08 22:47:05 +03:00
$(COMPOSE_RUN) experimenter sh -c '${PARALLEL} "$(RUFF_FIX);$(DJLINT_FIX);$(BLACK_FIX)" "$(ESLINT_FIX_CORE)" "$(ESLINT_FIX_NIMBUS_UI)" "$(ESLINT_FIX_NIMBUS_UI_NEW)"'
Implement most trivial rules from our quality standards (#9711) Because - We are trying to promote [Quality Standards](https://mozilla.github.io/syseng-pod/quality-standards/) across Mozilla's repositories - Experimenter has a [very good score already](https://mozilla.github.io/syseng-pod/quality-standards/#service-Experimenter) This PR - Implements a few of the harmless ones to improve even the score :) --------- Co-authored-by: Jared Lockhart <119884+jaredlockhart@users.noreply.github.com> Co-authored-by: Yashika Khurana <yashikakhuranayashika@gmail.com>
2023-11-10 04:18:05 +03:00
code_format: format
Update make commands after removing volume mapping from test compose fixes #2295 (#2301)
2020-02-21 21:45:39 +03:00
fix #5946 chore(project): cache docker layers in dockerhub (#5948) Because * It would save time if we push the docker build layers from circleci to dockerhub to reuse locally This commit * Uses the new buildkit --cache-from flag to pull in build layers from dockerhub when applicable * Builds all stages and pushes them with their layers to dockerhub on every merge to main * Configures local builds to pull those layers from dockerhub * Removes the build circle stage since each circle task will now be able to pull from dockerhub rather than the local circle docker cache
2021-07-15 18:37:09 +03:00
makemigrations: build_dev
chore(project): docker run with --rm (#11664) Because: - we are creating many short-lived containers for commands; and - we are not cleaning them up except in `make kill` This commit: - updates all docker run commands to use the `--rm` flag so that they are automatically deleted after the container exits. Fixes #11662
2024-11-08 22:47:05 +03:00
$(COMPOSE_RUN) experimenter python manage.py makemigrations
Enforce 1 control and 1 variant per experiment fixes #52
2017-05-05 22:52:56 +03:00
Implement most trivial rules from our quality standards (#9711) Because - We are trying to promote [Quality Standards](https://mozilla.github.io/syseng-pod/quality-standards/) across Mozilla's repositories - Experimenter has a [very good score already](https://mozilla.github.io/syseng-pod/quality-standards/#service-Experimenter) This PR - Implements a few of the harmless ones to improve even the score :) --------- Co-authored-by: Jared Lockhart <119884+jaredlockhart@users.noreply.github.com> Co-authored-by: Yashika Khurana <yashikakhuranayashika@gmail.com>
2023-11-10 04:18:05 +03:00
migrate: build_dev ## Run database migrations
chore(project): docker run with --rm (#11664) Because: - we are creating many short-lived containers for commands; and - we are not cleaning them up except in `make kill` This commit: - updates all docker run commands to use the `--rm` flag so that they are automatically deleted after the container exits. Fixes #11662
2024-11-08 22:47:05 +03:00
$(COMPOSE_RUN) experimenter sh -c "$(WAIT_FOR_DB) $(PYTHON_MIGRATE)"
Add project skeleton
2016-11-09 23:06:28 +03:00
fix #5946 chore(project): cache docker layers in dockerhub (#5948) Because * It would save time if we push the docker build layers from circleci to dockerhub to reuse locally This commit * Uses the new buildkit --cache-from flag to pull in build layers from dockerhub when applicable * Builds all stages and pushes them with their layers to dockerhub on every merge to main * Configures local builds to pull those layers from dockerhub * Removes the build circle stage since each circle task will now be able to pull from dockerhub rather than the local circle docker cache
2021-07-15 18:37:09 +03:00
bash: build_dev
chore(project): docker run with --rm (#11664) Because: - we are creating many short-lived containers for commands; and - we are not cleaning them up except in `make kill` This commit: - updates all docker run commands to use the `--rm` flag so that they are automatically deleted after the container exits. Fixes #11662
2024-11-08 22:47:05 +03:00
$(COMPOSE_RUN) experimenter bash
Add dbshell and kill to Makefile
2017-04-27 21:42:17 +03:00
feat(project): add a make refresh_db target (#11663) Because: - make refresh does rebuild the DB but also blows away all containers; and - I just want to rebuild the DB This commit: - adds a make refresh_db (which refresh depends on) that will just recreate the database. Fixes #11661
2024-10-31 22:49:37 +03:00
refresh: kill build_dev compose_build refresh_db ## Rebuild all containers and the database
refresh_db: # Rebuild the database
chore(project): docker run with --rm (#11664) Because: - we are creating many short-lived containers for commands; and - we are not cleaning them up except in `make kill` This commit: - updates all docker run commands to use the `--rm` flag so that they are automatically deleted after the container exits. Fixes #11662
2024-11-08 22:47:05 +03:00
$(COMPOSE_RUN) -e SKIP_DUMMY=$$SKIP_DUMMY experimenter bash -c '$(WAIT_FOR_DB) $(PYTHON_MIGRATE)&&$(LOAD_LOCALES)&&$(LOAD_COUNTRIES)&&$(LOAD_LANGUAGES)&&$(LOAD_FEATURES)&&$(LOAD_DUMMY_EXPERIMENTS)'
Use separate docker stack for integration tests fixes #1641 (#1644) * Use separate docker instances for integration tests fixes #1641 * Some cleanup * Oops gotta use the right env file * Use docker layer caching for the integration tests * Gotta add ssl to integration test run * Do we need to set the path owner to the circle user? * Use the correct user/group on circle * Lets try setting owner to ubuntu
2019-09-11 17:28:22 +03:00
fix #5949 chore(project): add makefile command to approve dependabot prs (#5950) Because * Rather than approving each dependabot pr by hand, it'd be handy to just do them all at once with the github cli This commit * Adds a makefile command to approve all dependabot prs
2021-07-14 22:09:33 +03:00
dependabot_approve:
echo "Install and configure the Github CLI https://github.com/cli/cli"
fix #9233 chore(project): update make dependabot_approve to support merge queue (#9234) Because * We recently added the gh merge queue to our project * This broke our make dependabot_approve command This commit * Updates our make dependabot_approve command to work with the merge queue
2023-08-08 22:16:58 +03:00
gh pr list | grep "dependabot/" | awk '{print $$1}' | xargs -n1 gh pr review -a -b "@dependabot squash and merge"
gh pr list | grep "dependabot/" | awk '{print $$1}' | xargs -n1 gh pr merge
fix #5949 chore(project): add makefile command to approve dependabot prs (#5950) Because * Rather than approving each dependabot pr by hand, it'd be handy to just do them all at once with the github cli This commit * Adds a makefile command to approve all dependabot prs
2021-07-14 22:09:33 +03:00
Use separate docker stack for integration tests fixes #1641 (#1644) * Use separate docker instances for integration tests fixes #1641 * Some cleanup * Oops gotta use the right env file * Use docker layer caching for the integration tests * Gotta add ssl to integration test run * Do we need to set the path owner to the circle user? * Use the correct user/group on circle * Lets try setting owner to ubuntu
2019-09-11 17:28:22 +03:00
# integration tests
fix #5946 chore(project): cache docker layers in dockerhub (#5948) Because * It would save time if we push the docker build layers from circleci to dockerhub to reuse locally This commit * Uses the new buildkit --cache-from flag to pull in build layers from dockerhub when applicable * Builds all stages and pushes them with their layers to dockerhub on every merge to main * Configures local builds to pull those layers from dockerhub * Removes the build circle stage since each circle task will now be able to pull from dockerhub rather than the local circle docker cache
2021-07-15 18:37:09 +03:00
integration_shell:
chore(project): docker run with --rm (#11664) Because: - we are creating many short-lived containers for commands; and - we are not cleaning them up except in `make kill` This commit: - updates all docker run commands to use the `--rm` flag so that they are automatically deleted after the container exits. Fixes #11662
2024-11-08 22:47:05 +03:00
$(COMPOSE_INTEGRATION_RUN) firefox bash
Change analysis owner to foreign key fixes #1652 (#1725) * Change analysis owner to foreign key fixes #1652 * Update integration tests * Oops an uncovered line * Missing a space apparently * That can go on one line * SM is case sensitive, use lower strings to compare
2019-10-09 21:02:08 +03:00
bug(nimbus): Support latest uniffi changes in application services (#10520) Because - application-services updated uniffi, which resulted in generating Python with relative imports; This commit: - updates our application-services packaging to produce a `nimbus_megazord` Python package; and - updates to the latest application-services build. Fixes #10521
2024-04-05 18:51:17 +03:00
integration_sdk_shell: build_prod build_integration_test
chore(project): docker run with --rm (#11664) Because: - we are creating many short-lived containers for commands; and - we are not cleaning them up except in `make kill` This commit: - updates all docker run commands to use the `--rm` flag so that they are automatically deleted after the container exits. Fixes #11662
2024-11-08 22:47:05 +03:00
$(COMPOSE_INTEGRATION_RUN) rust-sdk bash
fixes #7300 feat(nimbus): Add integration testing between the SDK and experimenter. (#7301) * fixes #7300 feat(nimbus): Add integration testing between the SDK and experimenter.
2022-06-07 19:31:50 +03:00
fix #7661 chore(nimbus): Update integration_sdk_shell command (#7662) * fix #7661 chore(nimbus): Update command * fix #7661 chore(nimbus): Build prod * fix #7661 chore(nimbus): Build prod
2022-09-02 19:14:36 +03:00
integration_vnc_up: build_prod
chore(project): Fix exp-10370, attached vnc image not starting. (#10371) Because - The ```integration_vnc_up``` command was failing to start This commit - Fixes the error by just starting the firefox container Fixes #10370
2024-03-07 03:37:58 +03:00
$(COMPOSE_INTEGRATION) up firefox
Updated makefile for headless firefox. (#2414) * Updated makefile for headless firefox. Removed vnc service from docker-compose. * Updates. * Removing extra changes. * Remove reruns. * Also gotta get rid of this Co-authored-by: Jared Lockhart <119884+jaredlockhart@users.noreply.github.com>
2020-03-30 19:04:18 +03:00
fix #7661 chore(nimbus): Update integration_sdk_shell command (#7662) * fix #7661 chore(nimbus): Update command * fix #7661 chore(nimbus): Build prod * fix #7661 chore(nimbus): Build prod
2022-09-02 19:14:36 +03:00
integration_vnc_up_detached: build_prod
Updated makefile for headless firefox. (#2414) * Updated makefile for headless firefox. Removed vnc service from docker-compose. * Updates. * Removing extra changes. * Remove reruns. * Also gotta get rid of this Co-authored-by: Jared Lockhart <119884+jaredlockhart@users.noreply.github.com>
2020-03-30 19:04:18 +03:00
$(COMPOSE_INTEGRATION) up -d firefox
Use separate docker stack for integration tests fixes #1641 (#1644) * Use separate docker instances for integration tests fixes #1641 * Some cleanup * Oops gotta use the right env file * Use docker layer caching for the integration tests * Gotta add ssl to integration test run * Do we need to set the path owner to the circle user? * Use the correct user/group on circle * Lets try setting owner to ubuntu
2019-09-11 17:28:22 +03:00
fix #7661 chore(nimbus): Update integration_sdk_shell command (#7662) * fix #7661 chore(nimbus): Update command * fix #7661 chore(nimbus): Build prod * fix #7661 chore(nimbus): Build prod
2022-09-02 19:14:36 +03:00
integration_test_legacy: build_prod
chore(project): docker run with --rm (#11664) Because: - we are creating many short-lived containers for commands; and - we are not cleaning them up except in `make kill` This commit: - updates all docker run commands to use the `--rm` flag so that they are automatically deleted after the container exits. Fixes #11662
2024-11-08 22:47:05 +03:00
MOZ_HEADLESS=1 $(COMPOSE_INTEGRATION_RUN) firefox sh -c "./experimenter/tests/experimenter_legacy_tests.sh"
Initial commit adding e2e integration tests for nimbus frontend. (#4988) * Initial commit adding e2e integration tests for nimbus frontend.
2021-04-14 23:04:31 +03:00
fix #7661 chore(nimbus): Update integration_sdk_shell command (#7662) * fix #7661 chore(nimbus): Update command * fix #7661 chore(nimbus): Build prod * fix #7661 chore(nimbus): Build prod
2022-09-02 19:14:36 +03:00
integration_test_nimbus: build_prod
chore(project): docker run with --rm (#11664) Because: - we are creating many short-lived containers for commands; and - we are not cleaning them up except in `make kill` This commit: - updates all docker run commands to use the `--rm` flag so that they are automatically deleted after the container exits. Fixes #11662
2024-11-08 22:47:05 +03:00
MOZ_HEADLESS=1 $(COMPOSE_INTEGRATION_RUN) firefox sh -c "UPDATE_FIREFOX_VERSION=$(UPDATE_FIREFOX_VERSION) FIREFOX_BETA=$(FIREFOX_BETA) FIREFOX_RELEASE=$(FIREFOX_RELEASE) PYTEST_SENTRY_DSN=$(PYTEST_SENTRY_DSN) PYTEST_SENTRY_ALWAYS_REPORT=$(PYTEST_SENTRY_ALWAYS_REPORT) CIRCLECI=$(CIRCLECI) ./experimenter/tests/nimbus_integration_tests.sh"
fixes #7300 feat(nimbus): Add integration testing between the SDK and experimenter. (#7301) * fixes #7300 feat(nimbus): Add integration testing between the SDK and experimenter.
2022-06-07 19:31:50 +03:00
feat(nimbus): Upgrade sdk integration tests to modern application-services (#10148) Because - The sdk integration test image was stuck on application-services v97.5.1 due to build system changes, which prevented landing any new targeting using new targeting attributes from v98 onwards. - The current system of periodically pushing a integration test image and pulling that pre-built image in tests lead to headaches and issues. - I discovered several oddities in the current integration-test-nimbus-rust setup (specifying a webdriver driver, sudo commands that never ran because sudo was not installed). - The new application services has a very different NimbusClient interface from the one currently used in tests. This commit - Adds a `experimenter:megazords` container, which is responsible for downloading a tagged nightly of the Cirrus and Nimbus-Experimenter megazords. - Adds a new `experimenter:integration-tests` container, which takes the place of the old "nimbus-rust-image" container. This container is very barebones, and only includes the application services megazord (copied from the other container) and tox. - Removes the old `Dockerfile-rust-image` and its publishing steps from CI. - Configures our integration tests to build the image on the fly instead of pulling a pre-built image from a registry. - Cleans up a few things in the `test_mobile_targeting.py` suite and updates the code to match the new interfaces. - Updates the `integration_test_nimbus_rust` task to run tox with `-vv`, which includes the output of any commands issued. Fixes #9820
2024-01-26 22:16:00 +03:00
integration_test_nimbus_rust: build_integration_test build_prod
chore(project): docker run with --rm (#11664) Because: - we are creating many short-lived containers for commands; and - we are not cleaning them up except in `make kill` This commit: - updates all docker run commands to use the `--rm` flag so that they are automatically deleted after the container exits. Fixes #11662
2024-11-08 22:47:05 +03:00
MOZ_HEADLESS=1 $(COMPOSE_INTEGRATION_RUN) -it rust-sdk sh -c "./experimenter/tests/nimbus_rust_tests.sh"
test(nimbus): Add android e2e test config. (#10844) Because It would be awesome to extend our coverage to android devices to make sure those stay healthy. This commit * Adds a job to build the fenix test APKs from mozilla central. * Adds a job to run a small suite of tests on fenix Fixes #10843
2024-06-24 21:56:10 +03:00
integration_test_nimbus_fenix:
chore(project): Change fenix integration tests to run off of upstream trigger. (#11233) Because - We want to run certain jobs based on external dependency changes as they happen. This commit - Changes the fenix integration and enrollment tests to run when a change has been detected within fenix. Fixes #11230
2024-08-27 23:41:33 +03:00
poetry -C experimenter/tests/integration/ -vvv install --no-root
poetry -C experimenter/tests/integration/ -vvv run pytest --html=experimenter/tests/integration/test-reports/report.htm --self-contained-html --reruns-delay 30 --driver Firefox experimenter/tests/integration/nimbus/android -vvv
fix #8576 chore(nimbus): update android feature manifest paths (#8477) Because * The feature manifest paths for Fenix and Focus Android have changed This commit * Updates to the latest feature manifest paths Because - Reason This commit - Change
2023-03-13 21:54:35 +03:00
fix #8377 feat(cirrus): Initial commit (#8384) Because - We want to add Cirrus to the experimenter repo This commit - Set up the cirrus server and requirements - Set up Dockerfile and include cirrus in docker-compose file - To run the cirrus server- use command `make cirrus_up`
2023-03-06 21:45:53 +03:00
# cirrus
chore(project): add a flag to disable/enable cirrus (#9916) Because * Building Cirrus can be time consuming * Cirrus is not necessary for many integration tests or local workflows * We can add a flag to enable/disable cirrus to speed up the integration tests or local workflows that don't involve Cirrus This commit * Adds a flag to enable/disable Cirrus in the Makefile * Sets the flag automatically for all Cirrus make commands * Sets the flag for Cirrus integration tests fixes #9910
2023-12-07 22:50:36 +03:00
CIRRUS_ENABLE = export CIRRUS=1 &&
fix #8817 chore(cirrus): only copy cirrus files into cirrus container (#8821) Becuase * We were copying the entire experimenter repo into the cirrus container * The cirrus container only needs the cirrus files This commit * Only copies the cirrus files into the cirrus container * Removes unnecessary top level python module files and updates import paths * Updates all path references * Build cirrus container on every cirrus make command * Remove duplicate cirrus entry from test compose file Co-authored-by: Yashika Khurana <yashikakhuranayashika@gmail.com>
2023-05-15 19:49:52 +03:00
CIRRUS_BLACK_CHECK = black -l 90 --check --diff .
CIRRUS_BLACK_FIX = black -l 90 .
chore(deps-dev): Bump ruff from 0.4.1 to 0.5.0 in /schemas (#10927) Bumps [ruff](https://github.com/astral-sh/ruff) from 0.4.1 to 0.5.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/astral-sh/ruff/releases">ruff's releases</a>.</em></p> <blockquote> <h2>0.5.0</h2> <h2>Release Notes</h2> <p>Check out the <a href="https://astral.sh/blog/ruff-v0.5.0">blog post</a> for a migration guide and overview of the changes!</p> <h3>Breaking changes</h3> <p>See also, the &quot;Remapped rules&quot; section which may result in disabled rules.</p> <ul> <li>Follow the XDG specification to discover user-level configurations on macOS (same as on other Unix platforms)</li> <li>Selecting <code>ALL</code> now excludes deprecated rules</li> <li>The released archives now include an extra level of nesting, which can be removed with <code>--strip-components=1</code> when untarring.</li> <li>The release artifact's file name no longer includes the version tag. This enables users to install via <code>/latest</code> URLs on GitHub.</li> <li>The diagnostic ranges for some <code>flake8-bandit</code> rules were modified (<a href="https://redirect.github.com/astral-sh/ruff/pull/10667">#10667</a>).</li> </ul> <h3>Deprecations</h3> <p>The following rules are now deprecated:</p> <ul> <li><a href="https://docs.astral.sh/ruff/rules/syntax-error/"><code>syntax-error</code></a> (<code>E999</code>): Syntax errors are now always shown</li> </ul> <h3>Remapped rules</h3> <p>The following rules have been remapped to new rule codes:</p> <ul> <li><a href="https://docs.astral.sh/ruff/rules/blocking-http-call-in-async-function/"><code>blocking-http-call-in-async-function</code></a>: <code>ASYNC100</code> to <code>ASYNC210</code></li> <li><a href="https://docs.astral.sh/ruff/rules/open-sleep-or-subprocess-in-async-function/"><code>open-sleep-or-subprocess-in-async-function</code></a>: <code>ASYNC101</code> split into <code>ASYNC220</code>, <code>ASYNC221</code>, <code>ASYNC230</code>, and <code>ASYNC251</code></li> <li><a href="https://docs.astral.sh/ruff/rules/blocking-os-call-in-async-function/"><code>blocking-os-call-in-async-function</code></a>: <code>ASYNC102</code> has been merged into <code>ASYNC220</code> and <code>ASYNC221</code></li> <li><a href="https://docs.astral.sh/ruff/rules/trio-timeout-without-await/"><code>trio-timeout-without-await</code></a>: <code>TRIO100</code> to <code>ASYNC100</code></li> <li><a href="https://docs.astral.sh/ruff/rules/trio-sync-call/"><code>trio-sync-call</code></a>: <code>TRIO105</code> to <code>ASYNC105</code></li> <li><a href="https://docs.astral.sh/ruff/rules/trio-async-function-with-timeout/"><code>trio-async-function-with-timeout</code></a>: <code>TRIO109</code> to <code>ASYNC109</code></li> <li><a href="https://docs.astral.sh/ruff/rules/trio-unneeded-sleep/"><code>trio-unneeded-sleep</code></a>: <code>TRIO110</code> to <code>ASYNC110</code></li> <li><a href="https://docs.astral.sh/ruff/rules/trio-zero-sleep-call/"><code>trio-zero-sleep-call</code></a>: <code>TRIO115</code> to <code>ASYNC115</code></li> <li><a href="https://docs.astral.sh/ruff/rules/repeated-isinstance-calls/"><code>repeated-isinstance-calls</code></a>: <code>PLR1701</code> to <code>SIM101</code></li> </ul> <h3>Stabilization</h3> <p>The following rules have been stabilized and are no longer in preview:</p> <ul> <li><a href="https://docs.astral.sh/ruff/rules/mutable-fromkeys-value/"><code>mutable-fromkeys-value</code></a> (<code>RUF024</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/default-factory-kwarg/"><code>default-factory-kwarg</code></a> (<code>RUF026</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/django-extra/"><code>django-extra</code></a> (<code>S610</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/manual-dict-comprehension/"><code>manual-dict-comprehension</code></a> (<code>PERF403</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/print-empty-string/"><code>print-empty-string</code></a> (<code>FURB105</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/readlines-in-for/"><code>readlines-in-for</code></a> (<code>FURB129</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/if-expr-min-max/"><code>if-expr-min-max</code></a> (<code>FURB136</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/bit-count/"><code>bit-count</code></a> (<code>FURB161</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/redundant-log-base/"><code>redundant-log-base</code></a> (<code>FURB163</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/regex-flag-alias/"><code>regex-flag-alias</code></a> (<code>FURB167</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/isinstance-type-none/"><code>isinstance-type-none</code></a> (<code>FURB168</code>)</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md">ruff's changelog</a>.</em></p> <blockquote> <h2>0.5.0</h2> <p>Check out the <a href="https://astral.sh/blog/ruff-v0.5.0">blog post</a> for a migration guide and overview of the changes!</p> <h3>Breaking changes</h3> <p>See also, the &quot;Remapped rules&quot; section which may result in disabled rules.</p> <ul> <li>Follow the XDG specification to discover user-level configurations on macOS (same as on other Unix platforms)</li> <li>Selecting <code>ALL</code> now excludes deprecated rules</li> <li>The released archives now include an extra level of nesting, which can be removed with <code>--strip-components=1</code> when untarring.</li> <li>The release artifact's file name no longer includes the version tag. This enables users to install via <code>/latest</code> URLs on GitHub.</li> <li>The diagnostic ranges for some <code>flake8-bandit</code> rules were modified (<a href="https://redirect.github.com/astral-sh/ruff/pull/10667">#10667</a>).</li> </ul> <h3>Deprecations</h3> <p>The following rules are now deprecated:</p> <ul> <li><a href="https://docs.astral.sh/ruff/rules/syntax-error/"><code>syntax-error</code></a> (<code>E999</code>): Syntax errors are now always shown</li> </ul> <h3>Remapped rules</h3> <p>The following rules have been remapped to new rule codes:</p> <ul> <li><a href="https://docs.astral.sh/ruff/rules/blocking-http-call-in-async-function/"><code>blocking-http-call-in-async-function</code></a>: <code>ASYNC100</code> to <code>ASYNC210</code></li> <li><a href="https://docs.astral.sh/ruff/rules/open-sleep-or-subprocess-in-async-function/"><code>open-sleep-or-subprocess-in-async-function</code></a>: <code>ASYNC101</code> split into <code>ASYNC220</code>, <code>ASYNC221</code>, <code>ASYNC230</code>, and <code>ASYNC251</code></li> <li><a href="https://docs.astral.sh/ruff/rules/blocking-os-call-in-async-function/"><code>blocking-os-call-in-async-function</code></a>: <code>ASYNC102</code> has been merged into <code>ASYNC220</code> and <code>ASYNC221</code></li> <li><a href="https://docs.astral.sh/ruff/rules/trio-timeout-without-await/"><code>trio-timeout-without-await</code></a>: <code>TRIO100</code> to <code>ASYNC100</code></li> <li><a href="https://docs.astral.sh/ruff/rules/trio-sync-call/"><code>trio-sync-call</code></a>: <code>TRIO105</code> to <code>ASYNC105</code></li> <li><a href="https://docs.astral.sh/ruff/rules/trio-async-function-with-timeout/"><code>trio-async-function-with-timeout</code></a>: <code>TRIO109</code> to <code>ASYNC109</code></li> <li><a href="https://docs.astral.sh/ruff/rules/trio-unneeded-sleep/"><code>trio-unneeded-sleep</code></a>: <code>TRIO110</code> to <code>ASYNC110</code></li> <li><a href="https://docs.astral.sh/ruff/rules/trio-zero-sleep-call/"><code>trio-zero-sleep-call</code></a>: <code>TRIO115</code> to <code>ASYNC115</code></li> <li><a href="https://docs.astral.sh/ruff/rules/repeated-isinstance-calls/"><code>repeated-isinstance-calls</code></a>: <code>PLR1701</code> to <code>SIM101</code></li> </ul> <h3>Stabilization</h3> <p>The following rules have been stabilized and are no longer in preview:</p> <ul> <li><a href="https://docs.astral.sh/ruff/rules/mutable-fromkeys-value/"><code>mutable-fromkeys-value</code></a> (<code>RUF024</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/default-factory-kwarg/"><code>default-factory-kwarg</code></a> (<code>RUF026</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/django-extra/"><code>django-extra</code></a> (<code>S610</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/manual-dict-comprehension/"><code>manual-dict-comprehension</code></a> (<code>PERF403</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/print-empty-string/"><code>print-empty-string</code></a> (<code>FURB105</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/readlines-in-for/"><code>readlines-in-for</code></a> (<code>FURB129</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/if-expr-min-max/"><code>if-expr-min-max</code></a> (<code>FURB136</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/bit-count/"><code>bit-count</code></a> (<code>FURB161</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/redundant-log-base/"><code>redundant-log-base</code></a> (<code>FURB163</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/regex-flag-alias/"><code>regex-flag-alias</code></a> (<code>FURB167</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/isinstance-type-none/"><code>isinstance-type-none</code></a> (<code>FURB168</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/type-none-comparison/"><code>type-none-comparison</code></a> (<code>FURB169</code>)</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/astral-sh/ruff/commit/244b923f615c2c162278fc0e06051853614760f3"><code>244b923</code></a> Add necessary permissions for cargo-dist Docker build (<a href="https://redirect.github.com/astral-sh/ruff/issues/12072">#12072</a>)</li> <li><a href="https://github.com/astral-sh/ruff/commit/a8b48fce7e32b35538072ccd55dac64e158d1e34"><code>a8b48fc</code></a> Release v0.5.0 (<a href="https://redirect.github.com/astral-sh/ruff/issues/12068">#12068</a>)</li> <li><a href="https://github.com/astral-sh/ruff/commit/04c8597b8ab1a459d77058b6899571095092bc2d"><code>04c8597</code></a> [<code>flake8-simplify</code>] Stabilize detection of Yoda conditions for &quot;constant&quot; col...</li> <li><a href="https://github.com/astral-sh/ruff/commit/4029a25ebd88a26424f45b20aba20c8e56a54d62"><code>4029a25</code></a> [Ruff v0.5] Stabilise 15 pylint rules (<a href="https://redirect.github.com/astral-sh/ruff/issues/12051">#12051</a>)</li> <li><a href="https://github.com/astral-sh/ruff/commit/0917ce16f477f20b60d6d6f96462d4c83168f6f6"><code>0917ce1</code></a> Update documentation to mention <code>etcetera</code> crate instead of <code>dirs</code> for user c...</li> <li><a href="https://github.com/astral-sh/ruff/commit/22cebdf29b79c9bb39b341149b2764730de72d97"><code>22cebdf</code></a> Add server config to filter out syntax error diagnostics (<a href="https://redirect.github.com/astral-sh/ruff/issues/12059">#12059</a>)</li> <li><a href="https://github.com/astral-sh/ruff/commit/72b6c26101ca920137202d455b014f9e680712f7"><code>72b6c26</code></a> Simplify <code>LinterResult</code>, avoid cloning <code>ParseError</code> (<a href="https://redirect.github.com/astral-sh/ruff/issues/11903">#11903</a>)</li> <li><a href="https://github.com/astral-sh/ruff/commit/73851e73ab0629461fbec84ee35ea91948d0c474"><code>73851e7</code></a> Avoid displaying syntax error as log message (<a href="https://redirect.github.com/astral-sh/ruff/issues/11902">#11902</a>)</li> <li><a href="https://github.com/astral-sh/ruff/commit/e7b49694a795e3347ffc6f499245dfcbbb4b28ed"><code>e7b4969</code></a> Remove <code>E999</code> as a rule, disallow any disablement methods for syntax error (#...</li> <li><a href="https://github.com/astral-sh/ruff/commit/c98d8a040fbcd3428f1b0189ebdc9fbb8183b215"><code>c98d8a0</code></a> [<code>pyflakes</code>] Stabilize detection of is comparisons to lists, etc. (<code>F632</code>) (#...</li> <li>Additional commits viewable in <a href="https://github.com/astral-sh/ruff/compare/v0.4.1...0.5.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=ruff&package-manager=pip&previous-version=0.4.1&new-version=0.5.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jared Lockhart <119884+jaredlockhart@users.noreply.github.com>
2024-07-03 23:32:25 +03:00
CIRRUS_RUFF_CHECK = ruff check .
feat(cirrus): Nimbus preview flag to return features based on preview experiments (#10998) Because - QA should be able to test web experiments on the prod of the implementing application This commit - Supports Cirrus to handle the `nimbus_preview` flag so that it should return a response based on the preview records Fixes #10953 --------- Co-authored-by: Jared Lockhart <119884+jaredlockhart@users.noreply.github.com>
2024-07-24 19:48:06 +03:00
CIRRUS_RUFF_FIX = ruff check --fix .
fix(cirrus): Run cirrus pytest in verbose mode (#11362) Because - To make it easier to identify failing tests This commit - make cirrus pytest tests run in verbose mode Fixes #9148 Co-authored-by: mosaadm <mohamed.mahmoud@toptal.com>
2024-09-13 18:43:17 +03:00
CIRRUS_PYTEST = pytest . --cov-config=.coveragerc --cov=cirrus -v
fix #8817 chore(cirrus): only copy cirrus files into cirrus container (#8821) Becuase * We were copying the entire experimenter repo into the cirrus container * The cirrus container only needs the cirrus files This commit * Only copies the cirrus files into the cirrus container * Removes unnecessary top level python module files and updates import paths * Updates all path references * Build cirrus container on every cirrus make command * Remove duplicate cirrus entry from test compose file Co-authored-by: Yashika Khurana <yashikakhuranayashika@gmail.com>
2023-05-15 19:49:52 +03:00
CIRRUS_PYTHON_TYPECHECK = pyright -p .
CIRRUS_PYTHON_TYPECHECK_CREATESTUB = pyright -p . --createstub cirrus
CIRRUS_GENERATE_DOCS = python cirrus/generate_docs.py
feat(nimbus): Use pre-built A-S in Cirrus and Experimenter (#10151) feat(nimbus): Use pre-built A-S in Cirrus and Experimenter Because: - our integration tests have been updated to use pre-built application-services artifacts; - the Cirrus and Experimenter Dockerfiles are currently building application-services from source; - Cirrus was using a Debian buster (oldoldstable); and - Cirrus and Experimenter were using a pinned minor version of Python, which prevents them from getting security upgrades in minor patches. This commit: - updates the Cirrus and Experimenter Dockerfiles to reference the `experimenter:megazords` image, which contains the pre-built binaries; - updates Cirrus to use a Debian bullseye (oldstable) image; and - updates Cirrus and Experimenter to not pin the minor verison of Python (3.11.2 to 3.11). Fixes #10150
2024-01-31 00:08:02 +03:00
cirrus_build: build_megazords
chore(project): add a flag to disable/enable cirrus (#9916) Because * Building Cirrus can be time consuming * Cirrus is not necessary for many integration tests or local workflows * We can add a flag to enable/disable cirrus to speed up the integration tests or local workflows that don't involve Cirrus This commit * Adds a flag to enable/disable Cirrus in the Makefile * Sets the flag automatically for all Cirrus make commands * Sets the flag for Cirrus integration tests fixes #9910
2023-12-07 22:50:36 +03:00
$(CIRRUS_ENABLE) $(DOCKER_BUILD) --target deploy -f cirrus/server/Dockerfile -t cirrus:deploy cirrus/server/
fix #9112 chore(cirrus): reduce cirrus deploy image size (#9113) Because * Smaller docker images are easier to deploy * The current cirrus docker image is 2gb This commit * Splits the cirrus docker file into three layers, one for building rust components, one for building python packages, and a third that copies them into a deploy container
2023-07-12 21:58:07 +03:00
bug(cirrus): Fix cirrus builds (#10173) Because: - the cirrus test jobs require the megazords; and - the cirrus build requires rustc on arm64 This commit: - adds `build_megazords` as a dependency of `cirrus_build_test`; and - installs `rustc` inside the `python-builder` phase of the Cirrus build. Fixes #10172
2024-01-31 04:11:50 +03:00
cirrus_build_test: build_megazords
chore(project): add a flag to disable/enable cirrus (#9916) Because * Building Cirrus can be time consuming * Cirrus is not necessary for many integration tests or local workflows * We can add a flag to enable/disable cirrus to speed up the integration tests or local workflows that don't involve Cirrus This commit * Adds a flag to enable/disable Cirrus in the Makefile * Sets the flag automatically for all Cirrus make commands * Sets the flag for Cirrus integration tests fixes #9910
2023-12-07 22:50:36 +03:00
$(CIRRUS_ENABLE) $(COMPOSE_TEST) build cirrus
fix #9687 chore(project): lock application services version (#9690) Because * Changes to Application Services can break consuming code in Cirrus/Experimenter * We currently consume the main branch of Application Services * This means that changes can land in main in Application Services and break main in Cirrus/Experimenter * We also neglected to explicitly rebuild the Cirrus test container when running Cirrus tests This commit * Explicitly locks Application Services to a specific hash when consumed in Cirrus/Experimenter * Explicitly builds the test container for Cirrus when running Cirrus tests
2023-11-07 23:36:54 +03:00
cirrus_bash: cirrus_build
chore(project): docker run with --rm (#11664) Because: - we are creating many short-lived containers for commands; and - we are not cleaning them up except in `make kill` This commit: - updates all docker run commands to use the `--rm` flag so that they are automatically deleted after the container exits. Fixes #11662
2024-11-08 22:47:05 +03:00
$(CIRRUS_ENABLE) $(COMPOSE_RUN) cirrus bash
fix #9687 chore(project): lock application services version (#9690) Because * Changes to Application Services can break consuming code in Cirrus/Experimenter * We currently consume the main branch of Application Services * This means that changes can land in main in Application Services and break main in Cirrus/Experimenter * We also neglected to explicitly rebuild the Cirrus test container when running Cirrus tests This commit * Explicitly locks Application Services to a specific hash when consumed in Cirrus/Experimenter * Explicitly builds the test container for Cirrus when running Cirrus tests
2023-11-07 23:36:54 +03:00
fix #8817 chore(cirrus): only copy cirrus files into cirrus container (#8821) Becuase * We were copying the entire experimenter repo into the cirrus container * The cirrus container only needs the cirrus files This commit * Only copies the cirrus files into the cirrus container * Removes unnecessary top level python module files and updates import paths * Updates all path references * Build cirrus container on every cirrus make command * Remove duplicate cirrus entry from test compose file Co-authored-by: Yashika Khurana <yashikakhuranayashika@gmail.com>
2023-05-15 19:49:52 +03:00
cirrus_up: cirrus_build
chore(project): add a flag to disable/enable cirrus (#9916) Because * Building Cirrus can be time consuming * Cirrus is not necessary for many integration tests or local workflows * We can add a flag to enable/disable cirrus to speed up the integration tests or local workflows that don't involve Cirrus This commit * Adds a flag to enable/disable Cirrus in the Makefile * Sets the flag automatically for all Cirrus make commands * Sets the flag for Cirrus integration tests fixes #9910
2023-12-07 22:50:36 +03:00
$(CIRRUS_ENABLE) $(COMPOSE) up cirrus
fix #8377 feat(cirrus): Initial commit (#8384) Because - We want to add Cirrus to the experimenter repo This commit - Set up the cirrus server and requirements - Set up Dockerfile and include cirrus in docker-compose file - To run the cirrus server- use command `make cirrus_up`
2023-03-06 21:45:53 +03:00
fix #8817 chore(cirrus): only copy cirrus files into cirrus container (#8821) Becuase * We were copying the entire experimenter repo into the cirrus container * The cirrus container only needs the cirrus files This commit * Only copies the cirrus files into the cirrus container * Removes unnecessary top level python module files and updates import paths * Updates all path references * Build cirrus container on every cirrus make command * Remove duplicate cirrus entry from test compose file Co-authored-by: Yashika Khurana <yashikakhuranayashika@gmail.com>
2023-05-15 19:49:52 +03:00
cirrus_down: cirrus_build
chore(project): add a flag to disable/enable cirrus (#9916) Because * Building Cirrus can be time consuming * Cirrus is not necessary for many integration tests or local workflows * We can add a flag to enable/disable cirrus to speed up the integration tests or local workflows that don't involve Cirrus This commit * Adds a flag to enable/disable Cirrus in the Makefile * Sets the flag automatically for all Cirrus make commands * Sets the flag for Cirrus integration tests fixes #9910
2023-12-07 22:50:36 +03:00
$(CIRRUS_ENABLE) $(COMPOSE) down cirrus
fix #8360 feat(nimbus): Change root folder app to experimenter (#8375) Because - We will be adding cirrus in experimenter This commit - Rename `app` to `experimenter` and make necessary changes
2023-03-09 00:36:51 +03:00
fix #9687 chore(project): lock application services version (#9690) Because * Changes to Application Services can break consuming code in Cirrus/Experimenter * We currently consume the main branch of Application Services * This means that changes can land in main in Application Services and break main in Cirrus/Experimenter * We also neglected to explicitly rebuild the Cirrus test container when running Cirrus tests This commit * Explicitly locks Application Services to a specific hash when consumed in Cirrus/Experimenter * Explicitly builds the test container for Cirrus when running Cirrus tests
2023-11-07 23:36:54 +03:00
cirrus_test: cirrus_build_test
chore(project): docker run with --rm (#11664) Because: - we are creating many short-lived containers for commands; and - we are not cleaning them up except in `make kill` This commit: - updates all docker run commands to use the `--rm` flag so that they are automatically deleted after the container exits. Fixes #11662
2024-11-08 22:47:05 +03:00
$(CIRRUS_ENABLE) $(COMPOSE_TEST_RUN) cirrus sh -c '$(CIRRUS_PYTEST)'
fix #8386 chore(nimbus): Add ruff and circle ci check for cirrus ✅ (#8497) Because - We want to add a linter on the Cirrus service and wanted to have CI runs the cirrus check This commit - Add [Ruff linter](https://pypi.org/project/ruff/) 💪 - New circle ci job for `cirrus_check` - Cirrus check - runs the test case and ruff linting - New make command for check `make cirrus_check` - New make command to fix formatting issues using `make cirrus_code_format` - Circle ci cirrus check will only run if the changes are in `/cirrus` directory - Experimenter check will only run if the changes are in `/experimenter` directory - Remove requirements.txt and uses poetry only closes #8386 #8388
2023-03-15 21:59:28 +03:00
fix #9687 chore(project): lock application services version (#9690) Because * Changes to Application Services can break consuming code in Cirrus/Experimenter * We currently consume the main branch of Application Services * This means that changes can land in main in Application Services and break main in Cirrus/Experimenter * We also neglected to explicitly rebuild the Cirrus test container when running Cirrus tests This commit * Explicitly locks Application Services to a specific hash when consumed in Cirrus/Experimenter * Explicitly builds the test container for Cirrus when running Cirrus tests
2023-11-07 23:36:54 +03:00
cirrus_check: cirrus_build_test
chore(project): docker run with --rm (#11664) Because: - we are creating many short-lived containers for commands; and - we are not cleaning them up except in `make kill` This commit: - updates all docker run commands to use the `--rm` flag so that they are automatically deleted after the container exits. Fixes #11662
2024-11-08 22:47:05 +03:00
$(CIRRUS_ENABLE) $(COMPOSE_TEST_RUN) cirrus sh -c "$(CIRRUS_RUFF_CHECK) && $(CIRRUS_BLACK_CHECK) && $(CIRRUS_PYTHON_TYPECHECK) && $(CIRRUS_PYTEST) && $(CIRRUS_GENERATE_DOCS) --check"
fix #8385 feat(cirrus): Set up test cases and test coverage (#8466) Because - We added Cirrus FastAPI recently This commit - Adds a test support- pytest, coverage and make command to run cirrus test cases - You can run the command `make cirrus_test` to run cirrus test cases <img width="1006" alt="image" src="https://user-images.githubusercontent.com/25848231/224199059-964e663b-f1f0-4511-adcb-1e38ebd2b66f.png"> closes #8385
2023-03-11 00:38:36 +03:00
fix #8817 chore(cirrus): only copy cirrus files into cirrus container (#8821) Becuase * We were copying the entire experimenter repo into the cirrus container * The cirrus container only needs the cirrus files This commit * Only copies the cirrus files into the cirrus container * Removes unnecessary top level python module files and updates import paths * Updates all path references * Build cirrus container on every cirrus make command * Remove duplicate cirrus entry from test compose file Co-authored-by: Yashika Khurana <yashikakhuranayashika@gmail.com>
2023-05-15 19:49:52 +03:00
cirrus_code_format: cirrus_build
chore(project): docker run with --rm (#11664) Because: - we are creating many short-lived containers for commands; and - we are not cleaning them up except in `make kill` This commit: - updates all docker run commands to use the `--rm` flag so that they are automatically deleted after the container exits. Fixes #11662
2024-11-08 22:47:05 +03:00
$(CIRRUS_ENABLE) $(COMPOSE_RUN) cirrus sh -c '$(CIRRUS_RUFF_FIX) && $(CIRRUS_BLACK_FIX)'
fix #8387 chore(cirrus): pyright type checker for cirrus (#8583) Because - We want to add type checker for cirrus This commit - Adds a `pyright` dependency in `pyproject.toml` - Include pyright in `make cirrus_check `command - Make a command to create stubs for cirrus i.e. `make cirrus_typecheck_createstub` - Added initially created a stub for cirrus in `typings` folder
2023-03-28 02:10:01 +03:00
fix #8817 chore(cirrus): only copy cirrus files into cirrus container (#8821) Becuase * We were copying the entire experimenter repo into the cirrus container * The cirrus container only needs the cirrus files This commit * Only copies the cirrus files into the cirrus container * Removes unnecessary top level python module files and updates import paths * Updates all path references * Build cirrus container on every cirrus make command * Remove duplicate cirrus entry from test compose file Co-authored-by: Yashika Khurana <yashikakhuranayashika@gmail.com>
2023-05-15 19:49:52 +03:00
cirrus_typecheck_createstub: cirrus_build
chore(project): docker run with --rm (#11664) Because: - we are creating many short-lived containers for commands; and - we are not cleaning them up except in `make kill` This commit: - updates all docker run commands to use the `--rm` flag so that they are automatically deleted after the container exits. Fixes #11662
2024-11-08 22:47:05 +03:00
$(CIRRUS_ENABLE) $(COMPOSE_RUN) cirrus sh -c '$(CIRRUS_PYTHON_TYPECHECK_CREATESTUB)'
fix #8387 chore(cirrus): pyright type checker for cirrus (#8583) Because - We want to add type checker for cirrus This commit - Adds a `pyright` dependency in `pyproject.toml` - Include pyright in `make cirrus_check `command - Make a command to create stubs for cirrus i.e. `make cirrus_typecheck_createstub` - Added initially created a stub for cirrus in `typings` folder
2023-03-28 02:10:01 +03:00
fix #8817 chore(cirrus): only copy cirrus files into cirrus container (#8821) Becuase * We were copying the entire experimenter repo into the cirrus container * The cirrus container only needs the cirrus files This commit * Only copies the cirrus files into the cirrus container * Removes unnecessary top level python module files and updates import paths * Updates all path references * Build cirrus container on every cirrus make command * Remove duplicate cirrus entry from test compose file Co-authored-by: Yashika Khurana <yashikakhuranayashika@gmail.com>
2023-05-15 19:49:52 +03:00
cirrus_generate_docs: cirrus_build
chore(project): docker run with --rm (#11664) Because: - we are creating many short-lived containers for commands; and - we are not cleaning them up except in `make kill` This commit: - updates all docker run commands to use the `--rm` flag so that they are automatically deleted after the container exits. Fixes #11662
2024-11-08 22:47:05 +03:00
$(CIRRUS_ENABLE) $(COMPOSE_RUN) cirrus sh -c '$(CIRRUS_GENERATE_DOCS)'
fix #8686 feat(cirrus): Fail ci to generate openapi.json (#8701) Because - We don't want to silently make ci update the open API schema for Cirrus This commit - Informs the user to update the schema - Make command to update open API schema `make cirrus_generate_docs` <img width="1225" alt="image" src="https://user-images.githubusercontent.com/25848231/232618015-2d4c55c6-e41a-4cd5-945a-f7b760756e94.png"> fixes #8686
2023-04-18 19:44:30 +03:00
fix #9243 feat(cirrus): Demo app frontend and server (#9250) Because - We want to test cirrus end to end This commit - Introduces demo app with frontend and server - Make command to build and run the demo app- `make build_demo_app` `make run_demo_app` - The frontend of the Demo App is accessible at [http://localhost:8080](http://localhost:8080) - The backend of the Demo App is accessible at [http://localhost:3002](http://localhost:3002) ps: FML and cirrus integration will come in different PR fixes #9243 fixes #9244
2023-08-11 20:35:58 +03:00
build_demo_app:
chore(project): add a flag to disable/enable cirrus (#9916) Because * Building Cirrus can be time consuming * Cirrus is not necessary for many integration tests or local workflows * We can add a flag to enable/disable cirrus to speed up the integration tests or local workflows that don't involve Cirrus This commit * Adds a flag to enable/disable Cirrus in the Makefile * Sets the flag automatically for all Cirrus make commands * Sets the flag for Cirrus integration tests fixes #9910
2023-12-07 22:50:36 +03:00
$(CIRRUS_ENABLE) $(COMPOSE_INTEGRATION) build demo-app-frontend demo-app-server
fix #9243 feat(cirrus): Demo app frontend and server (#9250) Because - We want to test cirrus end to end This commit - Introduces demo app with frontend and server - Make command to build and run the demo app- `make build_demo_app` `make run_demo_app` - The frontend of the Demo App is accessible at [http://localhost:8080](http://localhost:8080) - The backend of the Demo App is accessible at [http://localhost:3002](http://localhost:3002) ps: FML and cirrus integration will come in different PR fixes #9243 fixes #9244
2023-08-11 20:35:58 +03:00
fix #9156 feat(schemas): typescript schema generation and npm publish (#9157) Because - we want to use the population sizing schemas for graphql and UI This commit - sets up generation of typescript schemas from the pydantic schemas - sets up publishing the typescript schemas to npm
2023-08-11 23:56:49 +03:00
# nimbus schemas package
fix #9271 chore(project): dockerize schemas (#9616) Because * As we add a wider variety of elements to the Nimbus project including binary packages it becomes increasingly important to have a consistent environment for each of our modules * Using Docker allows us to control the environment each module runs in and use a consistent base layer * Dockerizing the schemas package will allow us to use identical Python, Node, and Rust environments as the other modules in Nimbus This commit * Wraps the schemas module in a Dockerfile that is consistent with the other modules in Nimbus
2023-10-24 23:30:55 +03:00
SCHEMAS_ENV ?= # This is empty by default
SCHEMAS_VERSION = \$$(cat VERSION)
chore(project): docker run with --rm (#11664) Because: - we are creating many short-lived containers for commands; and - we are not cleaning them up except in `make kill` This commit: - updates all docker run commands to use the `--rm` flag so that they are automatically deleted after the container exits. Fixes #11662
2024-11-08 22:47:05 +03:00
SCHEMAS_RUN = docker run --rm -ti $(SCHEMAS_ENV) -v ./schemas:/schemas -v /schemas/node_modules schemas:dev sh -c
fix #9271 chore(project): dockerize schemas (#9616) Because * As we add a wider variety of elements to the Nimbus project including binary packages it becomes increasingly important to have a consistent environment for each of our modules * Using Docker allows us to control the environment each module runs in and use a consistent base layer * Dockerizing the schemas package will allow us to use identical Python, Node, and Rust environments as the other modules in Nimbus This commit * Wraps the schemas module in a Dockerfile that is consistent with the other modules in Nimbus
2023-10-24 23:30:55 +03:00
SCHEMAS_BLACK = black --check --diff .
chore(deps-dev): Bump ruff from 0.4.1 to 0.5.0 in /schemas (#10927) Bumps [ruff](https://github.com/astral-sh/ruff) from 0.4.1 to 0.5.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/astral-sh/ruff/releases">ruff's releases</a>.</em></p> <blockquote> <h2>0.5.0</h2> <h2>Release Notes</h2> <p>Check out the <a href="https://astral.sh/blog/ruff-v0.5.0">blog post</a> for a migration guide and overview of the changes!</p> <h3>Breaking changes</h3> <p>See also, the &quot;Remapped rules&quot; section which may result in disabled rules.</p> <ul> <li>Follow the XDG specification to discover user-level configurations on macOS (same as on other Unix platforms)</li> <li>Selecting <code>ALL</code> now excludes deprecated rules</li> <li>The released archives now include an extra level of nesting, which can be removed with <code>--strip-components=1</code> when untarring.</li> <li>The release artifact's file name no longer includes the version tag. This enables users to install via <code>/latest</code> URLs on GitHub.</li> <li>The diagnostic ranges for some <code>flake8-bandit</code> rules were modified (<a href="https://redirect.github.com/astral-sh/ruff/pull/10667">#10667</a>).</li> </ul> <h3>Deprecations</h3> <p>The following rules are now deprecated:</p> <ul> <li><a href="https://docs.astral.sh/ruff/rules/syntax-error/"><code>syntax-error</code></a> (<code>E999</code>): Syntax errors are now always shown</li> </ul> <h3>Remapped rules</h3> <p>The following rules have been remapped to new rule codes:</p> <ul> <li><a href="https://docs.astral.sh/ruff/rules/blocking-http-call-in-async-function/"><code>blocking-http-call-in-async-function</code></a>: <code>ASYNC100</code> to <code>ASYNC210</code></li> <li><a href="https://docs.astral.sh/ruff/rules/open-sleep-or-subprocess-in-async-function/"><code>open-sleep-or-subprocess-in-async-function</code></a>: <code>ASYNC101</code> split into <code>ASYNC220</code>, <code>ASYNC221</code>, <code>ASYNC230</code>, and <code>ASYNC251</code></li> <li><a href="https://docs.astral.sh/ruff/rules/blocking-os-call-in-async-function/"><code>blocking-os-call-in-async-function</code></a>: <code>ASYNC102</code> has been merged into <code>ASYNC220</code> and <code>ASYNC221</code></li> <li><a href="https://docs.astral.sh/ruff/rules/trio-timeout-without-await/"><code>trio-timeout-without-await</code></a>: <code>TRIO100</code> to <code>ASYNC100</code></li> <li><a href="https://docs.astral.sh/ruff/rules/trio-sync-call/"><code>trio-sync-call</code></a>: <code>TRIO105</code> to <code>ASYNC105</code></li> <li><a href="https://docs.astral.sh/ruff/rules/trio-async-function-with-timeout/"><code>trio-async-function-with-timeout</code></a>: <code>TRIO109</code> to <code>ASYNC109</code></li> <li><a href="https://docs.astral.sh/ruff/rules/trio-unneeded-sleep/"><code>trio-unneeded-sleep</code></a>: <code>TRIO110</code> to <code>ASYNC110</code></li> <li><a href="https://docs.astral.sh/ruff/rules/trio-zero-sleep-call/"><code>trio-zero-sleep-call</code></a>: <code>TRIO115</code> to <code>ASYNC115</code></li> <li><a href="https://docs.astral.sh/ruff/rules/repeated-isinstance-calls/"><code>repeated-isinstance-calls</code></a>: <code>PLR1701</code> to <code>SIM101</code></li> </ul> <h3>Stabilization</h3> <p>The following rules have been stabilized and are no longer in preview:</p> <ul> <li><a href="https://docs.astral.sh/ruff/rules/mutable-fromkeys-value/"><code>mutable-fromkeys-value</code></a> (<code>RUF024</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/default-factory-kwarg/"><code>default-factory-kwarg</code></a> (<code>RUF026</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/django-extra/"><code>django-extra</code></a> (<code>S610</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/manual-dict-comprehension/"><code>manual-dict-comprehension</code></a> (<code>PERF403</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/print-empty-string/"><code>print-empty-string</code></a> (<code>FURB105</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/readlines-in-for/"><code>readlines-in-for</code></a> (<code>FURB129</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/if-expr-min-max/"><code>if-expr-min-max</code></a> (<code>FURB136</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/bit-count/"><code>bit-count</code></a> (<code>FURB161</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/redundant-log-base/"><code>redundant-log-base</code></a> (<code>FURB163</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/regex-flag-alias/"><code>regex-flag-alias</code></a> (<code>FURB167</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/isinstance-type-none/"><code>isinstance-type-none</code></a> (<code>FURB168</code>)</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md">ruff's changelog</a>.</em></p> <blockquote> <h2>0.5.0</h2> <p>Check out the <a href="https://astral.sh/blog/ruff-v0.5.0">blog post</a> for a migration guide and overview of the changes!</p> <h3>Breaking changes</h3> <p>See also, the &quot;Remapped rules&quot; section which may result in disabled rules.</p> <ul> <li>Follow the XDG specification to discover user-level configurations on macOS (same as on other Unix platforms)</li> <li>Selecting <code>ALL</code> now excludes deprecated rules</li> <li>The released archives now include an extra level of nesting, which can be removed with <code>--strip-components=1</code> when untarring.</li> <li>The release artifact's file name no longer includes the version tag. This enables users to install via <code>/latest</code> URLs on GitHub.</li> <li>The diagnostic ranges for some <code>flake8-bandit</code> rules were modified (<a href="https://redirect.github.com/astral-sh/ruff/pull/10667">#10667</a>).</li> </ul> <h3>Deprecations</h3> <p>The following rules are now deprecated:</p> <ul> <li><a href="https://docs.astral.sh/ruff/rules/syntax-error/"><code>syntax-error</code></a> (<code>E999</code>): Syntax errors are now always shown</li> </ul> <h3>Remapped rules</h3> <p>The following rules have been remapped to new rule codes:</p> <ul> <li><a href="https://docs.astral.sh/ruff/rules/blocking-http-call-in-async-function/"><code>blocking-http-call-in-async-function</code></a>: <code>ASYNC100</code> to <code>ASYNC210</code></li> <li><a href="https://docs.astral.sh/ruff/rules/open-sleep-or-subprocess-in-async-function/"><code>open-sleep-or-subprocess-in-async-function</code></a>: <code>ASYNC101</code> split into <code>ASYNC220</code>, <code>ASYNC221</code>, <code>ASYNC230</code>, and <code>ASYNC251</code></li> <li><a href="https://docs.astral.sh/ruff/rules/blocking-os-call-in-async-function/"><code>blocking-os-call-in-async-function</code></a>: <code>ASYNC102</code> has been merged into <code>ASYNC220</code> and <code>ASYNC221</code></li> <li><a href="https://docs.astral.sh/ruff/rules/trio-timeout-without-await/"><code>trio-timeout-without-await</code></a>: <code>TRIO100</code> to <code>ASYNC100</code></li> <li><a href="https://docs.astral.sh/ruff/rules/trio-sync-call/"><code>trio-sync-call</code></a>: <code>TRIO105</code> to <code>ASYNC105</code></li> <li><a href="https://docs.astral.sh/ruff/rules/trio-async-function-with-timeout/"><code>trio-async-function-with-timeout</code></a>: <code>TRIO109</code> to <code>ASYNC109</code></li> <li><a href="https://docs.astral.sh/ruff/rules/trio-unneeded-sleep/"><code>trio-unneeded-sleep</code></a>: <code>TRIO110</code> to <code>ASYNC110</code></li> <li><a href="https://docs.astral.sh/ruff/rules/trio-zero-sleep-call/"><code>trio-zero-sleep-call</code></a>: <code>TRIO115</code> to <code>ASYNC115</code></li> <li><a href="https://docs.astral.sh/ruff/rules/repeated-isinstance-calls/"><code>repeated-isinstance-calls</code></a>: <code>PLR1701</code> to <code>SIM101</code></li> </ul> <h3>Stabilization</h3> <p>The following rules have been stabilized and are no longer in preview:</p> <ul> <li><a href="https://docs.astral.sh/ruff/rules/mutable-fromkeys-value/"><code>mutable-fromkeys-value</code></a> (<code>RUF024</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/default-factory-kwarg/"><code>default-factory-kwarg</code></a> (<code>RUF026</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/django-extra/"><code>django-extra</code></a> (<code>S610</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/manual-dict-comprehension/"><code>manual-dict-comprehension</code></a> (<code>PERF403</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/print-empty-string/"><code>print-empty-string</code></a> (<code>FURB105</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/readlines-in-for/"><code>readlines-in-for</code></a> (<code>FURB129</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/if-expr-min-max/"><code>if-expr-min-max</code></a> (<code>FURB136</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/bit-count/"><code>bit-count</code></a> (<code>FURB161</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/redundant-log-base/"><code>redundant-log-base</code></a> (<code>FURB163</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/regex-flag-alias/"><code>regex-flag-alias</code></a> (<code>FURB167</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/isinstance-type-none/"><code>isinstance-type-none</code></a> (<code>FURB168</code>)</li> <li><a href="https://docs.astral.sh/ruff/rules/type-none-comparison/"><code>type-none-comparison</code></a> (<code>FURB169</code>)</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/astral-sh/ruff/commit/244b923f615c2c162278fc0e06051853614760f3"><code>244b923</code></a> Add necessary permissions for cargo-dist Docker build (<a href="https://redirect.github.com/astral-sh/ruff/issues/12072">#12072</a>)</li> <li><a href="https://github.com/astral-sh/ruff/commit/a8b48fce7e32b35538072ccd55dac64e158d1e34"><code>a8b48fc</code></a> Release v0.5.0 (<a href="https://redirect.github.com/astral-sh/ruff/issues/12068">#12068</a>)</li> <li><a href="https://github.com/astral-sh/ruff/commit/04c8597b8ab1a459d77058b6899571095092bc2d"><code>04c8597</code></a> [<code>flake8-simplify</code>] Stabilize detection of Yoda conditions for &quot;constant&quot; col...</li> <li><a href="https://github.com/astral-sh/ruff/commit/4029a25ebd88a26424f45b20aba20c8e56a54d62"><code>4029a25</code></a> [Ruff v0.5] Stabilise 15 pylint rules (<a href="https://redirect.github.com/astral-sh/ruff/issues/12051">#12051</a>)</li> <li><a href="https://github.com/astral-sh/ruff/commit/0917ce16f477f20b60d6d6f96462d4c83168f6f6"><code>0917ce1</code></a> Update documentation to mention <code>etcetera</code> crate instead of <code>dirs</code> for user c...</li> <li><a href="https://github.com/astral-sh/ruff/commit/22cebdf29b79c9bb39b341149b2764730de72d97"><code>22cebdf</code></a> Add server config to filter out syntax error diagnostics (<a href="https://redirect.github.com/astral-sh/ruff/issues/12059">#12059</a>)</li> <li><a href="https://github.com/astral-sh/ruff/commit/72b6c26101ca920137202d455b014f9e680712f7"><code>72b6c26</code></a> Simplify <code>LinterResult</code>, avoid cloning <code>ParseError</code> (<a href="https://redirect.github.com/astral-sh/ruff/issues/11903">#11903</a>)</li> <li><a href="https://github.com/astral-sh/ruff/commit/73851e73ab0629461fbec84ee35ea91948d0c474"><code>73851e7</code></a> Avoid displaying syntax error as log message (<a href="https://redirect.github.com/astral-sh/ruff/issues/11902">#11902</a>)</li> <li><a href="https://github.com/astral-sh/ruff/commit/e7b49694a795e3347ffc6f499245dfcbbb4b28ed"><code>e7b4969</code></a> Remove <code>E999</code> as a rule, disallow any disablement methods for syntax error (#...</li> <li><a href="https://github.com/astral-sh/ruff/commit/c98d8a040fbcd3428f1b0189ebdc9fbb8183b215"><code>c98d8a0</code></a> [<code>pyflakes</code>] Stabilize detection of is comparisons to lists, etc. (<code>F632</code>) (#...</li> <li>Additional commits viewable in <a href="https://github.com/astral-sh/ruff/compare/v0.4.1...0.5.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=ruff&package-manager=pip&previous-version=0.4.1&new-version=0.5.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jared Lockhart <119884+jaredlockhart@users.noreply.github.com>
2024-07-03 23:32:25 +03:00
SCHEMAS_RUFF = ruff check .
fix #9271 chore(project): dockerize schemas (#9616) Because * As we add a wider variety of elements to the Nimbus project including binary packages it becomes increasingly important to have a consistent environment for each of our modules * Using Docker allows us to control the environment each module runs in and use a consistent base layer * Dockerizing the schemas package will allow us to use identical Python, Node, and Rust environments as the other modules in Nimbus This commit * Wraps the schemas module in a Dockerfile that is consistent with the other modules in Nimbus
2023-10-24 23:30:55 +03:00
SCHEMAS_DIFF_PYDANTIC = \
chore(schemas): update to pydantic v2 (#11304) Because - the schemas package is used by a lot of data tooling - the data tooling is starting to complain about schemas requiring pydantic v1 due to other dependencies - the pydantic-to-typescript package is outdated and does not support pydantic v2 This commit - updates the schemas package to v2 - changes the typescript generation to a script internal to experimenter Fixes #11214
2024-09-09 21:26:28 +03:00
poetry run python generate_json_schema.py --output /tmp/test_index.d.ts &&\
fix #9271 chore(project): dockerize schemas (#9616) Because * As we add a wider variety of elements to the Nimbus project including binary packages it becomes increasingly important to have a consistent environment for each of our modules * Using Docker allows us to control the environment each module runs in and use a consistent base layer * Dockerizing the schemas package will allow us to use identical Python, Node, and Rust environments as the other modules in Nimbus This commit * Wraps the schemas module in a Dockerfile that is consistent with the other modules in Nimbus
2023-10-24 23:30:55 +03:00
diff /tmp/test_index.d.ts index.d.ts || (echo nimbus-schemas typescript package is out of sync please run make schemas_build;exit 1) &&\
echo 'Done. No problems found in schemas.'
SCHEMAS_TEST = pytest
chore(schemas): update to pydantic v2 (#11304) Because - the schemas package is used by a lot of data tooling - the data tooling is starting to complain about schemas requiring pydantic v1 due to other dependencies - the pydantic-to-typescript package is outdated and does not support pydantic v2 This commit - updates the schemas package to v2 - changes the typescript generation to a script internal to experimenter Fixes #11214
2024-09-09 21:26:28 +03:00
SCHEMAS_FORMAT = ruff check --fix . && black .
feat(schemas): generate .schema.json files for Experimenter and Feature Manifest schemas (#11519) Because: - we need the .schema.json files in Desktop; - they are not currently packaged into either the NPM or PyPI packages; and - the generated schemas do not include the custom validation logic expressed by Pydantic validators This commit: - adds JSON schema validation via Pydantic's json_schema_extra hook to give the JSON schemas validation parity with the Pydantic models and existing JSON schemas in Desktop; - generates the JSON schemas and commits them (in schemas/schemas); - packages the produced schemas into the NPM package; - packages the produced schemas into the PyPI package (but uncommitted, since they are duplicates); - revises the Makefile build steps for schema package generation; and - bumps the schema package version. Fixes #11518
2024-10-18 23:30:05 +03:00
SCHEMAS_GENERATE = poetry run python generate_json_schema.py
fix #9271 chore(project): dockerize schemas (#9616) Because * As we add a wider variety of elements to the Nimbus project including binary packages it becomes increasingly important to have a consistent environment for each of our modules * Using Docker allows us to control the environment each module runs in and use a consistent base layer * Dockerizing the schemas package will allow us to use identical Python, Node, and Rust environments as the other modules in Nimbus This commit * Wraps the schemas module in a Dockerfile that is consistent with the other modules in Nimbus
2023-10-24 23:30:55 +03:00
SCHEMAS_DIST_PYPI = poetry build
SCHEMAS_DEPLOY_PYPI = twine upload --skip-existing dist/*;
SCHEMAS_DEPLOY_NPM = echo "//registry.npmjs.org/:_authToken=${NPM_TOKEN}" > .npmrc;yarn publish --new-version ${SCHEMAS_VERSION} --access public;
SCHEMAS_VERSION_PYPI = poetry version ${SCHEMAS_VERSION};
SCHEMAS_VERSION_NPM = npm version --allow-same-version ${SCHEMAS_VERSION};
fix #9243 feat(cirrus): Demo app frontend and server (#9250) Because - We want to test cirrus end to end This commit - Introduces demo app with frontend and server - Make command to build and run the demo app- `make build_demo_app` `make run_demo_app` - The frontend of the Demo App is accessible at [http://localhost:8080](http://localhost:8080) - The backend of the Demo App is accessible at [http://localhost:3002](http://localhost:3002) ps: FML and cirrus integration will come in different PR fixes #9243 fixes #9244
2023-08-11 20:35:58 +03:00
feat(schemas): add version info to jetstream metadata schema (#10451) Because - we want to export metric and image version metadata from jetstream (https://github.com/mozilla/jetstream/issues/1786) - schemas_build make command was confusing This commit - adds config version to the jetstream metadata schema - makes schemas_build do the npm and pypi builds Fixes #10450 Fixes #10080
2024-03-25 18:08:55 +03:00
schemas_docker_build: ## Build schemas docker image
fix #9271 chore(project): dockerize schemas (#9616) Because * As we add a wider variety of elements to the Nimbus project including binary packages it becomes increasingly important to have a consistent environment for each of our modules * Using Docker allows us to control the environment each module runs in and use a consistent base layer * Dockerizing the schemas package will allow us to use identical Python, Node, and Rust environments as the other modules in Nimbus This commit * Wraps the schemas module in a Dockerfile that is consistent with the other modules in Nimbus
2023-10-24 23:30:55 +03:00
$(DOCKER_BUILD) --target dev -f schemas/Dockerfile -t schemas:dev schemas/
fix #8842: add jetstream/analysis schemas (#8847) Because - We want to have a better data contract between Jetstream and Experimenter This commit - Creates schemas for the data products that Jetstream produces - Adds a general python package structure with basic schema tests
2023-06-09 23:12:34 +03:00
feat(schemas): generate .schema.json files for Experimenter and Feature Manifest schemas (#11519) Because: - we need the .schema.json files in Desktop; - they are not currently packaged into either the NPM or PyPI packages; and - the generated schemas do not include the custom validation logic expressed by Pydantic validators This commit: - adds JSON schema validation via Pydantic's json_schema_extra hook to give the JSON schemas validation parity with the Pydantic models and existing JSON schemas in Desktop; - generates the JSON schemas and commits them (in schemas/schemas); - packages the produced schemas into the NPM package; - packages the produced schemas into the PyPI package (but uncommitted, since they are duplicates); - revises the Makefile build steps for schema package generation; and - bumps the schema package version. Fixes #11518
2024-10-18 23:30:05 +03:00
schemas_build: schemas_docker_build ## Build the mozilla_nimbus_schemas packages.
$(SCHEMAS_RUN) "$(SCHEMAS_GENERATE) && $(SCHEMAS_DIST_PYPI)"
feat(schemas): add version info to jetstream metadata schema (#10451) Because - we want to export metric and image version metadata from jetstream (https://github.com/mozilla/jetstream/issues/1786) - schemas_build make command was confusing This commit - adds config version to the jetstream metadata schema - makes schemas_build do the npm and pypi builds Fixes #10450 Fixes #10080
2024-03-25 18:08:55 +03:00
schemas_bash: schemas_docker_build
fix #9271 chore(project): dockerize schemas (#9616) Because * As we add a wider variety of elements to the Nimbus project including binary packages it becomes increasingly important to have a consistent environment for each of our modules * Using Docker allows us to control the environment each module runs in and use a consistent base layer * Dockerizing the schemas package will allow us to use identical Python, Node, and Rust environments as the other modules in Nimbus This commit * Wraps the schemas module in a Dockerfile that is consistent with the other modules in Nimbus
2023-10-24 23:30:55 +03:00
$(SCHEMAS_RUN) "bash"
fix #8842: add jetstream/analysis schemas (#8847) Because - We want to have a better data contract between Jetstream and Experimenter This commit - Creates schemas for the data products that Jetstream produces - Adds a general python package structure with basic schema tests
2023-06-09 23:12:34 +03:00
feat(schemas): add version info to jetstream metadata schema (#10451) Because - we want to export metric and image version metadata from jetstream (https://github.com/mozilla/jetstream/issues/1786) - schemas_build make command was confusing This commit - adds config version to the jetstream metadata schema - makes schemas_build do the npm and pypi builds Fixes #10450 Fixes #10080
2024-03-25 18:08:55 +03:00
schemas_format: schemas_docker_build ## Format schemas source tree
fix #9271 chore(project): dockerize schemas (#9616) Because * As we add a wider variety of elements to the Nimbus project including binary packages it becomes increasingly important to have a consistent environment for each of our modules * Using Docker allows us to control the environment each module runs in and use a consistent base layer * Dockerizing the schemas package will allow us to use identical Python, Node, and Rust environments as the other modules in Nimbus This commit * Wraps the schemas module in a Dockerfile that is consistent with the other modules in Nimbus
2023-10-24 23:30:55 +03:00
$(SCHEMAS_RUN) "$(SCHEMAS_FORMAT)"
fix #8842: add jetstream/analysis schemas (#8847) Because - We want to have a better data contract between Jetstream and Experimenter This commit - Creates schemas for the data products that Jetstream produces - Adds a general python package structure with basic schema tests
2023-06-09 23:12:34 +03:00
feat(schemas): add version info to jetstream metadata schema (#10451) Because - we want to export metric and image version metadata from jetstream (https://github.com/mozilla/jetstream/issues/1786) - schemas_build make command was confusing This commit - adds config version to the jetstream metadata schema - makes schemas_build do the npm and pypi builds Fixes #10450 Fixes #10080
2024-03-25 18:08:55 +03:00
schemas_lint: schemas_docker_build ## Lint schemas source tree
fix #9271 chore(project): dockerize schemas (#9616) Because * As we add a wider variety of elements to the Nimbus project including binary packages it becomes increasingly important to have a consistent environment for each of our modules * Using Docker allows us to control the environment each module runs in and use a consistent base layer * Dockerizing the schemas package will allow us to use identical Python, Node, and Rust environments as the other modules in Nimbus This commit * Wraps the schemas module in a Dockerfile that is consistent with the other modules in Nimbus
2023-10-24 23:30:55 +03:00
$(SCHEMAS_RUN) "$(SCHEMAS_BLACK)&&$(SCHEMAS_RUFF)&&$(SCHEMAS_DIFF_PYDANTIC)&&$(SCHEMAS_TEST)"
fix #8842: add jetstream/analysis schemas (#8847) Because - We want to have a better data contract between Jetstream and Experimenter This commit - Creates schemas for the data products that Jetstream produces - Adds a general python package structure with basic schema tests
2023-06-09 23:12:34 +03:00
feat(schemas): generate .schema.json files for Experimenter and Feature Manifest schemas (#11519) Because: - we need the .schema.json files in Desktop; - they are not currently packaged into either the NPM or PyPI packages; and - the generated schemas do not include the custom validation logic expressed by Pydantic validators This commit: - adds JSON schema validation via Pydantic's json_schema_extra hook to give the JSON schemas validation parity with the Pydantic models and existing JSON schemas in Desktop; - generates the JSON schemas and commits them (in schemas/schemas); - packages the produced schemas into the NPM package; - packages the produced schemas into the PyPI package (but uncommitted, since they are duplicates); - revises the Makefile build steps for schema package generation; and - bumps the schema package version. Fixes #11518
2024-10-18 23:30:05 +03:00
schemas_check: schemas_lint
fix #8842: add jetstream/analysis schemas (#8847) Because - We want to have a better data contract between Jetstream and Experimenter This commit - Creates schemas for the data products that Jetstream produces - Adds a general python package structure with basic schema tests
2023-06-09 23:12:34 +03:00
feat(schemas): generate .schema.json files for Experimenter and Feature Manifest schemas (#11519) Because: - we need the .schema.json files in Desktop; - they are not currently packaged into either the NPM or PyPI packages; and - the generated schemas do not include the custom validation logic expressed by Pydantic validators This commit: - adds JSON schema validation via Pydantic's json_schema_extra hook to give the JSON schemas validation parity with the Pydantic models and existing JSON schemas in Desktop; - generates the JSON schemas and commits them (in schemas/schemas); - packages the produced schemas into the NPM package; - packages the produced schemas into the PyPI package (but uncommitted, since they are duplicates); - revises the Makefile build steps for schema package generation; and - bumps the schema package version. Fixes #11518
2024-10-18 23:30:05 +03:00
schemas_generate: schemas_docker_build
$(SCHEMAS_RUN) "$(SCHEMAS_GENERATE)"
fix #8981 fix(schemas): use make commands for schemas deploy (#8982) Because - the circle config was assuming package directory - the circle working dir was not set - the circle image could not find the package to build/deploy This commit - uses make commands that drop into the correct directory before building and deploying
2023-06-15 21:12:45 +03:00
fix #9156 feat(schemas): typescript schema generation and npm publish (#9157) Because - we want to use the population sizing schemas for graphql and UI This commit - sets up generation of typescript schemas from the pydantic schemas - sets up publishing the typescript schemas to npm
2023-08-11 23:56:49 +03:00
feat(schemas): generate .schema.json files for Experimenter and Feature Manifest schemas (#11519) Because: - we need the .schema.json files in Desktop; - they are not currently packaged into either the NPM or PyPI packages; and - the generated schemas do not include the custom validation logic expressed by Pydantic validators This commit: - adds JSON schema validation via Pydantic's json_schema_extra hook to give the JSON schemas validation parity with the Pydantic models and existing JSON schemas in Desktop; - generates the JSON schemas and commits them (in schemas/schemas); - packages the produced schemas into the NPM package; - packages the produced schemas into the PyPI package (but uncommitted, since they are duplicates); - revises the Makefile build steps for schema package generation; and - bumps the schema package version. Fixes #11518
2024-10-18 23:30:05 +03:00
schemas_deploy_pypi: schemas_build
fix #9271 chore(project): dockerize schemas (#9616) Because * As we add a wider variety of elements to the Nimbus project including binary packages it becomes increasingly important to have a consistent environment for each of our modules * Using Docker allows us to control the environment each module runs in and use a consistent base layer * Dockerizing the schemas package will allow us to use identical Python, Node, and Rust environments as the other modules in Nimbus This commit * Wraps the schemas module in a Dockerfile that is consistent with the other modules in Nimbus
2023-10-24 23:30:55 +03:00
$(SCHEMAS_RUN) "$(SCHEMAS_DEPLOY_PYPI)"
fix #8981 fix(schemas): use make commands for schemas deploy (#8982) Because - the circle config was assuming package directory - the circle working dir was not set - the circle image could not find the package to build/deploy This commit - uses make commands that drop into the correct directory before building and deploying
2023-06-15 21:12:45 +03:00
feat(schemas): generate .schema.json files for Experimenter and Feature Manifest schemas (#11519) Because: - we need the .schema.json files in Desktop; - they are not currently packaged into either the NPM or PyPI packages; and - the generated schemas do not include the custom validation logic expressed by Pydantic validators This commit: - adds JSON schema validation via Pydantic's json_schema_extra hook to give the JSON schemas validation parity with the Pydantic models and existing JSON schemas in Desktop; - generates the JSON schemas and commits them (in schemas/schemas); - packages the produced schemas into the NPM package; - packages the produced schemas into the PyPI package (but uncommitted, since they are duplicates); - revises the Makefile build steps for schema package generation; and - bumps the schema package version. Fixes #11518
2024-10-18 23:30:05 +03:00
schemas_deploy_npm: schemas_build
fix #9271 chore(project): dockerize schemas (#9616) Because * As we add a wider variety of elements to the Nimbus project including binary packages it becomes increasingly important to have a consistent environment for each of our modules * Using Docker allows us to control the environment each module runs in and use a consistent base layer * Dockerizing the schemas package will allow us to use identical Python, Node, and Rust environments as the other modules in Nimbus This commit * Wraps the schemas module in a Dockerfile that is consistent with the other modules in Nimbus
2023-10-24 23:30:55 +03:00
$(SCHEMAS_RUN) "$(SCHEMAS_DEPLOY_NPM)"
fix #9156 feat(schemas): typescript schema generation and npm publish (#9157) Because - we want to use the population sizing schemas for graphql and UI This commit - sets up generation of typescript schemas from the pydantic schemas - sets up publishing the typescript schemas to npm
2023-08-11 23:56:49 +03:00
feat(schemas): add version info to jetstream metadata schema (#10451) Because - we want to export metric and image version metadata from jetstream (https://github.com/mozilla/jetstream/issues/1786) - schemas_build make command was confusing This commit - adds config version to the jetstream metadata schema - makes schemas_build do the npm and pypi builds Fixes #10450 Fixes #10080
2024-03-25 18:08:55 +03:00
schemas_version_pypi: schemas_docker_build
fix #9271 chore(project): dockerize schemas (#9616) Because * As we add a wider variety of elements to the Nimbus project including binary packages it becomes increasingly important to have a consistent environment for each of our modules * Using Docker allows us to control the environment each module runs in and use a consistent base layer * Dockerizing the schemas package will allow us to use identical Python, Node, and Rust environments as the other modules in Nimbus This commit * Wraps the schemas module in a Dockerfile that is consistent with the other modules in Nimbus
2023-10-24 23:30:55 +03:00
$(SCHEMAS_RUN) "$(SCHEMAS_VERSION_PYPI)"
fix #9156 feat(schemas): typescript schema generation and npm publish (#9157) Because - we want to use the population sizing schemas for graphql and UI This commit - sets up generation of typescript schemas from the pydantic schemas - sets up publishing the typescript schemas to npm
2023-08-11 23:56:49 +03:00
feat(schemas): add version info to jetstream metadata schema (#10451) Because - we want to export metric and image version metadata from jetstream (https://github.com/mozilla/jetstream/issues/1786) - schemas_build make command was confusing This commit - adds config version to the jetstream metadata schema - makes schemas_build do the npm and pypi builds Fixes #10450 Fixes #10080
2024-03-25 18:08:55 +03:00
schemas_version_npm: schemas_docker_build
fix #9271 chore(project): dockerize schemas (#9616) Because * As we add a wider variety of elements to the Nimbus project including binary packages it becomes increasingly important to have a consistent environment for each of our modules * Using Docker allows us to control the environment each module runs in and use a consistent base layer * Dockerizing the schemas package will allow us to use identical Python, Node, and Rust environments as the other modules in Nimbus This commit * Wraps the schemas module in a Dockerfile that is consistent with the other modules in Nimbus
2023-10-24 23:30:55 +03:00
$(SCHEMAS_RUN) "$(SCHEMAS_VERSION_NPM)"
fix #9156 feat(schemas): typescript schema generation and npm publish (#9157) Because - we want to use the population sizing schemas for graphql and UI This commit - sets up generation of typescript schemas from the pydantic schemas - sets up publishing the typescript schemas to npm
2023-08-11 23:56:49 +03:00
fix #9271 chore(project): dockerize schemas (#9616) Because * As we add a wider variety of elements to the Nimbus project including binary packages it becomes increasingly important to have a consistent environment for each of our modules * Using Docker allows us to control the environment each module runs in and use a consistent base layer * Dockerizing the schemas package will allow us to use identical Python, Node, and Rust environments as the other modules in Nimbus This commit * Wraps the schemas module in a Dockerfile that is consistent with the other modules in Nimbus
2023-10-24 23:30:55 +03:00
schemas_version: schemas_version_pypi schemas_version_npm