* fixes#7117 chore(project): Add firefox versions up to 120
Because:
* In the future we will need to target experiments above version 100
This commit:
* adds to the version lists up to version 120
Because
* branch names are not great rollout names
This Commit
* adds public name to rollout promotion
Co-authored-by: Jared Lockhart <119884+jaredlockhart@users.noreply.github.com>
* In anticipation of adding multifeature to nimbus ui, we should update the core nimbus ui infrastructure to use feature_configs instead of feature_config
This commit
* Updates the branches page to use and set feature_configs instead of feature_config
Because
* At some point we had to hard code a docker version in the docs because subsequent versions were broken
* This is no longer the case
This commit
* Updates docs to point to the latest docker desktop
Because
* We want users to be able to access the launch documents more easily
This commit
* adds a link to the onboarding for new reviewers doc on page summary
Co-authored-by: Jared Lockhart <119884+jaredlockhart@users.noreply.github.com>
Because
* The PIP targeting depends on prefs that may change during the experiment
* We need to add a sticky clause
This commit
* Adds a new PIP sticky targeting that includes the pref checks from the PIP targeting with a sticky clause
Because
* Strange behaviour was observed around saving branches during the transition from single to multi feature
* Turns out there is no bug and the serializers are behaving correctly but there weren't clear tests testing each single/multi flow
This commit
* Adds tests to the experiment serializer tests that test each of the single and multi feature cases to ensure they remain intact during the transition
Because
* Jetstream may output zero or None for certain numerical fields
* The Experimenter Jetstream parser should be resilient when encountering those values
This commit
* Adds test cases including jetstream returning all zeros or all None
* Updates the parse logic that was breaking when encountering those values
* fixes#6967 fix(Nimbus): removes choices from Firefox version model field
Because
* there were cases where a custom Firefox version was required for a particular experiment
This commit
* removes choices from Firefox version model field
* reverted admin changes based on feedback
Co-authored-by: Jared Lockhart <119884+jaredlockhart@users.noreply.github.com>
Because:
- we want to support multiple features in branches
This commit:
- adds the basics of managing selection of multiple features and
multiple per-branch feature configs to the branch editing reducer
Because:
- issue #6747 switched the branch editing reducer over to using the
input type, which itself uses feature IDs
This commit:
- ensures that the feature selection drop down uses feature IDs rather
than selection index
Because
* We need to update the V5 API to support setting multiple features on the experiment and per branch
* We need to keep the single feature interface intact while we make the transition
This commit
* Adds featureConfigs and featureValues to the V5 API and updates tests as necessary
Because:
- the branch editing reducer uses the experiment schema type for
internal state, rather than the ExperimentInput type that's the ultimate
product of the reducer
This commit:
- switches over to the ExperimentInput type so that the reducer can more
correctly handle the data it will eventually produce for submission to
the GQL API
Because
* The PiP team needs a custom targeting to target users that have pip enabled but have never used it
This commit
* Adds a custom targeting that filters on the relevant prefs
Because:
- we want to get controller logic out of AppLayoutWithExperiment and
simplify its use in Page components
This commit:
- moves ExperimentRoot into its own directory and adds tests
- simplifies the ExperimentContext properties down to essentials
- moves rendering of loading spinner, error messages, and experiment not
found from AppLayoutWithExperiment into ExperimentRoot
- moves logic for redirection, experiment & analysis fetching into
ExperimentRoot and exposes it to Page* components via utility hooks
- migrates all Page* components away from child-as-function pattern to
using new ExperimentContext directly
- assorted stories and tests tweaked to use ExperimentContext
- disable a test in PageResults that seems to fail intermittently
fix#6147fix#6148fix#6149fix#6150fix#6151fix#6152
Because
* Some core serializer logic was being tested at the graphql layer
* This made it difficult to reason about test coverage for major serializer changes
This commit
* Moves tests from graphql to serializer that test core serializer logic
* Deprecates some redundant graphql tests
* Preserves graphql tests for integration purposes
Jared Lockhart
dependabot[bot]
Tif Tran
anthonytran7757
Dan Mosedale
Tarik Eshaq
code-review-doctor
Les Orchard
Les Orchard
Ed Lee