Move email templates into content server and create a route to serve them
When rebased and merged with #517, all tests pass everywhere, all the time. Code looks good to me, reads well, all my requests have either been made or answered appropriately.
Nice work @zaach!
r+
The session tests attach a test "channel". "channel" cannot be cleared, and since Session is a singleton, the test channel never goes away. in fxa-clien.js->signIn, we attempt to send a message to a channel without a send function.
fixes#516
update fxa-client and add accept-language header based on browser language
@zaach - I rebased and added a couple of tests using the sinon spy. Looks good to me!
r+
* Pick `service` and `redirectTo` out of the URL search parameters on startup, add it to Session.
* Add sinon.js to ensure the fxa-js-client recieves the `service` parameter when expected.
* Update the views to get `service` from Session instead of the URL.
* Add two new test suites, complete_sign_up and reset_password_complete.
* Check whether service and redirectTo make it to the complete screens.
* Check whether the expected backend calls are made when expected.
* Hook up the real translator in the tests so string interpolation can be tested.
NOTE: I updated bower to use a specific version of sinon because the official sinon.js package in bower is not set up to correctly handle amd installs and does not give spy functionality.
adding /server/ to Grunt jshint task
@pdehaan - https://www.youtube.com/watch?v=PgpDN-bARwc
r+ - Aside frommy one comment about having subdir specific jshint files, looks great! tests all pass, I'm happy.
* Add tooltip/tooltip-below classes to tooltip containers.
* Add generic form validation in form.js with the ability for descendent views to override using strategy methods.
* MOAR TESTS!
* Create a new "base" View - FormView - useful for doing form validation.
* A FormView must provide three functions - isFormValid, showValidationErrors and submitForm.
* When a form element is invalid, it's containing .form-row recieves a title which is displayed as a tooltip.
* Change all Views that use forms to be a FormView
* Add a ton of tests.
fixes#252
* Focus can only be checked for if the window is currently in focus.
* .error is used by mocha to indicate errors. Namespace all checks for .error to the view.
* Up time timeout for mocha to 5seconds and the intern to 120seconds.
* Add a unit test for signing in with a non-existent user (see https://github.com/mozilla/fxa-js-client/issues/74)
fixes#489
Zachary Carter
Shane Tomlinson
Zach Carter
Peter deHaan
Nick Chapman
Andrew Chilton
johngruen