Граф коммитов

30783 Коммитов

Автор SHA1 Сообщение Дата
Lauren Zugai e2d233e2fb
Share session token back to FxA web content (does not work) 2024-06-24 16:56:43 -05:00
Lisa Chan 93c3d6c209
Merge pull request #17138 from mozilla/FXA-9457
feat(payments-server): Show coupon name in in Subscription Management
2024-06-21 12:34:16 -04:00
Lisa Chan c467ce4a4f
feat(payments-server): Show coupon name in in Subscription Management 2024-06-21 09:42:29 -04:00
Lauren Zugai 3e1bed826b
Merge pull request #17153 from mozilla/fixme-playwright-oauth-signintoken
fix(functional-tests): Mark Oauth SigninTokenCode tests with fixme
2024-06-20 17:55:33 -05:00
Valerie Pomerleau dab0ab6823
fix(functional-tests): Mark Oauth SigninTokenCode tests with fixme
Because:

* This test was failing on the latest tag

This commit:

* Marks test as fixme to not block the tag

Closes #
2024-06-20 15:20:53 -07:00
Lauren Zugai b1d6f78246
Merge pull request #17152 from mozilla/FXA-9916
fix(inline-totp): Display totp code for manual entry
2024-06-20 16:35:10 -05:00
Valerie Pomerleau 015b21e328
Merge pull request #17150 from mozilla/test-reduce-retries
fix(functional-tests): Address isolation issues caused by sync tests
2024-06-20 14:31:23 -07:00
Valerie Pomerleau 2794232b22
use syncBrowswerPages 2024-06-20 14:02:13 -07:00
Lauren Zugai d643724f6f
fix(inline-totp): Display totp code for manual entry
Because:
* We were not properly displaying this code on the inline TOTP page

This commit:
* Creates a new component to share with where we display this code inside Settings, and uses it in both locations
* Adds new component to Storybook, updates test

fixes FXA-9916
2024-06-20 15:50:50 -05:00
Ben Bangert 2cb0f284d0
Merge pull request #17141 from mozilla/chore/update-nx-to-19.3
chore: update nx to 19.3
2024-06-20 11:19:38 -07:00
Ben Bangert 39efc8ddf4
chore: update nx to 19.3
Because:

* We want to use the latest version of Nx.

This commit:

* Updates Nx to 19.3.
2024-06-20 17:34:39 +00:00
Valerie Pomerleau 94e32f4ca4
Merge pull request #17149 from mozilla/FXA-9909
fix(functional-tests): fix test failures on train 287.1 tag
2024-06-20 10:05:14 -07:00
Valerie Pomerleau b24bae28ec
mark tests with possible isolation issues as fixme 2024-06-20 08:40:54 -07:00
Valerie Pomerleau 00a90c7494
fix(functional-tests): fix test failures on train 287.1 tag
Because:

* Some functional tests were failing for the tag
* Some failure traces missing on CI

This commit:

* Increase timeout for assertions
* Update trace config to always retain trace on failure

Closes #FXA-9909
2024-06-19 15:12:50 -07:00
Valerie Pomerleau e30929d84c
Merge pull request #17147 from mozilla/revert-signin-fullProdFlag
revert react signin full prod flag
2024-06-19 10:23:43 -07:00
Valerie Pomerleau 8c8782ff8f
revert react signin full prod flag 2024-06-19 08:58:19 -07:00
Jonathan Almeida 75439904d0
Merge pull request #17137 from mozilla/FXA-9809
fix(metrics): Add Google and Apple signin telemetry
2024-06-18 15:07:22 -04:00
Lauren Zugai 52d2b1bc5e
Merge pull request #17144 from mozilla/FXA-9870
fix(fxa-settings): Enable sync after password reset
2024-06-18 13:55:14 -05:00
Jonathan Almeida d9435da90f
Merge pull request #17076 from mozilla/FXA-9788
task(content): Add cirrus integration to Backbone
2024-06-18 14:52:26 -04:00
Jonathan Almeida 98d290768f
fix(metrics): Add Google and Apple signin metrics
Fixes FXA-9809, fixes FXA-9808.
2024-06-18 14:51:52 -04:00
Dan Schomburg 20162158c8
Merge pull request #17143 from mozilla/FXA-9760
bug(settings): Force multiple tabs to logout of settings.
2024-06-18 11:35:52 -07:00
Valerie Pomerleau 4432ff57cf
fix(fxa-settings): Enable sync after password reset
Because:

* Sync was disabled after resetting password during a sync sign in

This commit:

* Add services to the FxaLoginSignedInUserRequest webchannel message used by reset password

Closes #FXA-9870
2024-06-18 11:26:35 -07:00
Dan Schomburg 13e635e0d7
Merge pull request #17136 from mozilla/FXA-9848 2024-06-18 11:25:27 -07:00
Valerie Pomerleau b0852932b4
Merge pull request #17145 from mozilla/20240618-functional-tests-fix
fix(functional-test): changeEmailBlocked tests failing on main
2024-06-18 11:25:16 -07:00
Valerie Pomerleau ec7045a662
fix(functional-test): Functional tests failing on main
Because:

* changeEmailBlocked tests were failing when run on CI

This commit:

* Add assertions to make sure correct state is awaited

Closes #
2024-06-18 10:24:26 -07:00
Jonathan Almeida 1862dd6ec7
task(content): Add cirrus integration to Backbone
We fetch the experiments as a passthrough between the app and server
so we don't have to expose another service.

In this patch, we've also added the experiments to the sign-in page
context.

Co-authored-by: dschom <dschomburg@mozilla.com>
2024-06-18 09:55:34 -07:00
dschom 0e42b8367d
bug(settings): Fix unnecessary bounce to signup page
Because:
- When 2FA is required, and user did not have 2FA enabled yet, they would get bounced to the signup page

This Commit:
- Allows isSessionVerified to settle before redirecting
- Allows totpStatus to settle before redirecting
- Puts redirect logic in separate useEffect to consolidate redirect logic
- Removes that catch block that was using an undefined error state to control user flow
- Cleans up tests:
  - Made mocks accessible
  - Made sure implementations were defined in setMocks
  - Use mockReturnValue where appropriate
  - Make sure waitFor is used as needed

fixes: FXA-9848
2024-06-18 09:53:55 -07:00
dschom 09ca5b8e75
bug(settings): Force multiple tabs to logout of settings.
Because:
- When two tabs are open, logging out of one tab, would not impact the second tab
- Some level interaction would still be possible in the second tab.

This Commit:
- Makes sure that after logging out of one tab, another active tab will also log out

Fixes: FXA-970 by addressing the UX issue. See ticket for more discussion about API level restrictions.
2024-06-18 09:48:04 -07:00
Vijay Budhram c16e4bcd57
Merge pull request #17139 from mozilla/fxa-9116
fix(metrics): Add metrics for `set_password` view, in glean and amplitude
2024-06-18 11:59:03 -04:00
Valerie Pomerleau 5405bec1ac
Merge pull request #17119 from mozilla/FXA-9519-take-2
task(functional-tests) : Update functional tests for react signin rollout
2024-06-18 08:31:26 -07:00
Reino Muhl 4e611b12e1
Merge pull request #17094 from mozilla/fxa-9706-next-hot-reload
feat(next): update payments-next build and restart
2024-06-18 11:18:33 -04:00
Lauren Zugai f64132dd9e
Merge pull request #17140 from mozilla/FXA-9834
fix(glean): Tweak view/submit CAD Glean events
2024-06-18 10:10:20 -05:00
Reino Muhl ab8ae37229
feat(next): update payments-next build and restart
Because:

- Starting and restarting payments-next takes a long time due to always
  building the app first, which isn't necessary during development.
- When changes are made to NestApp or its dependencies, these are not
  hot reloaded by Next.js, requiring a full Next.js restart.

This commit:

- Adopt Nx plugin for Next.js which more closely aligns with Next.js
  standard dev commands.
- Retained Nx Next.js executors for build, since it more closely fits
  into the current FxA build and deploy CI logic.
- Added a watcher to NestApp which calls a NestApp restart api, only
  available in development, to restart the NestApp on any changes.
- Adds a function to get the NestApp, instead of a const, thus ensuring,
  in dev mode, the latest NestApp is always returned.

Closes #FXA-9706
2024-06-18 10:45:04 -04:00
Ankita Shrivastava 85633d9ce2
Merge pull request #17142 from mozilla/create-html-reports-playwright
chore(functional): integrate html reporting with Playwright
2024-06-17 22:51:07 -04:00
Ankita Shrivastava 6b0e150597
chore(functional): integrate html reporting with Playwright 2024-06-17 22:27:45 -04:00
Valerie Pomerleau bc28b928e7
update fixme comments woth ticket numbers 2024-06-17 16:49:41 -07:00
Lauren Zugai 6202393479
fix(glean): Tweak view/submit CAD Glean events
Because:
* There are a couple of bugs we want to address

This commit:
* Swaps the event reason on choice submission, as they were inversed
* Fixes the Glean event map to cad_firefox_choice_view, as it referenced cad_firefox_view
* Only emits the 'cad_firefox_sync_device_submit' event when user reaches the "needs mobile" screen and clicks "Continue to sync"

fixes FXA-9834, fixes FXA-9833, fixes FXA-9832
2024-06-17 16:43:59 -05:00
Vijay Budhram a149eac05f
fix(metrics): Add metrics for `set_password` view, in glean and amplitude 2024-06-17 16:53:54 -04:00
Dan Schomburg 0b4e607e11
Merge pull request #17131 from mozilla/FXA-9861
task(auth-server): Fix invalid call
2024-06-17 13:21:02 -07:00
Dan Schomburg fd0d15c995
Merge pull request #17130 from mozilla/FXA-9802-p2-fix-clientid-none
bug(auth,event-broker): Don't allow invalid client ids through
2024-06-17 13:20:44 -07:00
Valerie Pomerleau 9230b2de5c
update cached signin tests with new react behaviour, skip until fullProdRollout 2024-06-17 12:59:18 -07:00
Lisa Chan bd067ed91e
Merge pull request #17124 from mozilla/FXA-9789
refactor(payments-stripe, auth): Update Coupon API endpoint
2024-06-17 13:34:53 -04:00
Valerie Pomerleau 96f504c4ef
removing oauth permissions tests, not supported in React 2024-06-17 10:06:05 -07:00
Valerie Pomerleau ee55f64028
remove login hint from params on change email click 2024-06-17 09:28:02 -07:00
Lisa Chan fc3e40888c
refactor(payments-stripe, auth): Update Coupon API endpoint 2024-06-17 12:03:21 -04:00
Valerie Pomerleau 081b5323f0
fix(functional-tests): Update tests for react signin
Because:

* Many tests were failing when react signin is switched to full prod rollout
* Login page object model was a bit of a grab bag that was used for signin, signup as well as other pages

This commit:

* Rename signinReact and signupReact POMs to signin and signup
* Discontinue use of login POM in most tests and replace with page-specific POMs

Closes #FXA-9519
2024-06-17 08:58:33 -07:00
Vijay Budhram 566c8ef9a1
Merge pull request #17129 from mozilla/fxa-9564
fix(metrics): always use the metrics flow data in `Metrics` model when redirecting in third party auth
2024-06-17 11:45:44 -04:00
Vijay Budhram 3f183283a0
Merge pull request #17121 from mozilla/fxa-sync-2
fix(login): fix sync login issue with react
2024-06-17 11:29:17 -04:00
Vijay Budhram 4539dd68c7
fix(login): fix sync login issue with react 2024-06-17 10:41:28 -04:00
Vijay Budhram 152be5bed3
fix(metrics): always use the metrics flow data in `Metrics` backbone when redirecting in third party auth 2024-06-17 10:28:58 -04:00