Because:
- Starting and restarting payments-next takes a long time due to always
building the app first, which isn't necessary during development.
- When changes are made to NestApp or its dependencies, these are not
hot reloaded by Next.js, requiring a full Next.js restart.
This commit:
- Adopt Nx plugin for Next.js which more closely aligns with Next.js
standard dev commands.
- Retained Nx Next.js executors for build, since it more closely fits
into the current FxA build and deploy CI logic.
- Added a watcher to NestApp which calls a NestApp restart api, only
available in development, to restart the NestApp on any changes.
- Adds a function to get the NestApp, instead of a const, thus ensuring,
in dev mode, the latest NestApp is always returned.
Closes #FXA-9706
Because:
* The other gcloud feature require arch linux, ours is debian based.
This commit:
* Changes the gcloud feature to one that works with debian based systems.
Because:
* It's useful having some CLI tooling for the fxa stack installed by
default in the devcontainer.
This commit:
* Adds mycli, redis, and gcloud to the devcontainer.
Because:
* We want a consistent development environment for all developers.
This commit:
* Adds a devcontainer configuration for Docker in Docker development.
Because:
* Two tests were failing smoke tests
This commit:
* Fix the PKCE test by using the correct url by environment (removed stray localhost)
* Fix failing assertion that was causing email check to fail
Closes #FXA-9800
Because:
* Adding 'await' in front of this waits for the browser to respond. We thought this may fix an intermittent sync signin issue, but instead hangs
This commit:
* Reverts this change
Because:
* we hypothesis that the cause of intermittence in functional tests may be due to uncleared emails and inadequate wait times
This commit:
* consolidates waiting for emails to the EmailClient
* decouples the EmailClient from POMS
* increases the default timeout from 15 to 45 seconds
Closes #FXA-9851
Because:
* We want to clear the error when the code is edited
This commit:
* Clears the error message when the users clicks backspace, delete or pastes a new code
Closes #FXA-9806
Because:
- We noticed that gql queries in inline_totp_setup were failing
- The value for service wasn't passing validation
- The service name was being passed instead of the service id
This Commit:
- Passes the service identifier (aka the RPs client id) in for the service value.
- Uses the integration's 'getService' function to determine this value
Because:
* Users are not signed in to Sync after entering their 2FA code
This commit:
* Prevents the fxaLogin web channel message from being sent up if the next page in the navigation flow is TOTP since we send it up on submit on that page
fixes FXA-9837
Because:
* Subplat subscriptions page sometimes redirects to force_auth and we need to pass params to this page as well as oauth/force_auth
This commit:
* Update router.js to route force_auth and oauth/force_auth to react
* Only pass redirectTo to navigation handler if integration is web
Closes #FXA-9826
Because:
* Redirect back to /subscriptions after signin was not working
This commit:
* Pass the redirectTo as search param
* Validate the redirectTo and if valid navigate there after signin
Closes #FXA-9826
Because:
* Users would be taken to the 2FA page from signin_token_code when they hadn't yet verified 2FA
* There's an edgecase at least in Sync signin causing an invalid token code on this page
This commit:
* Checks for totp verified instead of totp exists
* Uses the sessionToken passed into the component instead of useSession, which was causing console errors
fixes FXA-9836
Because:
- The events were rejected because the 'ts' field was missing
- In auth server this added in by the logger, so it wasn't initially detected
This Commit:
- Adds the ts field to all profileDataChange events emitted by admin-server
- Updates the DTO support additional optional fields
Reino Muhl
Vijay Budhram
Lisa Chan
Ben Bangert
Valerie Pomerleau
Jonathan Almeida
Vijay Budhram
Katrina Anderson
Lauren Zugai
Pdf Bot
Dan Schomburg
dschom