Because:
* Sync was disabled after resetting password during a sync sign in
This commit:
* Add services to the FxaLoginSignedInUserRequest webchannel message used by reset password
Closes #FXA-9870
We fetch the experiments as a passthrough between the app and server
so we don't have to expose another service.
In this patch, we've also added the experiments to the sign-in page
context.
Co-authored-by: dschom <dschomburg@mozilla.com>
Because:
- When 2FA is required, and user did not have 2FA enabled yet, they would get bounced to the signup page
This Commit:
- Allows isSessionVerified to settle before redirecting
- Allows totpStatus to settle before redirecting
- Puts redirect logic in separate useEffect to consolidate redirect logic
- Removes that catch block that was using an undefined error state to control user flow
- Cleans up tests:
- Made mocks accessible
- Made sure implementations were defined in setMocks
- Use mockReturnValue where appropriate
- Make sure waitFor is used as needed
fixes: FXA-9848
Because:
- When two tabs are open, logging out of one tab, would not impact the second tab
- Some level interaction would still be possible in the second tab.
This Commit:
- Makes sure that after logging out of one tab, another active tab will also log out
Fixes: FXA-970 by addressing the UX issue. See ticket for more discussion about API level restrictions.
Because:
- Starting and restarting payments-next takes a long time due to always
building the app first, which isn't necessary during development.
- When changes are made to NestApp or its dependencies, these are not
hot reloaded by Next.js, requiring a full Next.js restart.
This commit:
- Adopt Nx plugin for Next.js which more closely aligns with Next.js
standard dev commands.
- Retained Nx Next.js executors for build, since it more closely fits
into the current FxA build and deploy CI logic.
- Added a watcher to NestApp which calls a NestApp restart api, only
available in development, to restart the NestApp on any changes.
- Adds a function to get the NestApp, instead of a const, thus ensuring,
in dev mode, the latest NestApp is always returned.
Closes #FXA-9706
Because:
* There are a couple of bugs we want to address
This commit:
* Swaps the event reason on choice submission, as they were inversed
* Fixes the Glean event map to cad_firefox_choice_view, as it referenced cad_firefox_view
* Only emits the 'cad_firefox_sync_device_submit' event when user reaches the "needs mobile" screen and clicks "Continue to sync"
fixes FXA-9834, fixes FXA-9833, fixes FXA-9832
Because:
* Many tests were failing when react signin is switched to full prod rollout
* Login page object model was a bit of a grab bag that was used for signin, signup as well as other pages
This commit:
* Rename signinReact and signupReact POMs to signin and signup
* Discontinue use of login POM in most tests and replace with page-specific POMs
Closes #FXA-9519
Because:
- ClientIds with values 'none' were making their way to the auth server
- This was happening because 'none' is a valid value for service, and service was a fallback for clientId.
This Commit:
- Creates stricter checks on what a valid clientId is.
FXA-9802
Because:
* Our 'yarn glean-generate' command was failing with 'No module named 'pkg_resources', and this is fixed in latest Glean
This commit:
* Upgrades the package
Valerie Pomerleau
Jonathan Almeida
Lauren Zugai
Dan Schomburg
dschom
Vijay Budhram
Reino Muhl
Ankita Shrivastava
Ankita Shrivastava
Vijay Budhram
Lisa Chan
Wil Clouser
Ben Bangert