Граф коммитов

16316 Коммитов

Автор SHA1 Сообщение Дата
Ryan Kelly bfdf0cb3a9
Merge pull request #3634 from mozilla/tag-metrics-with-correct-service-in-sync-optional-flow;=shane-tomlinson
Set `service` tag for metrics events based on fxa_status response.
2019-12-14 07:57:55 +11:00
Barry Chen a25f476d26
Merge pull request #3622 from chenba/3589-disable-perf-metrics
chore(metrics): remove flow perf metrics from Payments
2019-12-13 14:38:33 -06:00
Barry Chen 42c2492ed3
chore(metrics): remove flow perf metrics from Payments
This patch removes flow based performance metrics on Payments server.  The
data from the logs are not present in Redshift due to the lack of a log
pipeline to ingest and process the events.  Furthermore, there was a bug
with the timing values.

This will be followed up with a switch to statsd, so that performance
metrics will be separated from flow events.
2019-12-13 14:30:10 -06:00
Barry Chen 9b13bc5b95
Merge pull request #3675 from chenba/3274-amplitude-for-sub-upgrades
feat(metrics): add Amplitude events for subscription upgrades
2019-12-13 13:46:53 -06:00
Barry Chen d5acb5a65e
feat(metrics): add Amplitude events for subscription upgrades 2019-12-13 13:03:50 -06:00
Vijay Budhram b5313b072b
Merge pull request #3671 from mozilla/verification-reminder-tests, r=@vladikoff
feat(reminders): Test verification reminders.
2019-12-13 13:57:10 -05:00
Vijay Budhram 0f658fa4dd
Merge pull request #3669 from mozilla/i3648-load-settings-unverified-account, r=@vbudhram
feat(signup): Use signup codes when visiting /settings w/ unverified account
2019-12-13 13:53:22 -05:00
Vijay Budhram 862889888e
Merge pull request #3668 from mozilla/i3649-cached-unverified-signin-to-code, r=@vbudhram
feat(signin): Cached signin w/ unverified account uses codes now.
2019-12-13 13:51:10 -05:00
Vijay Budhram 03bdc935bd
Merge pull request #3664 from mozilla/fix-flake, r=@lmorchad
fix(test): Update sign up code previous window test
2019-12-13 10:54:51 -05:00
Shane Tomlinson abac0a334d
feat(signup): Use signup codes when visiting /settings w/ unverified account
Before this we'd send users to /confirm which was the link flow.

This changes that to use a code based flow

fixes #3648
2019-12-13 13:16:48 +00:00
Shane Tomlinson 47f58654a6
feat(reminders): Test verification reminders.
Convert the `complete_sign_up` tests to be the `verification reminders`
tests. The only flow that sends signup verification links now are the
reminders, so re-purposing this module seemed appropriate.

Not attached to an issue.
2019-12-13 13:08:20 +00:00
Shane Tomlinson 52d58fb763
feat(signin): Cached signin w/ unverified account uses codes now.
Before this signing in to an OAuth RP with a cached unverified account
would send the user to /confirm, which would have resent verification
links.

This converts that flow to use codes instead.

fixes #3649
2019-12-13 12:17:06 +00:00
Ben Bangert 6ec9fa5b43
Merge pull request #3665 from mozilla/refactor/async-await-6
refactor(auth-server): asyncify utils/otp and utils/signup
2019-12-12 19:25:38 -08:00
Ben Bangert 67b75325c8
Merge pull request #3615 from mozilla/feat/issue-3422
feat(event-broker): use proper hapi/sqs filtering
2019-12-12 19:25:27 -08:00
Ben Bangert 6c9899e64e
feat(event-broker): use proper hapi/sqs filtering
Because:

* The stock Sentry plugin has limitations on what details it filters
  from the error details.
* We've customized Hapi error reporting Sentry for auth-server and have
  not used those elsewhere.

This commit:

* Brings over the Hapi Sentry configuration used in auth-server that
  filters out additional PII such as uid's.
* Add's a new SQS Sentry configuration that capatures additional Sentry
  details for SQS processing failures.

Closes #3422
2019-12-12 17:09:28 -08:00
Ben Bangert ab83c956f1
refactor(auth-server): asyncify utils/otp and utils/signup
Issue #2350
2019-12-12 17:08:51 -08:00
Ben Bangert 50427174a9
Merge pull request #3666 from mozilla/node-12
fix(build): update check.sh to use node 12
2019-12-12 17:08:31 -08:00
Danny Coates c24291a305
fix(build): update check.sh to use node 12 2019-12-12 16:27:46 -08:00
Ben Bangert b59a91c78b
Merge pull request #3663 from mozilla/refactor/async-await-5
refactor(auth-server): asyncify lib/email
2019-12-12 16:08:39 -08:00
Danny Coates db17f750b9
Merge pull request #3657 from mozilla/node-12
chore(node): updated node to v12
2019-12-12 15:56:18 -08:00
Ben Bangert c75e9e5580
refactor(auth-server): asyncify lib/email
Issue #2305
2019-12-12 15:47:37 -08:00
Ben Bangert 4d93779ccb
Merge pull request #3662 from mozilla/refactor/async-await-4
refactor(auth-server): asyncify lib/tokens
2019-12-12 15:16:06 -08:00
Danny Coates 7169a367e4
chore(node): updated node to v12 2019-12-12 14:34:45 -08:00
Dave Justice 97fd79b1d0
Merge pull request #3564 from mozilla/sentry-payments-server
task(payments-server): update sentry for sourcemaps on payments server
2019-12-12 13:55:28 -08:00
Ben Bangert 692cac3177
Merge pull request #3660 from mozilla/refactor/async-await-3
refactor(auth-server): asyncify devices/push/AM
2019-12-12 13:46:29 -08:00
Ben Bangert ea1df68ddb
Merge pull request #3659 from mozilla/refactor/async-await-2
refactor(auth-server): asyncify signer/updates/BS
2019-12-12 13:44:43 -08:00
Vijay Budhram 4283d0b4c2
Merge pull request #3644 from mozilla/issue-2427, r=@chenba
Connects to #2427

Removes most references to the older token code route. This was the first version of the code which was supposed to replace confirmation links. It was a randomly generated code with an expiration of 20mins.

This code has been replaced with a time based code that is used for verifying a login and session.
2019-12-12 16:37:50 -05:00
Vijay Budhram 71b067de9a
fix(test): Update sign up code previous window test 2019-12-12 16:35:34 -05:00
Dave Justice b49c1b451b
task(payments-server): update sentry for sourcemaps on payments server
- fixes #2345
2019-12-12 21:12:47 +00:00
Shane Tomlinson 2232152165
Merge pull request #3651 from mozilla/expose-create-email-helper r=@chenba
refactor(tests): Expose all TestHelpers within FunctionalHelpers.
2019-12-12 21:04:47 +00:00
Barry Chen 8c15b2c898
Merge pull request #3656 from chenba/3650-local-sub-upgrade
chore(subhub): handle subscription upgrades in stub API
2019-12-12 14:49:18 -06:00
Vijay Budhram c0887e505f
Merge pull request #3658 from mozilla/update-async-db, r=@bbangert, @dannycoates
chore(refactor): Add await to `request.app.devices` where needed
2019-12-12 15:27:09 -05:00
Ben Bangert 811aee303e
refactor(auth-server): asyncify lib/tokens
Issue #2305
2019-12-12 12:25:43 -08:00
Vijay Budhram 9024ec7f5b
chore(refactor): Add await to `request.app.devices` where needed 2019-12-12 14:52:38 -05:00
Ben Bangert 2de519da60
refactor(auth-server): asyncify devices/push/AM
Issue #2305
2019-12-12 11:51:16 -08:00
Ben Bangert e914b95ace
refactor(auth-server): asyncify signer/updates/BS
Updates for async/await:
* signer.js
* updates.js
* backendService.js

Issue #2305
2019-12-12 11:01:44 -08:00
Ben Bangert 8706a21025
Merge pull request #3639 from mozilla/refactor/async-await-1
refactor(auth-server): async/await updates
2019-12-12 09:43:47 -08:00
Ben Bangert 1d44b3dc0b
refactor(auth-server): async/await updates
Async/await updates to:
* cache.js
* db.js
* server.js
* context.js
2019-12-12 09:19:37 -08:00
Barry Chen 2f9d9b8cc4
chore(subhub): handle subscription upgrades in stub API
This patch add the missing `updateSubscription` function to the SubHub
stub API.
2019-12-12 10:35:57 -06:00
Shane Tomlinson a86e324a6a
refactor(tests): Expose all TestHelpers within FunctionalHelpers.
While writing the functional test deep dive, I found myself thinking
it odd I had to explain that two files had to be included to create
a user. So I decided to make it so one file needed to be included
by exposing all TestHelper methods in FunctionalHelpers.

Not attached to an issue.

ref https://github.com/mozilla/ecosystem-platform/pull/47
2019-12-12 16:22:59 +00:00
Vijay Budhram 11be99796b
Merge pull request #3613 from mozilla/issue-3597, r=@shane-tomlinson
fix(buttons): Add `Not now` button back to sms page
2019-12-12 09:11:05 -05:00
Shane Tomlinson abfb982276
Merge pull request #3636 from mozilla/flush-metrics-before-notifying-browser r=@vbudhram
fix(metrics): Flush metrics any time messages are sent to the browser
2019-12-12 10:52:54 +00:00
Shane Tomlinson a4f406cddc
fix(metrics): Flush metrics any time messages are sent to the browser
While writing docs on how to ensure metrics are flushed before
FxA closes, I realized we could probably automate this. Any
time we send a notice to the browser, flush metrics first.

issue #3213
2019-12-12 10:33:44 +00:00
Shane Tomlinson 3e99324488
Merge pull request #3595 from mozilla/signup-code-unverified-signin r=@vbudhram
feat(signin): Convert signin w/ unverified account to codes
2019-12-12 10:30:27 +00:00
Vijay Budhram 216af8bc23
chore(refactor): Remove token code routes, js endpoints and docs 2019-12-11 16:43:25 -05:00
Vijay Budhram 2110ef8db4
fix(buttons): Add `Not now` button back to sms page 2019-12-11 14:43:30 -05:00
Shane Tomlinson f384a7eed4
feat(signin): Signin w/ unverified accounts uses codes
Only handles signin that requires password with unverified account,
does not handle cached signin with an unverified account or visiting
settings with an unverified account.

fixes #3459
2019-12-11 08:29:53 +00:00
Ryan Kelly 16e58737d9
Set `service` tag for metrics events based on fxa_status response.
Because:

* Metrics events for the sync-optional flow currently have a missing
  `service` attribute.
* The sync-optional flow does not learn the client_id of the
  connecting application until it receives the `fxa_status` message.

This commit:

* Explicitly sets the `service` attribute on the metrics object
  when handling the `fxa_status` message response.

Fixes #3611.
2019-12-11 13:59:09 +11:00
Les Orchard 8255380181
Merge pull request #3632 from lmorchard/3452-csp-for-icons
feat(payments): add accounts-static CDN as imgSrc to CSP header
2019-12-10 16:00:38 -08:00
Les Orchard f4b519c95a
feat(payments): add accounts-static CDN as imgSrc to CSP header
fixes #3452
2019-12-10 18:44:34 -05:00