зеркало из https://github.com/mozilla/gecko-dev.git
bug 1332690 - return failure from DocAccessibleParent::RecvShow() when appropriate r=yzen
This commit is contained in:
Родитель
34e7abc036
Коммит
0d5925b408
|
@ -35,13 +35,13 @@ DocAccessibleParent::RecvShowEvent(const ShowEventData& aData,
|
||||||
// required show events.
|
// required show events.
|
||||||
if (!parent) {
|
if (!parent) {
|
||||||
NS_ERROR("adding child to unknown accessible");
|
NS_ERROR("adding child to unknown accessible");
|
||||||
return IPC_OK();
|
return IPC_FAIL(this, "unknown parent accessible");
|
||||||
}
|
}
|
||||||
|
|
||||||
uint32_t newChildIdx = aData.Idx();
|
uint32_t newChildIdx = aData.Idx();
|
||||||
if (newChildIdx > parent->ChildrenCount()) {
|
if (newChildIdx > parent->ChildrenCount()) {
|
||||||
NS_ERROR("invalid index to add child at");
|
NS_ERROR("invalid index to add child at");
|
||||||
return IPC_OK();
|
return IPC_FAIL(this, "invalid index");
|
||||||
}
|
}
|
||||||
|
|
||||||
uint32_t consumed = AddSubtree(parent, aData.NewTree(), 0, newChildIdx);
|
uint32_t consumed = AddSubtree(parent, aData.NewTree(), 0, newChildIdx);
|
||||||
|
@ -50,7 +50,7 @@ DocAccessibleParent::RecvShowEvent(const ShowEventData& aData,
|
||||||
// XXX This shouldn't happen, but if we failed to add children then the below
|
// XXX This shouldn't happen, but if we failed to add children then the below
|
||||||
// is pointless and can crash.
|
// is pointless and can crash.
|
||||||
if (!consumed) {
|
if (!consumed) {
|
||||||
return IPC_OK();
|
return IPC_FAIL(this, "failed to add children");
|
||||||
}
|
}
|
||||||
|
|
||||||
#ifdef DEBUG
|
#ifdef DEBUG
|
||||||
|
|
Загрузка…
Ссылка в новой задаче