Bug 1456590 Part 1: Omit line names from implicitly named areas, to avoid confusion. r=mats

MozReview-Commit-ID: 3vK2MUeEuqw

--HG--
extra : rebase_source : 52b948982757381deed80879917135c887103b2b
This commit is contained in:
Brad Werth 2018-05-02 16:24:20 -07:00
Родитель 5b50d3c787
Коммит 33507e6126
1 изменённых файлов: 8 добавлений и 0 удалений

Просмотреть файл

@ -145,6 +145,14 @@ GridLines::SetLineInfo(const ComputedGridTrackInfo* aTrackInfo,
// Add in names from grid areas where this line is used as a boundary. // Add in names from grid areas where this line is used as a boundary.
for (auto area : aAreas) { for (auto area : aAreas) {
// We specifically ignore line names from implicitly named areas,
// because it can be confusing for designers who might naturally use
// a named line of "-start" or "-end" and create an implicit named
// area without meaning to.
if (area->Type() == GridDeclaration::Implicit) {
continue;
}
bool haveNameToAdd = false; bool haveNameToAdd = false;
nsAutoString nameToAdd; nsAutoString nameToAdd;
area->GetName(nameToAdd); area->GetName(nameToAdd);