mozilla
/
gecko-dev
зеркало из https://github.com/mozilla/gecko-dev.git
1
0
Форкнуть 0
Код Задачи Пакеты Проекты Релизы Вики Активность

Bug 1651763 [wpt PR 24534] - [LayoutNG] Only spanner siblings are considered adjacent., a=testonly 

Automatic update from web-platform-tests
[LayoutNG] Only spanner siblings are considered adjacent.

The spec isn't crystal clear, but unconditionally considering spanners
that are siblings of another spanner's ancestors as adjacent is
definitely wrong. We need to resume column content layout inside the
parent block of the spanner, since it may have a fixed block-size,
block-end padding / border, or anything else that we'd just lose
otherwise.

This breaks one existing (non-WPT) test, but I'm not convinced that the
test is valid. Filed crbug.com/1100849 for it.

It also fixes 3 WPT tests. They were all quite complex, so I added a
couple of simple ones, that demonstrate this fix more to the point.

Bug: 829028
Change-Id: I9d55153f859dd84a5019e7d4dd09453f7f9ee1e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290150
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786841}

--

wpt-commits: 90c4db31dd07db9c6009cdbc0358f460099a15fb
wpt-pr: 24534
This commit is contained in:
Morten Stenshorne 2020-07-17 11:12:31 +00:00 коммит произвёл moz-wptsync-bot
Родитель ae5b105c5c
Коммит 8977c1e5e0
2 изменённых файлов: 21 добавлений и 0 удалений
Показать статистику Скачать Patch файл Скачать Diff файл Показать все файлы Свернуть все файлы

11
testing/web-platform/tests/css/css-multicol/non-adjacent-spanners-000.html Normal file
Просмотреть файл

@ -0,0 +1,11 @@
<!DOCTYPE html>
<link rel="author" title="Morten Stenshorne" href="mailto:mstensho@chromium.org">
<link rel="help" href="https://www.w3.org/TR/css-multicol-1/#spanning-columns">
<link rel="match" href="../reference/ref-filled-green-100px-square-only.html">
<p>Test passes if there is a filled green square.</p>
<div style="columns:2; column-fill:auto; column-gap:0; width:100px; background:green;">
<div style="height:80px;">
<div style="column-span:all; height:10px; margin-bottom:20px;"></div>
</div>
<div style="column-span:all; height:10px; margin-top:20px;"></div>
</div>

10
testing/web-platform/tests/css/css-multicol/non-adjacent-spanners-001.html Normal file
Просмотреть файл

@ -0,0 +1,10 @@
<!DOCTYPE html>
<link rel="author" title="Morten Stenshorne" href="mailto:mstensho@chromium.org">
<link rel="help" href="https://www.w3.org/TR/css-multicol-1/#spanning-columns">
<link rel="match" href="../reference/ref-filled-green-100px-square.xht">
<p>Test passes if there is a filled green square and <strong>no red</strong>.</p>
<div style="columns:2; column-fill:auto; column-gap:0; width:100px; background:red;">
<div style="height:200px; background:green;">
<div style="column-span:all;"></div>
</div>
</div>