Bug 1527861: Allow disabling BinAST compilation; r=tcampbell

Differential Revision: https://phabricator.services.mozilla.com/D19765

--HG--
extra : rebase_source : 059c236c7c3bcfff8349072cfb7a0364cf4d5f71
extra : amend_source : ee72ef04d5bc75c003f6aa3eedae028a8a3f491d
extra : histedit_source : 795c699d7f003b69569e8aacede6fea76b6e79f9

js/moz.configure

@@ -475,13 +475,16 @@ set_define('ENABLE_PIPELINE_OPERATOR', enable_pipeline_operator)
 # Experimental support for BinAST
 # ==============================================================
 
-@depends(milestone)
-def enable_build_binast(milestone):
-    if milestone.is_nightly:
-        return True
+@depends(milestone.is_nightly)
+def default_binast(is_nightly):
+    return is_nightly
 
-set_define('JS_BUILD_BINAST', enable_build_binast)
-set_config('JS_BUILD_BINAST', enable_build_binast)
+js_option('--enable-binast',
+          default=default_binast,
+          help="{Enable|Disable} BinAST support")
+
+set_config('JS_BUILD_BINAST', depends_if('--enable-binast')(lambda x: True))
+set_define('JS_BUILD_BINAST', depends_if('--enable-binast')(lambda x: True))
 
 
 # Experimental support for wasm code generation with Cranelift

js/src/frontend/moz.build

@@ -76,6 +76,10 @@ if CONFIG['JS_BUILD_BINAST']:
         'BinTokenReaderMultipart.cpp',
     ]
 
+    DIRS += [
+        'binsource'
+    ]
+
     # Instrument BinAST files for fuzzing as we have a fuzzing target for BinAST.
     if CONFIG['FUZZING_INTERFACES'] and CONFIG['LIBFUZZER']:
         include('/tools/fuzzing/libfuzzer-flags.mozbuild')

js/src/moz.build

@@ -409,7 +409,6 @@ else:
 DIRS += [
     'build',
     'frontend',
-    'frontend/binsource',
     'gc',
     'jit',
     'wasm',