Manuel Bucher
fb968aec40
Bug 1733498 - Migrate necko errors l10n strings from properties to Fluent r=necko-reviewers,valentin,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D136612
2024-11-04 16:58:29 +00:00
Alexandru Marc
71363f7504
Backed out 2 changesets (bug 1733498) for causing perma Localised repacks build bustages a=backout
...
Backed out changeset 2b0ab2780b86 (bug 1733498)
Backed out changeset 520270bde3eb (bug 1733498)
2024-11-01 11:37:29 +02:00
Manuel Bucher
f75f7b7494
Bug 1733498 - Migrate necko errors l10n strings from properties to Fluent r=necko-reviewers,valentin,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D136612
2024-10-31 17:53:03 +00:00
Noemi Erli
d635f30118
Backed out 1 changesets (bug 1733498) for causing failures in browser_necko_l10n.js CLOSED TREE
...
Backed out changeset 005a00fa3096 (bug 1733498)
2024-10-30 23:57:31 +02:00
Manuel Bucher
0cdfe4a2e4
Bug 1733498 - Migrate necko errors l10n strings from properties to Fluent r=necko-reviewers,valentin,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D136612
2024-10-30 20:38:41 +00:00
Norisz Fay
0c8a06b734
Backed out changeset e1b320fb4503 (bug 1914858
) for causing xpcshell failures on test_filename_sanitize.js and test_DownloadPaths.js
2024-10-29 03:39:41 +02:00
Neil Deakin
ad939ad166
Bug 1914858
, filename sanitization improvements, r=Gijs,mak
...
Differential Revision: https://phabricator.services.mozilla.com/D226639
2024-10-28 23:44:37 +00:00
Paul Zuehlcke
77aa09c197
Bug 1925479 - Remove security.external_protocol_requires_permission pref. r=Gijs,perftest-reviewers,fbilt
...
Differential Revision: https://phabricator.services.mozilla.com/D226179
2024-10-28 17:34:10 +00:00
Stanca Serban
4760b04798
Backed out 2 changesets (bug 1733498) for causing mochitests failures.
...
Backed out changeset 27bdb3f9ad81 (bug 1733498)
Backed out changeset a0a8e9643810 (bug 1733498)
2024-10-28 19:54:02 +02:00
Manuel Bucher
5bd00204c7
Bug 1733498 - Migrate necko errors l10n strings from properties to Fluent r=necko-reviewers,valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D136612
2024-10-28 16:25:01 +00:00
Alexandru Marc
63e1b92a4f
Backed out changeset 0643ca11931d (bug 1733498) for causing multiple failures.
2024-10-28 17:32:42 +02:00
Manuel Bucher
30108ed549
Bug 1733498 - Migrate necko errors l10n strings from properties to Fluent r=necko-reviewers,valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D136612
2024-10-28 14:34:04 +00:00
serge-sans-paille
e54774d573
Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang
...
Namely std::size, std::end and std::size. This drops C support for
MOZ_ARRAY_LENGTH but it wasn't used anyway.
Differential Revision: https://phabricator.services.mozilla.com/D224611
2024-10-28 08:21:19 +00:00
Alexandru Marc
191ccbe7fe
Backed out changeset d92f391b3b0c (bug 1922838) for backing out bug 1915351
2024-10-25 16:42:33 +03:00
serge-sans-paille
53068cdf31
Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang
...
Namely std::size, std::end and std::size. This drops C support for
MOZ_ARRAY_LENGTH but it wasn't used anyway.
Differential Revision: https://phabricator.services.mozilla.com/D224611
2024-10-24 09:06:01 +00:00
Alexandru Marc
83543f20f2
Backed out changeset 448597bce69d (bug 1922838) for causing build bustages. CLOSED TREE
2024-10-24 11:37:49 +03:00
serge-sans-paille
c7a369b29a
Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang
...
Namely std::size, std::end and std::size. This drops C support for
MOZ_ARRAY_LENGTH but it wasn't used anyway.
Differential Revision: https://phabricator.services.mozilla.com/D224611
2024-10-24 07:38:30 +00:00
Oliver Old
98599e718f
Bug 1776893 - Replace do_CreateInstance for nsIFile with NS_NewLocalFile. r=xpcom-reviewers,profiler-reviewers,emilio,aabh
...
Differential Revision: https://phabricator.services.mozilla.com/D226255
2024-10-22 09:45:32 +00:00
Emilio Cobos Álvarez
b5d2263c26
Bug 1925866 - NS_NewLocalFile's aFollowSymlinks arg is unused. r=xpcom-reviewers,necko-reviewers,valentin,media-playback-reviewers,win-reviewers,karlt,nika,rkraesig
...
Remove it and related functions, and update the callers.
Differential Revision: https://phabricator.services.mozilla.com/D226261
2024-10-22 09:38:16 +00:00
Gijs Kruitbosch
330e68106b
Bug 1923655 - add test for protocol handler from non-existent currentWindowGlobal, r=pbz
...
Differential Revision: https://phabricator.services.mozilla.com/D225332
2024-10-15 18:32:57 +00:00
Gijs Kruitbosch
6e7de6cd5c
Bug 1923655 - driveby: fix naming of existing test functions to be unique, r=pbz
...
Differential Revision: https://phabricator.services.mozilla.com/D225331
2024-10-15 18:32:57 +00:00
Florian Quèze
1e85e4281a
Bug 1922231 - Avoid recording to histograms or scalars in processes that don't match the probe definition, r=chutten.
...
Differential Revision: https://phabricator.services.mozilla.com/D224309
2024-10-02 21:05:57 +00:00
Emilio Cobos Álvarez
80e1f1f9af
Bug 1921110 - Distinguish rel=preload from early-hints preload. r=arai,firefox-style-system-reviewers,zrhoffman
...
No behavior change right now, but this is needed to fix the initiator in
bug 1899734.
Differential Revision: https://phabricator.services.mozilla.com/D223642
2024-09-26 15:33:15 +00:00
Calixte
93b83e203e
Bug 1920656 - Update PDF.js to new version cc63941b6496382bc8c762b6ccd886f036d43601 r=pdfjs-reviewers,fluent-reviewers,marco,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D223280
2024-09-24 18:15:13 +00:00
Jan Horak
84cd68932c
Bug 1751467 Use GAppInfo to open downloaded files; r=stransky,settings-reviewers,mossop,mak,jmaher
...
The GAppInfo supports starting up flatpak applications where the simple
command does not work.
Differential Revision: https://phabricator.services.mozilla.com/D221792
2024-09-24 15:14:24 +00:00
Joel Maher
3ab43074a1
Bug 1919776 - part2: adjust skip-if for apple_silicon/catalina/os==mac to include os_version/cpu. r=aryx,credential-management-reviewers,tabbrowser-reviewers,dimi
...
Differential Revision: https://phabricator.services.mozilla.com/D222845
2024-09-23 17:33:15 +00:00
Gijs Kruitbosch
f0c75454de
Bug 1817727 - re-enable test_filename_sanitize.js on macOS, r=NeilDeakin
...
Differential Revision: https://phabricator.services.mozilla.com/D222644
2024-09-20 10:45:36 +00:00
Sandor Molnar
9cdd487af0
Bug 1776017 - Disable browser_open_internal_choice_persistence.js on macosx for frequent failures. r=jmaher DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D222731
2024-09-19 01:58:13 +00:00
Ted Mielczarek
31e50fe685
Bug 1918300 - Apply bug 1293212 and bug 1628961
to the uikit uriloader. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D221911
2024-09-13 04:04:37 +00:00
Emilio Cobos Álvarez
60fad39eb9
Bug 1911977 - Don't abort networking activity on external protocol navigations. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D221029
2024-09-10 15:22:04 +00:00
Emilio Cobos Álvarez
69d03391c0
Bug 1911977 - Minor clean-ups in nsDocShell::InternalLoad. r=smaug
...
Use const and the same style for download and JS checks.
Differential Revision: https://phabricator.services.mozilla.com/D221028
2024-09-05 17:08:39 +00:00
Butkovits Atila
90dc3743ea
Backed out 2 changesets (bug 1911977) for causing failures at browser_thumbnails_bg_bad_url.js. CLOSED TREE
...
Backed out changeset 564fe3a44acf (bug 1911977)
Backed out changeset d142c4f64ae7 (bug 1911977)
2024-09-05 04:19:21 +03:00
Emilio Cobos Álvarez
a2778c9033
Bug 1911977 - Minor clean-ups in nsDocShell::InternalLoad. r=smaug
...
Use const and the same style for download and JS checks.
Differential Revision: https://phabricator.services.mozilla.com/D221028
2024-09-04 20:18:55 +00:00
Nika Layzell
793f001a6e
Bug 1914594 - Move docshell.newWindowTarget to be on LoadInfo, r=necko-reviewers,kershaw
...
Previously, this was passed around using the nsHashPropertyBag base
class on HTTP channels. In bug 1907269
, this base was added to
nsExtProtocolChannel to support reading this property for external
protocols.
This unfortunately ended up not working when a HTTP channel redirects to
an external protocol, as the hash property propagation logic in
nsHttpChannel happens after the check that the target channel is a HTTP
channel, so the property was lost when redirecting to an external
protocol.
Rather than refactoring HTTP redirect logic, this patch simplifies by
moving the property onto the LoadInfo where it will be trivially
preserved across redirects, and available in the places which need it.
Because the nsHashPropertyBag base is no longer required for
nsExtProtocolChannel, it is also removed.
Differential Revision: https://phabricator.services.mozilla.com/D220744
2024-09-03 16:00:23 +00:00
Rob Wu
e520e9fd35
Bug 1903780
- Support directory names again in downloads.download r=geckoview-reviewers,NeilDeakin,m_kato
...
Differential Revision: https://phabricator.services.mozilla.com/D218719
2024-08-20 18:53:21 +00:00
Sean
3799274f28
Bug 1890028 - Display Server Error message when server returns HTTP 500 and unusual content-type r=kershaw,fluent-reviewers,necko-reviewers,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D216978
2024-08-07 13:31:02 +00:00
Emilio Cobos Álvarez
e1ad6294bf
Bug 1910698 - Remove nsIScriptError.sourceLine. r=smaug,devtools-reviewers,webdriver-reviewers,necko-reviewers,nchevobbe,kershaw,jdescottes,credential-management-reviewers,dimi
...
Afaict the source lines are not exposed anywhere in the UI.
Differential Revision: https://phabricator.services.mozilla.com/D218115
2024-08-01 17:12:48 +00:00
Emilio Cobos Álvarez
198c331213
Bug 1910698 - Add a struct to represent JS caller location and more general warning source location. r=smaug,necko-reviewers,anti-tracking-reviewers,dom-storage-reviewers,pbz,kershaw,janv
...
Use it liberally across the tree. This could be cleaned up even more in the future.
Differential Revision: https://phabricator.services.mozilla.com/D218114
2024-08-01 17:12:48 +00:00
Nika Layzell
c87395824f
Bug 1907269
- Part 2: Test that external URIs load in noopener pop-ups, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D218011
2024-07-31 20:34:54 +00:00
Nika Layzell
22d1d975b2
Bug 1907269
- Part 1: Allow pop-up windows to load external URIs for first load, r=Gijs
...
Previously this load would be allowed due to the "web-controlled" check
failing to reject the load. This patch instead bases it on the
docshell.newWindowTarget flag, which is set for the first load in a new
DocShell due to a call to window.open or target=_blank.
This required making the external protocol channel be a property bag so
that the flag can be set on the channel. In the future we may want to
switch this flag to being set in a more generic way which is less
specific to the channel.
Differential Revision: https://phabricator.services.mozilla.com/D217484
2024-07-31 20:34:54 +00:00
Sandor Molnar
5ce501ee48
Backed out 2 changesets (bug 1907269
) for causing bc failures @ browser_ftp_protocol_handlers.js CLOSED TREE
...
Backed out changeset 3270496f12d8 (bug 1907269
)
Backed out changeset 218c98804a83 (bug 1907269
)
2024-07-30 02:16:42 +03:00
Nika Layzell
850e1046eb
Bug 1907269
- Part 2: Test that external URIs load in noopener pop-ups, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D218011
2024-07-29 22:15:43 +00:00
Nika Layzell
a5ec44308d
Bug 1907269
- Part 1: Allow pop-up windows to load external URIs for first load, r=Gijs
...
Previously this load would be allowed due to the "web-controlled" check
failing to reject the load. This patch instead bases it on the
docshell.newWindowTarget flag, which is set for the first load in a new
DocShell due to a call to window.open or target=_blank.
This required making the external protocol channel be a property bag so
that the flag can be set on the channel. In the future we may want to
switch this flag to being set in a more generic way which is less
specific to the channel.
Differential Revision: https://phabricator.services.mozilla.com/D217484
2024-07-29 22:15:43 +00:00
Neil Deakin
73dca49154
Bug 1907931, fix missing closing tags so that the downloads tests are properly run, r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D217307
2024-07-26 18:28:59 +00:00
Marco Bonardo
3ca32026b5
Bug 1904022 - Create the check file in the initial download folder when checking for executable bits. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D217385
2024-07-24 14:03:44 +00:00
Marco Bonardo
5c1d864d6e
Bug 1904023 - Provide the onStatusChange error message on the download when the failure is in nsExternalHelperAppService. r=Gijs
...
We can pass over the localized error message from nsExternalHelperAppService to
the downloads UI and show it to the user. That may help the user figuring out
why the download failed.
For now long messages are delegated to the tooltip.
Differential Revision: https://phabricator.services.mozilla.com/D217317
2024-07-24 14:03:14 +00:00
Sylvestre Ledru
45030f6970
Bug 1519636 - Reformat recent changes to the Google coding style r=emilio,necko-reviewers,geckoview-reviewers,application-update-reviewers,media-playback-reviewers,devtools-reviewers,anti-tracking-reviewers,profiler-reviewers,win-reviewers,migration-reviewers,padenot,mconley,nchevobbe,kershaw,gstoll,mstange,bytesized,m_kato
...
This new version of clang 17 also slightly changed the formatting.
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D215914
2024-07-17 11:15:31 +00:00
whale
a860887be7
Bug 1768758 - Add Windows-specific function getW() for getting wchar_t r=xpcom-reviewers,win-reviewers,gstoll,nika
...
`char16_t` and `wchar_t` are functionally the same on Windows. But logging statements do not handle `char16_t` very well, resulting in the need to static cast to `wchar_t`. For more info, see [[ https://bugzilla.mozilla.org/show_bug.cgi?id=1768758 | bug task ]]:
This diff introduces a Windows-specific function for getting strings as `wchar_t` and replaces previous workaround usages.
Differential Revision: https://phabricator.services.mozilla.com/D215869
2024-07-10 22:10:56 +00:00
Ray Kraesig
b626761907
Bug 1884426 - [3/6] Implement file-picker-crashed UI message r=Gijs,win-reviewers,fluent-reviewers,firefox-desktop-core-reviewers ,flod,gstoll
...
Fire a signal (via the observer service) when the file-dialog crashes or
otherwise fails.
Set up a listener for that signal which reports the failure to the
end-user via the NotificationBox.
Differential Revision: https://phabricator.services.mozilla.com/D214192
2024-07-09 22:16:55 +00:00
Joel Maher
3d4dfe804d
Bug 1903845 - Add 'os_integration' tags to test manifests for faster image verification. r=aryx,jgilbert,settings-reviewers,media-playback-reviewers,sessionstore-reviewers,places-reviewers,omc-reviewers,migration-reviewers,padenot,dao,aminomancer,Standard8,mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D214969
2024-07-09 13:01:55 +00:00