* Needed to account for the reverse icon/background colors made in this same bug so this changes it only for sound playing, muted, activemedia-blocked
Differential Revision: https://phabricator.services.mozilla.com/D228318
* `/css/css-align/abspos/stretch-intrinsic-size*`: Some tests still do not pass,
because it uses `<canvas>` which overrides `nsIFrame::ComputeSize`, skipping
the invocation of `nsIFrame::ComputeAbsoluteAutoSize`.
* `/css/css-anchor-position/`: Anchor positioning is not yet implemented,
changes are coincidental.
* `grid-baseline-align-001.html`: Baseline alignment of absolutely-positioned
grid item should no longer stretch it.
Differential Revision: https://phabricator.services.mozilla.com/D226533
Also implement the alignment safety behaviour that is described as "in-between"
[1].
This is mutually exclusive to `PLACEHOLDER_STATICPOS_NEEDS_CSSALIGN` related computation,
since it involves requiring CSS alignment to compute the static position when inset
values are auto, for grid & flex boxes.
[1] https://drafts.csswg.org/css-position-3/#abspos-layout
Differential Revision: https://phabricator.services.mozilla.com/D226531
In a weird case involving stack overflow, it's actually possible for this to be called with an invalid flag. I don't remember why I originally decide to assert against that, but it doesn't seem worthwhile.
While we're here, V8 replaced all uses of v8::base::Optional with std::optional, and this was the final remaining instance, so I've updated it.
I'm not including the testcase because it depends on stack overflow being triggered with extreme precision in native code.
Differential Revision: https://phabricator.services.mozilla.com/D228211
This is deprecated and causing issues for users on Python 3.12. Changed
the code to manually find the library file rather than depending on any
library.
Differential Revision: https://phabricator.services.mozilla.com/D228213
Because the tracer actor runs in the content process, the preference toggling logic
has to be done in some code running in the parent process: TargetConfiguration.
Differential Revision: https://phabricator.services.mozilla.com/D227833
Stop manually crafting the profiler data by using SpiderMonkey hooks.
Instead, use the profiler native pipeline to do the collection.
This still relies on JSTracer class in order to trigger the record on next interaction or page load.
One caveat is that it starts the profiler from the content process, which prevents recording screenshots correctly.
Differential Revision: https://phabricator.services.mozilla.com/D227831
Based on the [[ https://storage.googleapis.com/mobile-allure-test-reports/Fenix/allure-report/index.html | Allure report ]] these UI tests had a 1m 30s running duration time.
To improve the running times, I've removed some unnecessary steps from the UI test, reduced the waiting time in some cases and removed some unnecessary waits.
Managed to improve the running durations as it follows:
verifyCopyPDFTextOptionTest
- From an average of 1m 34s to 41s (**running duration reduced by approx. 53s**)
verifyCopyTextOptionTest
- From an average of 1m 27s to 42s (**running duration reduced by approx. 45s**)
Both UI tests successfully passed 100x on Firebase ✅
All UI tests successfully passed 2x on Firebase ✅
Differential Revision: https://phabricator.services.mozilla.com/D228307
We are wrapping incumbent global into host defined data, and the
this optimization still applies. This patch just renames it.
Differential Revision: https://phabricator.services.mozilla.com/D227841
Automatic update from web-platform-tests
[webcodecs] Add rotation and flip init options on VideoFrame
This change implements `rotation` and `flip` options in `VideoFrameInit`
and `VideoFrameBufferInit`, as described in
https://github.com/w3c/webcodecs/issues/351#issuecomment-2359389479.
Bug: 40243431
Change-Id: I9eae4f4f101df7a285abd6575f7271b7589a512c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5939863
Reviewed-by: Eugene Zemtsov <eugene@chromium.org>
Commit-Queue: Eugene Zemtsov <eugene@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1379353}
--
wpt-commits: a525424ff744bca3cb7e11c8aa19127c95a60cb0
wpt-pr: 49013
Automatic update from web-platform-tests
Fix#7169: rewrite assert_readonly to check property descriptors
This changes the implementation to only check that the property
descriptor makes the property readonly; it doesn't actually check its
behaviour. As detailed in the above issue, there's too many ways for
this test to be otherwise bogus, thus we should go for the simple
implementation.
This also fixes /css/cssom/cssimportrule.html, which previously
asserted that CSSImportRule#media was readonly, which was a
meaningless test, as even after the [PutForwards] [[Set]] call had
occured, the attribute being tested still returned the same object,
because it is defined with [SameObject].
--
wpt-commits: 877d18df86bb73b9b0f591eb0a56f38206d4b185
wpt-pr: 48965
Automatic update from web-platform-tests
Add attribute reflection behavior for dialog closedBy [2/N]
This implements reflection of `closedBy` including the "limited to
known values" behavior.
See spec PR for details:
https://github.com/whatwg/html/pull/10737
Bug: 376516550
Change-Id: Iddefd573fe19fd39f4b3aebe13390235fea969b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5988652
Commit-Queue: Mason Freed <masonf@chromium.org>
Reviewed-by: David Baron <dbaron@chromium.org>
Commit-Queue: David Baron <dbaron@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1379228}
--
wpt-commits: 28946b88d5b2e037bb2506ae4984e8725ba5560b
wpt-pr: 48989
Automatic update from web-platform-tests
[CodeHealth] Misc cleanup in PointerEvent wpts (#48983)
This is a no-op change to remove a few unused methods/features.
Change-Id: I5406533f119c052bfe63f7fffdd17e9d828b7964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5989014
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1378549}
Co-authored-by: Mustaq Ahmed <mustaq@google.com>
--
wpt-commits: eb02ec4fb139eee2d9360e6285a7561954f72198
wpt-pr: 48983
Automatic update from web-platform-tests
[@container] style() query unset on root element crashes
Discovered when trying to fix issue 376834363.
StyleResolver::ComputeValue() does not set up a parent style for the
root element which meant applying unset would crash. There was already a
check for inherit. Do the same for unset.
Bug: 376834363
Change-Id: I075dd462668436f98a6f7924929f5baba6eeba09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5999996
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1379181}
--
wpt-commits: 92228c4bcdc5e9e8c47a36086c274dc44cd8d87f
wpt-pr: 49010
Automatic update from web-platform-tests
[Clipboard APIs] Handle null values for blobs OnRead()
Don't create |V8UnionBlobOrString| if the blob is null so that the null
value is handled in |ClipboardPromise::ResolveRead()| and it doesn't
perform an invalid conversion |ToResolvedPromise|.
Updated |ClipboardItemWithDOMStringSupport| flag status to experimental
Bug: 377251898
Change-Id: I47400f8a7671e4bb7b98b44d864b24b510e64835
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5993934
Reviewed-by: Christine Hollingsworth <christinesm@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Ayu Ishii <ayui@chromium.org>
Commit-Queue: Sambamurthy Bandaru <sambamurthy.bandaru@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1379178}
--
wpt-commits: 3a14200cd9f7bddc2aab02efed9b3c757fd72e35
wpt-pr: 49009
Automatic update from web-platform-tests
Add a test updating scroll position mid-smooth-scroll
This is a minimized test of https://crbug.com/376097633 on
boostmobile.com.
Bug: 376097633
Change-Id: I014d2a1b276f8047272f2a1bf587233844574951
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6001172
Commit-Queue: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Auto-Submit: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1379136}
--
wpt-commits: 73600679fde08fe42c886d87564efaf7747840b2
wpt-pr: 49008
Automatic update from web-platform-tests
ListItemOrdinal should use explicit_value_ when the element's counter-set CSS property is set to empty
The patch[1] ensures that ListItemOrdinal does not use `explicit_value_`
when the `counter-set` is set. However, if the `counter-set` is assigned
an invalid value, ListItemOrdinal value will remain unchanged.
Consider this test case:
```
<!doctype html>
<ol>
<li value="5" style="counter-set: list-item 1"></li>
</ol>
<script>
document.body.offsetLeft;
document.querySelector("li").style.counterSet = "";
</script>
```
The li element should show "5" as the `counter-set` is not set.
This patch ensures that ListItemOrdinal should use `explicit_value_`
when `counter-set` is not set.
[1]: https://chromium-review.googlesource.com/c/chromium/src/+/5974811
Bug: 40205385
Change-Id: I0c9eeda21ef6890e727a6f42c464af412b08eb50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5992536
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Commit-Queue: Peng Zhou <zhoupeng.1996@bytedance.com>
Cr-Commit-Position: refs/heads/main@{#1379108}
--
wpt-commits: e8e4fa7bc56f2652515a0bd4cf3bbf857f9c0eb5
wpt-pr: 49006
Automatic update from web-platform-tests
Fix invalidation for base-select select:open
This patch moves the invalidation for :open on select elements to the
same place as :popover-open in order to prevent a crash. This is more
correct because the selector checker for select:open looks at
:popover-open when in base appearance mode.
This patch also uncovers a new way to hit the CHECK in
ManuallyAssignSlots which I was already planning on removing in
http://crrev.com/c/5953628 so I am removing it in this patch instead.
Fixed: 375004874, 364924715
Change-Id: I36b8c1e9d467c8d40623eb83bc3a8d5154fc9218
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5979628
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1379073}
--
wpt-commits: 67feadb88c777703674513acec307364a07bbed9
wpt-pr: 48996
Automatic update from web-platform-tests
[@scope] Make prelude selectors unforgiving
The selectors within the @scope prelude were previously unforgiving
(like within :is()), but this was changed in Issue 10042 [1].
Being forgiving means a rule like "@scope (.a, :unknown-thing)"
would behave like "@scope (.a)" (the invalid parts are just silently
ignored), whereas unforgiving behavior would consider it a parse error.
[1] https://github.com/w3c/csswg-drafts/issues/10042
Fixed: 346555843, 343794754
Change-Id: I017c098c1406bcc0df62690038d16879c1e8c110
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5999993
Reviewed-by: Steinar H Gunderson <sesse@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1378956}
--
wpt-commits: ff335edfbb85c271e3fe402c906237f67cc2d88c
wpt-pr: 49005
Automatic update from web-platform-tests
[Sanitizer] Implement the accessors of SanitizerConfig.
This implements the data members and associated functions of SanitizerConfig.
It does not (yet) implement the actual sanitization logic, or handling
of defaults.
Bug: 356601280
Change-Id: Iba9f1f053a74f1420e60551b734c6321e4309596
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5981094
Reviewed-by: Yifan Luo <lyf@chromium.org>
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1378961}
--
wpt-commits: c2c13750a58c50c076cbfcc30367d2e7ad849b7d
wpt-pr: 49003