The Fennec CrashReporter class is also renamed to
CrashReporterActivity. When running in Fennec, the Activity will be used
which retains what we do today, prompting for comments, email, etc. When
used in standalone GeckoView, we report the crash without user
interaction if the appropriate GeckoRuntimeSetting was set. The app will
want to ask for user permission at least once in order to set this.
We do not collect the URL, email, or logcat with GeckoView crashes.
Logcat and URL would be nice to have, but it's not clear what the API
for those would look like, and they can be addressed in followup
patches.
MozReview-Commit-ID: C5ROsUKreRe
The Fennec CrashReporter class is also renamed to
CrashReporterActivity. When running in Fennec, the Activity will be used
which retains what we do today, prompting for comments, email, etc. When
used in standalone GeckoView, we report the crash without user
interaction if the appropriate GeckoRuntimeSetting was set. The app will
want to ask for user permission at least once in order to set this.
We do not collect the URL, email, or logcat with GeckoView crashes.
Logcat and URL would be nice to have, but it's not clear what the API
for those would look like, and they can be addressed in followup
patches.
MozReview-Commit-ID: C5ROsUKreRe
Also fixes existing code which fails the rule.
MozReview-Commit-ID: CkLFgsspGMU
--HG--
extra : rebase_source : 86a43837659aa2ad83a87eab53b7aa8d39ccf55b
The symbol server recently gained the ability to upload symbols from try
to a different prefix in the symbols bucket. If we change the token stored
in the Taskcluster secret `project/releng/gecko/build/level-1/gecko-symbol-upload`
to one that has only "upload try symbols" permissions then we can upload
symbols from try server builds directly to symbols.mo.
MozReview-Commit-ID: HjQclKKXbA3
--HG--
extra : rebase_source : 8afed0bf52565bad513c30a7d5de274b356d6d84
The Fennec CrashReporter class is also renamed to
CrashReporterActivity. When running in Fennec, the Activity will be used
which retains what we do today, prompting for comments, email, etc. When
used in standalone GeckoView, we report the crash without user
interaction if the appropriate GeckoRuntimeSetting was set. The app will
want to ask for user permission at least once in order to set this.
We do not collect the URL, email, or logcat with GeckoView crashes.
Logcat and URL would be nice to have, but it's not clear what the API
for those would look like, and they can be addressed in followup
patches.
MozReview-Commit-ID: C5ROsUKreRe
Don't free memory in exception handling context to avoid deadlocks
and process state corruption. Replace old_handler_.reset() with
old_handler_.release() to intentionally leak the sigaction struct instead.
MozReview-Commit-ID: lUNygOJCUL
--HG--
extra : rebase_source : 1f50b7d22cc2fa32d3e31125e563df6203a48612
The assembly file uses the wrong syntax and MinGW cannot compile it.
(Also, gcc doesn't recognize it, because it ends in .asm and not .s.)
MozReview-Commit-ID: 5mHPi8PVio3
--HG--
extra : rebase_source : d10a61e5eda24245105b6acd3e78726feebd9fd1
Before we were falling back to using the raw version, which isn't
correct on at least beta (i.e. we would get `60.0` instead of `60.0b1`).
MozReview-Commit-ID: 7NfV6iRoj4y
--HG--
extra : rebase_source : de1ea9d64d1d03c8281fc0ab9efe4ffac6fd40cb
Historically we built all our binaries in directories in the objdir, then
symlinked them into dist/bin. Some binaries needed to be copied instead
so that certain relative path lookups work properly, so we resorted to
sprinkling `NSDISTMODE=copy` around Makefiles.
This change makes it so we build PROGRAMs (not any other sort of targets)
directly in dist/bin instead. We could do the same for our other targets
with a little more work.
There were several places in the tree that were copying built binaries to
some other place and needed fixup to match the new location of binaries.
On Windows pdb files are left in the objdir where the program was
originally linked. symbolstore.py needs to locate the pdb file both to
determine whether it should dump symbols for a binary and also to copy
the pdb file into the symbol package. We fix this by simply looking for
the pdb file in the current working directory if it isn't present next
to the binary, which matches how we invoke symbolstore.py.
MozReview-Commit-ID: 8TOD1uTXD5e
This cleans up the way the crash reporter client invokes the minidump analyzer
by removing the extra command-line parameter and replacing it with an
environment variable. Since I was at it I've also cleaned up other uses of env
variables in the code and added documentation for all of them.
MozReview-Commit-ID: ATkgsI3L2Md
--HG--
extra : source : 05a762d6cb5e5fd9856743b4db38287d7c58a487
We want to send information about the organization whose cert was used to sign
modules in our address space. Originally I had written this code to accumulate
that info within Firefox, but I realized that a better option is to do this
from the minidump analyzer:
(1) This way does not affect browser performance;
(2) This way allows us to properly gather cert info even from startup crashes.
This functionality was reviewed for data collection via bug 1430857.
I have already implemented code to check binary signatures in mozglue so that
we can do so from both firefox.exe and xul.dll.
Rather than including yet another implementation elsewhere, I'd rather just
reuse that code by building minidump-analyzer as a GeckoProgram with Null
XPCOM linkage, thus making it capable of using the mozglue implementation too.
I'd also like to add this signature stuff to Mac builds at some point, so I'm
trying to make this functionality as easy as possible to expand and reuse in the
future.
James Willcox
Tiberius Oros
Kris Maglione
Ted Mielczarek
Narcis Beleuzu
Haik Aftandilian
Dorel Luca
Sebastian Hengst
Tom Ritter
shindli
Tristan Bourvon
William Lachance
Henri Sivonen
Carl Corcoran
Cosmin Sabou
Tooru Fujisawa
Sylvestre Ledru
Coroiu Cristina
Aaron Klotz
Gabriele Svelto
Florian Quèze
Mark Banner
Adrian Wielgosik
Jeff Walden
Gurzau Raul
Thomas Wisniewski