Marco Bonardo
015111e434
Bug 1687397 - Don't flash the microphone/camera icon during WebRTC in the identity panel. r=dao
...
Differential Revision: https://phabricator.services.mozilla.com/D105282
2021-02-17 08:56:00 +00:00
Valentin Gosu
dbc436b39f
Bug 1675540 - Perform URL sanity checks when changing it r=necko-reviewers,kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D104541
2021-02-17 08:54:03 +00:00
Akshat
410a4c846a
Bug 1692974 - doc(mozlint): Add documentation for counting fixed issues r=sylvestre DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D105271
2021-02-17 08:49:12 +00:00
Henrik Skupin
c1aa949ca0
Bug 1693021 - [puppeteer] Add --enable-webrender argument to mach command. r=remote-protocol-reviewers,jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D105361
2021-02-17 08:48:57 +00:00
Valentin Gosu
1eabd8106b
Bug 1692862 - Null out mSession pointer when closing Http2Stream r=dragana,necko-reviewers
...
The Http2Stream holds a raw pointer to the Http2Session which gets initialized in the constructor and is never changed.
We should null out the member so we don't attempt to use it after it has been destroyed.
Differential Revision: https://phabricator.services.mozilla.com/D105188
2021-02-17 08:00:53 +00:00
Tom Tung
9b0647633f
Bug 1665942 - Collect userContextId from tab in _collectBaseTabData and stop collecting it in the session history collection; r=nika,geckoview-reviewers,agi
...
### Story
When a COOP+COEP page is opened, we change the remoteness of the tab. After
changing the remoteness, the tab is then restored by its TabState. However,
we haven't collected userContextId through the current mechanism.
To fix that, this patch changes the way to collect userContextId.
### Test Plan
Test: D98296
Depends on D98296
Differential Revision: https://phabricator.services.mozilla.com/D98468
2021-02-17 07:45:13 +00:00
Tom Tung
77da8b6452
Bug 1683713 - Ensure the restoring tab is not reused in addMultipleTabs; r=dao
...
Differential Revision: https://phabricator.services.mozilla.com/D100249
2021-02-17 07:45:12 +00:00
Csoregi Natalia
30ee58f188
Backed out changeset 11b157c81a3a (bug 1693241) for causing cpp bustage on RenderTextureHostSWGL.cpp. CLOSED TREE
2021-02-17 09:49:50 +02:00
sotaro
e14e72e339
Bug 1693241 - Add gfxCriticalNote to RenderTextureHostSWGL::LockSWGLCompositeSurface() r=mattwoodrow
...
It helps to understand Bug 1693208 .
Differential Revision: https://phabricator.services.mozilla.com/D105418
2021-02-17 06:47:26 +00:00
Punam Dahiya
ad41a3d038
Bug 1688802 - Remove focus from the address bar in about:welcome r=dao,k88hudson
...
Differential Revision: https://phabricator.services.mozilla.com/D103004
2021-02-17 06:25:09 +00:00
Adam Gashlin
d504494eab
Bug 1687562 - Part 2: Detect whether Firefox is pinned to the taskbar. r=mhowell
...
Differential Revision: https://phabricator.services.mozilla.com/D105365
2021-02-17 05:10:53 +00:00
Adam Gashlin
1d35ccd566
Bug 1687562 - Part 1: Implement Taskbar pinning. r=mhowell
...
Differential Revision: https://phabricator.services.mozilla.com/D104779
2021-02-17 05:10:53 +00:00
longsonr
826df957d6
Bug 1633038 - change selectSubString reftests to wait for MozReftestInvalidate r=dholbert
...
Differential Revision: https://phabricator.services.mozilla.com/D105240
2021-02-17 03:52:30 +00:00
Andreea Pavel
64289058b6
Backed out 5 changesets (bug 1690167) for failing xpcshell at bootstrapSvc.js on a CLOSED TREE
...
Backed out changeset d28c0f11743f (bug 1690167)
Backed out changeset 3b2bebed9128 (bug 1690167)
Backed out changeset 7e925e90a251 (bug 1690167)
Backed out changeset f85934a2b7ad (bug 1690167)
Backed out changeset 6d83474e81bb (bug 1690167)
2021-02-17 07:10:58 +02:00
Boris Chiou
d9de5c2358
Bug 1690422 - Resolve {min|max}-content contribution with the preferred aspect ratio and the definite block size. r=TYLin
...
This is simliar with the previous patch, but we use
min-content/max-content for the inner div (i.e. child frame).
Perhaps we could remove the simliar implementation from
ComputeISizeValue(). However, I still keep it because it can avoid some
extra work when resolving {min|max}-content with aspect-ratio when
reflowing.
Differential Revision: https://phabricator.services.mozilla.com/D104476
2021-02-17 02:41:24 +00:00
Boris Chiou
181e91cf22
Bug 1690422 - Take box-sizing into account when computing the intrinsic size with the preferred aspect ratio. r=TYLin,mats
...
We resolve the auto value in IntrinsicForAxis by the ratio determining size
and the preferred aspect ratio. However, this should take
box-sizing into account when using aspect-ratio property.
Differential Revision: https://phabricator.services.mozilla.com/D104293
2021-02-17 02:41:24 +00:00
Markus Stange
3c57a55638
Bug 1693196 - Remove -moz-mac-fullscreen-button value. r=emilio
...
Depends on D105379
Differential Revision: https://phabricator.services.mozilla.com/D105380
2021-02-17 01:40:04 +00:00
Markus Stange
da91221773
Bug 1693196 - Remove use of -moz-default-appearance: -moz-mac-fullscreen-button. r=emilio
...
This element is always 0x0 and macOS widget code no longer needs to know its position.
Depends on D105378
Differential Revision: https://phabricator.services.mozilla.com/D105379
2021-02-17 01:40:04 +00:00
Markus Stange
67c18889ba
Bug 1693196 - Remove code for setting the full screen button's position. Starting with macOS 10.10, there is no full screen button anymore. r=mac-reviewers,bradwerth
...
Differential Revision: https://phabricator.services.mozilla.com/D105378
2021-02-17 01:40:03 +00:00
Mike Hommey
b6d915dd07
Bug 1692383 - Upgrade python-zstandard to 0.15.1. r=firefox-build-system-reviewers,mhentges
...
As far as I can tell, we don't use zstandard from python2. As the last
version supporting python2 is 0.14.1, drop installing the python2
version.
Differential Revision: https://phabricator.services.mozilla.com/D105075
2021-02-17 00:53:38 +00:00
Julian Descottes
2b6f6c8116
Bug 1659129 - [devtools] Show a visual cue in the URL bar when DevTools has an opened socked r=ochameau,nchevobbe,freddyb
...
Differential Revision: https://phabricator.services.mozilla.com/D103776
2021-02-17 00:44:58 +00:00
Emilio Cobos Álvarez
a88b69fbe7
Bug 1684798 - Ensure fieldset in test_focus_scrollable_fieldset.html is scrollable even if window is very wide.
...
For some reason some of the verify things open a big window and causes
everything to fit and not be scrollable.
Differential Revision: https://phabricator.services.mozilla.com/D105388
2021-02-17 00:36:42 +00:00
Emilio Cobos Álvarez
306af38824
No bug - remove useless semicolon that causes a rust nightly warning. DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D105387
2021-02-17 00:30:52 +00:00
Emilio Cobos Álvarez
c0d75d9d0e
Bug 1690836 - Reduce the amount of code generated by UnparsedValues::substitute_variables. r=boris
...
This reduces the amount of assembly instructions generated by this
function from 18k+ to ~800.
This should make reasoning about its stack space usage sane, and should
fix the ASAN stack overflows, but also we should take this regardless,
because it's saner and makes reading it simpler.
I also think that the writing_mode shenanigans is fixing a bug (I think
before this, we'd pick the first physical value which mapped to any of
the properties, which is wrong), but I haven't bothered looking for a
test-case that fails before my patch. The relevant WPTs
(css/css-logical/animation*) still pass.
Differential Revision: https://phabricator.services.mozilla.com/D105342
2021-02-17 00:21:36 +00:00
Emilio Cobos Álvarez
109f0ef782
Bug 1690836 - Cache substituted values from shorthand properties during the cascade. r=xidorn
...
This brings the time down to 1.6ms from 4.8ms on the test-case in the
bug. This should be improvable too, but I think this is a nice
improvement for regular styling as well.
Differential Revision: https://phabricator.services.mozilla.com/D105187
2021-02-17 00:21:36 +00:00
Emilio Cobos Álvarez
db9bf3dfcc
Bug 1690836 - Rustfmt cascade.rs. r=xidorn
...
Differential Revision: https://phabricator.services.mozilla.com/D105186
2021-02-17 00:21:35 +00:00
alwu
6f21141c39
Bug 1690372 - part2 : add Telemetry probe for WMF usage. r=bryce
...
Depends on D103836
Differential Revision: https://phabricator.services.mozilla.com/D103837
2021-02-16 23:53:45 +00:00
alwu
8cdda9e6f3
Bug 1690372 - part1 : always use `WMFDecoderModule::Create()` to get a new decoder module. r=bryce
...
Differential Revision: https://phabricator.services.mozilla.com/D103836
2021-02-16 23:53:45 +00:00
Matthew Gregan
e7c3c62dc1
Bug 1693186 - Update cubeb to 9beb8ed0. r=cubeb-reviewers,chunmin
...
Differential Revision: https://phabricator.services.mozilla.com/D105374
2021-02-16 23:15:47 +00:00
Markus Stange
8f2e19e4c5
Bug 1692401 - Add a NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK macro which actually aborts. r=haik
...
Differential Revision: https://phabricator.services.mozilla.com/D104962
2021-02-16 22:55:22 +00:00
Markus Stange
355baf5b39
Bug 1692391 - Rename NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK macros, replacing ABORT with IGNORE. These macros just log the exception and move on, without aborting. r=haik
...
This patch was generated automatically, using the following commands:
```
rg -l 'NS_OBJC_BEGIN_TRY_ABORT_BLOCK' . | xargs sed -i '' -e 's/NS_OBJC_BEGIN_TRY_ABORT_BLOCK/NS_OBJC_BEGIN_TRY_IGNORE_BLOCK/g'
rg -l 'NS_OBJC_END_TRY_ABORT_BLOCK' . | xargs sed -i '' -e 's/NS_OBJC_END_TRY_ABORT_BLOCK/NS_OBJC_END_TRY_IGNORE_BLOCK/g'
```
Differential Revision: https://phabricator.services.mozilla.com/D104960
2021-02-16 22:55:21 +00:00
Markus Stange
9bc888af4a
Bug 1692391 - Replace NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK_NIL with the functionally identical NS_OBJC_BEGIN/END_TRY_BLOCK_RETURN(nil). r=haik
...
This patch was generated automatically, using the following commands:
```
rg -l 'NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NIL' . | xargs sed -i '' -e 's/NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NIL/NS_OBJC_BEGIN_TRY_BLOCK_RETURN/g'
rg -l 'NS_OBJC_END_TRY_ABORT_BLOCK_NIL' . | xargs sed -i '' -e 's/NS_OBJC_END_TRY_ABORT_BLOCK_NIL/NS_OBJC_END_TRY_BLOCK_RETURN(nil)/g'
```
Differential Revision: https://phabricator.services.mozilla.com/D104959
2021-02-16 22:55:21 +00:00
Markus Stange
c08d2df99d
Bug 1692391 - Replace NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK_NSNULL with the functionally identical NS_OBJC_BEGIN/END_TRY_BLOCK_RETURN(nullptr). r=haik
...
```
rg -l 'NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NSNULL' . | xargs sed -i '' -e 's/NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NSNULL/NS_OBJC_BEGIN_TRY_BLOCK_RETURN/g'
rg -l 'NS_OBJC_END_TRY_ABORT_BLOCK_NSNULL' . | xargs sed -i '' -e 's/NS_OBJC_END_TRY_ABORT_BLOCK_NSNULL/NS_OBJC_END_TRY_BLOCK_RETURN(nullptr)/g'
```
Differential Revision: https://phabricator.services.mozilla.com/D104958
2021-02-16 22:55:21 +00:00
Markus Stange
56051da2d0
Bug 1692391 - Replace the NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK_NSRESULT macros with the functionally identical NS_OBJC_BEGIN/END_TRY_BLOCK_RETURN(NS_ERROR_FAILURE). r=haik
...
This patch was generated with the commands:
```
rg -l 'NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NSRESULT' . | xargs sed -i '' -e 's/NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NSRESULT/NS_OBJC_BEGIN_TRY_BLOCK_RETURN/g'
rg -l 'NS_OBJC_END_TRY_ABORT_BLOCK_NSRESULT' . | xargs sed -i '' -e 's/NS_OBJC_END_TRY_ABORT_BLOCK_NSRESULT/NS_OBJC_END_TRY_BLOCK_RETURN(NS_ERROR_FAILURE)/g'
```
Differential Revision: https://phabricator.services.mozilla.com/D104957
2021-02-16 22:55:20 +00:00
Markus Stange
5257db6695
Bug 1692391 - Remove the word ABORT from the NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK_RETURN macros, because these macros don't abort. r=haik,necko-reviewers
...
This patch was generated automatically with the commands below:
```
rg -l 'NS_OBJC_BEGIN_TRY_ABORT_BLOCK_RETURN' . | xargs sed -i '' -e 's/NS_OBJC_BEGIN_TRY_ABORT_BLOCK_RETURN/NS_OBJC_BEGIN_TRY_BLOCK_RETURN/g'
rg -l 'NS_OBJC_END_TRY_ABORT_BLOCK_RETURN' . | xargs sed -i '' -e 's/NS_OBJC_END_TRY_ABORT_BLOCK_RETURN/NS_OBJC_END_TRY_BLOCK_RETURN/g'
```
Differential Revision: https://phabricator.services.mozilla.com/D104955
2021-02-16 22:55:20 +00:00
Markus Stange
fd5389943b
Bug 1692391 - Remove NS_OBJC_TRY_EXPR_ABORT macro and replace its use with the block version of the macro. r=haik
...
This macro was quite misguided, too. If evaluating _e raised an exception, then
the expression value of the block would be an uninitialized value. Super unsafe.
It's a good thing that we don't expect "retain" to ever throw.
Differential Revision: https://phabricator.services.mozilla.com/D104954
2021-02-16 22:55:19 +00:00
Markus Stange
173c610fda
Bug 1692391 - Remove NS_OBJC_TRY_ABORT macro and replace its uses with the block version of the macro. r=haik
...
Differential Revision: https://phabricator.services.mozilla.com/D104953
2021-02-16 22:55:19 +00:00
Markus Stange
7ae49906c4
Bug 1692391 - Remove some unused macros from nsObjCExceptions.h. r=haik
...
Differential Revision: https://phabricator.services.mozilla.com/D104952
2021-02-16 22:55:19 +00:00
Markus Stange
6b2cc7685c
Bug 1692391 - Clean up nsObjCExceptions.h a little bit, and use -[NSException callStackSymbols] instead of manual symbolication. r=haik
...
Differential Revision: https://phabricator.services.mozilla.com/D104951
2021-02-16 22:55:18 +00:00
Jed Davis
e0852b35ab
Bug 1692631 - Fix the profiler marker for IPC message reception on Windows. r=gerald
...
This point in the code is the end of receiving a message, not the start
(note the `if (partial) { break; }` above), so it should be marked
accordingly. The profiler frontend is expecting the end marker;
currently two of the four reported time intervals are `unknown` on
Windows, and this patch fixes that.
(Recording the receiving start time is complicated, because we don't
have a `Messsage` object until we've read the buffer with the (end of
the) header, and it might make more sense to timestamp it before the
first receive operation. Currently, neither channel implementation
attempts this.)
Differential Revision: https://phabricator.services.mozilla.com/D105094
2021-02-16 22:51:30 +00:00
Jed Davis
a2ac4377ec
Bug 1692631 - Add only one sending start profiler marker per message on Windows. r=gerald
...
Currently, we add an `eSending`/`TransferStart` marker every time we
send data as part of a message, rather than only the first time. The
profiler frontend appears to ignore the extra markers (the displayed time
intervals look reasonable), but it's wasteful: on large messages it can
consume enough CPU time to appear in the profile itself.
Differential Revision: https://phabricator.services.mozilla.com/D105093
2021-02-16 22:51:29 +00:00
Jed Davis
9f4a859e20
Bug 1692629 - Add profiler idleness annotations for IPC I/O thread on Windows. r=mstange
...
Differential Revision: https://phabricator.services.mozilla.com/D105092
2021-02-16 22:51:29 +00:00
Gregory Mierzwinski
57fa6fcce0
Bug 1693042 - Decrease default timeout for talos tests to 10 minutes. r=jmaher
...
This patch decreases the default timeout to 10 minutes (from 2 hours) and also fixes an issue in mozcrash.
Differential Revision: https://phabricator.services.mozilla.com/D105356
2021-02-16 22:45:48 +00:00
Gabriel Luong
dd9a6ddc00
Bug 1690340 - Part 5: Remove the menu separators from the developer tools menu. r=jdescottes
...
This removes the menu separators frmo the developer tools menu to conform to
the proton design.
We can safely remove the "devToolsEndSeparator" separator since it is no longer
used to append the "Work Offline" that is removed in Part 4.
We change the anchor element to be the "menu_devtools_remotedebugging" menu item
with the removal oof the "menu_devtools_separator" separator.
Differential Revision: https://phabricator.services.mozilla.com/D104904
2021-02-16 22:37:24 +00:00
Gabriel Luong
23021a139b
Bug 1690340 - Part 4: Insert the "Page Source" before the "Extensions for Developers" menu item. r=mconley,jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D104871
2021-02-16 22:37:23 +00:00
Gabriel Luong
5238d1af94
Bug 1690340 - Part 3: Remove the "Work Offline" menu item from the developer tools menu. r=mconley,jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D104870
2021-02-16 22:37:23 +00:00
Gabriel Luong
21979dc0fa
Bug 1690340 - Part 2: Use the new naming for the developer tools menu items. r=jdescottes
...
- Renames "Toggle Tools" to "Web Developer Tools"
- Renames "Get More Tools" to "Extensions for Developers"
Differential Revision: https://phabricator.services.mozilla.com/D104869
2021-02-16 22:37:23 +00:00
Gabriel Luong
1c278ebe57
Bug 1690340 - Part 1: Hide all the panel tools in the developer tools menu. r=jdescottes
...
For now, we hide all the individual panel tools from the developer tools menu.
We will want to evaluate whether or not to remove all the logic for adding all
the tools to the menu in the future if we see a permanent need for no longer
having it.
See https://searchfox.org/mozilla-central/rev/d3343662ce0aced933b30e053b33c93f759292eb/devtools/client/framework/browser-menus.js#197
Differential Revision: https://phabricator.services.mozilla.com/D104868
2021-02-16 22:37:22 +00:00
sotaro
0dc5ddff34
Bug 1691895 - Make RenderCompositorSWGL work on android r=geckoview-reviewers,mattwoodrow,agi
...
Partial present is not supported yet with RenderCompositorSWGL on Android.
Differential Revision: https://phabricator.services.mozilla.com/D104654
2021-02-16 22:30:47 +00:00
Dale Harvey
d928b9d17c
Bug 1689263 - Extend REGION_LOCATION_SERVICES_DIFFERENCE expiration until v92 r=chutten
...
Differential Revision: https://phabricator.services.mozilla.com/D104544
2021-02-16 22:19:23 +00:00