060d72b1fb
Bug 1733876 Part 3 - Consolidate logic dealing with and without aLineBreaker in FindWrapIndexForContent(). r=m_kato
...
This patch only moves logic, and shouldn't change the behavior.
Differential Revision: https://phabricator.services.mozilla.com/D127383
2021-10-07 17:10:14 +00:00
6993f02a9e
Bug 1733876 Part 2 - Run line wrapping algorithm only if content of current line is not empty. r=m_kato,mbrodesser
...
With this edge case explicitly considered, it will be easier for the
following patches to simplify logic in `FindWrapIndexForContent()`.
Differential Revision: https://phabricator.services.mozilla.com/D127382
2021-10-07 17:10:14 +00:00
431bd8d5d2
Bug 1733876 Part 1 - Remove unused kNoFlags in nsPlainTextSerializer.cpp. r=mbrodesser
...
Differential Revision: https://phabricator.services.mozilla.com/D127381
2021-10-07 17:10:14 +00:00
cc82c1d2e8
Bug 1734447 - Record in telemetry environment the user's choice in the Firefox Suggest online opt-in onboarding dialog/modal. r=chutten,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D127700
2021-10-07 17:02:08 +00:00
61c28d385f
Bug 1733687 - Store in a pref the user's response to the Firefox Suggest onboarding dialog and add two new telemetry event objects. r=dao,mythmon
...
This does a couple of things:
* Instead of using the `not_now` telemetry event object for the cases where the
dialog is closed by the Escape key or some other atypical way, reserve
`not_now` -- renamed `not_now_link` -- specifically for clicks on the "Not
now" link and add two new objects: `dismissed_escape_key` and
`dismissed_other`. That should give us a little better understanding of how
the dialog is being dismissed. The new `not_now_link` name is to avoid
conflation with the previous meaning of `not_now`.
* Add a new `browser.urlbar.quicksuggest.onboardingDialogChoice` pref that
stores exactly the same values as the telemetry event. e.g., if the dialog is
accepted, then we'll record a telemetry event whose object is `accept` and
we'll also store `accept` in the pref.
I figure if we decide to show the onboarding again for people who have already
seen it, (1) we'll use this pref to decide the flow for any given user, and (2)
we'll need to add another pref for the user's response to the "v2" dialog, or
maybe we could morph this one into an array of responses or something more
complex like that.
Differential Revision: https://phabricator.services.mozilla.com/D127354
2021-10-07 17:02:07 +00:00
15e2dd7a4e
Bug 1733384 - Allow explicitly-inert modal dialog to be inert. r=sefeng
...
This matches the consensus from the CSSWG call.
Differential Revision: https://phabricator.services.mozilla.com/D127423
2021-10-07 17:00:36 +00:00
9fbc18ca4c
Bug 1733384 - Make inert not modify the computed style. r=sefeng,layout-reviewers,jfkthame
...
Differential Revision: https://phabricator.services.mozilla.com/D127422
2021-10-07 17:00:36 +00:00
9dd0c68d5c
Bug 1714234 - Enable the dimension checks for visible-page screenshots in browser_screenshots_dimensions.js. r=sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D127573
2021-10-07 16:58:02 +00:00
e438bb47ac
Bug 1734460 - Make these profiler docs refer to the Upload button (which no longer says Publish) correctly. r=canaltinova
...
Differential Revision: https://phabricator.services.mozilla.com/D127699
2021-10-07 16:48:52 +00:00
ba1e989261
Backed out changeset bbea0c20d7fe (bug 1732724) for causing Xpcshell failures at test_targeting.js. CLOSED TREE
2021-10-07 19:29:34 +03:00
e8ced8b530
Bug 1717711 - Enable EV Treatment for HARICA's 2015 and 2021 root certificates r=rmf,keeler
...
Differential Revision: https://phabricator.services.mozilla.com/D127167
2021-10-07 16:22:49 +00:00
12f85654aa
Bug 1711120 - Fix test_ext_startup_cache intermittent failures on windows builds. r=mixedpuppy
...
Differential Revision: https://phabricator.services.mozilla.com/D127685
2021-10-07 16:09:38 +00:00
e0f2880ec7
Bug 1708718 - mach vendor rust. r=cubeb-reviewers,padenot
...
Depends on D127832
Differential Revision: https://phabricator.services.mozilla.com/D127833
2021-10-07 16:01:51 +00:00
eb155369ac
Bug 1708718 - Update cubeb-coreaudio to 5ada876. r=cubeb-reviewers,padenot
...
Differential Revision: https://phabricator.services.mozilla.com/D127832
2021-10-07 16:01:51 +00:00
66cb934308
Bug 1690483 - Use saturating add for mask of SIMD swizzle. r=lth
...
Differential Revision: https://phabricator.services.mozilla.com/D127746
2021-10-07 15:55:35 +00:00
a76e403529
Bug 1678373 - Remove mAudibleState. r=alwu
...
Differential Revision: https://phabricator.services.mozilla.com/D127559
2021-10-07 15:44:59 +00:00
c3e0d55a5d
Bug 1678373 - Don't count muted time without an audio track, but start counting time as soon as an audio track is added. r=alwu
...
Differential Revision: https://phabricator.services.mozilla.com/D126912
2021-10-07 15:44:58 +00:00
16b65bd57d
Bug 1678373 - Adjust media telemetry attributes. r=alwu
...
2h is a bit short for video.
Percentage need to be linear and between 0 and 100. 50 buckets are good enough,
having 100 buckets doesn't work, it needs to be lower than the `high` value.
Differential Revision: https://phabricator.services.mozilla.com/D125846
2021-10-07 15:44:58 +00:00
13eff79a3a
Bug 1678373 - Count muted time correct when seeking while muted. r=alwu
...
The counter was paused, but `mIsMuted` was getting desynchronized. It's best to
reset the media element muted state, visibility and media content when paused,
they are set again properly in ::Play, preventing any issue.
It is necessary to reset the media content after reporting telemetry, because a
media content of MEDIA_HAS_NOTHING isn't reported.
Differential Revision: https://phabricator.services.mozilla.com/D125845
2021-10-07 15:44:58 +00:00
ecc424b1c5
Bug 1678373 - Update description for media playback telemetry probes. r=alwu
...
Differential Revision: https://phabricator.services.mozilla.com/D125695
2021-10-07 15:44:57 +00:00
dc9fb0994e
Bug 1678373 - Add telemetry probes for audible and muted media. r=alwu data-review=chutten
...
Differential Revision: https://phabricator.services.mozilla.com/D125694
2021-10-07 15:44:57 +00:00
6a8e954392
Bug 1678373 - Add a testcase for MEDIA_PLAY_TIME_MS. r=alwu
...
Differential Revision: https://phabricator.services.mozilla.com/D125693
2021-10-07 15:44:56 +00:00
4fc40231a3
Bug 1678373 - Prepare tests for test-cases without video. r=alwu
...
Differential Revision: https://phabricator.services.mozilla.com/D125692
2021-10-07 15:44:56 +00:00
7ca1f38445
Bug 1678373 - Fix displaying the media element by using display: block. r=alwu
...
Differential Revision: https://phabricator.services.mozilla.com/D125691
2021-10-07 15:44:56 +00:00
b422324e29
Bug 1678373 - Put the new and old value in the assert to diagnose failures better. r=alwu
...
Differential Revision: https://phabricator.services.mozilla.com/D125690
2021-10-07 15:44:55 +00:00
2e756eee23
Bug 1678373 - Add tests for muted and audible audio. r=alwu
...
Differential Revision: https://phabricator.services.mozilla.com/D125689
2021-10-07 15:44:55 +00:00
410e29319c
Bug 1678373 - Add a telemetry probe for understanding how media content with audio content is played back. r=alwu data-review=chutten
...
Differential Revision: https://phabricator.services.mozilla.com/D125089
2021-10-07 15:44:54 +00:00
82125c0639
Bug 1678373 - Add a way to measure the duration a media was muted. r=alwu,webidl,emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D125088
2021-10-07 15:44:54 +00:00
ef0bfbff05
Bug 1678373 - Fix a typo in the accumulator names. r=alwu
...
Differential Revision: https://phabricator.services.mozilla.com/D125087
2021-10-07 15:44:54 +00:00
6dc847cdf6
Bug 1678373 - Expose audio telemetry counters as chrome-only attributes like their video counterparts. r=alwu,webidl,emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D125084
2021-10-07 15:44:53 +00:00
94b7678216
Bug 1678373 - Rename chrome-only telemetry counter attributes to distinguish audio and video. r=alwu,webidl,emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D125083
2021-10-07 15:44:53 +00:00
521f23c69b
Bug 1678373 - Make the test more robust, and check constant/increasing accumulators a bit more. r=alwu
...
This was failing locally sometimes. Resolving a Promise is not very
deterministic: it can take some time, or be almost instantaneous. It's simpler
to block the main thread for a time duration longer than the clock resolution of
the OS. Generally, the worst clock resolution is on Windows, it's by default
16ms, and resolving a Promise is often a lot faster than 16ms, so we could have
had the same value here, but the code was correct. The reason that it passed was
because of this code. This is currently changing a lot in Windows, but 30ms is a
good middle ground I thought. The clock resolution on macOS/Linux
desktop/Android/anything else such as BSDs is a lot better than 16ms (in the
microsecond/nanosecond range depending on the kernel), so we're good there.
Differential Revision: https://phabricator.services.mozilla.com/D125082
2021-10-07 15:44:53 +00:00
5b350b7fc5
Bug 1678373 - The test was failing because the video ended early. r=alwu
...
Differential Revision: https://phabricator.services.mozilla.com/D125081
2021-10-07 15:44:52 +00:00
575630f8df
Bug 1678373 - Don't detach the media element from the tree for checking play time probes: it pauses the media element per spec. r=alwu
...
Differential Revision: https://phabricator.services.mozilla.com/D125080
2021-10-07 15:44:52 +00:00
16baeacc14
Bug 1678373 - Add initial accumulator for audio. r=alwu
...
Differential Revision: https://phabricator.services.mozilla.com/D125079
2021-10-07 15:44:51 +00:00
d7ef88efff
Bug 1678373 - Add a way to specify the type of content (audio/video/both) in the TelemetryProbesReporter, change a bit visibility event handling. r=alwu
...
Differential Revision: https://phabricator.services.mozilla.com/D125078
2021-10-07 15:44:51 +00:00
26de5c39a8
Bug 1678373 - Move the call to report that media telemetry has been reported. r=alwu
...
Needed for report audio telemetry in a later patch.
Differential Revision: https://phabricator.services.mozilla.com/D125077
2021-10-07 15:44:51 +00:00
1f3a23567c
Bug 1678373 - Only call into the telemetry state change code when the state changes. r=alwu
...
Differential Revision: https://phabricator.services.mozilla.com/D125076
2021-10-07 15:44:50 +00:00
b934a76011
Bug 1678373 - Rename mTotalPlayTime and friends to mention it's about video. r=alwu
...
Differential Revision: https://phabricator.services.mozilla.com/D125075
2021-10-07 15:44:50 +00:00
bcd31bdb9b
Bug 1734511 - Remove unused TiledRegion. r=mstange
...
Differential Revision: https://phabricator.services.mozilla.com/D127754
2021-10-07 15:40:22 +00:00
f00d159f71
Bug 1730194 - Prevent Copy button to send information to Cloud Clipboard and Clipboard History on Windows r=dimi,johannh,cmartin
...
Differential Revision: https://phabricator.services.mozilla.com/D125831
2021-10-07 15:32:03 +00:00
d9c4a57805
Bug 1732724 - Report targeting expression source in the case of undesired events r=k88hudson
...
Differential Revision: https://phabricator.services.mozilla.com/D126776
2021-10-07 15:31:29 +00:00
a8e12d1f3f
Bug 1734622 - set ElementInternals tests for attribute form/label to pass on release and beta. r=edgar DONTBUILD
...
These got added in bug 1556362 and bug 1556373.
Differential Revision: https://phabricator.services.mozilla.com/D127830
2021-10-07 15:27:21 +00:00
da04cbec60
Bug 1734506 - Remove Layer. r=gfx-reviewers,aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D127753
2021-10-07 15:24:07 +00:00
a1bb3108bb
Bug 1733950 - Update vendored copies of 'taskcluster', 'taskcluster_urls' and 'slugid', r=aki
...
I'd like to vendor the 'taskcluster-taskgraph' pacakge, but it requires slugid
>= 2.0. In order to update that we also need to update 'taskcluster' and
'taskcluster_urls' as the currently vendored versions don't work with
'slugid>=2.0' (due to slugid returning str rather than bytes here).
Version changes are:
* taskcluster 6.0.0 -> 44.2.2
* taskcluster_urls 11.0.0 -> 13.0.1
* slugid 1.0.7 -> 2.0.0
Differential Revision: https://phabricator.services.mozilla.com/D127680
2021-10-07 15:22:54 +00:00
8c4f4eeecc
Bug 1627379 - disable test_unregister_invalid_json.js on Win_QR for frequent failures. r=intermittent-reviewers,MasterWayZ DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D127791
2021-10-07 15:21:17 +00:00
11406813c8
Bug 1734502 - Remove unused ContainerLayer. r=gfx-reviewers,mstange
...
Differential Revision: https://phabricator.services.mozilla.com/D127751
2021-10-07 15:19:25 +00:00
e67c38d728
Bug 1734523 - Remove the use of MozbuildObject.mozconfig in mozwebidlcodegen. r=firefox-build-system-reviewers,mhentges
...
Differential Revision: https://phabricator.services.mozilla.com/D127765
2021-10-07 15:19:03 +00:00
a8ca7acd1e
Bug 1726270 - disable browser_target_command_service_workers_navigation.js on Linux_64_opt and Win_64 for frequent failures. r=intermittent-reviewers,MasterWayZ DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D127799
2021-10-07 15:13:18 +00:00
ef6201cb3e
Bug 1698522: Process name setting cleanup r=nika,dveditz
...
Differential Revision: https://phabricator.services.mozilla.com/D108446
2021-10-07 14:57:10 +00:00
Ting-Yu Lin
Drew Willcoxon
Emilio Cobos Álvarez
Niklas Baumgardner
Markus Stange
Butkovits Atila
John M. Schanck
Luca Greco
Chun-Min Chang
Yury Delendik
Paul Adenot
Jeff Muizelaar
Sergey Galich
Andrei Oprea
Sebastian Hengst
Andrew Halberstadt
Mike Hommey
Randell Jesup