Currently there are a number of global fields in JSRuntime* which are basically
tracking per-thread state. This makes sense on the current trunk since there
is only ever a single thread associated with a runtime, but as Parallel JS (nee
Rivertrail) starts to land this assumption no longer holds.
This patch makes a struct, currently called |JS::PerThreadData|, that stores
per-thread data from the runtime. There is one instance of this struct
embedded in "Runtime" itself (the field |mainThread|). For now I have only
migrated the debug GC fields into |PerThread|, those are the ones causing me
immediate pain. Eventually more fields will want to move into there.
The eventual goal is to distinguish thread-safe code, which will take as
argument a |JS::PerThread*|, from non-thread-safe code, which will take a
|JSRuntime*| or |JSContext*|.
This is a pretty dumb bug, but we never actually hit this codepath at the moment.
We currently end up in wrapper by either explicitly calling
ReparentWrappedNativeIfFound (in nsNodeUtils and in nsHTMLDocument), or by moving
existing wrappers during orphan fixup. The former always passes a wrapper-cached
object, and the latter guarantees that we always have a wrapper. So we'd never
hit the "no wrapper cache, no wrapper" case in the current code.
We now return the status code from executed processes. The API to
require a successful status code has been changed from ignore_errors to
ensure_exit_code. The build mach command no longer spews a stack trace
if make fails.
DONTBUILD (NPOTB)
All mach modules are now explicitly listed in the mach driver.
--HG--
rename : python/mozbuild/mach/commands/build.py => python/mozbuild/mozbuild/mach_commands.py
Previously we were tighly coupled with MozbuildObject. This was not in
the spirit of mach being a generic tool. Now, instead of passing multiple
arguments to __init__ of the class providing the mach command we either
pass 0 or 1. The number of arguments is detected when processing the
@CommandProvider decorator. The optional argument is a named tuple
containing mach run-time state.
Capturing of mach command provider information is now captured in a
class (as opposed to an anoymous tuple). We also capture these in a rich
data structure which is passed as part of the run-time data to the
command provider class. This allows mach commands to inspect the mach
environment.
Mach decorators have been moved to mach.decorators. mach.base is
reserved for generic mach data/container classes.
Existing mach command classes derived from MozbuildObject have been
replaced with either object or mozbuild.base.MachCommandBase. This
latter class translates the mach context instance passed to __init__
into the constructor arguments for MozbuildObject.__init__.
Support for registering function handlers with mach has been removed.
All handlers must be inside classes.
--HG--
rename : python/mach/mach/base.py => python/mach/mach/decorators.py
Clear the sDiscardableImages linked list in DiscardTracker::Shutdown() so that the list destructor finds an empty array, which is required after bug 803688.
Matt Woodrow
Dave Hylands
Martijn Wargers
Karl Tomlinson
Wes Johnston
Mike Habicher
Nicholas D. Matsakis
Steven Lee
Ryan VanderMeulen
Bobby Holley
Nicholas Nethercote
Ehsan Akhgari
Gregory Szorc
Mark Hammond
Felipe Gomes
Richard Newman
Doug Turner
Shane Caraveo
Olli Pettay
Eric Chou
Jonathan Griffin
Ed Morley
Lucas Rocha
Jim Mathies
Robert O'Callahan
aceman
Patrick McManus
Ms2ger