The default styles of richlistbox autocomplete were originally created to support the location bar popup, but now every autocomplete field uses the richlistbox version. This reworks the styles so that the number of overrides is minimized.
MozReview-Commit-ID: BwagKpMR5Dt
--HG--
extra : rebase_source : 52eda7f9d561dd23f279a3d15659e84f6c46eec6
Disk corruption can lead to the stored length of a value to be
unreasonably large and trigger an OOM.
Since values are all currently <= 32 bytes, we can safely enforce
a 256-byte upper bound.
MozReview-Commit-ID: XygReOpEK3
--HG--
extra : rebase_source : cd2bc880d43612b04d43fb4132bba32bdc3d0f3e
While we could not cut the order of the inputs over directly to the AddToHash methods
(because AddToHash(string) does not exist) - we could rearrange them and then not need
to build a temporary string.
MozReview-Commit-ID: 6At4MQ0KotE
--HG--
extra : rebase_source : d768a38a726e4f459175d2f62e7f60ba4c1c54ef
The autocomplete module listens to keypress event for both printable keys and
non-printable keys a lot. However, we'll stop dispatching keypress event for
non-printable keys in the default event group of web content. So, autocomplete
should listen to keypress events at the system event group.
Note that it's difficult to change keypress event listeners to keydown event
listeners because if we stop keypress events at preceding keydown event in
autocomplete or satchel module, some other modules fail to handle keydown or
keypress event before autocomplete and it's not easy to investigate which
module's which keypress event listener should be changed to keydown event
listener. Therefore, this patch doesn't do it at least for now.
MozReview-Commit-ID: 7e3aklmKrXu
--HG--
extra : rebase_source : 1a1e71972e4f56f088c0372e12961ffb683c7b26
The change to RootAccessible.cpp fixes an obvious bug introduced in bug 741707.
The visibility changes in gfx/thebes are because NS_DECL_ISUPPORTS has a
trailing "public:" that those classes were relying on to have public
constructors.
MozReview-Commit-ID: IeB8KIJCGhU
See the comment on "Address test failures caused by bumping timer precision to 2 ms"
for more details.
MozReview-Commit-ID: LrsucEPdZIo
--HG--
extra : rebase_source : 8147c034f7dc93f678eebc80b0afabf55729d804
This patch creates the capability to have callsites specify if timestamps
should be clamped only in Resist Fingerprinting Mode, or in the more expansive
Timer PRecision Reduction Mode.
Then it changes the CSS Animation callsite to only apply in RFP Mode.
This avoids regressing RFP.
MozReview-Commit-ID: B1pSri0kRk6
--HG--
extra : rebase_source : f3d8c1f9561fbb19d1ca8594ba2b69cffd25445b
Summary:
These are made persistent:
1. What questions will you answer with this data?
These probes are critical to understanding use of notifications and push in
general (push provides significant incentive to sites to use notifications, so
the two are highly correlated). These probes allow us to understand when push
is enabled, and when pushes are propagated.
2. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements? Some example responses:
These allow is to understand baseline platform characteristics and ensure that changes don't degrade experience.
3. What alternative methods did you consider to answer these questions? Why were they not sufficient?
We have telemetry on autopush (our server infrastructure), and the information we get there is in many ways superior to data collected through the browser, but these metrics are impossible to measure using autopush.
4. Can current instrumentation answer these questions?
See 3.
5. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories on the found on the Mozilla wiki.
Measurement Description Data Collection Category Tracking Bug #
WEB_NOTIFICATION_CLICKED 2 1429286
WEB_NOTIFICATION_PERMISSIONS 2 1429286
WEB_NOTIFICATION_SHOWN 2 1429286
PUSH_API_NOTIFY 2 1429286
6. How long will this data be collected? Choose one of the following:
I want to permanently monitor this data. (Martin Thomson, :mt)
7. What populations will you measure?
All channels, countries, and locales. No filtering is in place. These are all opt-out telemetry.
8. Please provide a general description of how you will analyze this data.
Changes are monitored for changes, or analyzed on demand.
I believe that there are telemetry alerts that trigger on significant changes. If there isn't, there should be.
9. Where do you intend to share the results of your analysis?
telemetry.m.o, w3c webapps
Bug #: 1429286
Differential Revision: https://phabricator.services.mozilla.com/D361
MozReview-Commit-ID: Kkc1Qr6UaJ8
This macro is identical to NS_INTERFACE_MAP_END and encourages the
reader to think that there's something extra-special threadsafe about QI
implementations that use the macro, when in reality there's nothing of
the sort.
The only purpose of these bindings was to insert a stylesheet, which has been
moved to be included in toolkit/content/components.css.
MozReview-Commit-ID: 23jqkIrbVvi
--HG--
extra : rebase_source : 8d13f7a8afa730207d40e1457e36ec51331c4ea7
The titles for the root bookmark folders in the database will now never get updated. This
avoids doing maintenance and changing them if the locale changes.
The UI is now responsible for displaying the correct title.
WebExtensions API will get the UI visible names.
MozReview-Commit-ID: ErPPJXxy2d3
--HG--
extra : rebase_source : f08caa5b0d00ae81ffabf4a1076bd56b66414418
Previously, it was possible for AppendToLibPath to
fail to add the directory /A/B/C/ to LD_LIBRARY_PATH
if the directory /A/B/C/D/ was already present.
--HG--
extra : rebase_source : 516fb65a57afd97252ad35e52f906b54afdd1616
* The number is no longer selected on number input focus
MozReview-Commit-ID: AmR5c6YKTCP
--HG--
extra : rebase_source : fdaab23fca57f361c9185191d9c30e047375cbe8
* Add a serializeRequest method to paymentDialogWrapper to correctly serialize the nsIArray values
* Test results of serializing a request with multiple displayItems, shippingOptions, paymentMethods and modifiers
MozReview-Commit-ID: DTqzTAjvdxq
--HG--
extra : rebase_source : 5bdc3ca1bfec8d524348ca12fcfe4f95508329cc
Currently, the mirror treat roots like any other folder, and applies
remote value changes like titles, descriptions, and creation dates.
We should instead treat roots as immutable, and only apply new
structure states, to match the behavior of the legacy engine, iOS,
and Android.
This has a semantic change: if a root is changed locally, but we dedupe
all its children to match the remote tree, we'll still reupload a
record for the root. However, this change is consistent with the legacy
engine, as well as how we handle orphans moved into a locally modified
"unfiled".
MozReview-Commit-ID: 6hi0VcrG9ew
--HG--
extra : rebase_source : d72550ea3c8f82ab6a33654a021d55c487fbcd46
This removes all the homepage-related code. All the cases where we advance the wizard straight to
the homepage wizardpage now go straight to the 'start migrating' page (the 'point' was skipping
earlier pages that allowed users to select items).
The brand bundle was only used by the homepage code so is also being removed.
MozReview-Commit-ID: I9nSU2IMkQz
--HG--
extra : rebase_source : da803ed67b443cb164f2bc55550bfd7c107fa916
This patch creates the capability to have callsites specify if timestamps
should be clamped only in Resist Fingerprinting Mode, or in the more expansive
Timer PRecision Reduction Mode.
Then it changes the CSS Animation callsite to only apply in RFP Mode.
This avoids regressing RFP.
MozReview-Commit-ID: B1pSri0kRk6
--HG--
extra : rebase_source : 5c1a3a1bb7cb10cd5c4a608f30bf097bd7e119b9
* The number is no longer selected on number input focus
MozReview-Commit-ID: 6XQdnJP65m0
--HG--
extra : rebase_source : 96d16469e99fc52c15a0b5024bdf9c3b4211a171
I noticed these while looking for other things that were gettting an
nsIWebBrowserPrint for print preview. I think these must have been left for
legacy addons and they don't seem to be used, so I think they can go.
This test is supposed to verify that Safe Browsing providers can
be initialized correctly even when a table is not configured
properly.
By removing a table from both google and google4, we ensure that
the test will be meaningful regardless of the stack in use.
Also filter out the console noise triggered by looking for the
update and gethash URLs of the "test" dummy provider.
MozReview-Commit-ID: KjWqSqA4FxJ
--HG--
extra : rebase_source : c68ab76201f200de5b5f4ab329bfe00a50603db2
These can take minutes to run, while using integer foreign keys takes
milliseconds. The only time we delete from the mirror is in `reset`,
so we can make this more efficient by clearing the `structure` table
first, so that there are no foreign key references to clean up when we
clear `items`. For `itemsToUpload`, we can simply use integer IDs
everywhere.
MozReview-Commit-ID: rTfJzjPHi1
--HG--
extra : rebase_source : 5f6b1d0ed8362c670c832ec91963def069b35ba4
MozReview-Commit-ID: 270iURVhNRu
This patch builds upon the existing DLL services functionality:
1) We add code to obtain the name of the subject from the cert used to sign a
binary (if present). This code is added inside mozglue because in the future
we will be using this code from the DLL blocklist, which is also located
there.
2) We add annotation functionality that registers itself for DLL load events
and updates crash reporter annotations as new libraries are loaded. It also
annotates any existing libraries that are also in memory at the time that the
CertAnnotator is first instantiated. This all happens off main thread, with
the exception of actually making the annotation when in a child process.
--HG--
extra : rebase_source : 2e3726d37356479aee81915caed04fe7af74c815
The list of sites to suppress flash infobars on should not be
downloaded from shavar unless the infobar feature is enabled.
MozReview-Commit-ID: BjkS5vWiilg
--HG--
extra : rebase_source : ba7c104b758fc04994b8438222dda0c7feadc787
MozReview-Commit-ID: 270iURVhNRu
This patch builds upon the existing DLL services functionality:
1) We add code to obtain the name of the subject from the cert used to sign a
binary (if present). This code is added inside mozglue because in the future
we will be using this code from the DLL blocklist, which is also located
there.
2) We add annotation functionality that registers itself for DLL load events
and updates crash reporter annotations as new libraries are loaded. It also
annotates any existing libraries that are also in memory at the time that the
CertAnnotator is first instantiated. This all happens off main thread, with
the exception of actually making the annotation when in a child process.
--HG--
extra : rebase_source : f86c1a6fd2a44f21a71e7a7418267b3b0d5feeec
This patch was autogenerated by my decomponents.py
It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.
It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <
Shane Caraveo
Paolo Amadini
Andreea Pavel
Coroiu Cristina
Tim Nguyen
Dorel Luca
Richard Marti
Christoph Kerschbaumer
Gurzau Raul
shindli
Kirk Steuber
Francois Marier
Daniel Stenberg
Jeff Walden
Apoorv Goel
Kartikaya Gupta
Tom Ritter
Masayuki Nakano
Dão Gottwald
Alejandro Rodriguez
Andrea Marchesini
Noemi Erli
Boris Zbarsky
Ciure Andrei
Jared Wein
Sebastian Hengst
Franziskus Kiefer
David Anderson
Martin Thomson
Nathan Froyd
Mark Striemer
Martin Stransky
Timothy Guan-tin Chien
Emilio Cobos Álvarez
Mark Banner
Ursula Sarracini
Marco Bonardo
Arthur Edelstein
Jorg K
Margareta Eliza Balazs
Bogdan Tara
Adrian Wielgosik
Servo VCS Sync
Bob Owen
Sam Foster
Csoregi Natalia
Gijs Kruitbosch
Kit Cambridge
Eugen Sawin
Tiberius Oros
Eric Rahm
Cosmin Sabou
Aaron Klotz
Narcis Beleuzu
Brindusan Cristian
Geoff Brown
Marco Castelluccio
Florian Quèze
yulia
Nathan Watson
Gabriele Svelto
arthur.iakab
Zibi Braniecki
Josh Matthews
Manish Goregaokar
Andrew McCreight
vprabhu
hemant
Jeremy Lempereur