Move the initialization of this flag to `finishFunctionScopes` so that it is
set for both lazy and non-lazy compilations. We add a `VarScopeHasBindings`
helper to mirror the logic of `newVarScopeData` without allocating. We use
the ImmutableFlag to enable consistent initialization for lazy and non-lazy
scripts.
Note that the previous `hasExtraBodyVarScope` helper is only used for
bytecode emission which occurs after the FunctionHasExtraBodyVarScope flag is
properly initialized.
Differential Revision: https://phabricator.services.mozilla.com/D71241
* Add a new `allowSearchSuggestions` property to the query context. It defaults to true.
* `UrlbarInput` sets this property when it starts a query. If the event that started the query is a paste event and the pasted string's length is larger than maxChars, then don't allow suggestions. Otherwise do.
* `UrlbarProviderSearchSuggestions.isActive` returns false when `!context.allowSearchSuggestions`.
* `UrlbarProviderSearchSuggestions` doesn't truncate the query anymore.
* Keep the `browser.urlbar.maxCharsForSearchSuggestions` pref but use it only for pastes, and increase it from 20 to 100. I considered making a new pref but this way if a user changed it, then it still applies to pastes at least. I'm not sure it's important though.
Differential Revision: https://phabricator.services.mozilla.com/D70956
DownloadsSubview and DownloadsView do not inherit from custom elements and cannot rely on the static getFragment method.
The individual download list items all need to be cloned in order to display.
Differential Revision: https://phabricator.services.mozilla.com/D71204
These tests used <iframe mozbrowser> for convenience, mostly forcing
themselves to only run in non-e10s mode in the process, but none of them
really have any need to.
Differential Revision: https://phabricator.services.mozilla.com/D70745
These were added for the sake of app browsers, and all of the code which
actually needed them has since been removed.
Differential Revision: https://phabricator.services.mozilla.com/D70741
It makes no sense that the first thing in the session would be considered as
wrapping, it was happening only because we were incorrectly failing to find a
"visible" range deep in Gecko (so we started back from the beginning of the
document, wrapping).
Differential Revision: https://phabricator.services.mozilla.com/D71157
Multiple issues here. The IsRangeVisible code was wrong, it was returning false
for ranges that were perfectly valid, but outside the viewport, because the
following piece of code:
if (!aMustBeInViewPort) {
// This is an early exit case because we don't care that that range
// is out of viewport, so we return that the range is "visible".
return true;
}
Was incorrectly after some stuff checking viewport visibility. This code is
pretty complex for no good reason, it wants to do something very
simple: Start from the visible selection if possible.
This patch still achieves this, using IsRangeRendered (which does a proper
hit-test to figure out if a range is in the viewport). Should have no behavior
differences except for non-collapsed ranges that are partially inside the
viewport.
Differential Revision: https://phabricator.services.mozilla.com/D71067
This also fixes a bug where we weren't recording the telemetry probe clicks on breached password learn more links due to the refactoring and renaming of the .alert-link class. A test has been added that would have caught that mistake in automation.
Differential Revision: https://phabricator.services.mozilla.com/D70142
This also fixes a bug where we weren't recording the telemetry probe clicks on breached password learn more links due to the refactoring and renaming of the .alert-link class. A test has been added that would have caught that mistake in automation.
Differential Revision: https://phabricator.services.mozilla.com/D70142
Chris Peterson
aarushivij
Jeff Walden
Masayuki Nakano
Ted Campbell
Drew Willcoxon
Andreea Pavel
Emilio Cobos Álvarez
Emma Malysz
Nika Layzell
Jan-Ivar Bruaroey
Dzmitry Malyshau
Jeff Muizelaar
Shane Caraveo
Ciure Andrei
Kris Maglione
Jared Wein
Daosheng Mu
Imanol Fernandez
Erik Nordin
Scott
Bogdan Tara
Nicolas Silva