Should also have no behavior change.
After the previous patch we don't have sheets associated with a document but
not owned by it, so take advantage of that.
Differential Revision: https://phabricator.services.mozilla.com/D71264
Users have much better, easier alternatives, like
DOMWindowUtils.{loadSheetUsingURIString,removeSheet}, which we use to
replace the only caller that exists in mozilla-central (the editor
element, which loads EditorOverride.css).
This allows to clean up the style system and editor. There are other
callers in comm-central, but it seems they can switch to DOMWindowUtils
trivially, as the DOMWindowUtils APIs also use the system principal and
thus they can load any URL.
I'll make sure to give them some time with the migration and/or help
out of course.
Differential Revision: https://phabricator.services.mozilla.com/D71263
I think using MConstant::equals was /probably/ fine, but I find it hard to reason about.
This also potentially allows comparing double 1.0 to int32 1 or similar.
Differential Revision: https://phabricator.services.mozilla.com/D71240
Various updates to the custom retrigger action so that, without any custom changes to
parameters, the retriggered task runs with the same parameters as the original task.
Several issues were found and corrected, notably:
- parameters like --allow-software-gl-layers were ignored
- MOZHARNESS_TEST_PATHS was ignored
- many parameter customizations in the desktop mozharness configs were ignored
- mochitest suite/subsuite/flavor selection was not always correct
- using repeat=1 by default meant that each test ran twice
Differential Revision: https://phabricator.services.mozilla.com/D70457
As we change to use the 'HasStoragePermission' flag, there are some code
became uncessary. This patch removes those code.
Differential Revision: https://phabricator.services.mozilla.com/D71034
We move to use the 'HasStoragePermission' flag to check the storage
permission. For the storage permission check of windows, the flag would
come from the WindowContext. For the check of channels, the flag would
come from the loadInfo of the channel.
Differential Revision: https://phabricator.services.mozilla.com/D71033
We need the 'hasStoragePermission' flag for calculating the
HasStorageAccess() value. Right now the setting of the flag is later
than the calculation. So, we move the setting before the calculation.
Differential Revision: https://phabricator.services.mozilla.com/D71032
We need to check the HasStorageAccessGranted() in the channel version of
the ContentBlocking::ShouldAllowAccessFor(). It's because we will move
to use the flag 'HasStoragePermission' to check the permission. But, this
flag won't get updated if the storage is allowed by the heuristic. So,
we need to rely on the HasStorageAccessGranted() to check the storage
access in the channel check as well.
Differential Revision: https://phabricator.services.mozilla.com/D71031
This removes StyleSheet::GetComposedDoc because it wasn't doing the
right thing, and while constructable stylesheets _could_ in theory
return something meaningful (the constructor doc iff any adopters is
connected), it's not a concept we need in other places for now.
Differential Revision: https://phabricator.services.mozilla.com/D71261
Relaxes the type constraints for span overloads on `nsTArray`, such as
`AppendElements`. They previously took `Span<const Item>`, which could cause
build errors when attempting to pass a non const-qualified Item such as in
`Span<RefPtr<BrowsingContext>>`.
Differential Revision: https://phabricator.services.mozilla.com/D71232
Martin Robinson
Anthony Ramine
Jeff Walden
Robert Longson
Timothy Nikkel
Emilio Cobos Álvarez
Ryan VanderMeulen
sotaro
Tom Schuster
Geoff Brown
Lee Salzman
Imanol Fernandez
Tim Huang
Andreea Pavel
Dão Gottwald
Gijs Kruitbosch
Mihai Alexandru Michis
Daosheng Mu
Nika Layzell
Julian