In bug 634697, Firefox was changed to remember client authentication decisions
across sessions, so the option of having Firefox "Ask every time" was
misleading. Offering to "Select one automatically" is a privacy disaster and it
should not have been exposed in the UI.
Differential Revision: https://phabricator.services.mozilla.com/D98675
This also adds the first threshold of 0.9 for YouTube, which allows us to avoid
hittest false positives on the PiP toggle when the user has one of the YouTube
player menus open.
Differential Revision: https://phabricator.services.mozilla.com/D93124
In an earlier attempt to fix this shutdown hang, a timeout was added to the cacheNow
task function to try to have a maximum of 1s of wait time during the shutdown blocker
before giving up and letting the shutdown proceed.
This didn't seem to put a dent in the shutdown hangs. It looks like DeferredTasks
that are being finalized don't actually re-enter the task if the task was already
running, which might explain why in some cases the timeout wasn't being hit. This
patch makes sure that the timeout is being used regardless of whether or not the
cache task is already underway.
Differential Revision: https://phabricator.services.mozilla.com/D98688
tzdata 2020b removed the "US/Pacific-New" time zone link, but the link is
still present in CLDR/ICU, so we need to manually remove it before processing
the ICU time zone files.
Also reformats the complete file through Black because the linter was
complaining about it. (The `u` prefix for Unicode strings wasn't removed when
Black was applied on all in-tree files and apparently this is now causing
linter warnings.)
Differential Revision: https://phabricator.services.mozilla.com/D94604
BONUS: Improve the docs for adding new metric type in C++ and JS,
added two missing steps to the C++ part and changed the layout
a bit to make it easier to follow.
Differential Revision: https://phabricator.services.mozilla.com/D95314
Previously, the updates in OnStartRequest were not updating some of the
interface fields, including `nsIHttpChannelInternal`, which caused the wrong
channel object to be queried for Cross-Origin-Opener-Policy status during
process switches after a redirect, and crashes.
In the `browser_application_panel_viewsource-service-worker.js` test case, the
http channel was being intercepted by a service worker, but the non-intercepted
channel was being queried. As the non-intercepted channel had not observed
`OnStartRequest`, the query failed.
Differential Revision: https://phabricator.services.mozilla.com/D98619
Before switching to using DocumentChannel to process multipart requests,
multipart documents loaded as a view-source load would be displayed their
plain-text data, as the multipart processing would be after the view-source
channel had wrapped the channel, and replaced the content type with
"application/x-view-source".
This change restores that behaviour, by preventing parent process multipart
processing for wrapped channels like `view-source` loads. This also allowed
removing the replaceRequest option on nsViewSourceChannel, as it was no longer
necessary, and required introducing a mechanism to get the inner http channel
for process switching.
The crash in Bug 1670530 was caused by a bad interaction between the view-source
replaceChannel logic, and the parent/content process switching logic, which
could lead to the load in the content process being initialized in a broken
state after a process switch, due to accidentally acting on a wrapped
view-source channel when an unwrapped one was expected. This patch also fixes
that issue, by removing the replaceRequest logic which caused it in the first
place.
Differential Revision: https://phabricator.services.mozilla.com/D98205
buttonCount has a different value depending on whether or not the build is MOZ_DEV_EDITION or
not, since we show an extra Debug button for script hangs in Developer Edition.
We do not show that extra button for plugin hangs, regardless of the build type, so we
shouldn't use buttonCount here.
Differential Revision: https://phabricator.services.mozilla.com/D98793
No idea why this didn't show up in earlier try runs, but this is a known false-positive that we need to suppress in the newly-added EncryptedClientHelloServer.
Differential Revision: https://phabricator.services.mozilla.com/D98771
This patch enables PSM and Firefox to use TLS 1.3 Encrypted Client Hello (draft -08). Specifically:
- Compile NSS with NSS_ENABLE_DRAFT_HPKE=1
- Add ECH "public_name" handling in SSLServerCertVerification.cpp (see: https://tools.ietf.org/html/draft-ietf-tls-esni-08#section-6.3.2)
- Adds `mIsAcceptedEch` to TransportSecurityInfo, and xpcshell tests for ECH use cases
- Adds EncryptedClientHelloServer to facilitate the xpcshell tests
- Un-ifdef Set/GetEchConfigs code in nsNSSIOLayer.cpp. Also reverted the Base64 encoding and decoding, as the data returned from DNS is already decoded (wire-format).
Differential Revision: https://phabricator.services.mozilla.com/D92651
To build native python packages, the python dev packages are needed.
This should resolve the psutil installation failure.
Differential Revision: https://phabricator.services.mozilla.com/D98197
Agi Sferro
Mike Hommey
Dana Keeler
Shane Caraveo
Scott
Bas Schouten
Henrik Skupin
Mike Conley
André Bargull
Gregory Mierzwinski
brizental
Barret Rennie
Mihai Alexandru Michis
Andrew Sutherland
Dale Harvey
Nika Layzell
David Major
Ted Campbell
Alexis Beingessner
Nicolas Chevobbe
Csoregi Natalia
Kevin Jacobs
Mitchell Hentges
Emilio Cobos Álvarez
Steve Fink
Butkovits Atila
Simon Giesecke