mozilla
/
gecko-dev
зеркало из https://github.com/mozilla/gecko-dev.git
1
0
Форкнуть 0
Код Задачи Пакеты Проекты Релизы Вики Активность
783 821 коммит 615 Ветки 98 Теги 5,7 GiB
Граф коммитов

465 Коммитов

Автор SHA1 Сообщение Дата
Csoregi Natalia b355fcc4bf Backed out 6 changesets (bug 1464542) for xpcshell failures on test_Services.js. CLOSED TREE 
Backed out changeset b50af9005851 (bug 1464542)
Backed out changeset 9d3a0ea2cf65 (bug 1464542)
Backed out changeset 71c3475fcbc2 (bug 1464542)
Backed out changeset 51ff93220a95 (bug 1464542)
Backed out changeset e84de1547c09 (bug 1464542)
Backed out changeset bbecc16d08eb (bug 1464542)
 2020-07-09 23:19:26 +03:00
Kris Maglione d09458dc51 Bug 1464542: Part 3b - Add existing Services.jsm registrations to the new services cache. r=mccr8,geckoview-reviewers,agi 
Differential Revision: https://phabricator.services.mozilla.com/D81419
 2020-07-09 17:59:16 +00:00
Nika Layzell a3579f6f46 Bug 1458043 - Stop converting promises to nsISupports in xpconnect, r=kmag 
Differential Revision: https://phabricator.services.mozilla.com/D82616
 2020-07-07 22:20:01 +00:00
Jan Varga c3a253dfc8 Bug 1621920 - Polish directory traversal done by LS client; r=dom-workers-and-storage-reviewers,sg 
Differential Revision: https://phabricator.services.mozilla.com/D81689
 2020-07-02 07:19:44 +00:00
Jan Varga d4d374efdf Bug 1621920 - Convert some macros in dom/localstorage/ActorsParent.cpp to literal strings; r=dom-workers-and-storage-reviewers,sg 
Differential Revision: https://phabricator.services.mozilla.com/D81688
 2020-07-02 07:19:31 +00:00
Jan Varga db57e12a9d Bug 1621920 - Simplify handling of unknown directories in LS client directory; r=dom-workers-and-storage-reviewers,ttung 
Differential Revision: https://phabricator.services.mozilla.com/D81686
 2020-07-02 07:19:14 +00:00
Simon Giesecke 9364b353d4 Bug 1648010 - Remove NS_NAMED_LITERAL_CSTRING and NS_NAMED_LITERAL_STRING macros. r=froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D80631
 2020-07-01 08:42:31 +00:00
Simon Giesecke e3c223da3e Bug 1648010 - Fix uses of NS_LITERAL_STRING with C string literals. r=geckoview-reviewers,agi,froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D80861
 2020-07-01 08:34:12 +00:00
Simon Giesecke cd8b8939b9 Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D80860
 2020-07-01 08:29:29 +00:00
Andrea Marchesini c6e87ab4b6 Bug 1648141 - IPCBlobInputStream to RemoteLazyInputStream - part 5 - thread, r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D80928
 2020-06-29 13:39:01 +00:00
Razvan Maries f7cb24cc7e Backed out 8 changesets (bug 1648141) for build bustages on RemoteLazyInputStreamThread.cpp. CLOSED TREE 
Backed out changeset e9b4ca0ee700 (bug 1648141)
Backed out changeset b9bb847cee47 (bug 1648141)
Backed out changeset 11dfce46ec14 (bug 1648141)
Backed out changeset d824d2f67f27 (bug 1648141)
Backed out changeset e5b8292e7095 (bug 1648141)
Backed out changeset c1a3d5fa0c61 (bug 1648141)
Backed out changeset 24fdb83db3cd (bug 1648141)
Backed out changeset 749d894dde52 (bug 1648141)
 2020-06-29 13:59:16 +03:00
Andrea Marchesini 2641b9afe4 Bug 1648141 - IPCBlobInputStream to RemoteLazyInputStream - part 5 - thread, r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D80928
 2020-06-29 10:27:38 +00:00
Jan Varga f482502235 Bug 1621920 - Convert LS client to use the new macro for warning about unknown stuff and add testing for unknown directories in LS client directory; r=dom-workers-and-storage-reviewers,ttung 
Differential Revision: https://phabricator.services.mozilla.com/D80167
 2020-06-26 01:56:45 +00:00
Simon Giesecke 8193fe19be Bug 1641512 - Use distinct types for file and database usage. r=dom-workers-and-storage-reviewers,janv 
Differential Revision: https://phabricator.services.mozilla.com/D77462
 2020-06-25 09:30:06 +00:00
Simon Giesecke 55e3bdd7f8 Bug 1641512 - Use Result<UsageInfo, nsresult> as return type of InitOrigin and add separate InitOriginWithoutTracking. r=dom-workers-and-storage-reviewers,janv 
Differential Revision: https://phabricator.services.mozilla.com/D77453
 2020-06-25 09:31:39 +00:00
Simon Giesecke c23800e5f2 Bug 1641512 - Use Result<UsageInfo, nsresult> as return type of GetUsageForOrigin. r=dom-workers-and-storage-reviewers,janv 
Differential Revision: https://phabricator.services.mozilla.com/D77452
 2020-06-25 08:34:43 +00:00
Narcis Beleuzu 0084f5d032 Backed out 3 changesets (bug 1621920) for bustages on ActorsParent.cpp . CLOSED TREE 
Backed out changeset 6d94049a8f9e (bug 1621920)
Backed out changeset b85b0e346dee (bug 1621920)
Backed out changeset e3e3a090ee96 (bug 1621920)
 2020-06-25 10:08:13 +03:00
Jan Varga 48989fbc7c Bug 1621920 - Convert LS client to use the new macro for warning about unknown stuff and add testing for unknown directories in LS client directory; r=dom-workers-and-storage-reviewers,ttung 
Differential Revision: https://phabricator.services.mozilla.com/D80167
 2020-06-25 06:29:48 +00:00
Jean-Yves Avenard 87438519f0 Bug 1637500 - P2. Rename methods as they are not always dealing with "threads". r=froydnj 
Before P1, GetCurrentThreadSerialEventTarget would have always returned the same data as NS_GetCurrentThread, making the comment incorrect Now it will properly return the running TaskQueue if any.

This change of name more clearly exposes what they are doing, as we aren't always dealing with threads directly; but a nsISerialEventTarget

Differential Revision: https://phabricator.services.mozilla.com/D80354
 2020-06-23 05:05:36 +00:00
Simon Giesecke 2e8e66ab3c Bug 1641512 - Rename AppendTo*Usage methods to Increment*Usage. r=dom-workers-and-storage-reviewers,janv 
Differential Revision: https://phabricator.services.mozilla.com/D77450
 2020-06-11 10:42:16 +00:00
Jan Varga 478765004c Bug 1621916 - Provide a usable stack when requestFinished throws; r=dom-workers-and-storage-reviewers,sg,asuth 
Differential Revision: https://phabricator.services.mozilla.com/D77217
 2020-06-11 07:04:38 +00:00
Butkovits Atila 0e09b9191c Backed out changeset 3f5baab34b1f (bug 1621916) for causing failure at QuotaRequests.cpp. CLOSED TREE 2020-06-11 09:58:59 +03:00
Jan Varga e72a3e7779 Bug 1621916 - Provide a usable stack when requestFinished throws; r=dom-workers-and-storage-reviewers,sg,asuth 
Differential Revision: https://phabricator.services.mozilla.com/D77217
 2020-06-11 06:36:55 +00:00
Jan Varga 954ae9ed68 Bug 1526949 - Keep private browsing datastores alive until the private browsing session is closed; r=dom-workers-and-storage-reviewers,asuth 
Differential Revision: https://phabricator.services.mozilla.com/D78640
 2020-06-09 13:42:09 +00:00
Jan Varga d123d73b2d Bug 1621916 - Remove unused argument in Client::InitOrigin; r=dom-workers-and-storage-reviewers,sg 
Depends on D77070

Differential Revision: https://phabricator.services.mozilla.com/D77072
 2020-05-27 15:52:49 +00:00
Jan Varga 5183f79beb Bug 1621916 - Unify reporting of unknown files across quota manager, idb, sdb and ls quota client; r=dom-workers-and-storage-reviewers,ttung 
Depends on D76703

Differential Revision: https://phabricator.services.mozilla.com/D76717
 2020-05-26 07:02:07 +00:00
ssengupta cf852bbfb9 Bug 1635399 - Function PrincipalInfoToPrincipal now returns Result<nsCOMPtr<nsIPrincipal>, nsresult> r=ckerschb 
Differential Revision: https://phabricator.services.mozilla.com/D73868
 2020-05-12 19:02:05 +00:00
Chris Peterson a6d592bbe2 Bug 1620152 - Part 4: Replace MOZ_DIAGNOSTIC_ALWAYS_TRUE() with MOZ_ALWAYS_TRUE(). r=janv 
MOZ_ALWAYS_TRUE() evaluates its expression in both debug and release builds. This bug will change MOZ_ALWAYS_TRUE() to use MOZ_DIAGNOSTIC_ASSERT() instead of MOZ_ASSERT(), so MOZ_DIAGNOSTIC_ALWAYS_TRUE() will be redundant.

Differential Revision: https://phabricator.services.mozilla.com/D66922

--HG--
extra : moz-landing-system : lando
 2020-04-09 02:08:10 +00:00
Sebastian Hengst 88bbcf97df Backed out 4 changesets (bug 1620152) because it blocks the backout of bug 1626967. a=backout 
Backed out changeset c6fe172dd237 (bug 1620152)
Backed out changeset a13507db74f7 (bug 1620152)
Backed out changeset 005a31ffa4bf (bug 1620152)
Backed out changeset 9c80be97934f (bug 1620152)
 2020-04-08 10:06:27 +02:00
Chris Peterson 46bb24451b Bug 1620152 - Part 4: Replace MOZ_DIAGNOSTIC_ALWAYS_TRUE() with MOZ_ALWAYS_TRUE(). r=janv 
MOZ_ALWAYS_TRUE() evaluates its expression in both debug and release builds. This bug will change MOZ_ALWAYS_TRUE() to use MOZ_DIAGNOSTIC_ASSERT() instead of MOZ_ASSERT(), so MOZ_DIAGNOSTIC_ALWAYS_TRUE() will be redundant.

Differential Revision: https://phabricator.services.mozilla.com/D66922

--HG--
extra : moz-landing-system : lando
 2020-04-08 04:35:01 +00:00
Tom Tung 94e4123950 Bug 1536796 - P3 - Use QM_NewLocalFile in QM and its clients; r=janv,dom-workers-and-storage-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D67875

--HG--
extra : moz-landing-system : lando
 2020-04-01 07:26:27 +00:00
Sebastian Streich 5577df21f9 Bug 1615297 - Move Localstorage Keygen into Principal r=ckerschb,baku 
Differential Revision: https://phabricator.services.mozilla.com/D62757

--HG--
extra : moz-landing-system : lando
 2020-03-29 15:31:24 +00:00
Ed Lee acb960676c Bug 1620556 - Automatic code fixes for Prettier 1.19.1 upgrade. r=Standard8,remote-protocol-reviewers,marionette-reviewers,webcompat-reviewers,perftest-reviewers,sparky,whimboo,denschub 
Differential Revision: https://phabricator.services.mozilla.com/D66128

--HG--
extra : moz-landing-system : lando
 2020-03-13 23:38:52 +00:00
Daniel Varga 8edab673d8 Backed out changeset d15b968aa6d1 (bug 1615297) for causing build bustage 
CLOSED TREE

--HG--
extra : rebase_source : 4e525e82fb7f194d9b7eac0020932ed09ac005b7
 2020-03-11 05:41:51 +02:00
Sebastian Streich 1f23aca56c Bug 1615297 - Move Localstorage Keygen into Principal r=ckerschb,baku 
Differential Revision: https://phabricator.services.mozilla.com/D62757

--HG--
extra : moz-landing-system : lando
 2020-03-10 18:10:08 +00:00
Mark Banner 15cfe23b88 Bug 1620542 - Automatically fix ESLint errors in .eslintrc.js files. r=mossop 
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D65703

--HG--
extra : moz-landing-system : lando
 2020-03-07 10:09:44 +00:00
Cosmin Sabou 9ec8941cd4 Backed out 2 changesets (bug 1603703) for xpc failures on test_storage_aggregates.js. CLOSED TREE 
Backed out changeset 05dbbf7c379f (bug 1603703)
Backed out changeset a1e723439116 (bug 1603703)

--HG--
extra : rebase_source : 65d834f15b63fdd0ce5c90d2efd080e4841777aa
 2020-03-05 19:37:32 +02:00
Simon Giesecke 9e296ae57f Bug 1603703 - Part 2: Rename CreateFunction/RemoveFunction to RegisterFunction/UnregisterFunction. r=mak 
Depends on D57089

Differential Revision: https://phabricator.services.mozilla.com/D65504

--HG--
extra : moz-landing-system : lando
 2020-03-05 15:14:56 +00:00
Jan Varga 45769a3be8 Bug 1606635 - Modify QuotaManager::OpenDirectory to return a pending lock; r=asuth,dom-workers-and-storage-reviewers,sg 
Differential Revision: https://phabricator.services.mozilla.com/D64715

--HG--
extra : moz-landing-system : lando
 2020-02-29 04:42:50 +00:00
Oana Pop Rus d001aab6bf Backed out changeset ad8efac474bf (bug 1606635) for build bustages multiple failures in Context.cpp on a CLOSED TREE 2020-02-29 06:17:22 +02:00
Jan Varga 39371e357b Bug 1606635 - Modify QuotaManager::OpenDirectory to return a pending lock; r=asuth,dom-workers-and-storage-reviewers,sg 
Differential Revision: https://phabricator.services.mozilla.com/D64715

--HG--
extra : moz-landing-system : lando
 2020-02-29 04:02:13 +00:00
Eric Rahm e61be8e54e Bug 1617653 - Remove nsAutoPtr usage from localstorage, quota, storage, simpledb. r=dom-workers-and-storage-reviewers,sg 
Differential Revision: https://phabricator.services.mozilla.com/D63913

--HG--
extra : moz-landing-system : lando
 2020-02-25 23:14:57 +00:00
Simon Giesecke aaf6cb4e75 Bug 1617628 - Hide nsBaseHashtable Put overloads in nsRefPtrHashtable subclass. r=froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D63899

--HG--
extra : moz-landing-system : lando
 2020-02-25 17:03:36 +00:00
Eric Rahm 124379887c Bug 1617327 - Part 2: Remove nsAutoPtr usage from ipc, security, IDB. r=mccr8,janv 
This removes `nsAutoPtr` usage from ipc/. security/ failed to build due to missing includes so I fixed that as well. IDB was using `ThreadLocal` from ipc which had a member changed to a `UniquePtr` so needed to be updated as well. localstorage was missing some includes.

Differential Revision: https://phabricator.services.mozilla.com/D63745

--HG--
extra : moz-landing-system : lando
 2020-02-24 19:26:40 +00:00
Simon Giesecke b50347f917 Bug 1611415 - Prefer using std::move over forget. r=froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D60980

--HG--
extra : moz-landing-system : lando
 2020-02-13 14:38:48 +00:00
shindli 91aa0518dd Backed out changeset 0c982bc69cb3 (bug 1611415) for causing build bustages in /builds/worker/workspace/build/src/obj-firefox/dist/include/nsCOMPtr CLOSED TREE 2020-02-12 20:13:29 +02:00
Simon Giesecke f604a47fa5 Bug 1611415 - Applied FixItHints from mozilla-non-std-move. r=froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D60980

--HG--
extra : moz-landing-system : lando
 2020-02-12 17:24:41 +00:00
Simon Giesecke fa114fcf6f Bug 1613985 - Use default for equivalent-to-default constructors/destructors in dom/localstorage. r=dom-workers-and-storage-reviewers,janv 
Differential Revision: https://phabricator.services.mozilla.com/D62556

--HG--
extra : moz-landing-system : lando
 2020-02-12 10:24:28 +00:00
Simon Giesecke fd8148e7ed Bug 1613411 - Remove unnecessary const_cast. r=dom-workers-and-storage-reviewers,janv 
Differential Revision: https://phabricator.services.mozilla.com/D61700

--HG--
extra : moz-landing-system : lando
 2020-02-05 16:09:52 +00:00
Christian Holler 71231ac083 Bug 1612707 - Disable various slow tests under TSan. r=froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D61562

--HG--
extra : moz-landing-system : lando
 2020-02-04 14:34:07 +00:00
Sylvestre Ledru 187e9bafaf Bug 1519636 - Automatically reformat recent changes using clang-format r=Ehsan 
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D60354

--HG--
extra : moz-landing-system : lando
 2020-01-21 09:51:27 +00:00
Eric Rahm 78ee6675cf Bug 1606187 - Part 2b: Update users of nsClassHashtable to handle UniquePtr differences r=KrisWright,froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D59042

--HG--
extra : moz-landing-system : lando
 2020-01-13 19:18:56 +00:00
Emilio Cobos Álvarez 8f19f8bf47 Bug 1603904 - Assert WriteInfoComparator doesn't get nulls. r=janv 
Doesn't seem like it can.

Differential Revision: https://phabricator.services.mozilla.com/D57191

--HG--
extra : moz-landing-system : lando
 2020-01-10 15:09:09 +00:00
Sylvestre Ledru c521758c5e Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan 
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D58175

--HG--
extra : moz-landing-system : lando
 2020-01-09 21:50:11 +00:00
Botond Ballo 8b48782ea2 Bug 1605250 - Fix include-what-you-use errors in dom/localstorage. r=dom-workers-and-storage-reviewers,asuth 
Differential Revision: https://phabricator.services.mozilla.com/D57899

--HG--
extra : moz-landing-system : lando
 2019-12-21 01:13:29 +00:00
Emilio Cobos Álvarez b2fe832c7b Bug 1603313 - Remove some silly patterns. r=bzbarsky 
foo ? true : false

or:

  foo ? false : true

Have always a nicer way to be written.

Differential Revision: https://phabricator.services.mozilla.com/D56842

--HG--
extra : moz-landing-system : lando
 2019-12-14 05:05:01 +00:00
Kris Maglione 94e3b0bd8d Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato 
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740

--HG--
extra : moz-landing-system : lando
 2019-12-13 20:36:16 +00:00
shindli 91924fedc7 Backed out 9 changesets (bug 1596918) for causing mochitest permafailures in toolkit/content/tests/chrome/test_findbar_events.xhtml CLOSED TREE 
Backed out changeset 45a1c42118f2 (bug 1596918)
Backed out changeset db09910ffa56 (bug 1596918)
Backed out changeset 5c9d9f141c10 (bug 1596918)
Backed out changeset 6a135670d603 (bug 1596918)
Backed out changeset 3a0184e0df72 (bug 1596918)
Backed out changeset 2f0036486823 (bug 1596918)
Backed out changeset a770c6d08d52 (bug 1596918)
Backed out changeset ef062eb7a6ee (bug 1596918)
Backed out changeset a6ea596e98db (bug 1596918)
 2019-12-11 03:09:26 +02:00
Kris Maglione 16a9b29848 Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato 
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740

--HG--
extra : moz-landing-system : lando
 2019-12-10 23:07:13 +00:00
Noemi Erli 82d41a33b2 Backed out 9 changesets (bug 1596918) for causing multiple browser-chrome failures 
Backed out changeset 415007efd8c9 (bug 1596918)
Backed out changeset 011eb5ce927b (bug 1596918)
Backed out changeset e5fd3ee22ea1 (bug 1596918)
Backed out changeset 0bca4de31d40 (bug 1596918)
Backed out changeset 11ec4393f23d (bug 1596918)
Backed out changeset c5404a7c286d (bug 1596918)
Backed out changeset 7e9304405a46 (bug 1596918)
Backed out changeset fa0f0aeabf99 (bug 1596918)
Backed out changeset de196b077000 (bug 1596918)
 2019-12-07 22:26:43 +02:00
Kris Maglione 910eab35d2 Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato 
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740

--HG--
extra : moz-landing-system : lando
 2019-12-07 19:11:58 +00:00
Daniel Varga 84a601a6d4 Backed out 17 changesets (bug 1596918) for multiple browser-chrome and dev-tools failures. On a CLOSED TREE 
Backed out changeset ab87d2c1afae (bug 1596918)
Backed out changeset 775f3b06a687 (bug 1596918)
Backed out changeset 67cc63ef5d7f (bug 1596918)
Backed out changeset 7d290bcd2067 (bug 1596918)
Backed out changeset 048db9f4db7c (bug 1596918)
Backed out changeset 96a79d2ba614 (bug 1596918)
Backed out changeset be770d112dd8 (bug 1596918)
Backed out changeset 302c8ab8391c (bug 1596918)
Backed out changeset 44ef8f20732e (bug 1596918)
Backed out changeset 38c11ebfb8ff (bug 1596918)
Backed out changeset b586fc081374 (bug 1596918)
Backed out changeset 12283166716f (bug 1596918)
Backed out changeset 99b0421015d8 (bug 1596918)
Backed out changeset 97ec49dbbbf3 (bug 1596918)
Backed out changeset ec79478f58f1 (bug 1596918)
Backed out changeset c6d356833bb8 (bug 1596918)
Backed out changeset 5ef6026806c8 (bug 1596918)
 2019-12-07 03:12:07 +02:00
Kris Maglione 20da940e14 Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato 
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740

--HG--
extra : moz-landing-system : lando
 2019-12-06 22:14:14 +00:00
Gabriele Svelto ace6d1063f Bug 1600545 - Remove useless inclusions of header files generated from IDL files in dom/ r=Ehsan 
The inclusions were removed with the following very crude script and the
resulting breakage was fixed up by hand. The manual fixups did either
revert the changes done by the script, replace a generic header with a more
specific one or replace a header with a forward declaration.

find . -name "*.idl" | grep -v web-platform | grep -v third_party | while read path; do
    interfaces=$(grep "^\(class\|interface\).*:.*" "$path" | cut -d' ' -f2)
    if [ -n "$interfaces" ]; then
        if [[ "$interfaces" == *$'\n'* ]]; then
          regexp="\("
          for i in $interfaces; do regexp="$regexp$i\|"; done
          regexp="${regexp%%\\\|}\)"
        else
          regexp="$interfaces"
        fi
        interface=$(basename "$path")
        rg -l "#include.*${interface%%.idl}.h" . | while read path2; do
            hits=$(grep -v "#include.*${interface%%.idl}.h" "$path2" | grep -c "$regexp" )
            if [ $hits -eq 0 ]; then
                echo "Removing ${interface} from ${path2}"
                grep -v "#include.*${interface%%.idl}.h" "$path2" > "$path2".tmp
                mv -f "$path2".tmp "$path2"
            fi
        done
    fi
done

Differential Revision: https://phabricator.services.mozilla.com/D55442

--HG--
extra : moz-landing-system : lando
 2019-12-06 09:24:56 +00:00
Boris Zbarsky 75124bdd98 Bug 1517588. Use nsIPrincipal::IsSystemPrincipal instead of nsContentUtils::IsSystemPrincipal r=bzbarsky 
Differential Revision: https://phabricator.services.mozilla.com/D53067

--HG--
extra : moz-landing-system : lando
 2019-12-05 04:44:32 +00:00
Dorel Luca a381d5c96d Backed out changeset f6e53d1c6518 (bug 1600545) for Android build bustage. CLOSED TREE 2019-12-04 17:32:27 +02:00
Gabriele Svelto bc9290f767 Bug 1600545 - Remove useless inclusions of header files generated from IDL files in dom/ r=Ehsan 
The inclusions were removed with the following very crude script and the
resulting breakage was fixed up by hand. The manual fixups did either
revert the changes done by the script, replace a generic header with a more
specific one or replace a header with a forward declaration.

find . -name "*.idl" | grep -v web-platform | grep -v third_party | while read path; do
    interfaces=$(grep "^\(class\|interface\).*:.*" "$path" | cut -d' ' -f2)
    if [ -n "$interfaces" ]; then
        if [[ "$interfaces" == *$'\n'* ]]; then
          regexp="\("
          for i in $interfaces; do regexp="$regexp$i\|"; done
          regexp="${regexp%%\\\|}\)"
        else
          regexp="$interfaces"
        fi
        interface=$(basename "$path")
        rg -l "#include.*${interface%%.idl}.h" . | while read path2; do
            hits=$(grep -v "#include.*${interface%%.idl}.h" "$path2" | grep -c "$regexp" )
            if [ $hits -eq 0 ]; then
                echo "Removing ${interface} from ${path2}"
                grep -v "#include.*${interface%%.idl}.h" "$path2" > "$path2".tmp
                mv -f "$path2".tmp "$path2"
            fi
        done
    fi
done

Differential Revision: https://phabricator.services.mozilla.com/D55442

--HG--
extra : moz-landing-system : lando
 2019-12-04 15:01:19 +00:00
Jan Varga 6ba032116d Bug 1592934 - Refactor some storage initialization methods before adding new telemetry probes; r=ttung 
Differential Revision: https://phabricator.services.mozilla.com/D54307

--HG--
extra : moz-landing-system : lando
 2019-11-25 15:04:43 +00:00
Sebastian Hengst 0341151d63 Bug 1594981 - update Core::DOM* and Core::Storage* bugzilla product and component meta data in moz.build files after reorganization in bug 1594717. r=annevk 
Differential Revision: https://phabricator.services.mozilla.com/D52345

--HG--
extra : moz-landing-system : lando
 2019-11-08 12:17:57 +00:00
Jan Varga 547e3899d8 Bug 1589626 - LSNG: Add a check for null quota object; r=ttung 
Differential Revision: https://phabricator.services.mozilla.com/D49732

--HG--
extra : moz-landing-system : lando
 2019-10-18 14:13:37 +00:00
Jan Varga 111821c2c6 Bug 1587931 - LSNG: Force kill database actors during shutdown; r=asuth 
Database actors are force killed after 5 seconds if the child side doesn't
respond to the RequestAllowToClose message during shutdown.

Differential Revision: https://phabricator.services.mozilla.com/D48899

--HG--
extra : moz-landing-system : lando
 2019-10-11 03:03:01 +00:00
Jan Varga 458afbbe35 Bug 1586315 - LSNG: Finish RequestHelper when LSRequestChild actor is unexpectedly destroyed; r=asuth 
If LSRequestChild actor is unexpectedly destroyed, the nested event loop runs
until the timer fires. This patch improves that by calling the callback in
LSRequestChild::ActorDestroyed which immediatelly finishes RequestHelper and
finishes the nested event loop in the end too.

Differential Revision: https://phabricator.services.mozilla.com/D48194

--HG--
extra : moz-landing-system : lando
 2019-10-06 21:05:45 +00:00
Jan Varga ae7651951f Bug 1584323 - Add more object properties to IndexedDBShutdownTimeout and LocalStorageShutdownTimeout crash annotations; r=asuth, dr=chutten 
Differential Revision: https://phabricator.services.mozilla.com/D47341

--HG--
extra : moz-landing-system : lando
 2019-10-02 04:28:23 +00:00
Jan Varga 6a67dcfb67 Bug 1583019 - Cleanup PreparedDatastore only if it was added to gPreparedDatastores; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D46727

--HG--
extra : moz-landing-system : lando
 2019-09-27 04:18:23 +00:00
Jan Varga 4f4188c7ab Bug 1576260 - Make LSValue initialization fallible; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D45849

--HG--
extra : moz-landing-system : lando
 2019-09-14 05:33:01 +00:00
Jan Varga a650fac7b0 Bug 1563023 - Part 4: Get rid of custom usage tracking in LS by using client usage tracked by QM; r=asuth 
This patch gets rid of gUsages in LSNG. This provides better consistency and
makes it easier to cache quota info on disk.
The patch also fixes some edge cases when usage was not adjusted correctly after
a failed file or database operation.

Differential Revision: https://phabricator.services.mozilla.com/D38229

--HG--
extra : moz-landing-system : lando
 2019-08-23 04:46:14 +00:00
Jan Varga 0e46119bb9 Bug 1563023 - Part 3: Change client usage type to support the null value; r=asuth 
This patch wraps the uint64_t type in a Maybe container, so the client usage can
represent a state when there are no files on disk for the given client. Zero
usage then represents a state when there are some files but they are empty or
the client tracks logical size (not physical size of files on disk) and the
logical size is zero. This can be useful especially for LocalStorage.

Differential Revision: https://phabricator.services.mozilla.com/D38181

--HG--
extra : moz-landing-system : lando
 2019-08-22 20:52:09 +00:00
Jan Varga 9f906cd7c4 Bug 1563023 - Part 1: Implement per client usage tracking; r=asuth 
This patch adds a fixed-size array of client usages to OriginInfo and modifies
quota tracking APIs to require the client type to be passed in.
A new method ResetUsageForClient is implemented. The method is used during
client-specific origin clearing. ResetUsageForClient is much faster than calling
GetUsageForOrigin and calling DecreaseUsageForOrigin after that.
LockedUsage now has an assertion that verifies that the total sum of client
usages matches total origin usage. This method should be called instead of
touching mUsage directly.
A new assertion is added to GetQuotaObject which verifies that passed file
belongs to the given persistence type, origin, and client.

Differential Revision: https://phabricator.services.mozilla.com/D38028

--HG--
extra : moz-landing-system : lando
 2019-08-22 13:06:48 +00:00
Jan Varga dc66b57d8b Bug 1574569 - Don't abort LocalStorage requests when a sync message from parent is detected; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D42796

--HG--
extra : moz-landing-system : lando
 2019-08-21 20:24:00 +00:00
Nicholas Nethercote b634df9005 Bug 1573720 - Convert dom.storage.default.quota to a static pref. r=mccr8 
This one was VarCached to two different variables in two different modules.

Differential Revision: https://phabricator.services.mozilla.com/D41920

--HG--
extra : moz-landing-system : lando
 2019-08-15 05:31:38 +00:00
Nicholas Nethercote cd426e3ad2 Bug 1569526 - Remove return values from `Add*VarCache()`. r=KrisWright 
They're infallible in practice and always `NS_OK`. (This stems from
`AddVarCacheNoAssignment()` always returning `NS_OK`.)

As a result, the commit removes lots of unnecessary checks.

Differential Revision: https://phabricator.services.mozilla.com/D39804

--HG--
extra : moz-landing-system : lando
 2019-07-30 06:19:46 +00:00
Byron Campen [:bwc] 13d7ab645a Bug 1566445: Rename a couple of macros to avoid conflicts. r=ttung 
Differential Revision: https://phabricator.services.mozilla.com/D38226

--HG--
extra : moz-landing-system : lando
 2019-07-20 15:56:31 +00:00
Narcis Beleuzu 59c3fccd33 Merge inbound to mozilla-central. a=merge 2019-07-09 06:45:48 +03:00
Jonathan Kingston 31441f82ea Bug 1560455 - rename CodebasePrincipal to ContentPrincipal. r=ckerschb 
Differential Revision: https://phabricator.services.mozilla.com/D35504

--HG--
extra : moz-landing-system : lando
 2019-07-08 16:37:45 +00:00
Sylvestre Ledru 131d0c6a02 Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan 
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35622

--HG--
extra : moz-landing-system : lando
 2019-07-06 08:18:28 +00:00
Gurzau Raul 93233f439a Merge mozilla-central to inbound. a=merge CLOSED TREE 2019-07-07 01:44:47 +03:00
Jan Varga b240a41330 Bug 1562942 - Followup patch, fix a failing test; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D36934
 2019-07-04 18:26:29 +02:00
Victor Porof 0a8ff0ad85 Bug 1561435 - Format dom/, a=automatic-formatting 
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35951

--HG--
extra : source : 62f3501af4bc1c0bd1ee1977a28aee04706a6663
 2019-07-05 10:44:55 +02:00
Jan Varga 82fad8077a Bug 1542572 - Add more temporary logging to LocalStorageShutdownTimeout crash annotation; r=asuth dr=chutten 
Differential Revision: https://phabricator.services.mozilla.com/D34295
 2019-06-09 21:46:34 +02:00
Jan Varga 73bc7c8dc2 Bug 1559029 - LSNG: Connection::FlushOp::DoDatastoreWork needs to automatically rollback the transaction and detach the shadow database on an error; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D34814
 2019-06-13 04:17:52 +02:00
Razvan Maries 94dd792600 Backed out changeset 6baa1883dc72 (bug 1559029) for ES Lint failure. 2019-06-13 07:33:58 +03:00
Jan Varga a7f81b45b5 Bug 1559029 - LSNG: Connection::FlushOp::DoDatastoreWork needs to automatically rollback the transaction and detach the shadow database on an error; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D34814
 2019-06-13 04:17:52 +02:00
Jan Varga 5346f3347e Bug 1558112 - LSNG: Connection::FlushOp::DoDatastoreWork needs to automatically detach the shadow database on an error; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D34311
 2019-06-10 08:41:13 +02:00
Jan Varga e3f0977fd5 Bug 1540401 - Backout Part 1: Convert MOZ_DIAGNOSTIC_ASSERT back to MOZ_ASSERT since bug 1541972 hasn't been fixed yet; r=asuth 2019-06-07 15:11:56 +02:00
Eden Chuang 6ae5d6c65c Bug 1516333 - Part 2: Add LS unit test for uri encoding edge cases; r=janv 
Differential Revision: https://phabricator.services.mozilla.com/D33617
 2019-06-07 08:18:37 +02:00
Jan Varga d3f2beee0e Bug 1540401 - Backout Part 4: Convert MOZ_DIAGNOSTIC_ASSERT back to MOZ_ASSERT since bug 1541771 hasn't been fixed yet; r=asuth 2019-06-05 20:07:50 +02:00
Mihai Alexandru Michis 153172de0c Merge inbound to mozilla-central. a=merge 2019-06-05 12:51:25 +03:00
Jan Varga fe813f031d Bug 1534431 - Part 2: Disallow LS requests with undefined client id; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D33595
 2019-06-03 15:32:59 +02:00
Jan Varga e84d1ebb62 Bug 1534431 - Part 1: Verify LS request parameters as part of LS request state machine; r=asuth 
LS Request parameters are now verified as part of the state machine so an actor
is always created. Before this patch, we were doing verification prior to actor
creation. If the verification failed, we didn't create an actor and content
was endlessly waiting for a reply.
 2019-06-03 15:32:50 +02:00
Narcis Beleuzu 3c50127358 Merge mozilla-central to autoland. a=merge CLOSED TREE 2019-06-05 00:51:07 +03:00
Nihanth Subramanya 203396c6e0 Bug 1555562 - Make sure LocalStorageManager::PrecacheStorage() passes in the real storage principal. r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D33559

--HG--
extra : moz-landing-system : lando
 2019-06-04 21:13:40 +00:00
Jan Varga 67c1136dd9 Bug 1556217 - LSNG: Add a test for large items; r=asuth, smaug 
Differential Revision: https://phabricator.services.mozilla.com/D33417
 2019-06-02 08:00:25 +02:00
Jan Varga c6f87cb635 Bug 1540401 - Backout Part 3: Convert MOZ_DIAGNOSTIC_ASSERT back to MOZ_ASSERT since bug 1541772 hasn't been fixed yet; r=asuth 2019-06-04 09:59:11 +02:00
Jan Varga 65f92e054f Bug 1552428 - LSNG: Datastore::PrivateBrowsingClear uses wrong delta for usage updating; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D31605
 2019-05-17 10:30:19 +02:00
Razvan Maries 7afbe4a8bf Backed out changeset 01dd2842bbaa (bug 1552428) for ES Lint failure. CLOSED TREE 2019-05-31 18:07:15 +03:00
Jan Varga 673d464ca1 Bug 1552428 - LSNG: Datastore::PrivateBrowsingClear uses wrong delta for usage updating; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D31605
 2019-05-17 10:30:19 +02:00
Jan Varga 197c57d894 Bug 1546723 - Followup fix: Convert MOZ_DIAGNOSTIC_ASSERT back to MOZ_ASSERT since bug 1541775 hasn't been fixed yet; r=asuth 2019-05-30 21:34:11 +02:00
Jan Varga cce54f42f2 Bug 1546723 - Part 7: Fix ordering of items in special cases; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D31202
 2019-05-15 06:11:11 +02:00
Jan Varga f122f3cf74 Bug 1546723 - Part 6: Mark snapshot as dirty if the hasOtherProcessObservers flag changes; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D31201
 2019-05-15 06:11:11 +02:00
Jan Varga 55c0e5ec44 Bug 1546723 - Part 5: Generalize code for getting datastores; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D31200
 2019-05-15 06:11:11 +02:00
Jan Varga b5acd8a9aa Bug 1546723 - Part 4: Use a write optimizer in LSSnapshot; r=asuth 
This patch adds a write optimizer to LSSnapshot. The optimizer is only used when
there are no observers for other content processes.

Differential Revision: https://phabricator.services.mozilla.com/D31199
 2019-05-15 06:11:11 +02:00
Jan Varga 46fee7012e Bug 1546723 - Part 3: Change GetSnapshotInitInfo to deal with load info only; r=asuth 
This patch renames GetSnapshotInitInfo to GetSnapshotLoadInfo and removes some arguments that are not directly related to load info.

Differential Revision: https://phabricator.services.mozilla.com/D31198
 2019-05-15 06:11:10 +02:00
Jan Varga 70f70b482a Bug 1546723 - Part 2: Make it more clear that checkpointing also notifies observers; r=asuth 
This patch renames the Checkpoint IPC message to CheckpointAndNotify. Other structures used by checkpointing are renamed too. Datastore methods SetItem/RemoveItem/Clear no longer call NotifyObservers, it's now up to RecvCheckpointAndNotify to call it.

Differential Revision: https://phabricator.services.mozilla.com/D31197
 2019-05-15 06:11:10 +02:00
Jan Varga a74b30fb4c Bug 1546723 - Part 1: Convert WriterOptimizer to a generic reusable class; r=asuth 
This patch creates a new generic class LSWriteOptimizer which can be used with any value type for specific write optimizations either on the parent side or the child side.

Differential Revision: https://phabricator.services.mozilla.com/D31196
 2019-05-15 06:11:10 +02:00
Ehsan Akhgari 98960a9c41 Bug 1554361 - Move the high-level storage access check APIs to mozilla/StorageAccess.h; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D32556

--HG--
extra : moz-landing-system : lando
 2019-05-27 14:06:49 +00:00
Jan Varga c673cb342d Bug 1540401 - Backout Part 2: Convert MOZ_DIAGNOSTIC_ASSERT back to MOZ_ASSERT since bug 1541775 hasn't been fixed yet; r=asuth 2019-05-23 10:26:20 +02:00
Dorel Luca 60706fc799 Merge mozilla-inbound to mozilla-central. a=merge 2019-05-18 13:25:28 +03:00
Gurzau Raul bc953c3503 Merge mozilla-central to autoland. a=merge CLOSED TREE 2019-05-18 00:46:18 +03:00
Tom Tung a3f0aa60d4 Bug 1514600 - P1 - Notify LS to cleanup the gUsages while storage initialization fails; r=janv 
Differential Revision: https://phabricator.services.mozilla.com/D27502

--HG--
extra : moz-landing-system : lando
 2019-04-29 10:49:58 +00:00
Jan Varga 869d5c854a Bug 1548847 - Invalidate LSDatabase xpcom-shutdown observer after removing it from the observer service; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D31293
 2019-05-15 19:35:22 +02:00
Jan Varga 8c9f766a02 Bug 1540401 - Part 4: Convert MOZ_ASSERT to MOZ_DIAGNOSTIC_ASSERT to verify that bug 1541771 has been fixed; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D27494
 2019-04-15 13:55:42 +02:00
Jan Varga e8e655e076 Bug 1540401 - Part 3: Convert MOZ_ASSERT to MOZ_DIAGNOSTIC_ASSERT to verify that bug 1541772 has been fixed; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D27493
 2019-04-15 13:52:08 +02:00
Andrea Marchesini 99cbfe545e Bug 1551055 - StoragePrincipal should be supported by localStorage - part 3 - Validate storagePrincipal, r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D30947

--HG--
extra : moz-landing-system : lando
 2019-05-14 05:49:58 +00:00
Andrea Marchesini dc7545548e Bug 1551055 - StoragePrincipal should be supported by localStorage - part 1, r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D30801

--HG--
extra : moz-landing-system : lando
 2019-05-14 05:49:46 +00:00
Ciure Andrei f1dd75ca22 Backed out 3 changesets (bug 1551055) for causing xpcshell localStorage perma failures CLOSED TREE 
Backed out changeset 21e44ad9c6df (bug 1551055)
Backed out changeset 8727e61ab69b (bug 1551055)
Backed out changeset d99a6769beb4 (bug 1551055)

--HG--
extra : rebase_source : 56f7fe5c54cd7e4109acce5074be1aba12e91086
 2019-05-13 22:40:22 +03:00
Andrea Marchesini 1b54d6f1cd Bug 1551055 - StoragePrincipal should be supported by localStorage - part 3 - Validate storagePrincipal, r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D30947

--HG--
extra : moz-landing-system : lando
 2019-05-13 18:45:12 +00:00
Andrea Marchesini e1b74991fb Bug 1551055 - StoragePrincipal should be supported by localStorage - part 1, r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D30801

--HG--
extra : moz-landing-system : lando
 2019-05-13 18:42:36 +00:00
Jan Varga eef773ad6c Bug 1549654 - LSNG: Compress specific values during migration; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D30181
 2019-05-07 12:54:02 +02:00
Jan Varga e25844ad71 Bug 1548788 - LSNG: Datastore preparation doesn't have to create new origin directories if they don't exist; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D29822
 2019-05-03 15:03:54 +02:00
Jan Varga ea67826b85 Bug 1547688 - LSNG: Preloading can use gUsages hash table to quickly finish if there's nothing to preload; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D29194
 2019-04-29 14:23:55 +02:00
Jan Varga c260fbaf28 Bug 1540777 - LSNG: Move creation of empty databases to the connection thread; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D29134
 2019-04-29 04:42:37 +02:00
Jan Varga 2ffbce35b7 Bug 1513937 - LSNG: Compress specific values; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D29140
 2019-04-29 06:10:42 +02:00
Jan Varga 6360443a3b Bug 1546310 - LSNG: Parent process should store values in UTF8; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D29139
 2019-04-29 06:09:42 +02:00
Jan Varga d3494ff018 Bug 1547454 - LSNG: Create a new C++ class for local storage values; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D29138
 2019-04-29 06:05:56 +02:00
Jan Varga 0ef08f3c51 Bug 1547452 - LSNG: Refactor Datastore::GetSnapshotInitInfo using a switch statement; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D29137
 2019-04-29 06:05:55 +02:00
Jan Varga d7c902c239 Bug 1542669 - LSNG: GetItem, SetItem, RemoveItem should pass the key when creating a new snapsot; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D29136
 2019-04-09 06:18:29 +02:00
Ryan VanderMeulen 4f044a29d2 Backed out 8 changesets (bug 1513937, bug 1546310, bug 1548788, bug 1547688, bug 1547452, bug 1540777, bug 1542669, bug 1547454) for causing bug 1549362. 
Backed out changeset 8dca7df29492 (bug 1548788)
Backed out changeset 688f361e8bb6 (bug 1547688)
Backed out changeset b5d8d57838a3 (bug 1540777)
Backed out changeset d1bd31177b14 (bug 1513937)
Backed out changeset df97dfbb526a (bug 1546310)
Backed out changeset ade08d6dc361 (bug 1547454)
Backed out changeset b622431054b7 (bug 1547452)
Backed out changeset ad73e5604411 (bug 1542669)
 2019-05-06 09:02:54 -04:00
Jan Varga 2820fe9cc8 Bug 1548788 - LSNG: Datastore preparation doesn't have to create new origin directories if they don't exist; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D29822
 2019-05-03 15:03:54 +02:00
Jan Varga 0d5ae59a7b Bug 1547688 - LSNG: Preloading can use gUsages hash table to quickly finish if there's nothing to preload; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D29194
 2019-04-29 14:23:55 +02:00
Jan Varga f961342025 Bug 1540777 - LSNG: Move creation of empty databases to the connection thread; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D29134
 2019-04-29 04:42:37 +02:00
Jan Varga 12fd20045f Bug 1513937 - LSNG: Compress specific values; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D29140
 2019-04-29 06:10:42 +02:00
Jan Varga 120ed0037a Bug 1546310 - LSNG: Parent process should store values in UTF8; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D29139
 2019-04-29 06:09:42 +02:00
Jan Varga f482d3216d Bug 1547454 - LSNG: Create a new C++ class for local storage values; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D29138
 2019-04-29 06:05:56 +02:00
Jan Varga 55c70603a2 Bug 1547452 - LSNG: Refactor Datastore::GetSnapshotInitInfo using a switch statement; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D29137
 2019-04-29 06:05:55 +02:00
Jan Varga 128af24b07 Bug 1542669 - LSNG: GetItem, SetItem, RemoveItem should pass the key when creating a new snapsot; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D29136
 2019-04-09 06:18:29 +02:00
Jan Varga 827b401e30 Bug 1513915 - Followup patch to increase requesttimeoutfactor for test_snapshotting.js; r=asuth 2019-05-03 18:10:11 +02:00
Jan Varga 864dcf0703 Bug 1513915 - LSNG: LoadItem could return more items (up to the prefill limit); r=asuth,jld 
Differential Revision: https://phabricator.services.mozilla.com/D26476
 2019-04-08 10:56:19 +02:00
Jan Varga 478be0531a Bug 1540401 - Part 2: Convert MOZ_ASSERT to MOZ_DIAGNOSTIC_ASSERT to verify that bug 1541775 has been fixed; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D27492
 2019-04-15 13:49:35 +02:00
Jan Varga 1a8201461c Bug 1540401 - Part 1: Convert MOZ_ASSERT to MOZ_DIAGNOSTIC_ASSERT to verify that bug 1541972 has been fixed; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D27491
 2019-04-15 13:46:06 +02:00
Jan Varga 4d4622f55f Bug 1546305 - LSNG: Add temporary support for downgrading; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D28800
 2019-04-25 11:25:52 +02:00
Jan Varga bb200f7d87 Bug 1541771 - LSNG: Don't cache usage in InitOrigin if it's not for temporary storage initialization; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D27490
 2019-04-15 13:35:38 +02:00
Jan Varga f968189930 Bug 1535221 - Dead lock with a11y's mscom and mozilla::dom::LSObject; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D27463
 2019-04-15 05:04:02 +02:00
Jan Varga d50956f778 Bug 1542706 - LSNG: Don't close database if there's a snapshot registered; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D27437
 2019-04-13 17:59:55 +02:00
Jan Varga 8120eb21d7 Backout Bug 1540401 - Part 1: Convert MOZ_ASSERT to MOZ_DIAGNOSTIC_ASSERT to verify that bug 1541972 has been fixed; r=asuth 2019-04-16 20:05:49 +02:00
Jan Varga 91e4dfb638 Bug 1540401 - Part 1: Convert MOZ_ASSERT to MOZ_DIAGNOSTIC_ASSERT to verify that bug 1541972 has been fixed; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D27491
 2019-04-15 13:46:06 +02:00
Jan Varga 31b9a4462c Bug 1542155 - LSNG: Convert MOZ_ALWAYS_TRUE(SendFinish()) to MOZ_DIAGNOSTIC_ALWAYS_TRUE(SendFinish()); r=asuth 2019-04-05 16:46:59 +02:00
Jan Varga 2927a7377f Bug 1543209 - LSNG: Detect missing unregister calls for live datastores using CheckedUnsafePtr; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D26826
 2019-04-09 23:56:17 +02:00
Jan Varga 06dba23590 Bug 1542475 - LSNG: Potential double closing of datastores; r=asuth 2019-04-06 12:23:14 +02:00
Yaron Tausky e8af6c032a Bug 1539538 - Introduce UnsafePtr r=froydnj,janv 
This commit adds a smart pointer class that verifies that no dangling
pointers remain after the pointee went out of scope. This verification is
opt-in and can be controlled both statically and dynamically by the pointee.

Differential Revision: https://phabricator.services.mozilla.com/D25200

--HG--
extra : moz-landing-system : lando
 2019-04-09 14:41:57 +00:00
Sylvestre Ledru 03fc65347c Bug 1542146 - Apply the change with the option StatementMacros from clang-format-8 r=andi 
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D26280

--HG--
extra : moz-landing-system : lando
 2019-04-05 21:42:17 +00:00
Jan Varga caa68dc186 Bug 1542104 - LSNG: Incorrect usage calculation of archived data; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D26269
 2019-04-05 06:15:21 +02:00
Jan Varga 4286c73927 Bug 1540381 - LSNG: Result of SendRequestAllowToClose call is not checked; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D25703
 2019-04-02 05:44:56 +02:00
Ciure Andrei 4116e08315 Merge inbound to mozilla-central. a=merge 2019-04-04 07:34:14 +03:00
Ciure Andrei ec1fe36f87 Backed out changeset 97d88752079f (bug 1540401) for causing a nightly startup crash a=backout 2019-04-04 04:45:08 +03:00
Daniel Varga f89113118b Merge mozilla-central to mozilla-inbound. a=merge 2019-04-03 09:18:15 +03:00
Daniel Varga 14dc5b7d8a Merge mozilla-inbound to mozilla-central. a=merge 2019-04-03 09:05:41 +03:00
Gerald Squelart e2d15a1cfb Bug 1429613 - Variant matcher callbacks renamed from `match` to `operator()` - r=froydnj 
Mechanical change from Matcher::match(...) to Matcher::operator()(...).
This will now permit the use of generic lambdas, and facilitate the
implementation of multi-lambda match.

Differential Revision: https://phabricator.services.mozilla.com/D24889

--HG--
extra : moz-landing-system : lando
 2019-04-02 11:53:47 +00:00
Jan Varga 8838c839de Bug 1540401 - LSNG: Convert most of MOZ_ASSERT to MOZ_DIAGNOSTIC_ASSERT; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D25549
 2019-04-01 01:18:10 +02:00
Jan Varga 78e96d22bc Bug 1540189 - LSNG: Result of SendReady call is not checked; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D25423
 2019-03-29 17:58:46 +01:00
Eden Chuang 72b79c6fbd Bug 1442778 - Add "chromeContext" parameter to console API and console service messages. r=smaug 
1. Adding a new attribute chromeContext in ConsoleEvent
2. Adding a new boolean attribute isFromChromeContext in nsIConsoleMessage
3. Sending IsFromChromeContext to the parent process

Differential Revision: https://phabricator.services.mozilla.com/D23330

--HG--
extra : moz-landing-system : lando
 2019-04-01 22:42:34 +00:00
Mark Banner dba6983e75 Bug 1415265 - Remove now unnecessary .eslintrc.js files or entries. r=mossop 
Differential Revision: https://phabricator.services.mozilla.com/D23850

--HG--
extra : moz-landing-system : lando
 2019-03-28 09:38:14 +00:00
Cosmin Sabou 78fc71e3c3 Backed out changeset 7fa7d6e6dedc (bug 1442778) for devtools failures on browser_webconsole_check_stubs_console_api.js CLOSED TREE 2019-03-26 20:27:55 +02:00
Csoregi Natalia 888d83038c Merge mozilla-central to autoland. CLOSED TREE 2019-03-26 19:45:08 +02:00
Eden Chuang 5e4df764d9 Bug 1442778 - Add "chromeContext" parameter to console API and console service messages. r=smaug 
1. Adding a new attribute chromeContext in ConsoleEvent
2. Adding a new boolean attribute isFromChromeContext in nsIConsoleMessage
3. Sending IsFromChromeContext to the parent process

Differential Revision: https://phabricator.services.mozilla.com/D23330

--HG--
extra : moz-landing-system : lando
 2019-03-26 15:18:20 +00:00
Ian Moody fe4fab15e3 Bug 1537776 - dom/ automated ESLint no-throw-literal fixes. r=asuth,mccr8 
Result of running:
$ mach eslint -funix dom/ | sed -Ee 's/:.+//' - | xargs sed -E \
    -e 's/throw ((["`])[^"]+\2);/throw new Error(\1);/g' \
    -e 's/throw ((["`])[^"]+\2 \+ [^ ";]+);/throw new Error(\1);/g' \
    -e 's/throw \(/throw new Error(/g' -i

Differential Revision: https://phabricator.services.mozilla.com/D24369

--HG--
extra : moz-landing-system : lando
 2019-03-25 16:03:38 +00:00
Jan Varga 44461f8eff Bug 1535221 - Add more robust logging including more detailed logging for CheckClosingDatastore and DirectoryOpenPending state; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D24423
 2019-03-21 21:08:00 +01:00
Gurzau Raul b9149db16e Merge mozilla-central to inbound. a=merge CLOSED TREE 2019-03-26 11:56:14 +02:00
Jan Varga 8eef834961 Bug 1533789 - LSRequestBase::Finish is not called in some edge cases; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D24649
 2019-03-24 15:02:05 +01:00
Jan Varga 1ce29b4c3b Bug 1535221 - Add infrastructure for hang debugging; r=asuth 
This patch adds a timer for synchronous local storage requests. Once the timer
fires the request is canceled. The parent reports debugging information upon receiving cancellation.

Differential Revision: https://phabricator.services.mozilla.com/D24006
 2019-03-19 12:23:16 +01:00
Jan Varga 1678e32e36 Bug 1535995 - Quick followup patch to fix an ESlint failure; r=asuth 2019-03-18 18:12:09 +01:00
Jan Varga 9db88adebf Bug 1535995 - Check that group information is up to date; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D23822
 2019-03-18 07:14:26 +01:00
Sebastian Hengst 78d58dd656 Bug 1535619 - add meta information to create bugs for files in dom/localstorage/ in 'Core :: DOM: Web Storage' r=janv 
Differential Revision: https://phabricator.services.mozilla.com/D23670

--HG--
extra : moz-landing-system : lando
 2019-03-15 14:01:58 +00:00
Sylvestre Ledru 4aa92e3091 Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan 
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D22514
 2019-03-13 10:19:06 +01:00
Jan Varga 559e8234e4 Bug 1534208 - LSNG: DOM File thread and PBackground child for it must be created as soon as possible; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D22976
 2019-03-11 15:35:04 +01:00
Jan Varga 8b4670b550 Bug 1533541 - dom/localstorage/test/unit/test_groupLimit.js fails with LSNG enabled; r=asuth 
Reviewers: asuth

Reviewed By: asuth

Bug #: 1533541

Differential Revision: https://phabricator.services.mozilla.com/D22599

--HG--
extra : rebase_source : fd352191fec915b68bb9161e1de7c89a0522be52
 2019-03-07 20:46:46 -05:00
Jan Varga c2058d3bc4 Bug 1526891 - Part 10: Fix a content process leak by closing databases at xpcom-shutdown; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D20919
 2019-02-23 17:19:35 +01:00
Jan Varga 6b68f4dc07 Bug 1526891 - Part 5: Allow calling NextGenLocalStorageEnabled on any thread in the parent process; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D20914
 2019-02-23 17:06:40 +01:00
Jan Varga ea4f36b735 Bug 1526615 - Part 3: Avoid main thread during origin clearing; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D19284
 2019-02-10 10:20:14 +01:00
Jan Varga 62cb092a89 Bug 1526615 - Part 2: Implement GenerateOriginKey2 which can be used on any thread; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D19283
 2019-02-10 10:20:12 +01:00
Jan Varga 1ee1cd1c2d Bug 1517089 - Part 17: Avoid main thread during LSRequestBase/LSSimpleRequestBase processing; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D19214
 2019-02-08 21:02:28 +01:00
Jan Varga f150c82b06 Bug 1517089 - Part 14: Use ClientManagerService for client validation; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D19208
 2019-02-08 21:02:14 +01:00
Jan Varga 2e11851013 Bug 1517089 - Part 13: Use separate IPC params and response for datastore preloading; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D19207
 2019-02-08 21:02:11 +01:00
Jan Varga 993ecafb04 Bug 1517089 - Part 11: Verify principalInfo before creating any parent actors; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D19205
 2019-02-08 21:02:03 +01:00
Jan Varga 7fa5c4663a Bug 1517089 - Part 7: Pass originKey through IPC and get privateBrowsingId directly from ContentPrincipalInfo; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D19201
 2019-02-08 21:01:31 +01:00
Yaron Tausky 43054fe975 Bug 1516277 - Add local execution mode to nsThread r=janv,froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D21241

--HG--
extra : moz-landing-system : lando
 2019-03-06 16:26:07 +00:00
Gurzau Raul d5392415e2 Backed out changeset 44d83d32e254 (bug 1516277) for failing at /test/unit/test_eviction.js on a CLOSED TREE. 2019-03-06 17:50:28 +02:00
Yaron Tausky 3aa9896ebc Bug 1516277 - Add local execution mode to nsThread r=janv,froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D21241

--HG--
extra : moz-landing-system : lando
 2019-03-06 13:53:16 +00:00
Boris Zbarsky 9c5da5f234 Bug 1489308 part 9. Remove now-unused wyciwyg bits. r=mccr8 
Differential Revision: https://phabricator.services.mozilla.com/D17327

--HG--
rename : dom/html/test/browser_refresh_wyciwyg_url.js => dom/html/test/browser_refresh_after_document_write.js
rename : dom/html/test/file_refresh_wyciwyg_url.html => dom/html/test/file_refresh_after_document_write.html
extra : moz-landing-system : lando
 2019-02-28 01:09:48 +00:00
Sylvestre Ledru 41d1d79094 Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan 
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D19663

--HG--
extra : moz-landing-system : lando
 2019-02-15 08:15:57 +00:00
Jan Varga 38f8064388 Bug 1517089 - Part 6: Use BackgroundParent::GetChildID (which doesn't need releasing content parent on the main thread) for getting content parent id; r=asuth 2019-02-07 19:51:27 +01:00
Jan Varga 5302b36c41 Bug 1517089 - Part 5: Move storage service initialization to InitializeLocalStorage; r=asuth 2019-02-07 19:51:22 +01:00
Jan Varga 01b23e7ba8 Bug 1517089 - Part 4: Send an async IPC message instead of dispatching a runnable to the PBackground thread when clearing private browsing; r=asuth 2019-02-07 19:51:16 +01:00
Jan Varga f0a5d09ef7 Bug 1517089 - Part 3: Move observer registration to InitializeLocalStorage; r=asuth 2019-02-07 19:51:12 +01:00
Jan Varga ed1d36b2c0 Bug 1517089 - Part 2: Move pref initialization to InitializeLocalStorage; r=asuth 2019-02-07 19:51:07 +01:00
Jan Varga 913fd9266d Bug 1517089 - Part 1: Introduce InitializeLocalStorage and call it in nsLayoutStatics::Initialize; r=asuth 2019-02-07 19:50:57 +01:00
Jan Varga d0270542f0 Bug 1525291 - LSNG: Chrome observer notifications for session storage are not distributed to content processes; r=asuth,froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D18809
 2019-02-06 06:09:57 +01:00
Oana Pop Rus f9cf535efc Backed out changeset 04eecadabb48 (bug 1525291) for build bustages at build/src/obj-firefox/ipc/ipdl/PSessionStorageObserverChild.cpp on a CLOSED TREE 2019-02-07 11:33:00 +02:00
Jan Varga 93f5a88427 Bug 1525291 - LSNG: Chrome observer notifications for session storage are not distributed to content processes; r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D18809
 2019-02-06 06:09:57 +01:00
Kris Maglione e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API. 
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
 2019-01-17 10:18:31 -08:00
Ehsan Akhgari e5e885ae31 Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre 
# ignore-this-changeset

--HG--
extra : amend_source : 7221c8d15a765df71171099468e7c7faa648f37c
extra : histedit_source : a0cce6015636202bff09e35a13f72e03257a7695
 2019-01-18 10:16:18 +01:00
Tom Tung a4b7f90f3f Bug 1436188 - Add telemetry probes to collect the number of failures during the QuotaManager initialization; r=asuth, data-review=chutten 
This patch uses categorical keyed Historgram to collect data. While the key is
used to determine whether is it an external error or an internal error (Note:
the external error is referred to low level failure, for example: database
corrupt, OS API errors, ... etc; the internal error is referred to errors, like:
not handle file properly, unexpected filenames, ... etc), the labels for
categorical indicates where the error happens.
Furthermore, this patch make QuotaManager keep traversing the profile even if
an error happens so that we can get more information in the telemetry data.
Please note that these things should only happen in the Nightly Channel.

Differential Revision: https://phabricator.services.mozilla.com/D15908

--HG--
extra : moz-landing-system : lando
 2019-01-17 17:12:27 +00:00
Emilio Cobos Álvarez d2ed260822 Bug 1517241 - Rename nsIDocument to mozilla::dom::Document. r=smaug 
Summary: Really sorry for the size of the patch. It's mostly automatic
s/nsIDocument/Document/ but I had to fix up in a bunch of places manually to
add the right namespacing and such.

Overall it's not a very interesting patch I think.

nsDocument.cpp turns into Document.cpp, nsIDocument.h into Document.h and
nsIDocumentInlines.h into DocumentInlines.h.

I also changed a bunch of nsCOMPtr usage to RefPtr, but not all of it.

While fixing up some of the bits I also removed some unneeded OwnerDoc() null
checks and such, but I didn't do anything riskier than that.
 2019-01-03 17:48:33 +01:00
Sylvestre Ledru cccdda3c2a Bug 1516555 - Reformat everything to the Google coding style r=Ehsan 
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D15426

--HG--
extra : moz-landing-system : lando
 2018-12-28 15:48:06 +00:00
Gurzau Raul 55697e5bce Merge inbound to mozilla-central. a=merge 2018-12-21 18:36:36 +02:00
Mark Banner 925ccf2751 Bug 1515605 - Enable ESLint for dom/localstorage (manual changes). r=janv 
Differential Revision: https://phabricator.services.mozilla.com/D15073

--HG--
extra : moz-landing-system : lando
 2018-12-21 10:13:00 +00:00
Mark Banner e802d90ab3 Bug 1515605 - Enable ESLint for dom/localstorage (automatic changes). r=janv 
Differential Revision: https://phabricator.services.mozilla.com/D15072

--HG--
extra : moz-landing-system : lando
 2018-12-21 10:12:45 +00:00
Jan Varga 9f045e03d5 Bug 1513892 - Part 2: Cache usage in a standalone file; r=asuth 
This patch significantly speedups origin initialization by having a special file
for current data usage.
 2018-12-21 06:26:36 +01:00
Jan Varga 630b46cb1d Bug 1513892 - Part 1: Cache usage in the database table; r=asuth 
This patch slightly speedups origin initialization by having a special column in
the database table for current data usage.
This patch also fixes a problem with length computation of some unicode strings.
 2018-12-21 06:26:25 +01:00
Narcis Beleuzu 7cfde3000c Merge inbound to mozilla-central. a=merge 2018-12-20 23:56:42 +02:00
Jan Varga 2e452b2b07 Bug 1505798 - The used storage space for saved cookies,site data, cache displayed in about:preferences is abnormal after enabling NextGen Storage; r=asuth 
This patch fixes an oversight when an important hashtable lookup was only done
in debug builds.
 2018-12-20 19:20:36 +01:00
Alex Gaynor 55e3f21b2b Bug 1515437 - mark several IPC methods as final; r=froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D15011

--HG--
extra : moz-landing-system : lando
 2018-12-19 21:46:49 +00:00
Jan Varga 849998a8e0 Bug 1513859 - CPOWs can still cause a hang with LSNG enabled; r=asuth 2018-12-19 12:38:23 +01:00
Jan Varga f561d97124 Bug 1513892 - Followup for Part 2; r=asuth 
Add a comment about not being able to read 64-bit integers.
 2018-12-21 06:39:45 +01:00
Sylvestre Ledru 265e672179 Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 
# ignore-this-changeset

--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
 2018-11-30 11:46:48 +01:00
Andrew Sutherland 6c6e230a77 Bug 1286798 - Part 53: Review code comments; r=janv,mrbkap,mccr8 2018-11-05 14:04:39 -05:00
Jan Varga 35d317c919 Bug 1286798 - Part 52: Rework tests to use async functions; r=asuth 2018-11-29 21:50:01 +01:00
Jan Varga 4220031bba Bug 1286798 - Part 51: Add tests for archive and shadow database clearing; r=asuth 2018-11-29 21:49:58 +01:00
Jan Varga ccca35f7f3 Bug 1286798 - Part 50: Add support for clearing of the archive and shadow database; r=asuth 2018-11-29 21:49:55 +01:00
Jan Varga 03fc857fab Bug 1286798 - Part 46: Add a pref for database shadowing; r=asuth 2018-11-29 21:49:43 +01:00
Jan Varga 3f301fd6c0 Bug 1286798 - Part 45: Delay flushing to disk using a timer; r=asuth 
This improves performance even more by grouping database operations from multiple checkpoints and possibly from multiple processes.
 2018-11-29 21:49:40 +01:00
Jan Varga cf023d79b4 Bug 1286798 - Part 44: Switch Connection to use WriteOptimizer too; r=asuth 
This eliminates some code duplication.
 2018-11-29 21:49:37 +01:00
Jan Varga 1e027be676 Bug 1286798 - Part 43: Coalesce database operations before they are applied to disk; r=asuth 
This avoids persistence to disk in many cases since sites aften do setItem/removeItem for the same key in one JS function.
 2018-11-29 21:49:34 +01:00
Jan Varga 3177670987 Bug 1286798 - Part 42: Implement snapshot reusing; r=asuth 
This improves performance by keeping snapshots around for some time if there are no changes done by other processes. If a snapshot is not destroyed immediately after getting into the stable state then there's a chance that it won't have to be synchronously created again when a new opeartion is requested.
 2018-11-29 21:49:31 +01:00
Jan Varga 150cf2ce62 Bug 1286798 - Part 41: Implement QuotaClient::AbortOperationsForProcess; r=asuth 
Needed for snapshot reusing.
 2018-11-29 21:49:27 +01:00
Jan Varga 8d2b3b583d Bug 1286798 - Part 39: Reduce number of hash lookups; r=asuth 2018-11-29 21:49:20 +01:00
Jan Varga f2c1577652 Bug 1286798 - Part 38: Cache items in an array; r=asuth 
Items are now cached also in an array (besides a hashtable). This gives us very fast snapshot initizilization for datastores that fit into the prefill limit. String buffers are reference counted, so memory footprint is only affected by the size of nsString.
This patch also introduces a WriteOptimizer which is an abstraction for collecting, coalescing and applying write operations.
 2018-11-29 21:49:17 +01:00
Jan Varga 05662ca09e Bug 1286798 - Part 37: Always preallocate quota when initializing a snapshot; r=asuth 
Besides always preallocating quota we now also preallocate more. This mitigates number of additional sync calls.
 2018-11-29 21:49:14 +01:00
Jan Varga 5809f14bbd Bug 1286798 - Part 36: Allow snapshot initialization to a specific load state; r=asuth 
Before this patch, it was only possible to initialize a snapshot to the Partial state or AllOrderedItems state. Now there's a third state AllOrderedKeys.
This improves performance by eliminating sync calls to parent process when we know nothing about a key in content process (in that case we have to use a sync call to the parent process to see if there's a value for it).
With this patch we always try to send all keys to content when a snapshot is being initialized. For this to work efficiently, we cache the size of all keys.
Having cached size of all keys also allows us to just iterate the mValues hashtable when the size of keys is bigger than snapshot prefill threshold (instead of iterating over the mKeys array and joining with mValues for each particular key).
There's some additional cleanup in snapshot info construction and Datastore::SetItem/RemoveItem/Clear methods.
 2018-11-29 21:49:10 +01:00
Jan Varga ec6ab2e194 Bug 1286798 - Part 35: Implement database shadowing; r=asuth,janv 
This adds synchronization to the global database used by previous local storage implementation.

This patch was enhanced by asuth to bind attached database path.
Places has shown that argument binding is necessary.  (Profiles may include usernames in their path which can have cool emoji and such.)
 2018-11-29 21:49:07 +01:00
Jan Varga 4afa59b9c8 Bug 1286798 - Part 34: Queue database operations until update batch ends; r=asuth 
This avoids dispatching to the connection thread for every database operation and paves a way for database shadowing.
 2018-11-29 21:49:04 +01:00
Jan Varga 06d1c01932 Bug 1286798 - Part 33: Restrict localStorage from being available on some pages; r=asuth 
This matches the old implementation. localStorage shouldn't be available on some pages, for example about:home.
 2018-11-29 21:49:01 +01:00
Jan Varga d87888fe25 Bug 1286798 - Part 31: Support for lazy loading of items; r=asuth,mrbkap,mccr8 
There's now an upper limit for snapshot prefilling. The value is configurable and is currently set to 4096 bytes.
Snapshots can operate in multiple modes depending on if all items have been loaded or all keys have been received. This should provide the best performance for each specific state.
This patch also adds support for creating explicit snapshots which can be used for testing.
 2018-11-29 21:48:54 +01:00
Jan Varga 34cd5113f1 Bug 1286798 - Part 30: Preserve key order when sending items to a content process; r=asuth 
Keys needs to be redundantly stored in an array, so we can construct identical hashtable of values in a content process.
 2018-11-29 21:48:51 +01:00
Jan Varga c4f55013cf Bug 1286798 - Part 29: Implement implicit snapshotting of databases; r=asuth,mccr8 
This improves performance a lot in cases when multiple operations are invoked by a single JS function (number of sync IPC calls is reduced to a minimum). It also improves correctness since changes are not visible to other content processes until a JS function finishes.
The patch implements core infrastructure, all items are sent to content when a snapshot is initialized and everything is fully working. However, sending of all items at once is not optimal for bigger databases. Support for lazy loading of items is implemented in a following patch.
 2018-11-29 21:48:47 +01:00
Jan Varga 54be9b7307 Bug 1286798 - Part 28: Add more QuotaClient::IsShuttingDownOnBackgroundThread() and MayProceed() checks; r=asuth 
The shutdown and actor destroyed flag is now checked after each dispatch.
 2018-11-29 21:48:44 +01:00
Jan Varga 1812608353 Bug 1286798 - Part 27: Share database actors; r=asuth 
If a database actor already exists for given origin, reuse it instead of creating a new one. This improves memory footprint a bit and also eliminates some round trips to the parent process.
 2018-11-29 21:48:41 +01:00
Jan Varga 0649224345 Bug 1286798 - Part 26: Implement a lazy data migration from old webappsstore.sqlite; r=asuth,janv 
This patch was enhanced by asuth to bind attached database path.
Places has shown that argument binding is necessary.  (Profiles may include usernames in their path which can have cool emoji and such.)
 2018-11-29 21:48:38 +01:00
Jan Varga 7981be440b Bug 1286798 - Part 25: Add checks for the group and global limit; r=asuth 2018-11-29 21:48:34 +01:00
Jan Varga 6e40a9dccb Bug 1286798 - Part 22: Add support for preloading of datastores; r=asuth 
Datastores are preloaded only for content principals. The preloading is triggered as soon as possible to lower the chance of blocking the main thread in content process. If there is no physical database on disk for given origin, datastore is not created. Preloaded datastores are kept alive for 20 seconds.
 2018-11-29 21:48:25 +01:00
Jan Varga d015b67aae Bug 1286798 - Part 20: Add checks for the 5 MB origin limit; r=asuth 
The 5 MB limit is no longer applied to the whole group (eTLD+1). That will be controlled by quota manager.
 2018-11-29 21:48:19 +01:00