Use ReconstructFrame | (any ther bits needed) to replace
NS_STYLE_HINT_FRAMECHANGE in nsStyle*::MaxDifference.
For those nsStyle* that do not have nsChangeHint_NeutralChange in their
CalcDifference, we should be able to elimate nsChangeHint_NeutralChange from
their MaxDifference as well.
MozReview-Commit-ID: B3VJWt6gKoL
--HG--
extra : rebase_source : d0deff5bb579438c33b7b3288fc76d8b0420e1af
Replace NS_STYLE_HINT_FRAMECHANGE with nsChangeHint_ReconstructFrame in
nsStyle*::CalcDifference.
MozReview-Commit-ID: 85WPCyYolal
--HG--
extra : rebase_source : 7eb5f6528268001108b11dab7c00252714ca738d
The comment for nsChangeHint_ReconstructFrame is out-of-date.
In RestyleManager::ProcessRestyledFrames, we actually ignore all of the other
hints if ReconstructFrame is set. The old version was written when
ReconstructFrame was listed last. So, update the comment.
MozReview-Commit-ID: 97wMrW6S6ID
--HG--
extra : rebase_source : d76815f8cadd7ddc6babc65e24d197717269625f
According to our coding style guide, we should always brace controlled
statements, even a single-line consequent of an if-else-statement. It avoids
dangling else bugs.
MozReview-Commit-ID: FT1AR5MqOGw
--HG--
extra : rebase_source : f864e6f66c28e92574fb316a686e2d6d8fcb78e3
Use ReconstructFrame to replace NS_STYLE_HINT_FRAMECHANGE in many places, such
as HTML*Element::GetAttributeChangeHint and HTMLFrameSetElement::SetAttr.
MozReview-Commit-ID: EHbc4RMeuu0
--HG--
extra : rebase_source : f5163608c88362595ef5af5fcd36fa64c9c79ce7
Use ReconstructFrame | (any ther bits needed) to replace
NS_STYLE_HINT_FRAMECHANGE in nsStyle*::MaxDifference.
For those nsStyle* that do not have nsChangeHint_NeutralChange in their
CalcDifference, we should be able to elimate nsChangeHint_NeutralChange from
their MaxDifference as well.
MozReview-Commit-ID: B3VJWt6gKoL
--HG--
extra : rebase_source : 7b568b680be4ea108b08cc565f1651ded70d357d
Replace NS_STYLE_HINT_FRAMECHANGE with nsChangeHint_ReconstructFrame in
nsStyle*::CalcDifference.
MozReview-Commit-ID: 85WPCyYolal
--HG--
extra : rebase_source : 3a5e247fe38e0b75d9ea1826ce5758b5a5862675
The comment for nsChangeHint_ReconstructFrame is out-of-date.
In RestyleManager::ProcessRestyledFrames, we actually ignore all of the other
hints if ReconstructFrame is set. The old version was written when
ReconstructFrame was listed last. So, update the comment.
MozReview-Commit-ID: 97wMrW6S6ID
--HG--
extra : rebase_source : f1556012073e088af96c2e389532f1ae04b165af
According to our coding style guide, we should always brace controlled
statements, even a single-line consequent of an if-else-statement. It avoids
dangling else bugs.
MozReview-Commit-ID: FT1AR5MqOGw
--HG--
extra : rebase_source : 111b4f70c83a59ee7dab8bf8adf60bc10916cc79
EnsureAudioDecodeTaskQueued() is called from several places where
mReader->IsWaitingAudioData() can be proven to be false:
1. OnAudioDecoded() - definitely false.
2. OnNotDecoded() - false because aReason is MediaDecoderReader::CANCELED.
3. OnSeekResolved() - false becuase we haven't requested any samples.
4. SetCallbacks() - false because AudioWaitCallback is resolved.
MozReview-Commit-ID: 8ppYIQQw0uK
--HG--
extra : rebase_source : 721ab44f6c23b87edfbe6d132fca9d85ca468368
We need to request another audio sample in OnAudioDecoded() only when
mDoneAudioSeeking is false which also applies OnVideoDecodd().
Therefore we remove calls to Ensure{Audio,Video}DecodeTaskQueued()
from CheckIfSeekComplete() to prevent requesting video samples inside
OnAudioDecoded() for they will be handled by OnVideoDecodd().
This also allows us to remove checking of mReader->IsRequesting{Audio,Video}Data()
from Ensure{Audio,Video}DecodeTaskQueued().
MozReview-Commit-ID: LpXjiacp0D9
--HG--
extra : rebase_source : 14d2b2de81ec386a50e26fd75ac2b1087d2950b5
Ensure{Audio,Video}DecodeTaskQueued() is always called after OnSeekResolved()
where mSeekRequest is completed. So |mSeekRequest.Exists()| should be always
false in Ensure{Audio,Video}DecodeTaskQueued().
MozReview-Commit-ID: Jd1q7O5jVmJ
--HG--
extra : rebase_source : 1230b5ffd26e92f74c5d7b4c2334743e52ea1abd
1. On{Audio,Video}[Not]Decoded() is always called after Seek() and before
mSeekTaskPromise is resolved or rejected. So mSeekTaskPromise should be
never empty and Exists() should be always true.
2. Is{Audio,Video}SeekComplete is called by On{Audio,Video}[Not]Decoded()
where Exists should be always true.
MozReview-Commit-ID: BNXBerkIMns
--HG--
extra : rebase_source : 9297a3dab11b5d852b68b4952065f9667f790bfd
Jeremy Chen
Henrik Skupin
Alastor Wu
Astley Chen
Mantaroh Yoshinaga
Gerald Squelart
JW Wang
Carsten "Tomcat" Book
Xidorn Quan
Wes Kocher
Michael Layzell
Mark Banner