Automatic update from web-platform-tests
LoAF: Initial support for long scripts
AnimationFrameMonitor signs into the probe system to track scripts.
Scripts that are 5ms or longer that are part of a LoAF (long amimation
frame) are reported as one of the LoAF entry.
Since some of the probes can be recursive, and also layouts/styles can
be recursive, AnimationFrameTimingMonitor maintains a little state
machine so that only the top-level scripts are captured:
- CompileAndRunScript is called for a <script> tag.
- ExecuteScript is called for a script tag (after compilation) and also
when an imported module is executed.
- UserCallback is called specifically for callbacks who implemented it.
- CallFunction is called *a lot* and is there to collect source location
for the top level script.
- WillHandlePromise is added. Note that task that begin with a promise
resolution end only when the next microtask queue is emptied.
Note the following:
- Only script *entry points* are reported, as in, there are no
recursions or time-overlaps between scripts.
- To reduce overhead, bookekeping is done once it's clear that the
script is longer than 5ms. If this still creates too much overhead,
we can increase the number and measure even longer scripts only.
- The state machine is somewhat similar to the one in
PerformanceMonitor. However, the two classes have a different
lifecycle and PerformanceMonitor has a lot of legacy, so copying
some of the logic seemed less costly than trying to unify.
Missing pieces:
- Not all the user callbacks are measured/probed, e.g.
PerformanceObserver callbacks. This would require a lot of detail
and fine-tuning.
- At first, PromiseResolver-based entry points don't have a lot of
details, e.g. source location and name. This will be done in a
later phase.
- Queue time and presentation time are still missing.
Explainer:
https://github.com/w3c/longtasks/blob/loaf-explainer/loaf-explainer.md
Design doc:
https://docs.google.com/document/d/1SeMd4KbXWZf0ZnRSMvYhjSBpXPBln5xrRyTu2Gr68BY/edit#
Change-Id: I57b62ab51b3f1ab28bbfbcc2d992df4cc10d38ec
Bug: 1392685
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4268371
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Noam Rosenthal <nrosenthal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1114430}
--
wpt-commits: b8e9469a49469720bb72a078c4ecde798daa70f5
wpt-pr: 38826
Automatic update from web-platform-tests
Allow Worker_script_mimetype.htm to take long.
We found the test flakiness due to timeout, and let me make the test
timeout long to mitigate the flakiness.
Bug: 1422305
Change-Id: I72f05169063fdfdeb556a2f151c34d986f331f8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4318283
Reviewed-by: Minoru Chikamune <chikamune@chromium.org>
Reviewed-by: Shunya Shishido <sisidovski@chromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1114406}
--
wpt-commits: c95d15338d3d4380beffb8b1b8dda62a8d746ab9
wpt-pr: 38868
Automatic update from web-platform-tests
Move transformation test generator file to common folder
Tests in category transformation for HTMLCanvas and Offscreencanvas are identical.
Bug: 1275750
Change-Id: I2f4489adaeb45d1b7da19d522568027912107ef1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4303320
Reviewed-by: Jean-Philippe Gravel <jpgravel@chromium.org>
Commit-Queue: Yi Xu <yiyix@google.com>
Cr-Commit-Position: refs/heads/main@{#1114350}
--
wpt-commits: 417a64d8351792b768efe089934edce3259f63d1
wpt-pr: 38866
Automatic update from web-platform-tests
Use AdjustedFocusedElement when clearing focus from children
In this case:
<my-button>
<template shadowrootmode=open>
<button><slot></slot></button>
</template>
Button contents
</my-button>
when the shadow root button is focused, calling
`myButton.textContent=''` clears the focus. This is due to a change made
for performance reasons in [1], but I think it's not the right behavior.
The focus should not be cleared in this case, since the adjusted focused
element is still the <my-button> element.
This CL goes back to using AdjustedFocusedElement. This might have
a negative perf impact, but I think it's important to not clear
focus for custom elements in this case.
[1] 9aab5fab83
Fixed: 1300584
Change-Id: I3c79dd41c92da9bd35d715bab56e2b8fdef50008
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4305572
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1114311}
--
wpt-commits: 14684f837eba364df3de2b6683d4eb5385333158
wpt-pr: 38850
Automatic update from web-platform-tests
Move pixel-manipulated test generator file to common folder
Tests in category pixel-manipulated for HTMLCanvas and Offscreencanvas are almost identical. Add 4 new tests for offscreencanvas to close the gap.
Bug: 1275750
Change-Id: I3ad1f9f5556ffb3fae7228a96d015f597eb6b0f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4304224
Commit-Queue: Yi Xu <yiyix@google.com>
Reviewed-by: Jean-Philippe Gravel <jpgravel@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1114283}
--
wpt-commits: da91f6b5dbc0193b8f137b8c9711b0f5660050db
wpt-pr: 38808
Automatic update from web-platform-tests
Update WPT OffscreenCanvas test template
Follow up from cl:
https://chromium-review.googlesource.com/c/chromium/src/+/4304361. The
previous cl missed to apply to many tests.
Change-Id: Id8c9dfd866f47e711ffc69a65ab7ed836ec1f21c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4306866
Commit-Queue: Yi Xu <yiyix@google.com>
Reviewed-by: Jean-Philippe Gravel <jpgravel@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1113611}
--
wpt-commits: 71d751d6404d9454744fdd9ad7b2f54d710731f2
wpt-pr: 38862
Automatic update from web-platform-tests
[css-selectors-4] Add extra :nth-child(An+B of S) test that uses larger DOM (#38338)
--
wpt-commits: 89bf50889186126c09de4e93b4995724c83e2a73
wpt-pr: 38338
Automatic update from web-platform-tests
[text-balance] Disable line cache if `text-wrap: balance`
When parts of inline formatting context was changed, we try to
reuse existing fragments for lines above the change. When
`text-wrap: balance`, this should not apply, because lines
above the change may also be affected.
This patch disables the line cache in such case.
Fixed: 1421423
Change-Id: Ib4bb2b65838290940e713de6b09d725c7bb2931e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4314764
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Auto-Submit: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1114150}
--
wpt-commits: d4bad531093495a7417f332b5f2b297e0baa6b4d
wpt-pr: 38857
Automatic update from web-platform-tests
Add support for non-positive resolutions to image-set
This change was triggered by the recently added wpt tests that started
failing after auto import:
third_party/blink/web_tests/external/wpt/css/css-images/image-set/image-set-zero-resolution-rendering.html
third_party/blink/web_tests/external/wpt/css/css-images/image-set/image-set-zero-resolution-rendering-2.html
Currently the spec does not restrict the range for resolution,
thus non-positive resolutions are valid and should not be
rejected at parse time.
The current consensus is to parse the non-positive resolutions,
but treat them as unsupported options for rendering purposes.
With this change, image-set will match resolution parsing
with media queries.
An issue has been opend for the spec to define the valid
argument range for resolution:
https://github.com/w3c/csswg-drafts/issues/8532
In the discussion on the issue new proposals were added about
how to treat zero resolutions for rendering purposes. Until the spec
is well defined in this area we will remove the zero resolution
rendering tests.
R=futhark, pdr
Change-Id: I7b329519168f3c088f5c9ee8614931b0ead7a4df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4312883
Commit-Queue: Philip Rogers <pdr@chromium.org>
Commit-Queue: Traian Captan <tcaptan@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1114116}
--
wpt-commits: 6dd9e79912d5161f24b2bf576e0b115c28cde956
wpt-pr: 38839
Automatic update from web-platform-tests
Consistency check between AXObjectCacheImpl and AXTreeSerializer tree
This is the lite version of checking the entire tree structure, only checking that the number of nodes is the same. It's easier to do and a more performant check. This CL only adds the checks. Four precursor CLs were landed to clean up object leaks and tree inconsistencies so that these checks would pass: AXMenuList (CL:4289642), Slots (CL:4294848), Image maps (CL:4291697), Inline text boxes (CL:4289593).
Follow up: a future check should be added to check for consistency between AXTreeSerializer and AXTree.
Bug: none
Change-Id: I0f33f9f7bdcd3f70cfce9182ab1111c7dfec6236
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4185240
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1114055}
--
wpt-commits: 4b3af57a11a724363f9563744a16e4d763885adc
wpt-pr: 38777
Automatic update from web-platform-tests
Reland #2 "Implement CSSTransitionDiscrete which enables transitions on discrete properties."
Original patch: https://crrev.com/c/4219315
Revert 1: https://crrev.com/c/4305045
Reland 1: https://crrev.com/c/4304846
Revert 2: https://crrev.com/c/4307944
Despite the most relaxed value in TestExpectations for
discrete-no-interpolation.tentative.html, some bots are still breaking
for reasons I don't understand. I am going to remove the test completely
until it stops crashing or failing. This patch will still be useful
despite the lack of tests because other people are doing prototyping
work that builds on this change.
Bug: 1399631, 1413556
Change-Id: Ic08f16d6436e37acc8947a94ca699c1735fe221f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4308075
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Auto-Submit: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1114026}
--
wpt-commits: 268250ba6d4c1ce72b87d0cef576dd09bc7f765a
wpt-pr: 38812
Automatic update from web-platform-tests
Move some tests from toascii.json to urltestdata.json and setters_tests.json
These were introduced in e9a106175a02a192a7239f42a94235fbe0f0c7a3. However, these are not tests of the Unicode ToASCII algorithm. They are tests of the extra step introduced in cceb4356cc to the URL Standard.
Keep toascii.json focused on testing the ToASCII algorithm, so that software which implements it can use that file.
--
wpt-commits: 5d5a73183f333f572efd140e043cadf6ea44b87a
wpt-pr: 38813
Automatic update from web-platform-tests
Remove unnecessary dependency on popover=hint
popover=hint isn't specified yet. To test popover attribute change, just switch from auto to manual.
--
wpt-commits: 5029df746aee4eed9863b24961a90ec7690698ca
wpt-pr: 38854
Automatic update from web-platform-tests
Initial support for running tests against WebKitTestRunner (#37653)
--
wpt-commits: 0f8899ecf3856487e50522654fd4cc0f4dc6b7c3
wpt-pr: 37653
Automatic update from web-platform-tests
Use ErrorEvent for MediaRecorder.onerror
This CL makes sure an ErrorEvent is used when MediaRecorder.onerror is
fired. See https://github.com/w3c/mediacapture-record/pull/212
Change-Id: I423c9a27f5a280355eea3c744aba703e70108665
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4307539
Commit-Queue: Fr <beaufort.francois@gmail.com>
Reviewed-by: Markus Handell <handellm@google.com>
Cr-Commit-Position: refs/heads/main@{#1113893}
--
wpt-commits: 65593a9aaca75357d62ac626762da2276f8673cd
wpt-pr: 38847
Automatic update from web-platform-tests
MediaRecorder throws NotSupportedError when context destroyed
Even though the spec does not say which type of error is supposed to
be fired when MediaRecorder methods should fail with when context is
destroyed, this CL changes Chromium implementation to fire
NotSupportedError so that it matches Firefox and Safari implementations.
Change-Id: If94b90699f8c8f0104b96a40331bf10468ab8434
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4307250
Commit-Queue: Fr <beaufort.francois@gmail.com>
Reviewed-by: Markus Handell <handellm@google.com>
Cr-Commit-Position: refs/heads/main@{#1113837}
--
wpt-commits: 7065fcb6a43d32bf3306922600339aaea2d56e0c
wpt-pr: 38846
Automatic update from web-platform-tests
[webtransport_h3_server] Pass secrets_log_file when SSLKEYLOGFILE specified (#38842)
The `SSLKEYLOGFILE` environment variable is commonly used to specify
the path to a file that is used for TLS debugging [1]. aioquic supports
the feature so let's just pass it.
[1] https://datatracker.ietf.org/doc/html/draft-thomson-tls-keylogfile-00
--
wpt-commits: 4e81b4985fbd665f4b3a7b84059c07f81fd5d555
wpt-pr: 38842
Automatic update from web-platform-tests
Reland "Reject Web Serial requests with an opaque origin"
This reverts commit cd2f352906cbfa254100390271e51e9890ed2bbe.
Reason for revert: The fixed parent CL https://chromium-review.googlesource.com/c/chromium/src/+/4307819 is re-landed.
Original change's description:
> Revert "Reject Web Serial requests with an opaque origin"
>
> Revert submission 4112689
>
> Reason for revert: suspect for introducing test failures for
> DedicatedWorkerTest.TopLevelFrameSecurityOrigin, for example
> https://ci.chromium.org/ui/p/chromium/builders/ci/linux-ubsan-vptr/21391/overview
>
> Reverted changes: /q/submissionid:4112689
>
> Change-Id: I496ec21cc6a6e39dd3c2943b8fc7ce3d179a1f73
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4307114
> Owners-Override: Mikel Astiz <mastiz@google.com>
> Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/main@{#1112768}
Change-Id: Ic3f4fe58a946b53a23dfba57d30ee889ec3cc359
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4311852
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Jack Hsieh <chengweih@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1113766}
--
wpt-commits: 7d47202bd14cb8ce8aa1c377789beb480af7a402
wpt-pr: 38830
While the root issue should be fixed on the server,
this patch will help reduce a frequent intermittent
and prevent showing erroneous result to users.
Differential Revision: https://phabricator.services.mozilla.com/D173660
We want to create sources for inline script that were GCed, but we ended up
re-creating sources for _all_ the sources of HTML file where at least one inline
script was GCed, which could lead to duplicated source actors.
Differential Revision: https://phabricator.services.mozilla.com/D173524