Automatic update from web-platform-tests
Fix console error in anonymous-iframe/worker-cookies SW test
Fixes the following console error that appears when running
anonymous-iframe/worker-cookies.tentative.https.window.html?worker=service_worker:
CONSOLE ERROR: Uncaught (in promise)
ReferenceError: add_completion_callback is not defined
Bug: None
Change-Id: I613b8adf0105d0798c6807896437d12f3c10e22e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4350542
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1119288}
--
wpt-commits: 1b93b258c8257e5361c2f41c7dd1b1a9e43f8dea
wpt-pr: 39073
Automatic update from web-platform-tests
BiDi: consolidate BiDi fixtures in webdriver/tests/support/fixtures_bidi
This fixtures file is already globally included in
webdriver/tests/conftest.py via `pytest_plugins`.
Stop having webdriver/tests/bidi/conftest.py be a duplicate of the
support fixture.
--
wpt-commits: 969b345fb0c50a5fff56ea3a081629fd95c24ff9
wpt-pr: 38732
Automatic update from web-platform-tests
[@scope] Allow CSSNestingType::kScope without having a parent rule
Scopes without a <scope-start> selector are scoped to the owner node's
parent. The selectors within such @scope rules should parse according
to the behavior of CSSNestingType::kScope (i.e. relative rules allowed,
implicit :scope descendant if needed), even though there is no
parent rule. Therefore this CL changes CSSSelectorParser to check
for `nesting_type` instead of `parent_rule_for_nesting` when setting
the initial value of in_nested_style_rule.
Bug: 1280240
Change-Id: Ie8d90b8ef059e519919b89a13b93d340d0917d8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4345880
Reviewed-by: Steinar H Gunderson <sesse@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1119277}
--
wpt-commits: e9ef5fdaa91bd718b3479f437015d5c82dce85ea
wpt-pr: 39050
Automatic update from web-platform-tests
[@scope] Enable nesting features within @scope's body
This CL passes a parent rule and accompanying CSSNestingType
to the ConsumeRuleList call which handles @scope's body. This has
the following effects:
- A :scope descendant compound is implicitly inserted if the selector
is not scope-containing.
- The parent selector (&) now refers to the <scope-start>
selector list.
- Relative selectors are enabled.
The code to resize the arena in ConsumeStyleRule must now be detached
from whether or not parent_rule_for_nesting is nullptr. This is because
we can now enter ConsumeStyleRule with parent_rule_for_nesting!=nullptr
without another call to ConsumeStyleRule below us on the stack
(via ConsumeScopeRule).
Bug: 1280240
Change-Id: Ibe6b1e40e22d535a094b0ec464ae119952b015f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4272459
Reviewed-by: Steinar H Gunderson <sesse@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1119257}
--
wpt-commits: 00b9747943d4c008b366cb42a2b50d5717189e0e
wpt-pr: 39005
Automatic update from web-platform-tests
Drop Python 3.6 support from tools/
This replaces the 3.6-based CI jobs with Python 3.7, and drops 3.6
from test configurations.
It also updates requirements files that have specific pinned package
versions for 3.6, but does not attempt to update dependencies in
general (either through requirements or pinned).
--
wpt-commits: 8cf108d380ee91ef2667a05dd2389ad5cd6d6529
wpt-pr: 38911
Automatic update from web-platform-tests
LayoutMedia: Should not handle OOF boxes
After LayoutMediaNGContainer task, LayoutMedia could be a container of
its OOF descendants, but NGReplacedLayoutAlgorithm has no ability to lay
out OOF boxes.
This CL fixes the issue by making LayoutMedia children OOF containers
by forcing paint containment.
Bug: 1425520
Change-Id: I19e10c9a94341cba376883bf544ef69ea413dca5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4349736
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Auto-Submit: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1119211}
--
wpt-commits: 78f0f7dfccc8ea071919199e9c36d0dc87c8b19f
wpt-pr: 39076
Automatic update from web-platform-tests
Include Ahem in mask-text-001.svg and reference
This test references Ahem, but never includes the stylesheet.
--
wpt-commits: 1a963a601aa0ce5dd7eb88cd70af32f38f5307d0
wpt-pr: 39074
Automatic update from web-platform-tests
view-transitions: Ensure elements in the transition are stacking contexts.
This change ensures that the rendering constraints added by
view-transition-name continue to apply even if the property is removed,
if they are participating in an ongoing transition.
Change-Id: I8eb485233eefe1282baf15eb8bbdbd6a42f14f02
Fixed: 1424312
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4343032
Commit-Queue: Khushal Sagar <khushalsagar@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1119071}
--
wpt-commits: 2bf9cc74a8b58bb0af9ae9d31f9919e8a3b56205
wpt-pr: 39063
Automatic update from web-platform-tests
Fix a TextIterator crash in Greek text-transform
CSS text-transform can change text length in either ways, resulting in
more or fewer characters in LayoutText. The former case is more well
known and has been largely worked around.
Now that we see the latter case being possible, this patch works around
it in TextIterator to avoid reaching a NOTREACHED().
Fixed: 1424324
Bug: 750990
Change-Id: I4b8ba886bcacc06e9e491badb30af98d0f22c37c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4351287
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1119018}
--
wpt-commits: ceb972b009e1b43c589dce3f36b050121493d2e0
wpt-pr: 39064
Automatic update from web-platform-tests
De-flake two tests
These tests were timing out because window.screenX and window.screenY
were never set during the test run, leading to the code to wait 15
seconds before giving up trying to find them. But once it gave up,
it got the correct result, because there is no expected_screenX
or expected_screenY for these tests anyway.
Tests are:
external/wpt/html/browsers/the-window-object/open-close/open-features-non-integer-innerwidth.html
external/wpt/html/browsers/the-window-object/open-close/open-features-non-integer-width.html
Fixed: 1048149
Change-Id: I9e9620254b0e9284923e7a683213b1c0721ffc81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4347589
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1118959}
--
wpt-commits: cb19b01d65d9677bf53223322e32211c190eee5c
wpt-pr: 39060
Automatic update from web-platform-tests
[anchor-position] Make `anchor` attribute work for non-popovers
This patch reimplements how we mark elements that are implicit anchors.
Previously it was only marked for popover element's implicit anchors,
and now it works for all implicit anchors. This is done by a new class
AnchorElementObserver that observes all possible changes in implicit
anchor and replaces the old PopoverAnchorObserver.
This patch also reveals two existing issues:
1. Element::GetElementAttribute() may return non-null result even if
the element is out of tree scope. As fixing the bug is out of the
scope here, this patch just works around it. crbug.com/1425215 was
filed.
2. popover-anchor-idl-property.html has some bugs that made it pass
previously. This patch fixes those bugs.
Fixed: 1417346
Change-Id: I798977ab1ed7df0c528b7eb98c64fc04476e6106
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4338487
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1118933}
--
wpt-commits: e1dabe08c494d1b7aaf5e2e9437b71e51997c299
wpt-pr: 39041
Automatic update from web-platform-tests
[anchor-position] Use scroll-adjusted IMCB for position fallback
Previously, we've been using the inset-modified containing block for
position fallback, which doesn't work well with scrolling.
This patch fixes the issue by using the scroll-adjusted IMCB instead,
which was introduced earlier on the spec side [1].
As an implementation detail, this patch also calculates and stores
the non-overflowing scroll ranges [2] for each fallback position, so
that we can still use composited scrolling, and need to invalidate
layout only when we have scrolled out of that range.
This patch also adds WPT tests under various writing modes and
directions to cover all the new code paths.
[1] https://drafts4.csswg.org/css-anchor-position-1/#determine-the-position-fallback-styles
[2] https://github.com/w3c/csswg-drafts/issues/8059#issuecomment-1444616906
Bug: 1418725
Change-Id: If9e104c6ac3c51ccdfc4fa7d3cf9cbffcc5af46d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4292618
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1118926}
--
wpt-commits: e2169b6b0b5ca89b61b976f512e9ad52bace8597
wpt-pr: 38998
Automatic update from web-platform-tests
Scheduling APIs: Implement scheduler.yield() prototype (part 2: inherit)
This CL implements the scheduler.yield() "inherit" option:
- Signal selection: GetTaskSignalFromOptions() is updated to take
inheritance into account. If either the signal or priority options
are to inherit, the inherited signal is retrieved from V8 and used
in the computation:
- signal: "inherit", priority: unset - use the inherited signal
if there is one, otherwise default priority.
- signal: "inherit", priority: fixed - create a composite signal
from the inherited signal and fixed priority. If the inherited
signal is null, just use a fixed priority signal.
- signal: unset, priority: "inherit" - if there's nothing to
inherit use the default priority; if the inherited signal has
fixed priority and can't abort, use that; otherwise create a
new composite signal.
- DOMTask is updated to support continuation, passing its signal
when creating a task scope (main thread). For workers, DOMTask
will set the continuation preserved embedder data manually before
running the task.
- WPT tests are added and modified to cover the "inherit" option.
Bug: 979020
Change-Id: Ia9776b9292d70636e2b1eea191e9c09b1809fa84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4326152
Commit-Queue: Scott Haseley <shaseley@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1118868}
--
wpt-commits: c19eb6a201cf1dd04915ef9a2de24b779532df9d
wpt-pr: 39040
Automatic update from web-platform-tests
view-transitions: Update CSS to name the root element.
Default UA CSS is supposed to add view-transition-name to the root
element. Currently it targets html which is incorrect since multiple
html elements can exist on the page. Update it to target :root.
This also aligns with the spec. See
https://drafts.csswg.org/css-view-transitions-1/#ua-styles.
Bug: 1425445
Change-Id: If989e5549f1977c248b4f7e933379e2bfc17d07d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4350707
Auto-Submit: Khushal Sagar <khushalsagar@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Khushal Sagar <khushalsagar@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1118792}
--
wpt-commits: c2a197e2cbb2afc7cc7849f926884bb1ffdd3109
wpt-pr: 39058
Automatic update from web-platform-tests
[CSSTransitionDiscrete] Fix custom property issues
When attempting to transition a custom property with universal syntax,
we hit a DCHECK in StyleBuilder::ApplyProperty because we send
a CSSVariableReferenceValue, which is normally expected to be resolved
at this point. However, such custom properties represent their
computed values as CSSVariableReferenceValues, and the discrete
transitions machinery sends those computed values to ApplyProperty
without "transformations". This is expected behavior as of CL:4315803.
Representing the computed value of universal custom properties with
CSSVariableReferenceValue is a bit suspicious and might warrant further
investigation, but this CL does not attempt to address that. Instead
we alter the DCHECK to expect CSSVariableReferenceValues for relevant
custom properties.
Also:
- Fixed usage of irrelevant custom property in the WPT
token-stream-type-type-interpolation.html.
- Fixed accumulation of "transitionrun" event listeners when
testing multiple transitions in the same .html file
(e.g. custom-property-transition-mismatched-list.html).
WPTs related to <transform-function> and <transform-list> are still
failing, because we don't implement interpolation for those syntaxes
yet.
Bug: 1399631
Change-Id: I22f0766921061216421839def84bc305edda2a41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4334509
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1118779}
--
wpt-commits: e6c2d4cacfa621bc2656b577c1fb63f080bac2f5
wpt-pr: 39051
Automatic update from web-platform-tests
Test which XSLT functions are defined
This currently expects only functions defined in XSLT 1.0 (and references) to be defined. This matches what all browsers currently implement.
--
wpt-commits: d963cd40e87f20bbfaaffdb9eca2e539bac4d631
wpt-pr: 39057
Automatic update from web-platform-tests
CSSTransitionDiscrete: Fix counter related crashes
The generated code in CounterIncrement::ApplyValue expects to receive a
CSSValueList with a CSSValuePair inside of it, so this patch adds a
CSSValuePair to ComputedStyleUtils::ValueForCounterDirectives
Bug: 1399631, 1413556
Change-Id: If38d51d026965b2f481a9ed6432ce519587847ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4310132
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1118697}
--
wpt-commits: 98afc8a86461237414d32da9e6628499c0a0022a
wpt-pr: 38817
Automatic update from web-platform-tests
Fix#8122: Upstream Mozilla counter-style tests
These don't cover all of the counter styles, but they give us automated tests
for most of them.
They are all originally authored by @dbaron and @upsuper.
--
wpt-commits: 5e9421703a3de453d0792109a714f624e5185f27
wpt-pr: 8150
Automatic update from web-platform-tests
Collect popover invokers on root instead of document
See this HTML spec PR:
https://github.com/whatwg/html/pull/8993
It points out that it would be better to look within `root`
rather than `document` for invokers. Otherwise this use case
will be broken:
<div>
<template shadowrootmode=open>
<button popovertarget=p1>Click</button>
<div popover id=p1>Popover 1
<button popovertarget=p2>Click</button>
</div>
<div popover id=p2>Popover 2 (I'm not detected as a being related to p1)</div>
</template>
</div>
I.e. nested popovers entirely within a shadow tree. This CL
fixes that behavior and adds a test.
Bug: 1307772
Change-Id: I28521ec1008d43994ca738c5673da3b704d7ba9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4335444
Auto-Submit: Mason Freed <masonf@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1118671}
--
wpt-commits: 887ed601ff82d1cee8a358559e2c963528e6520b
wpt-pr: 38981
Automatic update from web-platform-tests
Fix inconsistent hasStorageAccess behavior for A(B(A)) frame tree case
This change for document.hasStorageAccess() is based on spec PR
fd28dc0543.
Bug: 1422628
Change-Id: I72cc1bb21a5d075a00b4b6719e2010855e5c2a63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4340989
Reviewed-by: Johann Hofmann <johannhof@chromium.org>
Commit-Queue: Shuran Huang <shuuran@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1118658}
--
wpt-commits: 186820b4ea00e96be00a7f57a2f709c67d78d05c
wpt-pr: 39019
Automatic update from web-platform-tests
Use base::ValuesEquivalent for custom property style queries
We previously compared the tokens from the tokenizated string instead.
Add tests for matching and serializing original string in style()
queries.
Bug: 1302630
Change-Id: I2768b930407f65c979b320597276e0d5d01a1b93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4342894
Reviewed-by: Steinar H Gunderson <sesse@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1118626}
--
wpt-commits: 0b9590a78d353217ae0bc6321ecc456f2da197ec
wpt-pr: 39052
stransky
moz-wptsync-bot
Andrew Williams
Henrik Skupin
dependabot[bot]
Thiago Perrotta
Anders Hartvoll Ruud
Anne van Kesteren
Philip Jägenstedt
James Graham
Kent Tamura
Tim Nguyen
BruceDai
Khushal Sagar
Xiaocheng Hu
Chris Harrelson
Scott Haseley
Sam Sneddon
Joey Arhar
Geoffrey Sneddon
Mason Freed
Shuran Huang
Rune Lillesveen
Frédéric Wang
Arnaud Mandy