Automatic update from web-platform-tests
Speculative fix for backdrop-animate-002.html
The differences only manifest on WPT.fyi, but they are minor single-
pixel-value differences on the green ::backdrop. This change just
adds a few rAF() loops to let things settle.
Bug: 1323293
Change-Id: I3e422e87f3a1a216a06df84e682a5c51207de440
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3632451
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1000737}
--
wpt-commits: 5eca98b81539a29b318d8b11c43da144311715c1
wpt-pr: 33978
Automatic update from web-platform-tests
[block-in-inline] Fix hit-testing when a block-in-inline is not hit-testable
This patch fixes hit-testing of block-in-inline when it is
not hit-testable but the requested point is in the inline box;
e.g.,
* The requested point is at the margin area of the block-in-
inline.
* The block-in-inline has lower z-index than other boxes.
In such cases, the anonymous block of the block-in-inline
hits. This patch redirects it to the containing inline box.
The logic to handle this case for pre-LayoutNGBlockInInline
(i.e., continuation) was added in 2003[1] with a good comment,
but without tests. This patch adds tests for both original
case and the case for crbug.com/1322747.
[1] dd67c9bf0f%5E%21/third_party/WebKit/WebCore/khtml/rendering/render_object.cpp
Bug: 1322747
Change-Id: I0f98b4d0253afbd6c22ebb426a3a5c04af649c53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3632259
Auto-Submit: Koji Ishii <kojii@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1000733}
--
wpt-commits: 2ab70aa54b166f6dfd97abd783ca1ebc0419c625
wpt-pr: 33981
If the tokenizer sees a number like `0.`, it currently starts at the '.' and discards
the '0'. This relies on `GetDecimalNonInteger` => `js_strtod_harder` returning 0
for invalid strings (such as "." in this case). This patch fixes this so that we
handle `0.x` similar to `1.x` for example.
In GetDecimalNonInteger we can now assert the whole string was parsed.
This also fixes the `decimalNumber` comment:
* Case 3 no longer exists with this change, '0' is now handled similar to case 1.
* Case 2 didn't match the code after bug 1609547. Fix the comment.
* Case 4 (now case 3) didn't match the code after bug 1421400. Fix the comment.
Differential Revision: https://phabricator.services.mozilla.com/D146570
Asm.js content is produced while generating the content of the enclosing script.
By filtering function which are already emitted, we filter out Asm.js functions
from the delazification tasks.
Differential Revision: https://phabricator.services.mozilla.com/D143465
blocklistchange/addon_update*.json contained incorrect values in
"version". There is a pattern in the way that these tests are
constructed, so test_blocklistchange.json was updated to generate the
update manifests, along with extra comments that explain the relation
between the various test files.
With this change, blocklistchange/ has become fully obsolete and has
been removed from the test.
As noted in the bug, "softblock5" is not used anywhere, so its
references have been removed too.
Differential Revision: https://phabricator.services.mozilla.com/D144497
The "succesful" update part of the test referenced a XPI where the
version differed from the update manifest. This is not supported,
the update manifest's version should match the version from the XPI.
As noted in the bug, addon_update1.json and addon_update2.json also
specify incorrect versions, but as the XPIs are not actually fetched
that doesn't matter in the test.
(I will address that in the next patch.)
Differential Revision: https://phabricator.services.mozilla.com/D144496
Tests got added e.g. in bug 1766674 and test first party isolation (partioning)
which is only enabled in Nightly. Bug 1549587 is the general bug tracking
first party isolation.
Differential Revision: https://phabricator.services.mozilla.com/D146484
We create a new nsPrintJob every time Print() or PrintPreview() is invoked
now ( https://phabricator.services.mozilla.com/D87417 ), so the mPrtPreview
member is never set this early on.
This also renames aSourceDoc to just aDoc since the document that is passed is
nowadays the actual document we're going to print from (the static clone,
which nowadays is created before these methods are invoked rather than being
created by them).
Differential Revision: https://phabricator.services.mozilla.com/D146563
This prevents long-standing artifacts on HiDPI screens on context menus and so
on.
This is much simpler than tooltips because menupopups and panels already have
the whole set-up ready.
The searchbar.css changes are kind of annoying, but they improve the rendering
a lot (see attached screenshots).
Let me know if you want me to draw shadows on all panels on Windows like we do
on Linux, it's probably doable and cleaner over-all.
Differential Revision: https://phabricator.services.mozilla.com/D145818
GeckoView is still using the deleted gl.msaa-level setting. As the rest of the engine does not use it,
modifying it basically became a noop. Replacing it by webgl.msaa-samples does the trick and allows
GeckoView clients to modify the antialiasing settings in WebGL.
Differential Revision: https://phabricator.services.mozilla.com/D146322
Bug 1766131 added a call to this method before the other call
to ReplacedBy, but apparently the other call site comes into play
in some tests, at least when parent controlled navigation is
enabled. This fixes browser_scrollPositions.js with parent controlled
navigation, and is a step towards fixing browser_test_shentry_wireframe.js.
It sounds like the issue happens when you navigate to one page, then
to another in the same site, via BrowserTestUtils. Because these are
initiated from the parent process, then end up getting redirected to
the content process in another docshell. We have to save the layout
history state before doing this, or we lose the scroll information.
Differential Revision: https://phabricator.services.mozilla.com/D146140
This patch series gave picture primitives the full anti-aliasing instead of just the inward half, some reftest references have to be changed accordingly.
Differential Revision: https://phabricator.services.mozilla.com/D146199
This patch adds a edge aa mask field in the common primitive data so that primitives can turn off anti-aliasing at their edges. There was some padding in the structure so it didn't change the size.
This will be use by a followup patch to turn off anti-aliasing between pieces of linear gradients when they are decomposed into simpler primitives.
Differential Revision: https://phabricator.services.mozilla.com/D145936
The Antialiasing code sets up the bounds of a rect to anti-alias in the vertex shader for the fragment shader to compute the AA via a distance approximation.
The modified mix call selects between the edges of the current instance (could be a primitive segment) and the edges of the primitive based on the anti-aliasing edge flags. If an edge does not have the AA flag, then the aa will be computed based on the distance to the primitive's edge. This usually works because we tend to want AA around the primitive but not along the internal edges of potential segments of a primitive. However it also means that if we take the anti-aliasing code path (for example under a non-axis-aligned transform) then the edges of the primitive are always anti-aliased. In some cases we want to disable the anti-aliasing along the primtive, though, for example when something is split into multiple primitive like the linear gradient optimization.
This patch changes this mix call so that it selects between the segment bounds and some very large rect. If the primitive is not segmented, then the segment bounds are the bounds of the primitive. The effect is that AA is only applied to edges that have the flag set rather than segment edges with the flag set as well as any edge at the border of the primitive.
Differential Revision: https://phabricator.services.mozilla.com/D145935
Using insertAnonymousContent on a document where a XUL popup is displayed seems
to hide/destroy it.
This patch extends the current behaviour for XUL windows to Chrome windows:
we add an iframe in the document which will contain the anonymous content.
Differential Revision: https://phabricator.services.mozilla.com/D146036
Long ago we used to play switcheroo with PresShells in order to print a
document, but for over a decade we've been cloning the document that is
to be printed (bug 487667). Since then we've had no need for this method.
Differential Revision: https://phabricator.services.mozilla.com/D146545
This is a kind of bug 1263887 for GeckoView.
We should update the prompt when child nodes in `<select>` element is modified.
I add `PromptInstanceDelegate.onPromptUpdate` to update the prompt's content.
Browser application should implement it if <select> element is updated during
showing the prompt.
Differential Revision: https://phabricator.services.mozilla.com/D144538
This instrumentation is used to build test cases and help with fuzzing, by
selecting a custom delazification type as the default mode for the top-level.
Differential Revision: https://phabricator.services.mozilla.com/D145993
Adds a delazification mode, which spawn a concurrent depth-first delazification
of all function to fill the stencil cache, to later compare cached results with
stencils produced by on-demand delazification.
The delazification mode also works when being used from a main-thread top-level
compilation, in which case the delazification tasks are created and potentially
blocking the main thread, while the delazification is happening.
This way of doing help comparing on-demand delazification, based on instantiated
stencils with concurrent delazification, based on stencils. Which is a good
mode for fuzzing purposes.
Differential Revision: https://phabricator.services.mozilla.com/D145992
Previously, we only had a single mode of delazification, then we added the
concurrent delazification, which could be mixed with on-demand delazification,
by always checking for cached entries.
Now, with the addition of a third mode which attempt to compare the outputs of
on-demand delazification with concurrent delazification, we need to distinguish
and carry this difference to the function responsible for running the
delazification. However, this information is only available when we first run
the delazification.
This patch adds the JS::DelazificationOption (uint8_t) to the ScriptSource
class, such that we can communicate the selected mode to the functions in charge
of the delazification.
Differential Revision: https://phabricator.services.mozilla.com/D145991
moz-wptsync-bot
Mason Freed
Koji Ishii
Emilio Cobos Álvarez
Jan de Mooij
Nicolas B. Pierron
Rob Wu
Alexandra Borovova
Drew Willcoxon
Magnus Melin
Nicolas Chevobbe
Sebastian Hengst
Jonathan Watt
Botond Ballo
Henrik Skupin
Sergio Villar Senin
Andrew McCreight
mleclair
Andrew Osmond
Narcis Beleuzu
Travis Long
Nicolas Silva
Julian Descottes
Hubert Boma Manilla
Makoto Kato
Paul Zuehlcke
Bogdan Szekely